jackpoz
dbed818f6f
Core/SAI: Fix crash
...
Disable script type SMART_SCRIPT_TYPE_TIMED_ACTIONLIST actions if they are trying to overwrite the timed action list while iterating it.
This was invalidating the iterator and deleting any smart action stored in it, including the current executed one.
Valgrind log:
Invalid read of size 1
at SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3258)
by SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:331)
by Creature::Update(unsigned int) (Creature.cpp:544)
Address 0x1807d9b2 is 10 bytes after a block of size 40 alloc'd
at operator new(unsigned long) (vg_replace_malloc.c:319)
...
by SmartAIMgr::LoadSmartAIFromDB() (SmartScriptMgr.cpp:231)
by World::SetInitialWorldSettings() (World.cpp:1724)
by Master::Run() (Master.cpp:169)
by main (Main.cpp:142)
2014-02-08 21:59:35 +01:00
Dehravor
12cafcf96b
Core/Warden: Fix crash
2014-02-08 09:33:51 +01:00
joschiwald
b9074f3491
Core/Achievements: rename some AchievementCriteriaDataTypes to keep consistent
2014-02-06 23:28:51 +01:00
jackpoz
84e73448f2
Core/Spells: Possible crash fix
...
Get Unit target with the proper method instead of retrieving Object target and then casting it to Unit, possible dereferencing NULL.
Updates #11560
2014-02-06 22:11:06 +01:00
joschiwald
b000fdca70
Core/Entities: allow interaction with gameobject questgivers if player can take or return quests
...
Closes #11269
Closes #8898
Closes #10204
Closes #11410
Closes #7053
Closes #6189
Closes #9474
2014-02-06 21:23:18 +01:00
Shauren
0d51fd55a1
Core/Auras: Implemented SPELL_AURA_MOD_COOLDOWN
...
Closes #9671
2014-02-05 13:00:42 +01:00
Discover-
30924211a3
Merge pull request #11568 from Rochet2/VendorChecks
...
Core: Add rest of checks from SendListInventory to BuyItemFromVendorSlot
2014-02-05 10:18:02 +01:00
Discover-
72ed06ddfd
Core/Achievements: Use ACE_OS::localtime_r instead of localtime in my previous commit for thread safety.
...
Thanks to @Shauren
2014-02-05 10:15:43 +01:00
Discover-
f29463cf66
Core/Achievements: Implement criteria type ACHIEVEMENT_CRITERIA_TYPE_ON_LOGIN and criteria requirements ACHIEVEMENT_CRITERIA_REQUIRE_NTH_BIRTHDAY and ACHIEVEMENT_CRITERIA_REQUIRE_KNOWN_TITLE. Fixes anniversary achievements.
...
By @Schmoozerd
2014-02-05 09:34:12 +01:00
Rochet2
49593361e3
Core: Add rest of checks from SendListInventory to BuyItemFromVendorSlot
2014-02-04 15:49:58 +02:00
Aokromes
988c2894a3
Merge pull request #11095 from gerripeach/pull_request3
...
Core/LFG: Minimum item level in Wotlk heroic dungeons
2014-02-04 04:18:34 -08:00
Shauren
d006f4b734
Core/Spells: Fixed AoE damage reduction auras, original patch by @Unholychick
2014-02-04 11:31:13 +01:00
Shauren
996e9115ac
Core/Groups: Fixed UnitIsPartyLeader lua function
2014-02-04 10:57:32 +01:00
joschiwald
f1bfd43c58
Core/Misc: remove error log, which returns false positives
2014-02-02 16:15:07 +01:00
Discover-
e59f3f7333
Core/Chat: Fix a new issue caused by c0224dd7ca which would trigger false positives for CHAT_MSG_AFK and CHAT_MSG_DND.
2014-02-02 15:13:53 +01:00
jackpoz
8f29fb9aee
Core/Spell: Handle SPELL_AURA_FORCE_REACTION missing cases
...
Always check forced reputation ranks before any other faction check to get the reaction between 2 units.
Fixes #5790
2014-02-01 21:21:47 +01:00
joschiwald
11b48569c8
Core/Spells: fix crash when loading custom spell attr with invalid spellid
2014-02-01 19:23:20 +01:00
Discover-
c0224dd7ca
Core/Chat: Fix an exploit where it was possible to speak in universal language in say/yell/emote by sending CMSG_MESSAGECHAT using cheats.
2014-02-01 13:27:16 +01:00
jackpoz
68d48ecbd1
Core/Arena: Fix arena season not always appearing to clients
...
Arena season sent to client with SMSG_INIT_WORLD_STATES opcode was not sent if Player was on a zone with id 0 on login. Initializing the zone id to -1 will always trigger UpdateZone() properly on login.
Fixes #10623
2014-01-31 20:47:47 +01:00
Duarte Duarte
5666c7cc35
Core/Achievs: Rename a few unknown achievement criteria flags
...
Source tomrus88, Mangos
2014-01-31 15:43:24 +00:00
Discover-
a242662ae6
Core/Spells: Fix DK Ghoul's damage after ad8eb434c0. I misread 'SpellScript::m_damage' for 'SpellScript::damage'.
...
By @joschiwald
2014-01-31 10:37:55 +01:00
Duarte Duarte
d749b72193
Core&DB/Spells: Move custom spell attributes from code to DB, spell_custom_attr table
...
`spell_custom_attr`
- `entry` uint PK
- `attributes` uint (enum SpellCustomAttributes of SpellInfo.h)
2014-01-31 04:32:03 +00:00
jackpoz
378d27f9bc
Core/Splines: Fix "velocity > 0.1f" error
...
Updates #6191 .
2014-01-30 20:03:13 +01:00
Discover-
ad8eb434c0
Core/Misc: Missing changes and get rid of useless method in acd46085d1
2014-01-30 10:28:05 +01:00
joschiwald
acd46085d1
Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscripts
...
Closes #1719
Closes #3186
2014-01-30 02:40:12 +01:00
zorix
e9b7bb0a7b
Core/Spell:
...
Triggered spells now will be cast on the primal target instead of on caster
Close #10853
Close #10860
2014-01-27 20:26:34 +01:00
joschiwald
6dc15294e2
Core/Spells: move paladins judgements to spellscripts
2014-01-26 23:56:53 +01:00
w1sht0l1v3
38436f21c6
Core/Gameobjects: Fix not being able to use the fishing node/float after 6b25c2b414
2014-01-26 22:46:10 +02:00
gerripeach
ffe1e6e2ba
Core/LFG: Minimum item level in Wotlk heroic dungeons
...
WotLK Heroics, beside Trial of the Champion, Pit of Saron, Halls of Reflection and The Forge of Souls unlock with an average item level of 160.
Also Trial of the Champion (normal) and The Forge of Souls (normal) unlock with an item level of 160.
http://www.wowwiki.com/Dungeon_Finder?oldid=2404648#Wrath_of_the_Lich_King_dungeons
2014-01-27 03:14:50 +07:00
Aokromes
d2e782a13b
Core/Spells: Add SPELL_ATTR0_CU_REQ_CASTER_BEHIND_TARGET to some Backstab spells
...
Original fix by Bruescrues
Closes #10767
Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com >
2014-01-26 14:26:25 +00:00
Vincent_Michael
955fb907c5
Core: Fix warnings
2014-01-26 03:48:33 +01:00
joschiwald
fbddda52e7
Core/Spells: move more spells to spellscripts
2014-01-26 02:24:57 +01:00
joschiwald
96060bf007
Core/Spells: move some spells so spellscripts
2014-01-26 01:02:20 +01:00
jackpoz
88a5d01016
Core/Calendar: Crash fix
...
Attempt to fix #11512 crash by adding a NULL check since GetEvent() can return NULL.
2014-01-25 21:28:01 +01:00
Discover-
6b25c2b414
Core/Gameobjects: Fix an exploit where it was possible to use gameobjects from any distance. Fixes for example picking up the WSG flag from any distance using hacking tools.
2014-01-25 16:59:01 +01:00
Vincent_Michael
c6650ecc71
Core/Spells: Move Pilgrims Bounty BuffFood in AuraScript (mimimi)
2014-01-25 16:28:29 +01:00
Dehravor
e619246d58
Core/SkillHandler: Check if player is using proper NPC on talent reset
2014-01-25 10:55:29 +01:00
Discover-
d7f76f2eda
Merge pull request #11396 from natepizzle/master
...
SpellAuraEffects
2014-01-24 02:32:02 -08:00
Discover-
08bc9da22e
Merge pull request #11499 from Dehravor/taxi-node
...
Core/Taxi: Fix exploit related to unexplored nodes
2014-01-24 02:15:14 -08:00
Vincent_Michael
abc1effd80
Core: Fix non pch build
2014-01-24 06:19:52 +01:00
joschiwald
f0c4224603
Core/Spells: move killing spree to spellscript
...
Closes #10597
Closes #11468
2014-01-24 01:32:15 +01:00
Discover-
7d8b65b3cc
Core/Chat: Disallow sending CMSG_MESSAGECHAT with CHAT_MSG_SAY, CHAT_MSG_EMOTE or CHAT_MSG_YELL while the sender is not alive.
...
Also replaced all WorldSession::_player calls by 'sender'
By @TakenBacon
2014-01-23 20:22:37 +01:00
Discover-
cb1964770e
Core/Loot: Fix an exploit with CMSG_LOOT using non-creature guids which would allow you to loot despawned chests in some cases.
...
By @Kiddie
2014-01-23 20:09:13 +01:00
joschiwald
a5b04e06f7
Core/SpellScripts: Implemeted SpellScript hook OnDestinationTargetSelect to easier modify SpellDestinations
2014-01-23 18:15:59 +01:00
Dehravor
e8e23ef03d
Core/Taxi: Fix exploit related to unexplored nodes
2014-01-23 15:29:02 +01:00
Vincent_Michael
516a6344fe
Misc: Fix warnings
2014-01-22 07:31:37 +01:00
Vincent_Michael
101ac7f511
Misc: Minor cosmetic changes here and there
2014-01-21 20:20:38 +01:00
Discover-
bebb581d2e
Core/SAI: I need more sleep...
2014-01-21 20:01:00 +01:00
Discover-
bf0d8c1346
Core/SAI: Implement three more event phases which makes a total of 9 (from 6).
...
Ref. #11486
2014-01-21 19:56:43 +01:00
Discover-
9d85d0d928
Core/Misc: Fix compile.
...
Forgot to save file
2014-01-21 10:01:32 +01:00
