Commit Graph

29287 Commits

Author SHA1 Message Date
Treeston
ac8b9be5d6 Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156. 2018-02-13 15:47:44 +01:00
Treeston
fe3b4de1cd Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310. 2018-02-13 15:47:04 +01:00
tkrokli
1ca0e776ce DB/Loot: add missing column name to 2018_02_13_00_world_335.sql
Error message upon loading the original file into DB:
- ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1

Closes #21407
2018-02-13 07:59:37 +01:00
Killyana
9f59fb54fc DB: Add a missing action_param to the previous commit
Gobs always requires respawn time with the action 41, otherwise they will never respawn
2018-02-13 01:55:03 +01:00
Killyana
c9811a48c4 SAI/Quest: Sabotage
Closes #20881
2018-02-13 01:28:07 +01:00
Teppic1
75b975b4e8 DB/Loot: Reference template 24064 corrections
Closes #21385
2018-02-13 01:26:40 +01:00
ccrs
28c6db0807 Core/Movement: fe1ba18905 followup
ref fe1ba18905 (r27507316)

plus I noticed a logic error on speedchange call
2018-02-12 23:44:18 +01:00
ariel-
59fb0a581c Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice 2018-02-12 19:32:59 -03:00
ariel-
bc2a4c816d Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic)
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)
2018-02-12 19:04:01 -03:00
ariel-
c7095375c3 Core/Unit: kill unused parameter from SpellxxxBonusTaken 2018-02-12 18:36:10 -03:00
ariel-
404240fb68 Core/Scripts: remove Tenacity hack, implemented with proper aura 2018-02-12 18:35:06 -03:00
tkrokli
57553ed96a Build fix (unused parameter 'stack' in Unit.cpp)
Ref. commit 4d14f613f3
2018-02-12 22:22:34 +01:00
Wilcalaf
0c1aaac219 Archaedas should properly start now when clicking on the altar. (#21401) 2018-02-12 21:38:08 +01:00
ariel-
4d14f613f3 Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras
- Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses
- Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty)
2018-02-12 16:52:59 -03:00
ariel-
e73bfe8df8 Core/Spells: implemented SpellPriority field from SpellEntry to cleanup charged mod proc behaviour
- Only one charged mod will be consumed per SpellMod apply, and it'll be compared against other mod priority
- This is proper way of handling Backdraft/Backlash and Deathchill/Killing Machine

Thanks to killerwife for info
2018-02-12 03:09:22 -03:00
ariel-
3edf90d167 Core/Scripts: fix nopch build mk II 2018-02-12 00:51:36 -03:00
ariel-
490f807a42 Core/Scripts: fix nopch build 2018-02-12 00:47:14 -03:00
ariel-
dfa861593e Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 2018-02-12 00:21:26 -03:00
ariel-
546a605bd0 Core/Spells: implement SPELLVALUE_CRIT_CHANCE and SPELL_ATTR4_INHERIT_CRIT_FROM_AURA
Closes #18813
2018-02-12 00:21:26 -03:00
ariel-
52873a7072 Core/Spells: calculate crit chance only for spells that do damage/healing
Refs #18813
2018-02-12 00:21:26 -03:00
Treeston
bf3973dc61 Scripts/CoT4: Stratholme Residents should no longer rudely interrupt Arthas by punching him in the face while he's giving a righteous sermon on his reasons for wiping them all out. 2018-02-12 03:47:31 +01:00
Treeston
e4e6e2209c Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent.
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.

Tagging #20310.
2018-02-12 03:25:05 +01:00
Treeston
f6bf9bc04d Revert "Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310)"
This reverts commit 6ff71dffbb.
2018-02-12 03:23:54 +01:00
Treeston
b243a7929b Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310. 2018-02-12 03:08:34 +01:00
Treeston
6ff71dffbb Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310) 2018-02-12 02:58:51 +01:00
Treeston
92a8f65203 DB/Quest: fix Territorial Trespass SmartScript to use proper target type (tag #20310) 2018-02-12 02:58:23 +01:00
Treeston
fe1ba18905 Core/Movement: WaypointMovementGenerator cleanup 2018-02-12 02:57:55 +01:00
Treeston
d02f481d9a Core/Movement: Creatures' idle movement generator can no longer override player mover control.
Tagging #20310, partial fix.
2018-02-12 01:50:36 +01:00
ariel-
477878630e Core/Scripts: implemented Combined Toxins proc only from poisons 2018-02-11 21:10:56 -03:00
ariel-
9d0e90829c Core/Auras: fix periodic ticks proc after previous commit 2018-02-11 21:09:41 -03:00
ariel-
b42ade918a Core/Spells: require phasemask set for periodic damage procflag
Closes #21379
2018-02-11 20:42:06 -03:00
ariel-
da7501144d DB/Spell: fix Unstable Affliction and Vampiric Touch dispel double dipping from SP
Closes #21393
2018-02-11 19:49:22 -03:00
jackpoz
3576a38f6c Core/Player: Add some asserts
Assert PlayerInfo for race/class pair in a few Player functions
2018-02-11 17:43:12 +01:00
jackpoz
5aba5c7aff Scripting/Obsidian Sanctum: Fix crash
Fix crash caused by calling Reset() in constructor (which is not allowed)
2018-02-11 15:53:30 +01:00
Jildor
edd6e7d524 Whitespace cleanup in Transaction.cpp
Removing white space after commit 54b0b8f5ea
2018-02-11 13:23:53 +01:00
Aokromes
638cb33ea0 Update characters_database.sql 2018-02-11 09:08:12 +01:00
Killyana
201b0b3720 DB/SAI: Mire Hydra 2018-02-10 21:10:51 +01:00
Killyana
e4817aa822 DB: Fix some DB errors
Ref 3acd9a7c4f
2018-02-10 20:42:12 +01:00
jackpoz
54b0b8f5ea Shared/Database: Improve dead-lock error handling
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times
2018-02-10 16:07:56 +01:00
Killyana
6952d0a5ea DB/Creature: Arcatraz Sentinel
Updates #21156
2018-02-09 23:19:02 +01:00
Treeston
a4fc32dd86 Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep) 2018-02-09 19:21:49 +01:00
Keader
2994abeae6 Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
ty sirikfoll :)
2018-02-09 16:02:00 -02:00
Treeston
b456915f9a Game/AI: InvalidAIException internal cleanup 2018-02-09 18:07:57 +01:00
ariel-
303efcf0e4 Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC
Thanks to killerwife for the heads-up
2018-02-08 23:18:45 -03:00
Killyana
b4c16971cb DB: Fix the previous commit 2018-02-08 23:14:07 +01:00
Killyana
3acd9a7c4f DB/Creature: Remove Tamed Sporebat spawns, summoned as pets by other npcs 2018-02-08 22:26:58 +01:00
ZenoX92
23dd63da98 DB/Gossip: Zorbin Fandazzle
Closes #21369
2018-02-08 17:35:56 +01:00
ZenoX92
fa1db68fec DB/Quest: Zapped Giants
Closes #21370
2018-02-08 17:34:38 +01:00
ZenoX92
58bb542e50 DB/Quest: Weapons of Spirit
Closes #21371
2018-02-08 17:34:00 +01:00
ZenoX92
c60eef9cda DB/Misc: Feralas Quest Emotes (Horde)
Closes #21372
2018-02-08 17:31:45 +01:00