Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-18 00:18:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
29,288 Commits 4 Branches 146 Tags
adae429aa01028911337443166b336a2ea8a6762
Commit Graph

20767 Commits

Author SHA1 Message Date
Treeston
ac8b9be5d6 Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156. 2018-02-13 15:47:44 +01:00
Treeston
fe3b4de1cd Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310. 2018-02-13 15:47:04 +01:00
ccrs
28c6db0807 Core/Movement: fe1ba18905 followup 
ref fe1ba18905 (r27507316)

plus I noticed a logic error on speedchange call
 2018-02-12 23:44:18 +01:00
ariel-
59fb0a581c Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice 2018-02-12 19:32:59 -03:00
ariel-
bc2a4c816d Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic) 
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)
 2018-02-12 19:04:01 -03:00
ariel-
c7095375c3 Core/Unit: kill unused parameter from SpellxxxBonusTaken 2018-02-12 18:36:10 -03:00
ariel-
404240fb68 Core/Scripts: remove Tenacity hack, implemented with proper aura 2018-02-12 18:35:06 -03:00
tkrokli
57553ed96a Build fix (unused parameter 'stack' in Unit.cpp) 
Ref. commit 4d14f613f3
 2018-02-12 22:22:34 +01:00
Wilcalaf
0c1aaac219 Archaedas should properly start now when clicking on the altar. (#21401) 2018-02-12 21:38:08 +01:00
ariel-
4d14f613f3 Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras 
- Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses
- Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty)
 2018-02-12 16:52:59 -03:00
ariel-
e73bfe8df8 Core/Spells: implemented SpellPriority field from SpellEntry to cleanup charged mod proc behaviour 
- Only one charged mod will be consumed per SpellMod apply, and it'll be compared against other mod priority
- This is proper way of handling Backdraft/Backlash and Deathchill/Killing Machine

Thanks to killerwife for info
 2018-02-12 03:09:22 -03:00
ariel-
3edf90d167 Core/Scripts: fix nopch build mk II 2018-02-12 00:51:36 -03:00
ariel-
490f807a42 Core/Scripts: fix nopch build 2018-02-12 00:47:14 -03:00
ariel-
dfa861593e Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 2018-02-12 00:21:26 -03:00
ariel-
546a605bd0 Core/Spells: implement SPELLVALUE_CRIT_CHANCE and SPELL_ATTR4_INHERIT_CRIT_FROM_AURA 
Closes #18813
 2018-02-12 00:21:26 -03:00
ariel-
52873a7072 Core/Spells: calculate crit chance only for spells that do damage/healing 
Refs #18813
 2018-02-12 00:21:26 -03:00
Treeston
e4e6e2209c Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent. 
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.

Tagging #20310.
 2018-02-12 03:25:05 +01:00
Treeston
f6bf9bc04d Revert "Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310)" 
This reverts commit 6ff71dffbb.
 2018-02-12 03:23:54 +01:00
Treeston
b243a7929b Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310. 2018-02-12 03:08:34 +01:00
Treeston
6ff71dffbb Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310) 2018-02-12 02:58:51 +01:00
Treeston
fe1ba18905 Core/Movement: WaypointMovementGenerator cleanup 2018-02-12 02:57:55 +01:00
Treeston
d02f481d9a Core/Movement: Creatures' idle movement generator can no longer override player mover control. 
Tagging #20310, partial fix.
 2018-02-12 01:50:36 +01:00
ariel-
477878630e Core/Scripts: implemented Combined Toxins proc only from poisons 2018-02-11 21:10:56 -03:00
ariel-
9d0e90829c Core/Auras: fix periodic ticks proc after previous commit 2018-02-11 21:09:41 -03:00
ariel-
b42ade918a Core/Spells: require phasemask set for periodic damage procflag 
Closes #21379
 2018-02-11 20:42:06 -03:00
jackpoz
3576a38f6c Core/Player: Add some asserts 
Assert PlayerInfo for race/class pair in a few Player functions
 2018-02-11 17:43:12 +01:00
jackpoz
5aba5c7aff Scripting/Obsidian Sanctum: Fix crash 
Fix crash caused by calling Reset() in constructor (which is not allowed)
 2018-02-11 15:53:30 +01:00
Jildor
edd6e7d524 Whitespace cleanup in Transaction.cpp 
Removing white space after commit 54b0b8f5ea
 2018-02-11 13:23:53 +01:00
jackpoz
54b0b8f5ea Shared/Database: Improve dead-lock error handling 
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times
 2018-02-10 16:07:56 +01:00
Treeston
a4fc32dd86 Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep) 2018-02-09 19:21:49 +01:00
Keader
2994abeae6 Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload 
ty sirikfoll :)
 2018-02-09 16:02:00 -02:00
Treeston
b456915f9a Game/AI: InvalidAIException internal cleanup 2018-02-09 18:07:57 +01:00
ariel-
303efcf0e4 Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC 
Thanks to killerwife for the heads-up
 2018-02-08 23:18:45 -03:00
Keader
31ad6358fb Core/Scripts: Fixed tabs issues introduced in 5bef3e426a 2018-02-08 10:16:19 -03:00
Keader
5bef3e426a Core/Scripts: Fixed possible crashs related with JustDied 2018-02-08 10:05:08 -03:00
ariel-
b490d3f5ad Core/Scripts: fix non-functional Celestial Planetarium Access GO 
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982
 2018-02-06 13:59:08 -03:00
sirikfoll
cfaa4e6caf Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor 
Closes #20727
 2018-02-05 21:27:13 -02:00
sirikfoll
14b6e3bbb3 Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos) 2018-02-05 21:14:26 -02:00
Shauren
713bf944ae Build fix 2018-02-05 21:08:09 +01:00
Shauren
2fd9dc2edb Core/Scripts: Fixed ENSURE_AI assertion failures when used in Reset()/InitializeAI() hooks with hotswap 
Updates #20727
 2018-02-05 20:52:19 +01:00
ariel-
ed931cfa19 Core/ScriptSystem: AfterHit hook can't modify damage/healing, so log it 
- Also added const to getter members
 2018-02-05 14:43:11 -03:00
ariel-
650a92dc9f Core/Channel: properly notify client about invalid channel names 
Closes #16190
 2018-02-05 13:45:52 -03:00
Treeston
4bd2d28119 Revert "Scripts/Northrend: Malygos now uses modifiable threat list when teleporting after vortex. Fixes a crash. Closes #21315." 
This reverts commit 6bbc95f3a0, which is made unnecessary by 65709e1c30.
 2018-02-05 10:14:00 +01:00
ariel-
65709e1c30 Core/Spells: fix logic error causing near teleports to drop combat for players 
Closes #21362
 2018-02-04 22:47:53 -03:00
ariel-
e979a58d17 Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells 
- It is already called at Unit::DealDamage
 2018-02-04 22:07:10 -03:00
Treeston
6bbc95f3a0 Scripts/Northrend: Malygos now uses modifiable threat list when teleporting after vortex. Fixes a crash. Closes #21315. 2018-02-05 01:38:56 +01:00
Treeston
4cb13af4fa Core/Threat: Custom ThreatListIterator that transparently iterates over the backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation. 
Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view.
 2018-02-05 01:33:41 +01:00
ariel-
2d2c43f4b9 Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells 
Closes #20597
 2018-02-04 21:28:15 -03:00
ariel-
9fc732eb97 Core/Spells: kill unused parameter from Spell constructor 
Added in 1f2292af79
 2018-02-04 20:15:38 -03:00
jackpoz
71feb2149e Core/Misc: Fix no-pch build 2018-02-04 21:54:06 +01:00