Commit Graph

32608 Commits

Author SHA1 Message Date
jackpoz
adc7cd3cee Core/Misc: Fix static analysis issues reported by Coverity Scan 2020-06-03 20:49:31 +02:00
Gildor
90e00c3e2a Core/Spells: Fix ammo consumption (#24736) 2020-06-02 20:34:44 +02:00
Shauren
0e9eb8e7f5 Core/PacketIO: Validate AddonInfo size
Closes #24734
2020-06-01 23:43:38 +02:00
Ovah
43ef610fe0 Core/Units: flight and hover checks will now consider movement template data as well as manually set flight states
- manually set flight states via auras and scripts will no longer be ignored
- restored movement template consideration when generating pathings
- renamed IsLevitating to IsGravityDisabled to reflect the referenced movement flag's name
2020-06-01 15:58:31 +02:00
jackpoz
48c5c0d7a2 Core/Misc: Fix Clang 10 build warnings 2020-05-31 15:52:28 +02:00
jackpoz
e3dfab52a6 CI/CircleCI: Switch to Ubuntu 20.04 and MySQL 8 2020-05-31 15:40:15 +02:00
Giacomo Pozzoni
8c09b6e58b Cherry-pick some cmake commits (#24720)
* Build system: Support  new in cmake 3.17 Ninja Multi-Config generator

(cherry picked from commit 369b618d4f)

* Build system: Fixed PCH with MSVC & Ninja generator

(cherry picked from commit d669f46b6d)

* Core: Fix clang 10 warnings

(cherry picked from commit 7272508cb4)

# Conflicts:
#	src/common/Utilities/Util.h
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/game/Entities/Object/Position.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Guilds/GuildFinderMgr.h
#	src/server/game/Movement/Spline/MoveSplineFlag.h
#	src/server/shared/Dynamic/LinkedList.h

* Build system: Set -Wno-deprecated-copy only for clang 10

(cherry picked from commit 7fdeb259ba)

* Core/Misc: GCC build and warning fixes

(cherry picked from commit 4d69cc1c56)

# Conflicts:
#	src/common/Utilities/Util.cpp
#	src/server/database/Database/MySQLConnection.cpp
#	src/server/game/Battlefield/Zones/BattlefieldTB.cpp
#	src/server/game/DataStores/M2Stores.cpp
#	src/server/game/DungeonFinding/LFGMgr.cpp
#	src/server/game/DungeonFinding/LFGPlayerData.cpp
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Object/Updates/UpdateFields.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/RestMgr.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/GuildPackets.h
#	src/server/game/Spells/Auras/SpellAuraEffects.cpp
#	src/server/game/Spells/Auras/SpellAuras.cpp
#	src/server/game/Spells/Spell.cpp
#	src/server/game/Spells/SpellInfo.cpp
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Argus/AntorusTheBurningThrone/boss_garothi_worldbreaker.cpp
#	src/server/scripts/Kalimdor/HallsOfOrigination/instance_halls_of_origination.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/instance_icecrown_citadel.cpp
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_mimiron.cpp
#	src/server/scripts/Northrend/zone_sholazar_basin.cpp
#	src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp
#	src/server/scripts/Outland/GruulsLair/instance_gruuls_lair.cpp
#	src/server/scripts/Outland/HellfireCitadel/BloodFurnace/instance_blood_furnace.cpp
#	src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
#	src/tools/vmap4_extractor/gameobject_extract.cpp
#	src/tools/vmap4_extractor/model.cpp
#	src/tools/vmap4_extractor/vec3d.h

* Build system: Print found git version when warning about it being too old

(cherry picked from commit 1ae72db201)

* Build system: Removed hard requirement on BOOST_ROOT being set as environment variable, it can now be also passed as command line argument to cmake and fix compile warning with boost 1.73

(cherry picked from commit 161944b764)

# Conflicts:
#	dep/boost/CMakeLists.txt

* Remove some code that was already removed from 335 and then cherry-picked into master

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-31 14:17:26 +02:00
offl
0eb9b5bfe6 DB/Creature: Add missing emote to Dragonflayer Forge Master in heroic mode
Closes #24719
2020-05-30 21:49:34 +02:00
offl
b938c26090 DB/Creature: Totem of Spirits
Closes #17183
2020-05-30 21:46:19 +02:00
offl
487dae864f DB/Creature: Improve Deathforge Mine
Closes #24721
2020-05-30 21:44:14 +02:00
Keader
a72197911e Scripts/Ulduar: Codestyle fix
* Making jackpoz happy xD
2020-05-30 13:13:02 -03:00
Giacomo Pozzoni
141ada19b0 Cherry pick some db commits (#24713)
* Core/DBLayer: Implement async transaction completion callbacks

(cherry picked from commit 0f0ca3a919)

# Conflicts:
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/bnetserver/Server/Session.cpp
#	src/server/bnetserver/Server/Session.h
#	src/server/database/Database/Transaction.cpp
#	src/server/game/Handlers/CharacterHandler.cpp
#	src/server/game/Handlers/SpellHandler.cpp
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSocket.cpp
#	src/server/game/Server/WorldSocket.h

* Core/Misc: Fixed char enum packet sometimes not showing newly created character when client latency is too low

(cherry picked from commit fc9d2e728e)

# Conflicts:
#	src/server/game/Handlers/CharacterHandler.cpp

* Fix no-pch build

* Core/Player: Wait for correct transaction on character creation

(cherry picked from commit 01c68b2aa2)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp

* Fix warning

* Remove unused login transaction

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-30 17:43:54 +02:00
Keader
00bc6e7d54 Scripts/BloodFurnace: Fixed Broggok stopping work after wipe
By: Rushor
2020-05-30 11:57:30 -03:00
Killyana
52c1415239 DB: Eva Sarkhoff and Doctor Theolen Krastinov, the Butcher
Closes #24711
For 3.3.5 only
2020-05-30 16:54:33 +02:00
Keader
05eeaade3e Scripts/Ulduar: Fixed XT002 Heart health regeneration 2020-05-30 11:47:43 -03:00
offl
9ebf7b1272 DB/SAI: Convert & update support for Forest Frog to SAI
Closes #24714
2020-05-30 16:37:59 +02:00
Keader
456aaf2cea Scripts/Pet: Fixed Mirror Image trying attacking invalid targets 2020-05-30 11:31:53 -03:00
Gildor
6c1a874e57 Scripts/Trial Of The Crusader: Fixed Anub'arak Pursuing Spikes movement (#24715) 2020-05-30 08:50:33 -03:00
ForesterDev
f7ac6296b6 Core/PacketIO: Create BankHandler & update bank opcodes to new packet class (#24695)
* Core/PacketIO: Create BankHandler & update bank opcodes to new packet class

(cherry picked from commit 478e86c074)

* fix nopch build

* Update SMSG_BUY_BANK_SLOT_RESULT

* fix naming

* fix copypaste error

Co-authored-by: Luzifix <luzifix19@gmail.com>
2020-05-29 18:26:53 +02:00
Shauren
f0060496f9 Core/Networking: Switch to intrusive variant of MPSC queue to halve the number of memory allocations for packet sending (#24659) 2020-05-29 18:17:24 +02:00
offl
0ba62a45e5 DB/SAI: Remove useless event params for linked events
Closes #24707
2020-05-28 15:20:04 +02:00
offl
77ae76852b DB/SAI: Fix targets for group quests
Closes #24706
2020-05-28 15:18:14 +02:00
Killyana
fef63de7ff DB/SAI: Fix some SAI targets 2020-05-28 14:56:05 +02:00
Killyana
f885706413 DB/Quest: Fix some targets for the quest When the Cows Come Home 2020-05-27 23:22:29 +02:00
offl
12679fdd08 DB/SAI: Fix typos in two timed action lists
Closes #24700
2020-05-27 16:03:53 +02:00
offl
9d7f033bf3 DB/SAI: Remove excess event flags from timed action lists
Closes #24701
2020-05-27 15:36:13 +02:00
Paraciusz
5b7b21c362 Core/PacketIO: Fixed the problem of not displaying random properties of equipment when inspecting other player equipment. (#24696) 2020-05-26 14:53:35 +02:00
Gildor
3ab970aa47 Scripts/Ulduar: Fix Flame Leviathan movement (#24673) 2020-05-26 13:20:38 +02:00
offl
e48c415156 DB/Quest: Convert & update support for 'Mark V is Alive!' to SAI
Closes #24686
2020-05-26 00:01:54 +02:00
offl
1316ca482d DB/Quest: Convert & update support for 'When the Cows Come Home' to SAI
Closes #24685
2020-05-25 23:32:50 +02:00
offl
0e7cabd7f1 DB/Quest: Convert & update support for 'Cuergo's Gold' to SAI
Closes #24675
2020-05-25 23:10:12 +02:00
Killyana
5856f520bb Boss/Script: Remove Hex Lord Malacrass wrong equipment from the script and use the one from the DB 2020-05-25 15:52:23 +02:00
offl
e6db72d586 DB/Creature: Fix some creatures position in Zul'Aman & add missing
Closes #24690
2020-05-25 15:28:16 +02:00
dr-j
daa7b11ae2 DB/GameObject: Add 58 More Netherwing Eggs
Closes #24688
2020-05-25 14:55:01 +02:00
offl
82dc3a2aef DB/SAI: Fix some wrong values in timed action lists
Closes #24693
Closes #24692
2020-05-25 14:48:08 +02:00
NoName
1680f2221e Core/Misc: Sync some funcion names with master (#24683) 2020-05-24 21:56:34 +02:00
Killyana
9683ce99eb DB/Creature: Remove Ossirian Crystal Trigger as spawned by script
Closes #24681
2020-05-24 21:06:09 +02:00
NoName
89193c3548 Scripts/RuinsOfAhnQiraj: Crystal handling (#24679)
+ make crystal usable with animation and despawn after use;
+ small code update;
+ spell rearrange;
+ define some magic numbers;
+ update crystal coordinates from sniffed data
2020-05-24 20:45:28 +02:00
Gildor
dd3fbf426c Scripts/Icecrown Citadel: Fix Sindragosa movement when Wipe in fly phase (#24665) 2020-05-24 20:38:24 +02:00
NoName
2efaf1dda8 Entities/Player: Restore old checks for UpdatePvPFlag (#24372)
Partly revert 671052575a
+ implemented timer reset to 300s after relog never worked, therefore removing that part;
+ reverting other parts with 300s timer changes, as not needed;
2020-05-24 20:35:34 +02:00
Killyana
e0b0586afc DB/Quest: Birds of a Feather
Closes #24687
2020-05-24 19:23:55 +02:00
Killyana
73d55f6968 DB/Spell: Fix rampart of skulls and upper spire teleport orientation 2020-05-23 23:53:52 +02:00
jackpoz
cbd6c89822 CI/GitHub: Remove PR GitHub Action because of current limitations
GitHub Actions triggered when creating a Pull Request receive a read-only token that makes them useless when trying to do anything on GitHub.
Useful links:
- https://github.com/actions/first-interaction/issues/10
- https://github.com/actions/labeler/issues/12
- https://github.com/actions/labeler#pull-request-labeler

(cherry picked from commit 59e8b98bef)
2020-05-23 18:44:18 +02:00
jackpoz
f46c84fd9e CI/GitHub: Add action to label issues
(cherry picked from commit ce10a9482a)

CI/GitHub: Add action to label pull requests

(cherry picked from commit 92a289e455)

CI/GitHub: Fix github actions syntax

(cherry picked from commit 0435ecc8f5)

CI/GitHub: Rename jobs

(cherry picked from commit 58013167de)
2020-05-23 18:15:28 +02:00
Killyana
fd66e291b5 DB/Quest: Convert "HELP!" & "Corki's Gone Missing Again!" & "Cho'war the Pillager" to SAI
Closes #24649
2020-05-23 02:44:18 +02:00
Killyana
5ba021844d DB/GameObject: Remove Jump-a-tron 4000 from the DB
Ref #24668
2020-05-22 01:37:37 +02:00
offl
2008cb7dd3 DB/Quest: Convert & update support for 'Prisoners of Wyrmskull' to SAI
Closes #24650
2020-05-22 00:32:06 +02:00
offl
0cfd63fd26 DB/GameObject: Convert & update support for Shrine of the Eagle / Falcon / Hawk to SAI
Closes #24647
2020-05-21 23:52:02 +02:00
offl
626aeb5817 DB/Creature: Convert Sayge to SAI
Closes #24663
2020-05-21 23:34:59 +02:00
jackpoz
013301088d Scripts/Misc: Fix issues reported by ASan 2020-05-21 22:17:13 +02:00