Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-21 17:54:48 +01:00
Code Issues Packages Projects Releases Wiki Activity
7,715 Commits 4 Branches 146 Tags
be739e99009c2796d0153e7b3dabcf819e915541
Commit Graph

6849 Commits

Author SHA1 Message Date
Anubisss
be739e9900 Use GUIDs instead of "global" pointers in ~all boss/instance scripts. 
GUIDs are most safer than pointers and in some cases can avoid segmentation faults.

== - ==

Let me show a simple example:

We have a pointer to a creature: Creature *pCreature;

and try to search a creature and store it in the pointer:
pCreature = SearchCreature(ID);

We can check simply if the creature found or not:
if(pCreature)
- if this give true: creature found and we have a memory address which points to the creature
- if this give false: creature not found and this is a NULL pointer

Suppose that we have a valid pointer, so creature found.
We wanna use that pointer somewhere, for example in script phase 3.
But we delete the creature(from world) in phase 1.
In phase 3:
if(pCreature)
    pCreature->DoSomeShit();
The if condition gives true, but pCreature points to an _invalid_ address.
In that address maybe have "nothing" or another creature's object or a player or anything else, dont know that.

~~ - ~~

Let me show the correct way:
Creature's GUID: uint64 CreatureGUID;

search the creature and set the GUID:
Creature *pCreature = SearchCreature(ID);
CreatureGUID = pCreature ? pCreature->GetGUID() : 0; // if pCreature is NULL set the GUID to 0

So we have a GUID and not a pointer.
We can get the creature from that GUID:
Creature *pCreature = GetCreature(CreatureGUID);
and we can simply check it is valid or not(found or not):
if(pCreature)

So we deleted the creature in phase 1 and try to use it in phase 3:
Creature *pCreature = GetCreature(CreatureGUID);
And this gives NULL because GetCreature() can't find the creature which GUID is CreatureGUID.

if(pCreature) // pCreature is NULL
    pCreature->DoSomeShit(); // DoSomeShit() not called

== - ==

Remove some not used variables.
Some clean.

TODO: Should search/fix these in zones scripts.

--HG--
branch : trunk
 2010-03-27 13:54:38 +01:00
Trazom62
099ef2a9b6 Fix InstanceData::DoCompleteAchievement (and crash in AchievementMgr::CompletedAchievement). 
Remove support of no longer existing achievement "The Party is Over". Thanks JuliuSZS.
Fixes issue #1318.

--HG--
branch : trunk
 2010-03-27 13:45:39 +01:00
Trazom62
eedd43efa5 Fix UT/Ingvar the plunderer script. 
Fixes issue #1034.

- Remove setDisplayID hack and use UpdateEntry to fix Ingvar Kill Credit related achievements.
- code style cleaning.

Requires DB update to set loot from Ingvar Human (23954) to Undead (23980) (in normal and heroic).

--HG--
branch : trunk
 2010-03-27 13:14:13 +01:00
_manuel_
ecba58c8f6 Fix hardmode achievement from Obsidiam Sanctum 
Fix Flame Tsunami aura and visual effects

Author: Gyullo

--HG--
branch : trunk
 2010-03-26 23:16:22 -03:00
_manuel_
2cb7a31512 Corrected script for Glyph of Feral Spirit, aura must be checked on Owner not Pet. By Gyullo. 
--HG--
branch : trunk
 2010-03-26 22:19:03 -03:00
_manuel_
49c5be6d80 Improvement in npc_mageguard_dalaranAI. 
--HG--
branch : trunk
 2010-03-26 22:13:04 -03:00
_manuel_
2796f08297 Support for spell Disarm Trap. 
--HG--
branch : trunk
 2010-03-26 22:04:38 -03:00
Xanadu
180651d95e A visually better way to handle Avenger Wrath blocking of immunity shields. 
--HG--
branch : trunk
 2010-03-26 22:21:33 +01:00
Brian
ec72846da4 * Check for incorrect settings for AHbot 
* Patch by click

--HG--
branch : trunk
 2010-03-26 13:07:24 -06:00
Spp
cd372966af * Add support to save and load worldstates. 
will be mainly used by outdoorPvP system
* Update next arena auto distribute points time to custom worldstate

--HG--
branch : trunk
 2010-03-26 16:48:33 +01:00
Xanadu
d0c10d44b8 Merge 
--HG--
branch : trunk
 2010-03-25 17:09:45 +01:00
Xanadu
20de79f6ba Fixed Forbearance. Also self-cast LoH will now correctly prevent Avenging Wrath for 30 s. Closes issue #1270. Thanks to _manuel_ for research. 
--HG--
branch : trunk
 2010-03-25 17:09:05 +01:00
Tartalo
7d6923d8c7 BlackRock Depths: Some improvements, by antihrists 
Fix Tomb of Seven event
Fix Shadowforge braziers
GO handling for Magmus

--HG--
branch : trunk
 2010-03-25 13:33:49 +01:00
Tartalo
5bd9bfcdda Merge 
--HG--
branch : trunk
 2010-03-25 10:34:41 +01:00
Tartalo
080229fec3 Gundrak, Gal'Darah: Script improvements by pivonroll 
Fix some Spell IDs & timers
Implement transformation

--HG--
branch : trunk
 2010-03-25 10:32:07 +01:00
silverice
5f60483033 cleanups in vehicle accessories storage 
transfer accesory list by pointer, make it constant

--HG--
branch : trunk
 2010-03-25 04:09:26 +02:00
Tartalo
5a2e20b765 Gundrak: Cleanup 
--HG--
branch : trunk
 2010-03-25 02:49:41 +01:00
Brian
66a890ca0f * Allow the use of referenced trainer / vendor data. 
* This will reduce the size of the trainer / vendor tables a LOT.
* Current tables will continue to work as/is until the refs can be made.
* Huge thanks to XTElite1
* Credits for patch to Cycrow

--HG--
branch : trunk
 2010-03-24 18:27:09 -06:00
Xanadu
2f17cff295 Cleaned and tidied-up the mechanic immunity handler 
--HG--
branch : trunk
 2010-03-24 20:35:04 +01:00
Tartalo
41ad4fffeb Drak'Tharon Keep, Novos the Summoner: some improvements by pivonroll 
Fix resseting issues
Better IA for adds

--HG--
branch : trunk
 2010-03-24 13:34:49 +01:00
Tartalo
80cb722bba Drak'Tharon Keep: Cleanup 
--HG--
branch : trunk
 2010-03-24 12:31:00 +01:00
Tartalo
90b19607a1 Merge 
--HG--
branch : trunk
 2010-03-24 00:21:59 +01:00
Tartalo
50c5d81a79 Merge 
--HG--
branch : trunk
 2010-03-24 00:21:31 +01:00
Tartalo
c7f5d95a1d Azjol Nerub, Azjol Nerub: Cleanup 
--HG--
branch : trunk
 2010-03-24 00:13:00 +01:00
Tartalo
29201cf687 Azjol Nerub, Ahn'Kahet: cleanup 
--HG--
branch : trunk
 2010-03-23 22:34:31 +01:00
Trazom62
76a8d8a62c Implement Tharon'ja achievements (Requires DB Data). 
--HG--
branch : trunk
 2010-03-23 21:31:30 +01:00
Trazom62
72c3c4696b Implement Tribunal of Ages Achievements (Requires DB Data) 
--HG--
branch : trunk
 2010-03-23 20:31:55 +01:00
n0n4m3
5fe2454b24 Fix one WPE exploit. 
When apply more 6 gems, and after  player logout, server crash, also apply code style and cleanup.

--HG--
branch : trunk
 2010-03-23 14:38:31 -05:00
Trazom62
1e9de7dbd7 Implement Four-Horsemen achievements (requires DB Data). 
Fixes issue #1107.

--HG--
branch : trunk
 2010-03-23 19:15:17 +01:00
Xanadu
cfc094040f Added support for maximum allowed player level for quests. By Gyullo. 
--HG--
branch : trunk
 2010-03-23 16:10:18 +01:00
Tartalo
a348b591a7 Violet Hold: Exploit fix 
Now bosses reset if they're hitted when their door is closed

--HG--
branch : trunk
 2010-03-23 12:48:28 +01:00
Tartalo
3cd729294e Gundrak: Fix for Eck the Ferocious spawning 
--HG--
branch : trunk
 2010-03-23 12:25:01 +01:00
Tartalo
2c2b75fb55 Ahn'Kahet: Code cleansing 
--HG--
branch : trunk
 2010-03-22 23:24:59 +01:00
Tartalo
2e5c5d3e1b Hall of Lightning: Fix Encounter state saving to db 
Thanks Aokromes, Baraka & Spawn

--HG--
branch : trunk
 2010-03-22 22:48:05 +01:00
Tartalo
c80b67cebd Nexus, Anomalus: Summons rifts only once. Blizzlike 3.3.2 update 
--HG--
branch : trunk
 2010-03-22 22:44:54 +01:00
Tartalo
0d1bd05ce7 Gundrak: Code cleansing 
--HG--
branch : trunk
 2010-03-22 22:36:26 +01:00
Tartalo
df45e38ba6 Gundrak: Implement Eck the Ferocious spawning 
Based on pivonroll's code but rewrited from scratch

--HG--
branch : trunk
 2010-03-22 22:27:37 +01:00
Trazom62
e018c4cc7b Implemented new achievement criteria data: 
* ACHIEVEMENT_CRITERIA_DATA_TYPE_S_EQUIPED_ITEM_LVL (item level and item quality).

Implemented achievement criteria:
* ACHIEVEMENT_CRITERIA_TYPE_LOOT_EPIC_ITEM
* ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM

Update ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM implementation. Requires DB update to use new criteria data.

Thanks VladimirMangos.

--HG--
branch : trunk
 2010-03-22 18:32:38 +01:00
XTZGZoReX
f6e516d819 * Fix CRLF. 
--HG--
branch : trunk
 2010-03-22 17:47:38 +01:00
silverice
d4c3620557 restore work of IsInMap check 
--HG--
branch : trunk
 2010-03-22 18:46:48 +02:00
Trazom62
4478ccf6c4 Add script VoA/Koralon and Toravon. Thanks WarHead. 
Fixes issue #1231.

--HG--
branch : trunk
 2010-03-22 15:33:44 +01:00
Trazom62
248286c08d Fix Crash in XT-002 (Gravity Bomb proc). Fixes issue #734. 
Fix compilation warning.
Fix typo in Freya soundid.

--HG--
branch : trunk
 2010-03-22 14:07:08 +01:00
_manuel_
e34a7d3134 Merge 
--HG--
branch : trunk
 2010-03-21 15:22:40 -03:00
Machiavelli
a4e98f50d0 Fix mounts in Arena's/BGs 
--HG--
branch : trunk
 2010-03-21 19:12:04 +01:00
_manuel_
fae77f2621 Add additional field for storage of speed_run rate of creature 
This allow independent rate of walk vs run speed. Existing field renamed to explicit speed_walk.

Note that default database rate for run is a result of the most common value seen, 8.0/7.0

Author: NoFantasy.

--HG--
branch : trunk
 2010-03-21 14:57:49 -03:00
Tartalo
4a7b208eab Naxxramas, Noth the Plaguebringer: Adjust timers, by scarymovie87 
Closes issue #172.

--HG--
branch : trunk
 2010-03-21 18:44:28 +01:00
Tartalo
2c34b6d376 The Obsidiam Sanctum: Several updates, by Ouden 
Portal event, Flame Tsunami, Twilight Eggs, Twilights Fissure, Achievements in Hard Mode
Closes issue #1015.

--HG--
branch : trunk
 2010-03-21 18:32:50 +01:00
Machiavelli
fe30fc8bf2 Securer check for instance template for previous commit 
--HG--
branch : trunk
 2010-03-21 18:17:20 +01:00
Machiavelli
48051d1cd6 Add support field 'allowMount' to instance_template table (see http://trinitydatabase.org/index.php?/topic/14994-7656-instance-template/), this will define whether or not mounting is allowed in an instance, instead of defining it hard coded in the core. 
--HG--
branch : trunk
 2010-03-21 17:34:25 +01:00
Trazom62
450b2fba9d Update Script Ulduar/XT-002. Thanks Dakeyras. Fixes issue 1074. 
Add script texts for all ulduar bosses and adds. Mainly from wowwiki, Thanks.
Some code style cleanup.
Still WiP.

--HG--
branch : trunk
 2010-03-21 17:17:34 +01:00