ccrs
44e9572a77
Core/Creature: add a const spell-focus-check method and remove a nasty const_cast from IsMovementPreventedByCasting()
...
closes #23670
maybe #22857 ?
(cherry picked from commit 8e88f4501d )
2021-12-18 00:35:14 +01:00
ccrs
4db13853f7
Core/Unit: rename more things
...
Workaround prework till actual facing system rework arrives
(cherry picked from commit 3a4021be50 )
2021-12-18 00:34:15 +01:00
ccrs
a58881d6da
Core/Unit: rename more methods
...
Workaround prework till actual facing system rework arrives
(cherry picked from commit 85ad0befc5 )
2021-12-18 00:29:38 +01:00
ccrs
be4ed9152c
Core/Unit: rename IsFocusing method
...
Workaround prework till actual facing system rework arrives
(cherry picked from commit ec9f15a5ff )
2021-12-18 00:25:14 +01:00
Wyrserth
2f2de26311
Core/Spell: honor IsStackableOnOneSlotWithDifferentCasters() when deciding if an aura should stack from different casters or not. ( #23579 )
...
Fixes #23387 and #22818 .
(cherry picked from commit 0b87dffc35 )
2021-12-18 00:09:49 +01:00
Treeston
3db58c4d96
Core/SmartAI: SmartAI creatures no longer process health-based hooks after death.
...
(cherry picked from commit 1faa54fe8b )
2021-12-18 00:03:55 +01:00
Sorikoff
1fd0ba816f
Scripts/Spells: Devour Humanoid ( #23660 )
...
(cherry picked from commit 0d53a0ba98 )
2021-12-18 00:01:56 +01:00
Giacomo Pozzoni
92fc09b1b5
3.3.5 Don't allow to summon dead hunter pets ( #23271 )
...
* Core/Player: Add support to SMSG_PET_TAME_FAILURE
* Core/Pet: Don't summon dead pets when using "Call pet"
(cherry picked from commit a0f8ce14e9 )
2021-12-17 23:56:51 +01:00
Giacomo Pozzoni
e26b31509e
Core/Misc: Fix build warning
...
(cherry picked from commit 543fe77d2e )
2021-12-17 23:23:30 +01:00
Treeston
8839fa3fe2
Core/Chat: Custom channel preservation rewrite. Channel data is now loaded at startup, and written to the DB periodically, instead of both things happening in real time.
...
(cherry picked from commit fedf1f557b )
2021-12-17 23:22:13 +01:00
Treeston
8c3eb07889
Scripts/FollowerAI: Some cleanup:
...
- FollowerAI properly resumes follow after evading.
- Removed duplicated getters from CreatureAI (IsEscorted vs IsEscortNPC), they were used to do the same thing
- FollowerAI properly assists in combat.
- FollowerAI properly despawns if quest is abandoned.
- FollowerAI now supports dynamic respawning for escort NPCs.
(cherry picked from commit 3d4bebd8d9 )
2021-12-17 23:05:55 +01:00
Ovah
d01a22f58e
Core/Spells: fixed root behaivior of creatures that are being rooted via movement template while getting a root aura removed ( #23216 )
...
* Core/Spells: do not allow root auras to bypass the root movement template state when getting removed
* yeah....
(cherry picked from commit d629bad7a1 )
2021-12-17 22:55:50 +01:00
Treeston
4330b7c921
Entities/Unit: fix an unrelated check from doing nothing because somebody didn't understand how type-casting works
...
(cherry picked from commit 0b722e23cf )
2021-12-17 22:54:01 +01:00
Treeston
970a89a8c3
Entities/Unit: Add a missing underflow check to prevent really really low damage from underflowing when paired with flat damage modifiers. Closes #23655 .
...
(cherry picked from commit a8b1b9a3c6 )
2021-12-17 22:50:25 +01:00
jackpoz
dad86f5bce
Core/GameEvent: Fix OnGameEvent() hook not being called on Creature/GameObject spawned by the event itself
...
Hook broken since it was added in 1b2c413933
(cherry picked from commit d9ae19d974 )
2021-12-17 22:48:01 +01:00
Giacomo Pozzoni
18e394c993
Core/PetAI: Change an assert to a TC_LOG_ERROR
...
(cherry picked from commit c3619f42a5 )
2021-12-17 22:46:46 +01:00
Treeston
917d9b7621
Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary
...
(cherry picked from commit 7fa990edc6 )
2021-12-17 22:46:06 +01:00
Treeston
6b1ca0ca12
Core/Combat: Properly unset engagement flag on death.
...
(cherry picked from commit 9c603ea87f )
2021-12-17 22:45:55 +01:00
Treeston
0c4a2a33fd
Core/Misc: Add even more RBAC/Language values I need for #23633 .
...
(cherry picked from commit 5378fc4500 )
2021-12-17 22:42:02 +01:00
Treeston
5bb0cce3a2
Core/Misc: Add RBAC/Language values I need for #23633 .
...
(cherry picked from commit cb690fc705 )
2021-12-17 22:40:34 +01:00
Treeston
2b65dbbeab
Core/Misc: Kick a Totem error log upstairs one stack frame to give it access to various debug info and make Aokromes happy.
...
(cherry picked from commit e813200e5e )
2021-12-17 22:36:55 +01:00
Treeston
3388cea685
Core/Misc: Remove Trinity::Containers::Size (duplicate of advstd::size)
...
(cherry picked from commit f1d9a36c5f )
2021-12-17 21:57:41 +01:00
Treeston
3269c42789
Core/AI: No longer do strange things when told to enter evade mode while there's no need to do so, typically by terrible legacy code.
...
(cherry picked from commit 163f44c1b0 )
2021-12-17 21:50:47 +01:00
Treeston
0e13ed412a
Core/Threat: Properly update offline states even if all threat references are offline. Closes #23639 .
...
(cherry picked from commit 55ec3bd73f )
2021-12-17 21:46:33 +01:00
Treeston
1759502f5d
Core/AI: PetAI now properly signals engagement state. Closes #23640 .
...
(cherry picked from commit c3dd67dfbb )
2021-12-17 21:46:23 +01:00
jackpoz
e6e73b7b13
Core/Spells: Fix infinite loop
...
Fix an infinite loop caused by a mix of item 25498 and liquid damage
(cherry picked from commit 9b292f4369 )
2021-12-17 21:44:04 +01:00
Gildor
46c0f0d8fe
Core/Arenas: Remove doors in RL, NA and BE when arena has begun ( #23606 )
...
(cherry picked from commit 6d2cd7f687 )
2021-12-17 20:48:47 +01:00
ForesterDev
529ca2dd5d
Scripts/Defines: cleanup some magic numbers in factions ( #23631 )
...
(cherry picked from commit 0c317498a5 )
2021-12-17 20:48:31 +01:00
Giacomo Pozzoni
2a63135d37
Core/Misc: Replace some abs() with std::abs()
...
Always prefer std:: math function compared to C ones, as done in 7fe7f30521
(cherry picked from commit e68ebd3339 )
2021-12-17 20:33:48 +01:00
Keader
ca71fc7b6c
Core/Spells: Added spellgroup support to HandleModCastingSpeed ( #23592 )
...
(cherry picked from commit 4c2f7df4f3 )
2021-12-17 20:31:57 +01:00
Shauren
e8b3dda4a0
Core/BattlePets: Wrap battle pet related code in a separate namespace
2021-12-17 14:23:43 +01:00
Meji
446997cdf2
Core/BattlePets: Misc fixes
...
* The battle pet's experience and level will now be reflected in the player's UpdateFields
* Despawn summoned battle pet when it is caged
2021-12-17 14:23:43 +01:00
Shauren
05037bd936
Core/Auras: Implemented ChangeSpec, ChangeTalent and ChangeGlyph interrupt flags
2021-12-17 12:18:43 +01:00
Kelno
f3b0325758
Core/OPvP: Remove dangling line after 84b7b2e (PR #23625 )
...
(cherry picked from commit ef3ee63d88 )
2021-12-17 00:33:35 +01:00
Treeston
4c754de7a8
!= and == are not the same thing.
...
(cherry picked from commit 51cf1c7136 )
2021-12-17 00:29:31 +01:00
Treeston
c6834a1de6
oops, that wasn't supposed to remain there ( 0e7c66c follow-up)
...
(cherry picked from commit 81fcd2e2d5 )
2021-12-17 00:29:21 +01:00
jackpoz
e998a1169d
Core/Spline: Fix crash
...
Fix crash when calling MoveSpline::ToString() on an empty spline
(cherry picked from commit 2bac44c7d0 )
2021-12-17 00:27:09 +01:00
Treeston
a4c2c0fb1d
Core/AI: No longer override chase movement with follow movement if the creature engages before JustAppeared has had a chance to fire.
...
(cherry picked from commit 49b04c0fdd )
2021-12-17 00:25:59 +01:00
Wyrserth
a2b1b3e2aa
Core/Instance: remove wrong raid-only restriction in the logic that kicks offline players out of instances when the instance is reset.
...
(cherry picked from commit e5615402cc )
2021-12-17 00:24:22 +01:00
Treeston
c13d83796f
Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
...
(cherry picked from commit 0e7c66cb4c )
2021-12-17 00:23:33 +01:00
Giacomo Pozzoni
493fe066f6
Core/Misc: Handle timezones for hour-specific events specifieds in worldserver.conf ( #23540 )
...
* Core/Misc: Handle timezones for hour-specific events specifieds in worldserver.conf
* Handle Respawn.RestartQuietTime too
* Handle XP.Boost.Daymask too
* Core/Misc: Code cleanup
* Core/Misc: Code cleanup
* Update Util.cpp
* Update boosted_xp.cpp
(cherry picked from commit aeddd417c4 )
2021-12-16 22:35:44 +01:00
ccrs
e94dca132b
Core/SmartAI: add missing movement generator type check on SmartAI::SetCombatMove
...
ref #21562
(cherry picked from commit 0e3e4353a1 )
2021-12-16 22:10:54 +01:00
ccrs
f1ef2f73a4
Core/SmartAI: allow more Unit::ResumeMovement calls on JustReachedHome()
...
Since ResumeMovement also works on other MOTION_SLOT_DEFAULT generators (like RandomMG)
(cherry picked from commit c8cb866db0 )
2021-12-16 22:08:01 +01:00
Ovah
879e7094b7
Core/Misc: Add new centralized location for generic predicates (PR #23607 )
...
(cherry picked from commit 6e2ca481e5 )
2021-12-16 22:05:20 +01:00
jackpoz
17bf908847
Core/Misc: Fix warnings
...
(cherry picked from commit a9f1dc1da7 )
2021-12-16 22:04:25 +01:00
jackpoz
2c3cdf67c2
Core/MovementGenerator: Add more asserts
...
(cherry picked from commit 9ed35e2108 )
2021-12-16 22:04:12 +01:00
jackpoz
f65edd1130
Core/MovementGenerator: Add more details to asserts
...
Include movespline in Unit::GetDebugInfo() and the Player owner in FlightPathMovementGenerator::DoEventIfAny() assert
(cherry picked from commit 560b7e3397 )
2021-12-16 22:03:52 +01:00
Ovah
a24a5e7778
Core/Movement: add a velocity argument for the spline chain meta table (PR #23575 )
...
(cherry picked from commit 3f7b2252a1 )
2021-12-16 22:03:35 +01:00
Wyrserth
434ef51c10
Core/Creature: honor existing DB data for health and mana in case of summoned pets that don't have pet-specific stat data.
...
Closes #23570 .
(cherry picked from commit 55570be661 )
2021-12-16 22:01:10 +01:00
Wyrserth
537b425377
Core/Creature: don't set guardian stats in Creature::UpdateEntry(), because stat calculation from guardians is already done in Guardian::InitStatsForLevel.
...
Closes #281 .
Signed-off-by: Wyrserth <wyrserth@protonmail.com >
(cherry picked from commit 5f5d2028df )
2021-12-16 21:57:19 +01:00