Commit Graph

4724 Commits

Author SHA1 Message Date
Keader
db525a1401 Scripts/Spells: Fixed Nature's Guardian proc (#21314) 2018-01-26 00:06:50 -02:00
Treeston
51e28ae76a DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and Hellfire Citadel: Ramparts.
(also some minor adjustments to command output for convenience)
2018-01-25 13:45:11 +01:00
Treeston
6c3c200cc5 Misc: assert -> ASSERT 2018-01-25 12:39:19 +01:00
Treeston
6ce078d8e8 Scripts/Commands: new command '.debug instancespawn' 2018-01-24 22:52:42 +01:00
ariel-
6dd465c441 Core/Scripts: reverted Auriaya spell script logic
Thanks Shauren for spotting it
2018-01-24 12:32:26 -03:00
ariel-
c099174ff7 Core/Misc: fix some /W4 warnings and some reported by GCC 6.3 2018-01-22 23:55:33 -03:00
ariel-
7c9722a4ae Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version
Closes #12108 (again)
2018-01-22 15:00:55 -03:00
ariel-
73cc613dc8 Core/Formations: update codestyle and fix crash
Closes #21288
2018-01-22 02:43:34 -03:00
Kittnz
8f64612cb1 Scripts/Outland: Fix logical error in Hellfire event in Honor Hold 2018-01-21 14:40:56 +01:00
joschiwald
5f54149107 Core/Battleground: Dropped battleground texts from trinity_string and replaced them with proper BroadcastText
(cherry picked from commit ed318fdc46)

Fixed nopch build
(cherry picked from commit 6eff69818b)

Fixed nopch build again
(cherry picked from commit 3039f4bf86)
2018-01-21 13:41:02 +01:00
ariel-
9f5d1e2b10 Core/Scripts: fix wrong uses of SetHitDamage hook.
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.

- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power

Closes #9560
2018-01-20 21:09:22 -03:00
ariel-
cb75105434 Core/Scripts: fix Wild Growth losing info about caster bonuses
Closes #21281
2018-01-20 19:08:03 -03:00
Keader
96983fc6bb Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again)
Closes #21264
2018-01-19 20:56:27 -02:00
ariel-
7167edf27c Core/Scripts: fix Roar of Sacrifice 2018-01-18 18:13:38 -03:00
ariel-
0db5c2df3f Core/Scripts: added nullptr checks to DamageTaken hooks
Since cb9e72e521 attacker may not be in world when hook is called
2018-01-18 13:58:40 -03:00
Treeston
d9d26200f7 Scripts/AzjolNerub: Missing nullptr check in Hadronox. Closes #21258. 2018-01-18 16:47:31 +01:00
Treeston
0319c713a4 DB/SpawnGroup: instance_spawn_group data for map 576 (The Nexus) 2018-01-18 16:06:08 +01:00
ariel-
b75ff7d4bf Core/Globals: revert back to unordered_map for templates
Partial revert of commit b64c504314
See discussion on b64c504314
2018-01-18 01:07:29 -03:00
Moein
e519e14df8 Scripts/Spells: quest "That's Abominable" (#21253)
- scripted spell "Burst At The Seams" (59576)
- added Pet Bar

Closes #10876
2018-01-17 23:55:05 +01:00
ariel-
fb8885fabc Core/Scripts: fix warning 2018-01-17 13:07:44 -03:00
ariel-
ab3307fc23 Core/Scripts: fix some spells double dipping from done/taken bonuses
Closes #21007
2018-01-17 13:01:18 -03:00
ariel-
b64c504314 Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors
Ref #14274
2018-01-17 02:17:49 -03:00
sirikfoll
72ff2e30c3 Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player
2018-01-17 00:12:41 -02:00
Keader
0b09e9ee4e Scripts/Pit of Saron: Tyrannus followup
fix new issue caused by 947cb6a453
2018-01-16 20:38:38 -02:00
Keader
947cb6a453 Scripts/Pit of Saron: Fixed Tyrannus not working after evade 2018-01-16 18:32:17 -02:00
Keader
a41cd41695 Scripts/Trial Of The Crusader: Lord Jaraxxus rework (#21216) 2018-01-15 19:47:15 -03:00
ariel-
50a84f0b2b Core/Scripts: fix static analysis issue
CID 1384439
2018-01-14 17:28:10 -03:00
ariel-
f1986c6aaf Core/Entities: implement secondary damage for some weapons and removal of old voodoo
- Fixed correct Retaliation damage spell according to sniffs is 20240
- CalcArmorReducedDamage insisted on dealing a minimum of 1 damage even if damage was 0
- CalculateDamage was zero-phobic too: it defaulted to arbitrary max 5 damage

Closes #19081
2018-01-14 09:23:34 -03:00
ariel-
a305661785 Core/Scripts: fix Sanctified Wrath 2018-01-13 20:49:43 -03:00
ariel-
3b01cccd7e Core/Spell: SpellValueOverrides encapsulation
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct
2018-01-13 20:49:43 -03:00
ariel-
31a3a6f0c5 Core: fix non pch build, redux 2018-01-13 17:07:25 -03:00
Kittnz
46e1e35a88 fix non pch 2018-01-13 13:02:44 +01:00
Kittnz
a9c853ee3f Scripts/EasternKingdoms: implement Children of Goldshire event (#20745)
* Script: Implement Childeren of Goldshire

Notes: Need to update waypoints and default location of the childeren
http://wowwiki.wikia.com/wiki/Children_of_Goldshire
2018-01-13 12:22:36 +01:00
ariel-
cb9e72e521 Core/Auras: removed caster dependency from core
- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813) crit handling

Closes #19876
2018-01-13 06:45:21 -03:00
Kittnz
acc73d4693 Scripts/Outland: Implement Hellfire event in Honor Hold (#21110)
* Script/Outland: Implement Hellfire event in Honor Hold

This is hourly, event is only 60 seconds long.
2018-01-12 19:27:56 +01:00
ariel-
f50a333418 Core/Misc: kill whitespace 2018-01-12 00:07:29 -03:00
Treeston
a23c97a0fc Scripts/World: New target dummy AI, because I don't trust the existing one in light of #21187. 2018-01-09 23:34:50 +01:00
Treeston
45168f9612 nopch fix 2018-01-09 22:04:35 +01:00
Treeston
d283f96f70 missing return 2018-01-09 18:23:50 +01:00
Treeston
f45c211987 Scripts/Commands: New command: .debug threatinfo 2018-01-09 18:09:24 +01:00
Treeston
f0a394753a 9ad11e6 follow-up, prevent Halion respawn without loot
tagging #21198
2018-01-07 23:13:20 +01:00
Treeston
663a6f2f23 typo fix 2018-01-07 20:35:24 +01:00
Treeston
9ad11e67fb Core/Threat: Fix a potential exploit allowing players to damage a boss without them taking damage.
Scripts/Halion: General cleanup of old hacks no longer needed under new combat system.
2018-01-07 20:32:30 +01:00
Treeston
3bb33e3108 Core/Map: New Map::ForceRespawn to override objections and force a respawn (equivalent to force = true). Use this to fix various GM commands.
Scripts/Valithria: Fix an issue that could get the encounter stuck in an unloaded state.
2018-01-07 19:53:39 +01:00
Treeston
cbf5535b74 Revert "Scripts/Commands: Allow to use .tele in combat only to GMs"
This reverts commit 3ae5b72075 - see discussion on commit.
2018-01-06 13:32:11 +01:00
Shauren
b2b4f9d1e4 Core/Misc: Added compatibility layer for boost 1.66 and future std:: networking stuff
* Based on work done by @dimiandre in PR #21173

Closes #21171
Closes #21173

(cherry picked from commit dfd2660a85)
2018-01-06 12:30:28 +01:00
jackpoz
3ae5b72075 Scripts/Commands: Allow to use .tele in combat only to GMs
Allow to use .tele in combat only to players who can be GMs (even if they have .gm off)
2018-01-06 10:34:54 +01:00
Treeston
fdacf12739 Core/Combat: Some more sanity check asserts to try and track down #21187.
Also, some anti-annoyance treatment for dot tele.
2018-01-06 01:40:31 +01:00
Treeston
e0b609a178 Core/Map: Fix a crash that could happen if a player moved very far away from a creature they were in combat with. Closes #21177. 2018-01-04 15:19:37 +01:00
Moein
18f5eae835 MovementInform should overrides 2018-01-04 09:52:48 +01:00