Commit Graph

26357 Commits

Author SHA1 Message Date
Wyrserth
2c55730a01 Misc/Config: set decay timer for unlooted normal creatures to 5 minutes.
Now that respawns do not care about the previous corpse's state, there's no reason to force a very frustrating faster despawn.

(cherry picked from commit 1bdbede7e0)
2021-12-14 22:00:53 +01:00
Shauren
776298207a Core/Entities: Regenerate updatefields 2021-12-14 21:26:44 +01:00
Martin Topholm
dc0728b9a0 Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816)
(cherry picked from commit 4529a94e0d)
2021-12-14 21:19:01 +01:00
Wyrserth
f31d8f7ffb Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad.
(cherry picked from commit 8fcc82138f)
2021-12-14 21:11:10 +01:00
Ovahlord
3fc20584bc Core/Creature: Reworked creature aggro radius calculation (#20615)
* Core/Creatures: rewrote creature aggro radius calculation
* Formulas are taken from WoW Wiki

(cherry picked from commit 980047763a)
2021-12-14 21:09:11 +01:00
Wyrserth
edf12fd6a1 Core/Conditions: allow spellclick conditions to properly work for aura apply/remove (#23527)
(cherry picked from commit 12e545f7e2)
2021-12-14 20:52:13 +01:00
ForesterDev
104ec7a81a Core/Unit: Implement more helper methods (#23555)
(cherry picked from commit c44fb37f74)
2021-12-14 20:42:32 +01:00
Shauren
dbb96e7717 Core/Spells: Fixed spells not doing damage after cherry-picking 83a9222c39 2021-12-14 16:13:41 +01:00
Giacomo Pozzoni
c5173aca15 Core/Quest: Fix repeatable quest mark (#23338)
(cherry picked from commit 2cb4517303)
2021-12-14 00:13:47 +01:00
Treeston
513b35ea2f Entities/Unit: Properly unset engaged flag for creates that cannot have a threat list on combat exit. Fixes #23518.
(cherry picked from commit f44539b642)
2021-12-14 00:07:37 +01:00
Gildor
e0f3255f90 Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy (#23559)
(cherry picked from commit a0a64b10b5)
2021-12-14 00:07:14 +01:00
Treeston
096269349c Entities/Player: Fix an edge case where overlapping CCs could prevent player movement from being re-enabled. f6f1c48 follow-up.
(cherry picked from commit 4e767f1c7c)
2021-12-14 00:06:51 +01:00
Treeston
bba4696de7 Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness. Closes #23539.
(cherry picked from commit f6f1c48aa5)
2021-12-13 23:44:13 +01:00
Wyrserth
9cfa2ed71e Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
Closes #23337.

(cherry picked from commit a8b8a43b8d)
2021-12-13 00:42:20 +01:00
ForesterDev
27886c7f5d Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520)
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class

(cherry picked from commit b47bb59e2a)
2021-12-13 00:42:20 +01:00
ccrs
4e6c59dca7 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7)
2021-12-13 00:42:20 +01:00
Sorikoff
b8d675eba7 Scripts/Spells: Dimensional Ripper - Everlook (#23547)
(cherry picked from commit 5c09ff51f7)
2021-12-13 00:42:20 +01:00
Wyrserth
819f8b1a2d Script/DarkmoonFaire: fix logical error in go_darkmoon_faire_music.
Closes #23548.

(cherry picked from commit 028d16a812)
2021-12-13 00:42:19 +01:00
Wyrserth
ecce30a807 Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED.
Allows the gossip window to close after the client receives a quest failed error (for example: not enough inventory space to store the reward).

(cherry picked from commit c8289ada7f)
2021-12-13 00:42:19 +01:00
ccrs
2e4f38d949 Scripts/ICC: cleanup ReadSaveDataMore definition
(cherry picked from commit 4c398743b9)
2021-12-13 00:42:19 +01:00
ccrs
3bc4fc65b9 Scripts/ICC: 3dbf3fe followup
repeat timer typo

(cherry picked from commit b19a23a5c6)
2021-12-13 00:42:19 +01:00
Wyrserth
04b02f3672 Core/Spell: Challenge Flag should only hit one target.
(cherry picked from commit 39aa91f982)
2021-12-13 00:42:19 +01:00
ccrs
8be1927d31 Scripts/ICC: base support for Ymirjar Vrykuls AI
(cherry picked from commit 3dbf3fed7c)
2021-12-13 00:42:19 +01:00
ccrs
9d84b56df1 Scripts/ICC: 1eb2aef followup
(cherry picked from commit 3e9b553618)
2021-12-13 00:42:19 +01:00
Shauren
116285818b Core/Misc: Corrected file headers 2021-12-13 00:42:19 +01:00
ccrs
bb321ccb02 Scripts/ICC: move Sister Svalna to her own file
I've almost guttered her, so lets try it more gently this time

(cherry picked from commit 1eb2aef179)
2021-12-13 00:42:19 +01:00
ccrs
fce492d2e2 Core/Instance: 14788ce followup
No need to repeat code

(cherry picked from commit b9a8095967)
2021-12-13 00:42:19 +01:00
ccrs
5e3ba5e96f Scripts/ICC: 94b60ff followup
(cherry picked from commit eb6ea57e7f)
2021-12-13 00:42:19 +01:00
ccrs
934b72262d Core/Instance: add new method
(cherry picked from commit 14788ce026)
2021-12-13 00:42:18 +01:00
ccrs
6a63200e40 Core/Instance: add new hook & method
(cherry picked from commit 953b05459a)
2021-12-13 00:42:18 +01:00
ccrs
fc6dc06513 Build: fix error
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:583:132: warning: format specifies type 'unsigned int' but the argument has type 'float' [-Wformat]
                TC_LOG_TRACE("scripts.cos", "npc_arthas_stratholmeAI::AdvanceToState: has snapback for this state, distance = %u", target.SnapbackPosition->GetExactDist(me));
                                                                                                                              ~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                                                                              %f
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:176:56: note: expanded from macro 'TC_LOG_TRACE'
    TC_LOG_MESSAGE_BODY(filterType__, LOG_LEVEL_TRACE, __VA_ARGS__)
                                                       ^~~~~~~~~~~
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:159:32: note: expanded from macro 'TC_LOG_MESSAGE_BODY'
                    check_args(__VA_ARGS__);                            \
                               ^~~~~~~~~~~

(cherry picked from commit 303811399f)
2021-12-13 00:42:18 +01:00
ccrs
70fd6e7398 Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling
(cherry picked from commit 22b3b21ae3)
2021-12-13 00:42:18 +01:00
ccrs
cadbf42ea4 Misc: some corrections after recent merges
(cherry picked from commit 626a24822b)
2021-12-13 00:42:18 +01:00
Sorikoff
996b7c1f0e Scripts/Spells: Ultrasafe Transporter: Toshley's Station (#23537)
* Scripts/Spells: Ultrasafe Transporter: Toshley's Station

* Rename 9999_99_99_99_world.sql to 2019_06_29_01_world.sql

(cherry picked from commit 33b4ad5a89)
2021-12-13 00:42:18 +01:00
Sorikoff
7b08125c23 Scripts/Spells: Remove Collapsing Cave Aura (#23533)
* Scripts/Spells: Remove Collapsing Cave Aura

* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql

(cherry picked from commit 8d1a5fa126)
2021-12-13 00:42:18 +01:00
Wyrserth
5ca9f51033 Core/Loot: fix issue that prevented players from rolling for an unique-category item while an equipped item shares the same unique-category.
(cherry picked from commit eb7a6391aa)
2021-12-13 00:42:18 +01:00
jackpoz
841630fcc3 Core/Misc: Fix static analysis issues reported by Coverity Scan
(cherry picked from commit de88691e25)
2021-12-13 00:42:18 +01:00
Sorikoff
88457030cc Scripts/Spells: Deathbolt (#23531)
* Scripts/Spells: Deathbolt

* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql

(cherry picked from commit 62b2c379b3)
2021-12-13 00:42:18 +01:00
Sorikoff
ea4c1ae7d0 Scripts/Spells: Dimensional Ripper - Area 52 (#23505)
* Scripts/Spells: Dimensional Ripper - Area 52

* Rename 9999_99_99_99_world.sql to 2019_06_28_00_world.sql

(cherry picked from commit 63f548921c)
2021-12-13 00:42:18 +01:00
Wyrserth
2fea2a1e81 Core/GameObject: do not allow consumable chests to restock while partially looted.
(cherry picked from commit cd73664f53)
2021-12-13 00:42:18 +01:00
Wyrserth
f136d3cfe0 Core/GameObject: fix some cases where summoned gameobjects of a type different than chest or goober would behave wrongly.
(cherry picked from commit 9f0ac0c243)
2021-12-13 00:42:18 +01:00
Wyrserth
575f42089e Core/Spell: fix some issues with taunt spells (#23425)
(cherry picked from commit 5dc2dfd60c)
2021-12-13 00:42:18 +01:00
Wyrserth
9d40a105e6 Core/Mail: include 100g in the mail sent after turning in the quest The Wrath of Neptulon (#23500)
(cherry picked from commit cf223370f3)
2021-12-13 00:42:18 +01:00
Wyrserth
5c5bcba65a Script/ZulGurub: rewrite High Priest Thekal's encounter script (#23429)
(cherry picked from commit 365e2f191e)
2021-12-13 00:42:18 +01:00
Wyrserth
c637260a37 Core/GameObject: implement restock mechanic for non-consumable gameobjects (#23526)
(cherry picked from commit e77c2d55c4)
2021-12-13 00:42:17 +01:00
Wyrserth
d197a7ce9b Core/SAI: add param3 to SMART_ACTION_CALL_TIMED_ACTIONLIST to allow it to override a currently running actionlist.
(cherry picked from commit eeba12778b)
2021-12-13 00:42:17 +01:00
Wyrserth
7c7bb95da5 Core/GameObject: restore old behavior for non-consumable chests with restock timer (make them despawn).
(cherry picked from commit 50c5d30d13)
2021-12-13 00:42:17 +01:00
Wyrserth
836a1bc622 Core/GameObject: don't allow non-consumable goobers to despawn on use (#23469)
Closes #15730.

(cherry picked from commit 2b1e8d135b)
2021-12-13 00:42:17 +01:00
Wyrserth
09e849bb69 Core/Spell: allow damage from binary spells to go through elemental resistance's damage reduction. (#23479)
(cherry picked from commit efc999227d)
2021-12-13 00:42:17 +01:00
Wyrserth
83a9222c39 Core/SAI: allow creatures to handle gameobject spellhit SAI events. (#23492)
(cherry picked from commit 7a71127da9)
2021-12-13 00:42:17 +01:00