Commit Graph

36946 Commits

Author SHA1 Message Date
Killyana
e071f08ca7 DB/Quest: The Path to the Citadel
Make the credit for the party invoker

(cherry picked from commit 58b0ca8641)
2021-12-18 23:24:03 +01:00
ccrs
bb1a4e884a Scripts/PoS: a7a96d4 followup
we cant despawn all summons since vehicle spawn their passengers as regular summons
ty Aokromes

(cherry picked from commit fcbcb43b2b)
2021-12-18 23:23:08 +01:00
ccrs
b7346bac48 Scripts/PoS: a7a96d4 followup
(cherry picked from commit 40116f1025)
2021-12-18 23:22:54 +01:00
ccrs
7594ae72d7 Scripts/PoS: little implementation cleanup in boss_krickandick with, you guessed it, movement related corrections
also, never forgetti  -->
                                     ¨¨Ç*^¿?_:;_^!"·Ç!Ñ·$%/(/)/()(=)(=]]{
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air

(cherry picked from commit a7a96d4271)
2021-12-18 23:22:38 +01:00
ccrs
a73e6a7438 Scripts/PoS: move boss_krickandick into new script definition
(cherry picked from commit d27fd717c1)
2021-12-18 23:22:08 +01:00
ccrs
1add1c31d8 Core/Movement: prevent any Initialize queue till AddToWorld is signaled
(cherry picked from commit c9c6871659)
2021-12-18 23:18:26 +01:00
ccrs
7b21b53ac9 Core/Movement: d033032 followup
now THATS a typo... sorry folks

(cherry picked from commit bc9a9ad7e1)
2021-12-18 23:18:16 +01:00
Killyana
3edf174d21 DB/Spell: Fix phasing in Foote Steppes (with the correct spell this time)
Ref 1e4f0619fd (diff-c64f2de863d9cbe0fc088f5ed7eeeb04R3-R5)

(cherry picked from commit 8dbceb421c)
2021-12-18 23:18:06 +01:00
Killyana
490c007827 DB/Spell: Fix phasing in Foote Steppes
Closes #22867

(cherry picked from commit 1e4f0619fd)
2021-12-18 23:17:21 +01:00
Killyana
b926f524ba DB/Quest: Pushed Too Far
(cherry picked from commit 5e1b828365)
2021-12-18 23:16:07 +01:00
ccrs
a59e4da7f5 Core/Movement: d033032 followup
ty jackpoz

(cherry picked from commit 5d056f37c7)
2021-12-18 23:14:40 +01:00
Killyana
8281c92dce DB/Creature: Brann Bronzebeard & Brann's Flying Machine
Closes #22650

(cherry picked from commit e10cab89f7)
2021-12-18 23:14:10 +01:00
ccrs
50c90728b2 Core/AI: 06443e3 followup
(cherry picked from commit bb9af06cd4)
2021-12-18 23:13:20 +01:00
ccrs
2f5d97b951 Core/AI: add missing public tag & correct alignment
(cherry picked from commit fe7c2c3772)
2021-12-18 23:10:45 +01:00
Killyana
64ad90a9d8 DB/Creature: Plaguehoof & Bloodsunder & Icefury
(cherry picked from commit 439c434164)
2021-12-18 23:06:04 +01:00
Killyana
8b35d5b8fc DB/Creature: Spitzpatrick's Bomber
(cherry picked from commit cd32ef7798)
2021-12-18 23:04:28 +01:00
Killyana
294f232e4a DB/Creature: Argent Mason
(cherry picked from commit 77f857cb4e)
2021-12-18 23:03:00 +01:00
Killyana
ae9ca35807 DB/Creature: Vanguard Sound Dummy
(cherry picked from commit db4a2a721f)
2021-12-18 23:03:00 +01:00
ccrs
c658ba2fc9 Core/Movement: d033032 followup
ty jackpoz

(cherry picked from commit bc507209a7)
2021-12-18 23:03:00 +01:00
ccrs
d3ddb3726a Core/AI: 06443e3 followup
cause its not "that" horrible

(cherry picked from commit a71c5f4c7f)
2021-12-18 23:03:00 +01:00
ccrs
dfb2221552 Core/Movement: delay movement update in MotionMaster until its owner signals AddToWorld
ref #23199
closes #23876

(cherry picked from commit d033032d33)
2021-12-18 23:03:00 +01:00
Aokromes
7f074efa04 Core/Totem: Change log level of a log
To much spam of people doing quests with totem-like creatures

(cherry picked from commit 69b7958ebc)
2021-12-18 23:03:00 +01:00
Jildor
c1b0ffbef8 DB/Creature: Bronjahm interrupt immunity
Closes #23870

(cherry picked from commit c023b7aeff)
2021-12-18 23:03:00 +01:00
Killyana
c1a7a424df DB/Creature: Emissary Roman'khan
(cherry picked from commit ec81d1c6a9)
2021-12-18 23:03:00 +01:00
Killyana
cb13d0b185 DB/Creature: Obsidian Eradicator & Obsidian Nullifier
Closes  #23869

(cherry picked from commit fe479ec8fd)
2021-12-18 23:03:00 +01:00
jackpoz
58fe0f9e4a Build/Misc: Add ASan CMake flag
Allow to enable/disable Address Sanitizer in Clang and GCC from CMake flag "ASAN" of type Boolean. It can be enabled passing -DASAN=TRUE to CMake.

(cherry picked from commit 580f40769c)
2021-12-18 23:03:00 +01:00
jackpoz
7d63166ff3 Core/GameObject: Fix battleground flags not showing burning animation
Fix battleground flags not displaying the typical burning animation when they "despawn" (they don't actually despawn, they just change state)

(cherry picked from commit 90bb10aa3a)
2021-12-18 23:02:49 +01:00
jackpoz
d5d04a6c55 Core/Misc: Fix C++17 build errors
(cherry picked from commit 30823f9b79)
2021-12-18 22:51:50 +01:00
ForesterDev
4a47e1c6be Core/Defines: define UNIT_FLAG_SWIMMING (#23630)
(cherry picked from commit c03c88d0c0)
2021-12-18 22:50:52 +01:00
Giacomo Pozzoni
3da3683a90 Scripts/Kologarn: Fix "stuck in combat" issues (#23866)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.

(cherry picked from commit fed030da19)
2021-12-18 22:47:49 +01:00
ForesterDev
915d13020a Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL (#23844)
* Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL

* Remove codestyle changes

* Remove codestyle changes

(cherry picked from commit f4be544629)
2021-12-18 22:47:37 +01:00
jackpoz
7d78ddcbd5 Core/AI: Add new method to force creatures around to stop combat
(cherry picked from commit 06443e38e7)
2021-12-18 22:46:24 +01:00
Ovah
14c2a7fb92 Core/Taxis: teleport players to the destination taxi node location instead of their current ground position (#23835)
* Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position

* fixed a typo

(cherry picked from commit 7fcb77ecd1)
2021-12-18 22:45:49 +01:00
Giacomo Pozzoni
4062c9763f Core/LFG: Fix re-queueing while in a dungeon (#23862)
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue.
In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore.

(cherry picked from commit abcad7cda5)
2021-12-18 22:43:38 +01:00
jackpoz
6c0412c3d9 Core/LFG: Remove Dungeon Cooldown when getting kicked
(cherry picked from commit ada4e431ae)
2021-12-18 22:42:38 +01:00
jackpoz
d15b3c48b4 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan

(cherry picked from commit 88317a4ec8)
2021-12-18 22:41:20 +01:00
Keader
db03975a57 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845)
(cherry picked from commit a108f2ba61)
2021-12-18 22:40:29 +01:00
Keader
e5accfa71a Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847)
(cherry picked from commit 8210b4a539)
2021-12-18 22:40:16 +01:00
Keader
03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc8)
2021-12-18 22:37:30 +01:00
Keader
9abdc4ee3d Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846)
(cherry picked from commit 16fde1ffad)
2021-12-18 22:33:47 +01:00
Giacomo Pozzoni
6e1ed95a63 Core/Pet: Fix guardians low damage (#23840)
Fix guardians low damage for unhandled cases in Guardian::InitStatsForLevel()

(cherry picked from commit b3b8ec811d)
2021-12-18 22:30:38 +01:00
Giacomo Pozzoni
02c2ee9a43 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build

(cherry picked from commit ef694cc251)
2021-12-18 22:27:40 +01:00
Ovah
0910843538 Core/Movement: fixed taxi pathings getting finalized earlier than intended (#23830)
* Core/Movement: fixed taxi pathings getting finalized earlier than intended

Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended

* apply a missing change

(cherry picked from commit c1e3d79a4f)
2021-12-18 22:27:20 +01:00
Giacomo Pozzoni
157eca58d7 Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity

(cherry picked from commit ca8953a0ec)
2021-12-18 22:26:58 +01:00
ForesterDev
7da053be66 DB/Creature: Remove wrong SAI from guards
Closes #23824

(cherry picked from commit 176f51d1e8)
2021-12-18 22:25:56 +01:00
Keader
5d2b37634b Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828
Ty Rizztazz

(cherry picked from commit 746a1d89b3)
2021-12-18 22:24:21 +01:00
Giacomo Pozzoni
c886e87991 Core/Misc: Fix static analysis issue
Fix static analysis issue

(cherry picked from commit ed08754663)
2021-12-18 22:24:09 +01:00
tarwyn
474d903d79 Fix inconsistent NPC aggro on spell miss (#23816)
(cherry picked from commit c8dc9fdc41)
2021-12-18 22:23:00 +01:00
Ovah
f4ae34c5c9 Core/Movement: provide an extra spline path vertex for taxi pathings … (#23817)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.

* Update FlightPathMovementGenerator.cpp

(cherry picked from commit cf3277c641)
2021-12-18 22:21:57 +01:00
Killyana
f6e176b7d7 Instance/Script: Gorkun Ironskull & Martin Victus
(cherry picked from commit 8e3862cfbd)
2021-12-18 22:21:41 +01:00