Commit Graph

29155 Commits

Author SHA1 Message Date
ariel-
e315e41d36 Core/Entities: don't allow client control if player is still affected by any lose of control state 2018-01-22 14:13:46 -03:00
ariel-
590d251882 Core/PlayerAI: perform cast checks on auto ranged attack
Closes #19928
2018-01-22 14:02:01 -03:00
ariel-
514c847881 Core/Unit: fixed Global cooldown cancelation on spell interrupt
Thanks to Nyeriah for the heads up
2018-01-22 03:55:14 -03:00
ariel-
73cc613dc8 Core/Formations: update codestyle and fix crash
Closes #21288
2018-01-22 02:43:34 -03:00
ariel-
4402f71eb7 Core/Spells: fix Spirit of Redemption
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags?
- Remove mirror timers hack (triggered spell already allows underwater breathing)
2018-01-21 21:18:02 -03:00
tkrokli
3feb8a6955 Core/Misc: 2 comment corrections in Language.h
- comments adjusted to match the unordered enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT
2018-01-21 23:31:40 +01:00
Shauren
ef014d0832 Core/Misc: Revert LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT change from ba5f6a8616
* It may be out of place but at least matches db value and matches master branch
2018-01-21 23:21:43 +01:00
tkrokli
ba5f6a8616 Core/Misc: corrections and indentations in Language.h
- corrected the comment "1205-2002 - free" to "1205-1999 - free"
- increased the main indent by 2 spaces to get more lines aligned
- corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199

Ref. commit 5f54149107
2018-01-21 23:11:05 +01:00
offl
231777425b DB/Creature: set correct 3.3.5a faction for Argent Guard Thaelrid
- he was incorrectly set up with faction 80 (Darnassus), a Cataclysm value
- he should now be able to hand out quest ID 6561, Blackfathom Villainy.

by offl

Closes #21287
2018-01-21 22:11:22 +01:00
Treeston
2c86c78f04 Core/Unit: Remove a superfluous threat state update in SetPhaseMask. 2018-01-21 15:34:39 +01:00
Kittnz
8f64612cb1 Scripts/Outland: Fix logical error in Hellfire event in Honor Hold 2018-01-21 14:40:56 +01:00
joschiwald
5f54149107 Core/Battleground: Dropped battleground texts from trinity_string and replaced them with proper BroadcastText
(cherry picked from commit ed318fdc46)

Fixed nopch build
(cherry picked from commit 6eff69818b)

Fixed nopch build again
(cherry picked from commit 3039f4bf86)
2018-01-21 13:41:02 +01:00
Treeston
013d4560c7 Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split (instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere.
(No apologies for charm AI though. You deserve that one.)
2018-01-21 02:14:17 +01:00
Treeston
a373275612 Core/Threat: Passive creatures now properly become engaged when adding an offline threat entry. Fixes RoS and Thaddius, maybe more. Closes #21269. 2018-01-21 01:16:35 +01:00
ariel-
9f5d1e2b10 Core/Scripts: fix wrong uses of SetHitDamage hook.
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.

- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power

Closes #9560
2018-01-20 21:09:22 -03:00
ariel-
cb75105434 Core/Scripts: fix Wild Growth losing info about caster bonuses
Closes #21281
2018-01-20 19:08:03 -03:00
tje3d
946856258c DB/Quest: A Rough Ride & The Black Knight's Orders
Closes #21248
Closes #21249
2018-01-20 18:00:50 +01:00
ariel-
fa3eb754cb Core/Unit: fixed Lava Burst crit when Flame Shock is present on target
Closes #21268
2018-01-20 00:15:48 -03:00
Keader
96983fc6bb Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again)
Closes #21264
2018-01-19 20:56:27 -02:00
ariel-
f1896144c0 Core/Auras: fixed EquippedItemClass check
follow-up to 29c3b7d8f6
2018-01-18 19:14:38 -03:00
ariel-
4fca3bfc04 DB/Spell: Magma Totem shouldn't generate threat
By Jildor, closes #21178
2018-01-18 18:34:37 -03:00
ariel-
7167edf27c Core/Scripts: fix Roar of Sacrifice 2018-01-18 18:13:38 -03:00
ariel-
b8c281f497 Core/Auras: Don't remove shield only dependant auras on disarm
Closes #19782
2018-01-18 16:29:21 -03:00
ariel-
29c3b7d8f6 Core/Auras: define and implement attribute SPELL_ATTR3_IGNORE_PROC_SUBCLASS_MASK
Closes #20148
2018-01-18 16:08:24 -03:00
ariel-
0db5c2df3f Core/Scripts: added nullptr checks to DamageTaken hooks
Since cb9e72e521 attacker may not be in world when hook is called
2018-01-18 13:58:40 -03:00
Treeston
d9d26200f7 Scripts/AzjolNerub: Missing nullptr check in Hadronox. Closes #21258. 2018-01-18 16:47:31 +01:00
Treeston
666bc16325 DB/Quest: Allow starting Amphitheater of Anguish (12932) without having completed The Champion's Call (12974) 2018-01-18 16:29:50 +01:00
Treeston
0319c713a4 DB/SpawnGroup: instance_spawn_group data for map 576 (The Nexus) 2018-01-18 16:06:08 +01:00
ariel-
b75ff7d4bf Core/Globals: revert back to unordered_map for templates
Partial revert of commit b64c504314
See discussion on b64c504314
2018-01-18 01:07:29 -03:00
Moein
e519e14df8 Scripts/Spells: quest "That's Abominable" (#21253)
- scripted spell "Burst At The Seams" (59576)
- added Pet Bar

Closes #10876
2018-01-17 23:55:05 +01:00
sirikfoll
e12e0ad582 Core/CombatAI: Npcs with TurretAI will be able to attack again
Needed after the new Threat system
2018-01-17 19:01:09 -02:00
sirikfoll
ed9e220991 Core/Player: Pass correct Zone ID to HandlePlayerLeaveZone
This will fix some issues with Wintergrasp, like phasing auras getting stuck and missing group invites for the battle, among others
2018-01-17 18:59:20 -02:00
ariel-
fb8885fabc Core/Scripts: fix warning 2018-01-17 13:07:44 -03:00
ariel-
ab3307fc23 Core/Scripts: fix some spells double dipping from done/taken bonuses
Closes #21007
2018-01-17 13:01:18 -03:00
ariel-
b64c504314 Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors
Ref #14274
2018-01-17 02:17:49 -03:00
sirikfoll
72ff2e30c3 Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player
2018-01-17 00:12:41 -02:00
ariel-
ccf0807be0 Core/Unit: check remaining instead of full duration for Bounced by DR auras 2018-01-16 20:51:07 -03:00
Keader
0b09e9ee4e Scripts/Pit of Saron: Tyrannus followup
fix new issue caused by 947cb6a453
2018-01-16 20:38:38 -02:00
Keader
947cb6a453 Scripts/Pit of Saron: Fixed Tyrannus not working after evade 2018-01-16 18:32:17 -02:00
Moein
891bca934e Core/SAI: Extended SMART_TARGET_VEHICLE_PASSENGER to allow specifying seat mask instead of single seat index (can now target all passengers) (#21245) 2018-01-16 21:28:41 +01:00
ariel-
3d7166c1c7 Core/Creatures: creatures only have one damage
Closes #21236
2018-01-16 14:44:04 -03:00
Aokromes
d4e64950a1 Rename 2018_01_15_00_world.sql.sql to 2018_01_15_00_world.sql 2018-01-16 07:38:54 +01:00
Keader
a41cd41695 Scripts/Trial Of The Crusader: Lord Jaraxxus rework (#21216) 2018-01-15 19:47:15 -03:00
Treeston
1847555c8c Core/Threat: Fix a potential crash that would occur in specific edge cases of AI being a bit naughty. 2018-01-15 15:42:41 +01:00
ariel-
50a84f0b2b Core/Scripts: fix static analysis issue
CID 1384439
2018-01-14 17:28:10 -03:00
ariel-
5153f464d8 Core/Auras: fix static analysis issues
CID 1384433
CID 1384436
2018-01-14 17:23:48 -03:00
ariel-
01537e1dfb Core/Unit: fix mess-up with CalcArmorReducedDamage parameter order 2018-01-14 17:19:26 -03:00
ariel-
46fcbb42d2 Core/Unit: fix typo 2018-01-14 09:30:42 -03:00
ariel-
f1986c6aaf Core/Entities: implement secondary damage for some weapons and removal of old voodoo
- Fixed correct Retaliation damage spell according to sniffs is 20240
- CalcArmorReducedDamage insisted on dealing a minimum of 1 damage even if damage was 0
- CalculateDamage was zero-phobic too: it defaulted to arbitrary max 5 damage

Closes #19081
2018-01-14 09:23:34 -03:00
Aokromes
24cf532557 Rename 2018_01_12_03.sql to 2018_01_12_03_world.sql 2018-01-14 08:31:02 +01:00