Commit Graph

210 Commits

Author SHA1 Message Date
jackpoz
1d04a3b216 Core/Misc: Fix GCC 8 warnings 2019-03-31 17:34:28 +02:00
Keader
a0de602d38 Core/Spell: Fixed some negative spells showing as positive
Closes #22840
Revert 9ecce33192 and 7611242530
Update #22757
2019-01-05 11:26:29 -03:00
Keader
9ecce33192 Core/Spells: Malleable Goo need be negative
Closes #22757
2019-01-04 14:58:17 -03:00
Treeston
fcfcb0eb6f Happy New Year, folks. It's 2019! 2019-01-01 15:45:25 +01:00
Shauren
bbdf62d6e8 Core/Spells: Warning fix 2018-10-27 12:14:54 +02:00
Aokromes
d6d2c4efb9 Core/Spells: Hallowed Wand - Bat custome must be positive
closes #22684
2018-10-19 09:45:32 +02:00
Treeston
ab3eab990e Core/Misc: Revert 4990423, need to find out a better way to handle this. 2018-09-27 20:59:48 +02:00
Treeston
4990423dbf Core/Misc: Unify naming of DBC entry, storage and format identifiers based on DBC file name
* DBC file name: <dbc>.dbc
* Format string: DBCfmt_<dbc>
* DB Format string: DBCfmt_<dbc>_DBFormat
* DB index string: DBCfmt_<dbc>_DBIndex
* Entry struct: <dbc>Entry
* Global storage: s<dbc>Store
2018-09-27 18:19:20 +02:00
HelloKitty
0d1eed5dab Core/Spells: Include RealPointsPerLevel when determining if aura is negative (#22427) 2018-09-15 18:00:20 +02:00
Keader
ca7ee982db Scripts/Ulduar: Algalon the Observer fixes (#22320) 2018-08-31 21:48:56 -03:00
Keader
7611242530 Core/Spells: Mage slow need be negative
Was possible use Spellsteal vs Bosses
2018-08-27 21:13:55 -03:00
Gildor
e114939071 Core/Spells: Shadow of Death & Spiritual Vengeance should be negative spells (BlackTemple/Teron Gorefiend) (#22164)
Closes: #22160
Closes: #22161
2018-07-18 08:59:52 -03:00
Alan Deutscher
81dc5a714b Flag Explosive Shot as a negative spell effect. Closes #21922. (#22045) 2018-06-23 01:19:02 +02:00
Андрей
5fa783bd34 Core/Spells: Make some spells negative (#21696)
Closes #21634
2018-06-09 10:10:54 -03:00
ariel-
d88b50a6ad Core/Spells: fix another regression with arcane missiles being marked positive
Closes #21670
2018-03-19 17:28:04 -03:00
ariel-
d46f36f773 Core/Spells: tweak 'neutral' spell positivity
- Fixes Mind Control dummy self aura appearing as a debuff
2018-03-10 00:57:19 -03:00
ariel-
45c5e1b9d6 Core/Spells: rework part 5: GameObject casting
Closes #21330
Closes #18885
Ref #18752
2018-03-09 14:41:28 -03:00
ariel-
080d2c6cd4 Core/Spells: rework part 4: iterate over effects first
Ref #18395

Implement far spell queue processing
Closes #7395
2018-03-09 14:41:28 -03:00
ariel-
9b38a6352c Core/Spells: rework part 2: Split up target selection logic
Target check only determines what kind of entities we can target, spell positivity determines if that entity is valid for attack/assist

Closes #8844
2018-03-09 14:41:28 -03:00
ariel-
efeae33495 Core/Spells: rework part 1: Improved positive detection logic 2018-03-09 14:41:28 -03:00
ariel-
e73bfe8df8 Core/Spells: implemented SpellPriority field from SpellEntry to cleanup charged mod proc behaviour
- Only one charged mod will be consumed per SpellMod apply, and it'll be compared against other mod priority
- This is proper way of handling Backdraft/Backlash and Deathchill/Killing Machine

Thanks to killerwife for info
2018-02-12 03:09:22 -03:00
Treeston
532ab1c7f8 Core: Combat/threat system rewrite (PR #19930)
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
  - They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
  - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
  - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.

Closes #7951 and #19998.
2018-01-03 20:04:19 +01:00
tkrokli
f6b6f57a6d Update copyright note for 2018
Best wishes for the new year.
2018-01-01 01:55:29 +01:00
ariel-
e6d529a75a Core/Auras: implemented SPELL_AURA_MOD_ATTACK_POWER_OF_ARMOR delay mechanic 2017-12-15 13:26:34 -03:00
ariel-
7dff0e3246 Core/Auras: fixed off by one error in counting SPELL_ATTR5_START_PERIODIC_AT_APPLY ticks
- Made SpellInfo::GetMaxTicks and AuraEffect::GetTotalTicks return the same number without mods (dumped arbitrary default return value of 6 and arbitrary 30 sec limit)
- They should be streamlined whenever SPELL_AURA_48 is implemented
2017-12-15 03:40:36 -03:00
Keader
04271388f8 Typo 2017-10-27 08:28:48 -03:00
Keader
90f07bd948 Scripts/BlackTemple: Updates on Illidan encounter
- Fixed issues related with Parasitic Shadowfiend
- Updated script to new model
- Fixed loop of Parasitic Shadowfiend Summon
- Added a new spell (SPELL_REMOVE_PARASITIC_SHADOWFIEND)
- Fixed illidari elite attacking players
- SPELL_PARASITIC_SHADOWFIEND now is a negative aura
2017-10-26 23:10:00 -03:00
Keader
b507acf1c0 Core/Spells: Spells with Attribute SPELL_ATTR1_DISPEL_AURAS_ON_IMMUNITY should dispel snare auras. (#20621) 2017-10-20 10:57:47 -02:00
Keader
98c363154a Core/Spells: Fixed issues with School Immune vs SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE (#20546) 2017-10-07 18:38:11 -03:00
Aokromes
edb82fcfbf Core/Spells: Renamed TARGET_DEST_UNK_110 to TARGET_UNIT_CONE_ENTRY_110
cherry pick from be7486f
2017-07-18 17:04:39 +02:00
jackpoz
348b02155b Core/Misc: Build fix
Fix build broken in 9cf4dd7345
2017-07-16 18:26:05 +02:00
jackpoz
9cf4dd7345 Core/Misc: Fix static analysis issues 2017-07-16 18:20:29 +02:00
Treeston
489478b74d Core/Entities: Extend combo point system to all Units and fix numerous quirks with rogue CP and vehicles (Malygos P3) (#19914)
- Implement Wolverine Bite (fixes #752)
- General combo point system cleanup
2017-06-24 22:41:16 -03:00
ariel-
85a7d5ce9a Core: ported headers cleanup from master branch 2017-06-19 23:20:06 -03:00
ariel-
b58a364192 Core/Spell: fix some spells that shouldn't allow stealth or invisibility
- Touch of Zanzil
- Glowing Blood
- Lambent Blood
- Vibrant Blood
- Black Blood
- Perpetual Instability
2017-06-11 02:31:59 -03:00
Keader
672bc29df9 Core/Spells: Allows Dispersion under Freeze (stun by hunter trap) 2017-06-05 12:02:05 -03:00
Keader
abc749034e Core/Spells: Allows Dispersion and Barkskin to be used under death coil 2017-06-03 20:01:57 -03:00
Chaouki Dhib
2ff76e828f Core/Spells: Change the radius of PBAoEs following the feedback received on (#16290) 2017-05-14 21:40:11 +02:00
xinef1
cbbb745246 Various quest system fixes (seasonal quests, timed quests and more) (#18940)
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone

Closes #18913
Closes #11187
Closes #15279
2017-04-24 00:46:06 -03:00
ariel-
3a0cb90ea9 Core/Spell: define channels without movement interrupt flags as allowed move
- Remove script hacks no longer needed
2017-04-23 21:48:06 -03:00
ariel-
25a449a90e Core/Spell: implement pvp trinket immunity against Judgement of Justice
By Riztazz, closes #19484
2017-04-22 06:45:03 -03:00
ariel-
c296d255e2 Revert "Core/Spell: don't set scaleAura for some special spells"
This reverts commit 1ca8434b36.

Closes #19472
2017-04-21 01:37:07 -03:00
ariel-
1ca8434b36 Core/Spell: don't set scaleAura for some special spells
Closes #14541
2017-04-03 04:04:02 -03:00
Chaouki Dhib
a1f2f30c14 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.
2017-03-23 00:43:04 +01:00
xinef1
9142c778dd Corrected points per level calculation for some spells (#19105) 2017-02-19 02:30:04 -03:00
xinef1
e261754c9c Fixed setting and unsetting of m_spellModTakingSpell (#19116)
- A problem when a different spell tries to overwrite existing ModTakingSpell should no longer happen
2017-02-19 02:10:50 -03:00
xinef1
e7a9549422 Core/Spells: Fixed some item ranged spells dealing wrong damage (#19104) 2017-02-13 21:52:51 +01:00
xinef1
c6060dd0c5 Core/Spells: Remade trajectory target selection (#19048)
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received
2017-02-05 21:10:15 -03:00
xinef1
14dfc377b4 Core/Misc: Various crash fixes (#19059)
* Replaced some FindPlayer calls with GetPlayer
Fixed some more crashes

* Correction
2017-02-05 23:42:31 +01:00
xinef1
93746e8c4a Implemented binary resistances and some more (#18933)
- Fixed possible exploit with tamed pets having template immunities
- Implemented binary resistances
- Corrected resistances calculations
- Pets properly inherit players spell penetration
- Fixed doubled block calculation for damaging melee spells
- Auras removing snare effects will only remove the snaring component
- Shapeshifting will properly remove movement impairing auras only and not crowd control (dragon's breath)
- Immunities are properly checked versus all schools appearing in spell, unit is immune only if immune to all schools
- Spells with melee and magic school mask should compare armor reduction with resistances and select smaller reduction
- Demonic Circle: Teleport no longer removes root effects
2017-02-04 19:50:32 -03:00