Machiavelli
e8675dd4ed
Scripts/Blood Furnace: Fix possible compile errors on old VS versions
2013-09-07 15:17:56 +01:00
Sebastian Valle
07d793b94b
Core/Misc: Fixed some more issues found by static code analysis tools.
2013-09-03 17:31:02 -05:00
Shauren
79d1b7f543
Scripts/Misc: Removed unused fields and fixed a warning about uninitialized value
2013-09-01 20:33:52 +02:00
Nay
7776016106
Core/Quests: Remove CastedCreatureOrGO method
...
- Remove EAI's ACTION_T_CAST_EVENT and ACTION_T_CAST_EVENT_ALL
- Remove SAI's SMART_ACTION_CALL_CASTEDCREATUREORGO
- Split QUEST_TRINITY_FLAGS_KILL_OR_CAST into QUEST_TRINITY_FLAGS_KILL and QUEST_TRINITY_FLAGS_CAST
- Assign QUEST_TRINITY_FLAGS_CAST to all the quests that were using RequiredSpellCastX
- (unrelated) Fix a warning in Player.cpp
- Replace CastedCreatureOrGO usage in scripts by KilledMonsterCredit
TODO: Convert the two EAI scripts commented out in the .sql to proper SAI
Closes #10667
2013-08-30 19:32:08 +01:00
Nay
78786c7b54
Core&Scripts: Fix clang compiler warnings
2013-08-27 23:47:03 +01:00
joschiwald
2aa944caee
Scripts/Auchindoun: add missing InstanceScripts and cleanup some boss scripts
2013-08-26 18:52:29 +02:00
Nay
2050a36b58
SAI & Scripts: Fix unitialized values found by Valgrind
...
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19B3031: boss_skarvald_the_constructor::boss_skarvald_the_constructorAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:217)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19B3948: boss_dalronn_the_controller::boss_dalronn_the_controllerAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:388)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x15E2FCC: SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:144)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191D242: npc_shadron::npc_shadronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1122)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19AE913: boss_ymiron::boss_ymironAI::UpdateAI(unsigned int) (boss_ymiron.cpp:215)
==3064== Use of uninitialised value of size 8
...
==3064== by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)
==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064== by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191CE88: npc_tenebron::npc_tenebronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1027)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191D5B8: npc_vesperon::npc_vesperonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1220)
==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064== by 0x1868F59: boss_lady_vashj::boss_lady_vashjAI::Reset() (boss_lady_vashj.cpp:206)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191C14C: dummy_dragonAI::MovementInform(unsigned int, unsigned int) (boss_sartharion.cpp:802)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x1046986: Position::NormalizeOrientation(float) (Object.h:388)
...
==3064== by 0x17D9463: boss_malchezaar::boss_malchezaarAI::SummonInfernal(unsigned int) (boss_prince_malchezaar.cpp:373)
2013-08-26 16:13:26 +01:00
Nay
a0a377a0ce
Scripts: Fix two issues found by Valgrind
...
==3400== Invalid write of size 8
==3400== at 0x1241C32: instance_ahnkahet::GetInstanceScript(InstanceMap*) const (instance_ahnkahet.cpp:54)
...
==3400== Conditional jump or move depends on uninitialised value(s)
==3400== at 0xB5DEAE: std::tr1::_Hashtable<unsigned long, std::pair<unsigned long const, Creature*>, std::allocator<std::pair<unsigned long const, Creature*> >, std::_Select1st<std::pair<unsigned long const, Creature*> >, std::equal_to<unsigned long>, std::tr1::hash<unsigned long>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>::_M_find_node(std::tr1::__detail::_Hash_node<std::pair<unsigned long const, Creature*>, false>*, unsigned long const&, unsigned long) const (hashtable.h:830)
==3400== by 0xBDA4CA: std::tr1::_Hashtable<unsigned long, std::pair<unsigned long const, Creature*>, std::allocator<std::pair<unsigned long const, Creature*> >, std::_Select1st<std::pair<unsigned long const, Creature*> >, std::equal_to<unsigned long>, std::tr1::hash<unsigned long>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>::find(unsigned long const&) (hashtable.h:698)
==3400== by 0xBDA5BF: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67)
==3400== by 0xCB5C03: Map::GetCreature(unsigned long) (ObjectAccessor.h:114)
==3400== by 0xB6E6EF: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13023)
==3400== by 0x10F0790: boss_hydross_the_unstable::boss_hydross_the_unstableAI::Reset() (boss_hydross_the_unstable.cpp:164)
2013-08-24 01:54:37 +01:00
joschiwald
99081bcf54
Merge branch 'master' of github.com:TrinityCore/TrinityCore
2013-08-22 13:48:47 +02:00
joschiwald
8e833743d4
Scripts/GruulsLair: reworked InstanceScript
...
Known Issue: position desynch after creature respawn
2013-08-22 13:47:54 +02:00
Vincent-Michael
dc86e87f25
Scripted/ShadeOfAkama: Some cleanups
2013-08-21 19:58:12 +02:00
joschiwald
a383885f5c
Scripts/AhnKahet: reworked InstanceScript
2013-08-21 19:43:46 +02:00
Vincent-Michael
1e89ae1960
Core: Fix warnings and random changes
2013-08-21 18:46:52 +02:00
joschiwald
62c7e309ee
Scripts/BlackTemple: reworked InstanceScript
2013-08-21 12:29:28 +02:00
joschiwald
e0f010b310
Scripts: Random script fixes and code optimizations
2013-08-19 20:03:06 +02:00
Vincent-Michael
7dbf68cbfc
Scripted/Misc: Remove some whitespace
2013-08-18 02:07:13 +02:00
joschiwald
2b19ba1879
Misc: replace Unit::GetPlayer with ObjectAccessor::GetPlayer and some cosmetic changes
2013-08-18 01:41:10 +02:00
Vincent-Michael
da1e466bd5
Core/Misc: Implemented GetObjectScale function
2013-08-17 23:47:43 +02:00
w1sht0l1v3
7c7f19228e
Core/Scripts: Placeholders for instances The Slave Pens and The Underbog.
...
It is needed for Random Dungeon Finder credit.
2013-08-17 17:50:33 +03:00
Vincent-Michael
8acefbff8c
Scripted: Use now override for instance scripts
2013-08-10 17:42:12 +02:00
Malcrom
090f348d59
Scripting/Sethekk Halls: Move Boss Anzu from EAI to CPP and some cleanup.
2013-08-07 18:53:17 -02:30
Vincent-Michael
1e8fd6489d
Core: Fix non pch build
2013-08-07 18:44:23 +02:00
joschiwald
0667e89005
Scripts/DrakTharonKeep: add some spellscripts, add yells to novos, and do some cosmetic changes
2013-08-07 17:31:36 +02:00
Malcrom
f4815fbf80
Scripting/Mana Tombs: Move Yor scripting from EAI to CPP.
2013-08-07 11:42:13 -02:30
Vincent-Michael
75e6c40630
Core/Misc: Rename some no name enums
2013-08-06 21:16:05 +02:00
Shauren
ac10589eda
Core/Misc: Fixed some issues found by Coverity Scan
2013-08-01 21:31:11 +02:00
Vincent-Michael
baeecba6c9
Core: Fix build
2013-07-15 01:07:02 +02:00
Vincent-Michael
08c1a81096
Scripted/Misc: Fix random stuff
2013-07-15 01:01:37 +02:00
Malcrom
4aad735af9
Core/Scripting: Add Wrathbone Flayer script to show channelling visual and correct combat AI.
2013-07-13 09:27:27 -02:30
Shauren
30f6efb416
Core/Quests: Fixed quest sharing
2013-07-11 21:45:14 +02:00
Machiavelli
93226005c6
Scripts/Akama: Uninitialized variable
2013-07-11 13:45:51 +02:00
Malcrom
f274560c4a
Core/Scripting: Minor fix to Shade of Akama Script.
2013-07-10 21:21:05 -02:30
Malcrom
b7cf456f53
Core/Scripting: Additions to Shade of Akama Script. Just ending sequence left to do.
...
Please supply feedback if anything is not like offi so I can fix.
2013-07-10 18:29:32 -02:30
Malcrom
4fe0f1339e
Core/Scripting: A couple fixes for Hellfire Ramparts.
2013-07-10 13:09:37 -02:30
Malcrom
7d5be7a3ef
Core/Scripting: A little update to Hellfire Ramparts. Thanks joschiwald.
2013-07-10 11:51:15 -02:30
Malcrom
81d8739d68
Core/Scripting: Converted Watchkeeper Gargolmar to use events.
2013-07-10 00:13:36 -02:30
Malcrom
ea49f98170
Core/Scripting: Fix up Hellfire Ramparts instance and add Instance save.
2013-07-09 23:32:34 -02:30
Malcrom
d5687a1003
Core/Scripting: Few minor fixes for Shattered Halls.
2013-07-09 18:42:52 -02:30
Malcrom
fb783fb098
Core/Scripting: A couple fixes for shattered Halls
2013-07-09 18:27:03 -02:30
Malcrom
17398a4043
Core / Scripting: Coverted a couple Shattered Halls npc scripts to use events
2013-07-09 07:10:48 -02:30
Malcrom
ebe1ef2492
Core / Scripting: Updates to Shattered Halls and added Instance save.
2013-07-08 23:29:55 -02:30
Vincent-Michael
e464d2bd2c
Scripted: Some cleanups + ninja changes
2013-07-08 21:15:23 +02:00
Malcrom
d8b39e9bae
Core/Scripting: Fix some errors in Shade of Akama script.
2013-07-08 16:31:29 -02:30
Malcrom
ac85fac977
Core / Scripting: fix a few warnings.
2013-07-08 14:44:10 -02:30
Malcrom
92eec6831a
Core: Scripting: Shade of Akama WIP
2013-07-08 12:39:32 -02:30
Nay
3561ab98ba
Misc: Use override and final C++11 keywords in a few places (mostly scripts)
...
OVERRIDE and FINAL are TC macros (expand to nothing if compiler does not support C++11)
2013-07-06 20:21:45 +01:00
Vincent-Michael
6079f369af
Scripted/Misc: Some cleanup
2013-07-06 01:00:05 +02:00
Vincent-Michael
b4d4e04f53
Scripts/Misc: Rename creatures with mob_ / mobs_ in npc_
...
Note: Have fun :P
2013-07-04 22:11:47 +02:00
Malcrom
19aeac3abd
Core/Scripting: Fix Gossip option select for npc_spirit_of_olum
2013-07-02 00:09:33 -02:30
Malcrom
b77eb5e527
Core/Scripting: Fix error in previous commit.
2013-07-01 20:21:15 -02:30
