Commit Graph

491 Commits

Author SHA1 Message Date
ariel-
ebba8dcba8 Core/Spells: fix some db errors 2017-03-03 21:36:56 -03:00
ariel-
7072bf8c02 Core/Spell: disable proc for magnet auras, they're handled differently
Closes #19208
2017-03-02 00:18:00 -03:00
ariel-
01f5befcec Core/Scripts: Thrusting Hodir's Spear
- Everything is sniffed, enjoy this hell of a quest!

Closes #12808
2017-02-25 04:46:02 -03:00
ariel-
d0f760420a Core/Scripts: remove no longer needed scripts, use db attribute for disabling procs
(e7ccd8ea3f followup)

- Fix some broken procs after c0cb823a91

Closes #19068
2017-02-22 17:54:12 -03:00
ariel-
f609e7a08b Core/Spells: refactor spell_enchant_proc_data table
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789
2017-02-22 00:11:49 -03:00
xinef1
c6060dd0c5 Core/Spells: Remade trajectory target selection (#19048)
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received
2017-02-05 21:10:15 -03:00
xinef1
93746e8c4a Implemented binary resistances and some more (#18933)
- Fixed possible exploit with tamed pets having template immunities
- Implemented binary resistances
- Corrected resistances calculations
- Pets properly inherit players spell penetration
- Fixed doubled block calculation for damaging melee spells
- Auras removing snare effects will only remove the snaring component
- Shapeshifting will properly remove movement impairing auras only and not crowd control (dragon's breath)
- Immunities are properly checked versus all schools appearing in spell, unit is immune only if immune to all schools
- Spells with melee and magic school mask should compare armor reduction with resistances and select smaller reduction
- Demonic Circle: Teleport no longer removes root effects
2017-02-04 19:50:32 -03:00
ariel-
ad6912f0d5 Core/Spell: modified HitMask for new default procs 2017-01-23 15:41:43 -03:00
ariel-
bff36a81be Core/Spell: add more aura types to default procs
Ref #18542
2017-01-23 15:35:35 -03:00
ariel-
9442ce888c Core/Spell: removed some startup errors
Ref #18542
2017-01-23 14:11:28 -03:00
Keader
28b955bd25 Core/Spell: Fixed Val'kyr Target Search exploit
Closes #16347
by ariel-
2017-01-19 14:12:50 -03:00
Keader
6f7310a259 Core/Spell: Fixed range issues with some quest spells
Closes #17815
2017-01-19 14:09:27 -03:00
tkrokli
6a51a88767 Update Copyright notice for 2017
Happy new year!
2017-01-02 19:52:45 +01:00
Keader
5af1fa2273 Core/Scripts: Illidari Council Rewrite (#18546)
Thanks to Sirikfoll, Krudor and Offl for all help
2017-01-01 21:11:15 -02:00
ariel-
a20fda9b2d Core/Spell: unbreak generic mount spells after prev commit 2016-12-30 14:23:05 -03:00
ariel-
63a4a94f5a Core/Spell: fix one spell range issue 2016-12-29 23:28:08 -03:00
ariel-
29827855d0 Core/Spell: Fix Turn the Tables
Closes #5134
2016-12-29 02:06:53 -03:00
Keader
dbd567799f Core/Scripts: Fixed Suppresser behavior in Valithria Dreamwalker encounter
Closes #18530
* Fixed range issue
* Fixed weave spawn when Summon Timmer Suppresser(70912) is casted
* Fixed spawn count
2016-12-22 17:40:24 -03:00
ariel-
07bb3037de Core/Spell: fix Magic Absorption, take two 2016-12-09 14:39:18 -03:00
Keader
891551e845 Core/Scripts: Rewrite Magtheridons Lair (#18330)
Core/Scripts: Rewrite Magtheridons Lair
2016-12-07 09:46:46 +01:00
ariel-
3d5c1b83b1 Core/SpellMgr: added a startup error for possibly unhandled procs 2016-12-03 22:55:12 -03:00
ariel-
5b56c94e6d Core/Spell: restore old proc system behaviour on auras self proc.
- Use Spell::m_triggeredByAuraSpell and compare against trigger aura, it requires scripts to set triggeredByAura parameter.
- Fixed existing scripts lacking it

DB/Spell: Anger Capacitor (Tiny Abomination in a Jar) proc

Closes #18269
2016-11-19 03:05:44 -03:00
ariel-
e7ccd8ea3f Core/Spell: Added the possibility to explicitly disable auraEffect procs using attributes
- Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use
2016-11-18 02:15:45 -03:00
ariel-
50a3ce5703 Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)

Closes #16658
Closes #16901
Closes #18114
2016-11-12 17:58:00 -03:00
ariel-
70a867531d Core/SpellMgr: overwrite dbc range for Unleashed Souls
Closes #17968

By sirikfoll
2016-11-09 00:58:46 -03:00
ariel-
ed49626c22 Core/Spell: fix interaction of on taken damage procs with triggered casts
DB/Spell: Seal of Righteousness proc
- Lightining and Water Shield should proc with triggered

Closes #18211
2016-11-07 23:50:18 -03:00
ariel-
555fe2fe5b Core/SpellMgr: add some trap effect range overrides
Ref #18206
2016-11-07 13:31:40 -03:00
ariel-
4f1ef6985e Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default
Closes #18160
2016-11-04 14:22:27 -03:00
ariel-
7a79443281 Core/SpellMgr: static analysis checks 2016-11-03 22:42:34 -03:00
ariel-
ca1a050e8a Core/Globals: normalize DBC data for Maelstrom Weapon ranks 2016-11-03 03:06:23 -03:00
ariel-
6c7cf99594 Core/Spell: fix range for Ancestral Healing (shaman) and Grace (priest) 2016-10-30 04:55:05 -03:00
ariel-
b3a4815067 Core/Spells: workaround stealth interaction with Death and Decay and GameObject casts
Closes #10179
Closes #16154
2016-10-30 00:16:45 -03:00
ariel-
d48cf75005 Core/SpellMgr: fix Abolish Disease/Poison targets
Spells were failing due to "out of range"
2016-10-29 20:16:02 -03:00
ariel-
1df8ca7fe3 Core/Spells: require phaseMask set for trap activation procs 2016-10-28 03:14:09 -03:00
ariel-
0c59f2f0f7 Core/Scripts: fix Cobra Strikes 2016-10-28 01:18:01 -03:00
ariel-
e17e489207 Core/SpellMgr: overwrite DBC RangeEntry for Safeguard
Closes #18117
2016-10-26 23:58:31 -03:00
ariel-
531904afff Core/SpellMgr: some changes in default proc generation. Fix an issue of stealth breaking with positive and/or healing spells 2016-10-17 02:19:29 -03:00
ariel-
9b0fa51022 Core/Globals: compute aura diminishing return info at startup and cache it
Core/Entities: Save diminish return on an array instead of a linked list
2016-10-17 01:52:40 -03:00
SnapperRy
5c419949b6 Core/Spell: overwrite DBC RangeEntry values for spells Concussive Barrage, Desecration and Polymorph.
Closes #17545.
2016-10-13 20:27:07 +02:00
SnapperRy
bdb08fba6e Script/Quest: Stop the Ascension! 2016-10-12 17:12:07 +02:00
ariel-
8167d6d4a0 Core/Spell: do not automatically set proc Family Name if no Family Flags present
Closes #18075
2016-10-12 10:01:38 -03:00
ariel-
aaa1a43204 Core/Spells: fix auto repeat spells triggering auras
Auto repeat spells are casted as triggered and didn't register procs properly if the aura can't proc with triggered
2016-10-12 01:32:40 -03:00
ariel-
a129b41f3d Core/Spells: fix runtime error
Partial revert of 11650e4008
2016-10-10 16:31:47 -03:00
ariel-
ce45e1bf95 Core/Globals: cache SpellSpecific and AuraState information instead of computing them each time they're needed 2016-10-07 00:51:52 -03:00
ariel-
e641d0c7d7 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-04 20:21:55 -03:00
ariel-
405167dafd Core/Spell: Add Dual Wield skill dependency to Dual Wield effect, should remove the skill properly when unlearning spell.
Closes #17196
2016-10-02 15:49:29 -03:00
Treeston
4b990eb7d7 [3.3.5] Azjol-Nerub rewrite
* Scripts/AzjolNerub: Complete rewrite.
- Gatewatcher:
  - Trash now actually engages properly one by one
  - Fix trash spell casting
  - Add missing quotes
- Hadronox:
  - Everything. Literally.
- Anub'arak:
  - Fix add spawns
  - Fix impale
  - OK this might as well be "fix everything with every boss". Because that's pretty much what happened.
- General hack cleanup

* Update and rename 9999_99_99_99_AZJOLNERUB.sql to 2016_09_25_01_world.sql

* Update and rename 2016_09_25_01_world.sql to 2016_09_25_02_world.sql

* Rename 2016_09_25_02_world.sql to 2016_09_26_02_world.sql
2016-09-26 12:49:32 +02:00
SnapperRy
275a53b34d Script/Quest: improvements for Let Them Eat Crow. (#17948) 2016-09-24 04:04:34 +02:00
SnapperRy
271c16fb60 DB/Quest: improvements for Test at Sea:
- Prevent player from entering combat when using the quest item.
- The targeted NPCs should only yell sporadically.
2016-09-13 01:44:33 +02:00
ariel-
43846d2d51 Core/SpellMgr: removed some wrong spells from LoadSpellInfoCorrections:
34754 is actually Holy concentration, and does not proc.
39805 doesn't exist
2016-09-11 00:06:06 -03:00