Commit Graph

36476 Commits

Author SHA1 Message Date
Treeston
edc7583119 Entities/Unit: Cleanup all the direct accesses to m_unitMovedByMe. Refactor the field to be protected. Add assertions to catch dangling pointers.
(cherry picked from commit 396f87c30d)
2021-12-12 01:26:41 +01:00
Treeston
06823f19cd Core/Misc: Add static versions of GetGUID and ToX methods to Object. The static versions return Empty/nullptr for null objects.
(cherry picked from commit b3ee407707)
2021-12-12 00:46:03 +01:00
Treeston
f29644efd5 some more cleanup, a5f8c0d follow-up
(cherry picked from commit 00728cef15)
2021-12-12 00:33:36 +01:00
Treeston
e3411b4740 Core/Creature: Attach out-of-combat health regen to the Engaged system, not the Combat flag. Closes #21571.
(cherry picked from commit a5f8c0d30c)
2021-12-12 00:33:23 +01:00
Treeston
dabdad3b47 Core/Misc: Rename Unit::AttackedTarget to Unit::AtTargetAttacked to match naming scheme for these notifiers
(cherry picked from commit 632a300dd2)
2021-12-12 00:33:18 +01:00
Treeston
35e55f1089 Core/Entities: Kick engagement logic upstairs to Unit (from ThreatManager), since all Units with AI need it (not just those with threat list). Fixes #17981.
(cherry picked from commit dbe3bbefe7)
2021-12-12 00:31:15 +01:00
jackpoz
dd22c6fe67 Core/Misc: Code cleanup
(cherry picked from commit eeced9ae15)
2021-12-11 23:20:05 +01:00
zartech22
1c3c59d7fa Core/Instance : Fix instance resetting exploit (#23263)
* Push offline players out of instance

Push offline players out of instance when reseting dungeon with a raid mode group

* Add SQL request to character

Add a SQL request to update the position of a player in a specified map

* Teleport to graveyard instead

(cherry picked from commit 678e0e606a)
2021-12-11 23:12:27 +01:00
Sorikoff
799fba7fd1 Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind (#23463)
* Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind

* Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind"

This reverts commit a8055960

* Revert "Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind""

This reverts commit a5be792b

* Fix NoPCH

* Clean up

* Clean up

* fixup! Clean up

* Caster -> Target

* Rename 9999_99_99_99_world.sql to 2019_06_22_01_world.sql

(cherry picked from commit ac7c72d633)
2021-12-11 23:01:46 +01:00
Sorikoff
aa407adf3e Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster (#23456)
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster

* Fix NoPCH

* Correct header

* fixup! Clean up

* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql

(cherry picked from commit 40b09e3df1)
2021-12-11 22:58:16 +01:00
Wyrserth
b709ea9a8d Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts (#23459)
* Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts.

* Kill evil spaces.

* Rename 9999_99_99_99_auth.sql to 2019_06_21_00_auth.sql

* Update auth_database.sql

(cherry picked from commit 8163ea60c8)
2021-12-11 22:47:08 +01:00
Sorikoff
8fc52bc5e5 Scripts/Spells: Migrate Teleporting to Script (#23458)
* Scripts/Spells: Migrate Teleporting to Script

* Rename 9999_99_99_99_world.sql to 2019_06_21_02_world.sql

(cherry picked from commit e9d803ccee)
2021-12-11 22:28:55 +01:00
Shauren
4595e63dd7 Core/Spells: Deleted old script (partial port of a4cd4d8b87) 2021-12-11 21:40:30 +01:00
Wyrserth
a04d8fc71a DB/Loot: Fix Mighty Protection Potion recipes drop chances
Closes #23461

(cherry picked from commit fc92bd358c)
2021-12-11 21:38:29 +01:00
Keader
ba606753bd Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
Followup: 394b119664
(cherry picked from commit 3b0743ea67)
(cherry picked from commit f9a366628a)
2021-12-11 21:37:53 +01:00
Killyana
5979afd778 DB/Creature: Fix Ick boss Boss Whisper text
(cherry picked from commit 1445b5aa11)
2021-12-11 21:35:15 +01:00
Killyana
2aca19a079 DB/Quest: "Where Kings Walk" and "Warchief's Blessing"
The script was deleted by 5f928f7949 But it wasn't done properly via the spell_area anyway

(cherry picked from commit 8d6295559d)
2021-12-11 21:34:48 +01:00
Killyana
0993b491dd DB/Quest: A Visit With The Ancestors
Closes #23284

(cherry picked from commit a3dec9068b)
2021-12-11 16:32:05 +01:00
Killyana
cf6b2586d8 DB/Loot: Remove wrong loot from Dusty Journal
(cherry picked from commit 872d6a015b)
2021-12-11 16:24:27 +01:00
Wyrserth
07dcb28f80 Spell/Fishing: ensure that the fishing bobber expires when the Fishing channeling ends, and don't allow fish to be hooked in the instant the spell is cast. (#23448)
(cherry picked from commit 9083fc149d)
2021-12-11 16:18:57 +01:00
Wyrserth
bfef73b510 Core/Loot: don't allow to regenerate chest loot inside instances and raids. (#23449)
(cherry picked from commit 4320cd7d37)
2021-12-11 16:18:41 +01:00
Wyrserth
20082ac65a DB/SAI: Add out-of-combat texts to Overlord Bor'gorok
Closes #23445

(cherry picked from commit 2762925215)
2021-12-11 16:18:26 +01:00
Wyrserth
86eb312494 DB/SAI: Add out-of-combat texts to Sergeant Gorth
Closes #23443

(cherry picked from commit 5eafa03b46)
2021-12-11 16:18:01 +01:00
Wyrserth
1a9198dc04 DB/Quest: Quest: The Great Hunter's Challenge
Clsoes #23442
Closes #16037

(cherry picked from commit 2525f863e2)
2021-12-11 16:17:28 +01:00
Killyana
5e0a9982c2 DB/Quest: Building a Perimeter
(cherry picked from commit 62e44d0e4b)
2021-12-11 16:16:47 +01:00
Killyana
4afa727661 DB/Creature: Add a cosmetic spawns for "Ar'tor, Son of Oronok"
(cherry picked from commit 0132f13791)
2021-12-11 16:15:35 +01:00
Shauren
3d3d255a47 Core/Conditions: Sync CONDITION_QUEST_OBJECTIVE_PROGRESS implementation with 3.3.5 2021-12-11 16:13:45 +01:00
Wyrserth
a032d84cf4 Core/FlightPath: teleport players at destination on floor Z when the flight ends (#23428)
* Core/FlightPath: teleport players at destination on floor Z when the flight ends, instead of having them fall from the air.

Closes #10051.

* Use the path destination's mapheight instead of the player position's.

* Update FlightPathMovementGenerator.cpp

(cherry picked from commit 6a0a800535)
2021-12-11 16:05:31 +01:00
Wyrserth
5331656785 Core/SAI: allow to start waypoint movement for a creature that is in combat. (#23426)
(cherry picked from commit d6e3660115)
2021-12-11 15:29:32 +01:00
Killyana
1f47729ecb DB/Creature: Big Shirl
Closes #23380

(cherry picked from commit 8a174d2295)
2021-12-11 15:28:11 +01:00
DanVS
f15bcebdbe Core/Spell: Jump Speed Calculations (#22886)
* Jump Speed Calculations

* Fix

(cherry picked from commit 0197a2f990)
2021-12-11 15:25:57 +01:00
Wyrserth
2bcfc6680c Core/Misc: don't allow FindNearestCreature() and FindNearestGameObject() searches to return the entity that called them. (#23437)
Closes #23334.

(cherry picked from commit 015870bfe1)
2021-12-11 15:14:43 +01:00
Killyana
468ff09c78 DB/Quest: Destroying the Altars
Closes #23431

(cherry picked from commit 17671c633c)
2021-12-11 14:58:27 +01:00
Keader
b3493935b6 Core/Scripts: Fixed a reference error introduced in 394b119664
(cherry picked from commit 70cbedd75d)
2021-12-11 14:56:14 +01:00
Killyana
253527a6dc DB/SAI: SMART_SCRIPT_TYPE_TIMED_ACTIONLIST don't use event_type
(cherry picked from commit d0bdd06087)
2021-12-11 14:55:56 +01:00
Keader
f749b3a2e9 Scripts/Icecrown Citadel: Fixed Blood Orb Game Object (#23397)
Close #18005 and Update #18529

(cherry picked from commit 394b119664)
2021-12-11 14:55:18 +01:00
Sorikoff
c8d0e0fd6d Scripts/Isle of Quel'Danas: Thalorien Dawnseeker (#23382)
* Scripts/Isle of Quel'Danas: Thalorien Dawnseeker

* Kill warning

* Kill warning

* Fixes

* Code style

* Code style

* Accident

* Prevent Out of Bound & spelling

(cherry picked from commit e87f8b1aac)
2021-12-11 14:51:31 +01:00
Killyana
934efded41 DB/Gameobject: Gordunni Dirt Mound
Closes  #23232
And fix DB errors related to repeat min/max for quest rewarded and quest accepted

(cherry picked from commit 1c067b3221)
2021-12-11 14:21:11 +01:00
Wyrserth
cf71e5f4b2 DB/Quest: Outro event for "On Brann's Trail" and fix prevquest for "Sniffing Out the Perpetrator"
Closes #23419

(cherry picked from commit 4a9e0b5aca)
2021-12-11 14:16:39 +01:00
Wyrserth
302a13f57f DB/Spell: Don't allow costume auras from Savory Deviate Delight to stack with each other
Closes #23417

(cherry picked from commit 578f93be24)
2021-12-11 14:16:15 +01:00
Killyana
d17c06793e DB/Creature: Fix some spell click
Closes #21772

(cherry picked from commit d98b78237f)
2021-12-11 14:14:47 +01:00
Wyrserth
7745e3f943 Core/SAI: add cooldownMin (event_param2) and cooldownMax (event_param3) to SMART_EVENT_ACCEPTED_QUEST and SMART_EVENT_REWARD_QUEST. (#23422)
(cherry picked from commit 50be697e1f)
2021-12-11 14:14:10 +01:00
Wyrserth
4c5ae42a63 Core/Creature: drop current target when evading while a spell cast is in progress (#23420)
* Core/Creature: drop current target when evading while a spell cast is in progress.

Closes #18373.

* Update Creature.h, thanks jackpoz!

(cherry picked from commit 5ac9b20fcf)
2021-12-11 14:13:53 +01:00
Wyrserth
e846d4c3ef Core/SAI: don't allow to start a new SAI actionlist while the entity is already running one. (#23421)
(cherry picked from commit 2b1cde2560)
2021-12-11 14:13:11 +01:00
Wyrserth
ae43820ca0 Core/Commands: implement commands to look up a map/item/quest name for a given id (#23416)
* Core/Commands: implement commands to look up a map/item/quest name for a given id.

* Add entry to updates table.

* Rename 9999_99_99_99_auth.sql to 2019_06_16_00_auth.sql

* Add missed change, thanks jackpoz!

* Update auth_database.sql

(cherry picked from commit ce3dcdcb1a)
2021-12-11 14:12:54 +01:00
Wyrserth
01be9f44af Core/RDF: fix counting issue with the achievement Looking for More (and similar) (#23418)
* Core/RDF: allow the achievement Looking for More (and similar) to increase the counter based on how many random players were picked.

* Use getter/setter instead.

(cherry picked from commit 14c2bdc5da)
2021-12-11 14:12:54 +01:00
Wyrserth
3278f87789 Core/Loot: fix some other cases where a creature should not be able to set focus. (#23415)
(cherry picked from commit d50be8e020)
2021-12-11 14:12:54 +01:00
Killyana
441e08869e DB/Quest: Quest: Meet Lieutenant Icehammer
Closes #23384

(cherry picked from commit 5c019db6a7)
2021-12-11 14:12:54 +01:00
jackpoz
134fa22510 Core/Unit: Ignore On Transport spline movements if the Unit isn't on a transport anymore
On Transport splines use coordinates relative to the transport but if the transport is not found anymore than there is no way to get the absolute coordinates, leading to relative coordinates being used as absolute instead. The result is a Unit being set at position (0, 0, 0) or close by.

(cherry picked from commit c90f789eac)
2021-12-11 14:12:54 +01:00
Killyana
c08da92575 DB/Quest: Quest: As the Crow Flies
Closes #23354

(cherry picked from commit 96a5bdbe05)
2021-12-11 14:12:54 +01:00