Commit Graph

37371 Commits

Author SHA1 Message Date
funjoker
f50458d654 Fix build, cherrypick mistakes and start up 2022-01-28 22:32:59 +01:00
ariel-
4ecfc62438 Core/Achievement: fix bad lookup of ACHIEVEMENT_CRITERIA_DATA_TYPE_S_EQUIPPED_ITEM item
Closes #19064

(cherry picked from commit 70c4a37544)
2022-01-28 22:32:59 +01:00
funjoker
eb21768138 Core/Misc: Fix cherry-pick mistakes 2022-01-28 22:32:59 +01:00
ariel-
35b5eaed8f Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts
Closes #19334

(cherry picked from commit 9cfa7c752e)
2022-01-28 22:32:59 +01:00
ariel-
8aa53f2df7 Core/Achievements: port realm first achievement handling from master
veeeery partial cherry-pick of c75fcbe20b

(cherry picked from commit 4596c17dae)
2022-01-28 22:32:59 +01:00
Xinef
62a7c88ef6 Core/Achievements: Optimized resetting achievement criteria by condition and changed the functionality to properly reset all possible criteria with given condition
Closes #18905

(cherry picked from commit 7c7b877c3f)
2022-01-28 22:32:59 +01:00
Xinef
dc15ba1193 Core/Achievements: Greatly optimize achievement system by splitting large types by miscvalue
Closes #18633

(cherry picked from commit 9b44ed9cda)
2022-01-28 22:32:59 +01:00
Ovahlord
0d2a56473a Scripts/Achievements: fixed "You'll Feel Right as Rain" 2022-01-28 22:28:28 +01:00
Shauren
f4c39d1aa9 Build: Disable Visual Studio 2022 MSBuild resource manager to make compile take only as much time as it does in Visual Studio 2019 2022-01-28 21:14:47 +01:00
Ovah
2f99af8d70 Core/Achievements: properly handle ACHIEVEMENT_CRITERIA_TYPE_LEARN_SKILL_LEVEL 2022-01-27 19:00:49 +01:00
Ovahlord
04983ce882 Core/Packets: converted SMSG_CRITERIA_UPDATE to packet class 2022-01-24 02:34:54 +01:00
Ovahlord
292887a0c2 Core/Datastores: corrected a member type in AchievementCriteriaEntry 2022-01-24 02:04:29 +01:00
Ovahlord
03328fe84e Core/Achievements: ported criteria asset union refactor 2022-01-23 22:32:59 +01:00
Ovahlord
2bef0ce3f6 Core/Spells: fixed logic for selecting a channel focus target 2022-01-23 12:44:08 +01:00
xinef1
9da4acce08 Core/Spells: Remade trajectory target selection (#19048)
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received

(cherry picked from commit c6060dd0c5)
2022-01-22 22:29:20 +01:00
xinef1
a07f73c846 Core/Achievements: Mountain o' Mounts and similar achievement will be properly awarded when you have required amount of mounts, not earlier (#19002)
(cherry picked from commit 8646e72f18)
2022-01-22 21:03:06 +01:00
ariel-
29166a1d0a Core/Util: avoid one useless copy when adding stuff into a HookList
(cherry picked from commit 077b5aec9e)
2022-01-22 20:27:51 +01:00
Keader
3681f356d6 Core/Spell: Fixed range issues with some quest spells
Closes #17815

(cherry picked from commit 6f7310a259)
2022-01-22 19:04:34 +01:00
Ovahlord
3c88782b87 Core/Movement: no longer copy movement status returned in ack messages and stricly rely on server side status 2022-01-22 17:25:26 +01:00
Ovahlord
ba4df11ab8 Core/Items: handle ITEM_MOD_EXTRA_ARMOR
closes #323
2022-01-21 23:12:16 +01:00
Ovahlord
58d5546139 Core/Datastores: increased the db2 locales mask to allow loading locales >= ruRU 2022-01-21 17:18:47 +01:00
Ovahlord
c076340347 warning fix 2022-01-21 15:00:53 +01:00
Ovahlord
67b19e741d Core/Misc: fixed several warnings that have been exposed by the new warnings 2022-01-21 14:22:06 +01:00
Shauren
29fc3d55b4 Build: Enable some msvc warnings that are enabled for other compilers
# Conflicts:
#	cmake/compiler/msvc/settings.cmake
2022-01-21 13:56:39 +01:00
acidmanifesto
803bd2c79b Scripts/Eastern Kingdoms: merged zone_goldshire into zone_elwynn_forest to follow standards 2022-01-18 17:10:57 +01:00
Ovahlord
e7f13602b6 Scripts/BWD: Magmaw's Blazing Bone Construct will now move with a run speed of 10 to match sniff data 2022-01-17 23:41:11 +01:00
Ovahlord
5a54280179 Scripts/BoT: corrected Cho'Gall's initial timer for Fury of Cho'Gall 2022-01-17 22:44:56 +01:00
Ovahlord
bf669937be Core/Spells: SPELL_AURA_MOD_FACTION will now apply UNIT_FLAG2_IGNORE_REPUTATION to all targets instead of players only 2022-01-17 22:11:17 +01:00
Ovahlord
db769f5e52 Core/Units: safeguard Unit::CancelSpellMissiles against triggering an assert in BasicEvent::ScheduleAbort when trying to cancel spell events that already are about to the aborted 2022-01-17 10:59:41 +01:00
Ovahlord
03cbd6fe92 Core/Movement: yoinked the movement direction calculation from master's TARGET_DEST_CASTER_MOVEMENT_DIRECTION implementation
thx Shauren for the headsup
2022-01-16 20:40:19 +01:00
Shauren
9ab7c6e8f6 Fixed -Wdeprecated-copy warning in G3D 2022-01-16 19:37:03 +01:00
Ovahlord
edcc11423b warning fix 2022-01-16 19:35:37 +01:00
Shauren
a06b3cea3c Core/Spells: Fixed caster unit validation for players that have charmed (not possessed) units 2022-01-16 18:45:07 +01:00
Ovahlord
9892d239a8 Core/Spells: renamed SPELL_ATTR5_INCLUDE_MELEE_RANGE to SPELL_ATTR5_TREAT_AS_AREA_EFFECT and handle the attribute in SpellInfo::IsAffectingArea 2022-01-16 11:44:49 +01:00
Ovahlord
d5fa8c3e10 Core/Spells: Hunter Pets will now correctly inherit 22% of the player's attackpower instead of 42.5% 2022-01-16 11:32:47 +01:00
Ovahlord
d17ceb70d5 Core/Movement: add a helper to obtain movement direction angles from player movement 2022-01-16 11:31:14 +01:00
Ovahlord
7342ba57f7 DB/Loot: unlink references that were referencing themselves, resulting in infite loops
closes #319
2022-01-16 09:23:49 +01:00
Ovahlord
f621152df6 typo fix² 2022-01-16 03:33:46 +01:00
Ovahlord
8368c065fb typo fix 2022-01-15 21:05:31 +01:00
Ovahlord
19bf9cd7d7 DB/Pets: corrected level 85 stat values for DK ghouls 2022-01-15 21:04:16 +01:00
ModoX
83456ed853 Core/Quests: Set quest slot earlier when abandoning a quest 2022-01-14 21:40:27 +01:00
Ovahlord
319ef144b4 Core/Spells: SPELL_ATTR0_CU_CONE_LINE is no longer taking a target's combatreach into account to avoid being falsely hit when not even inside of the cone 2022-01-14 21:37:08 +01:00
Ovahlord
86d8443732 Core/Spells: further fixups for spell focusing and channel target selection
* SPELL_ATTR1_SELF_CHANNELED is now also considering targets when required
2022-01-14 21:36:13 +01:00
Ovahlord
b242ca48ed Scripts/BH: fixed a crash in Occu'thar's target selection script for Focused Fire 2022-01-14 18:46:43 +01:00
Ovahlord
520b53a5e0 Core/Spells: added a helper to determine whenever a periodic aura should roll over its duration on refresh
* introduce another custom spell attribute to grant full control over when or when not to roll over ticks
2022-01-14 18:46:03 +01:00
Ovahlord
19e28e2077 Core/Phasing: fixed a typo in b1f16bceb0 2022-01-13 22:00:44 +01:00
Ovahlord
0aa9129c3b Core/Spells: let all periodic effects roll over their timers on refresh
* renamed SPELL_ATTR0_CU_DONT_RESET_PERIODIC to SPELL_ATTR0_CU_RESET_PERIODIC_TIMER and changed functionality to prevent described behavior from happening
2022-01-12 18:51:21 +01:00
Ovahlord
1149fbce3d Core/Spells: revert an unwanted change that sneaked into 9085526f9a 2022-01-12 17:57:41 +01:00
Ovahlord
9085526f9a Core/Spells: define and implement SPELL_ATTR8_PERIODIC_CAN_CRIT
* SPELL_ATTR8_DONT_RESET_PERIODIC_TIMER has been moved to a custom attribute (SPELL_ATTR0_CU_DONT_RESET_PERIODIC)
2022-01-12 17:33:34 +01:00
Shauren
6252bd9fa8 Core/Groups: Fixed crash in loot rolls happening when looted object despawns before roll expires 2022-01-12 15:56:48 +01:00