Fixed bugs with Sapphiron encounter:
- Sapphiron will now properly re-engage if the previous attempt ended while he was in flight.
- Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground.
- Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.
(cherry picked from commit a90ae075c9)
Fix queuing in LFG with 5-men groups leaving the party in queue forever, caused by group GUID being added to list of party members.
(cherry picked from commit 42a71133fa)
Conflicts:
src/server/game/DungeonFinding/LFGQueue.cpp
Add an optional parameter "escapeCharacters" to ChatHandler::SendSysMessage() to properly escape | character, otherwise it might freeze the client.
(cherry picked from commit 7c91984a64)
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
(cherry picked from commit 2f92a2f58e)
Conflicts:
src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet(), IsTotem(), IsSummon(), IsGuardian(), IsHunterPet() and IsVehicle() from Creature to Unit
(cherry picked from commit ea4d9c0d9e)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/scripts/Spells/spell_pet.cpp
Remove some ToCreature() casts not needed anymore after 1ee90e1022 changes that moved IsPet() from Creature to Unit
(cherry picked from commit d243630acf)
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Spells/Spell.cpp
src/server/game/Spells/SpellEffects.cpp
The log is triggered when a mage creates a portal to another map, uses it and then the portal despawns.
(cherry picked from commit a8ceb18cdf)
Conflicts:
src/server/game/Entities/GameObject/GameObject.cpp
The "error" is a false positive happening every time a player in a Battleground logs out because WorldSession::LogoutPlayer() notifies the bg twice
(cherry picked from commit ca5a2785f7)
Fix a rare case that would cause SPELL_EFFECT_NORMALIZED_WEAPON_DMG to do 4 billions damage or to trigger an assertion in Unit::CalculateDamage() depending by Unit base damage.
To reproduce the issue cast spell 25816 on a level 1-14 warrior, then make the warrior cast spell 694 on a Creature.
(cherry picked from commit 143026ed19)
Apply an exponential formula to define the chance to bid/buyout an auction depending on auction price and item price ratio. The formula can be adjusted changing the new AuctionHouseBot.Buyer.ChanceFactor config parameter
Chance = 100 ^ (1 + (1 - (auction_price / item_price) / k)
k is the config parameter AuctionHouseBot.Buyer.ChanceFactor, the higher the number the higher chance to buy overpriced auctions.
(cherry picked from commit 177b6319d1)
Conflicts:
src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
Addition to a328a11978 , clamp object size to [0,4] in case of very huge Creatures like Lord Marrowgar entry 36612
(cherry picked from commit 0a94382637)
