Commit Graph

15318 Commits

Author SHA1 Message Date
ariel-
24413cd30f Core/Auras: travis fix 2018-03-05 14:33:25 +01:00
ariel-
62c114d402 Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases
Updates #21367
2018-03-05 14:19:32 +01:00
ariel-
0321955726 Core/Auras: added sanity checks for area auras having a different owner unit than caster
Closes #21517
2018-03-05 14:19:22 +01:00
Chaouki Dhib
81e7cb4c42 Core/Movement: Correct distance checking
Distance checking should always be in 3D, independently on if the mover has the ability to fly or not.
2018-03-05 14:18:33 +01:00
Aokromes
17bd341fda Core/DBUpdater: Code cleanup 2018-03-05 14:02:05 +01:00
Aokromes
8ad35cb9fa rename files 2018-02-24 13:50:29 +01:00
Aokromes
7bc51fe29e Revert "DB/Spells: fix proc regression with Missile Barrage"
This reverts commit 640dd138a5.
2018-02-24 13:26:26 +01:00
ariel-
30e0c87ff9 Core/Auras: restrict target map update only to area auras as player requires to have auras registered on load
Closes #21472
2018-02-24 13:13:47 +01:00
ariel-
f2f574fbdd DB/Spells: fix proc regression with Missile Barrage
Closes #21466
2018-02-24 13:12:03 +01:00
Aokromes
e3423b4298 Core/DBUpdater: Improve message when base SQL file is missing 2018-02-18 18:39:07 +01:00
jackpoz
86f03d79cc Core/Spells: Revert SPELL_ATTR2_IGNORE_ITEM_CHECK to unknown
Revert SPELL_ATTR2_IGNORE_ITEM_CHECK to unknown, too many spells unrelated to items have this attribute and the current handling was causing exploits with "Mote of Water" and other elements.
Fix #19547
2018-02-18 18:37:00 +01:00
Wilcalaf
be2a17f191 Scripts/Nexus: Fixed a rare bug when sometimes Magus telestra managed to die while invisible preventing players from looting. (#21436) 2018-02-18 18:36:49 +01:00
jackpoz
4a7089b10a Core/Misc: ASSERT() cleanup
Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.
2018-02-18 18:00:27 +01:00
sirikfoll
263617f81f Scripts/Icecrown Citadel: Prevent Lady Deathwhisper movement during first phase. 2018-02-18 18:00:13 +01:00
ariel-
e219b3f940 Core/Auras: fixed Drain Mana breaking early if caster has Mana Feed talent but no active pet 2018-02-18 17:59:30 +01:00
Aokromes
3adfc66859 Core/Scripts: implement Drain Mana breaking some auras on hit 2018-02-18 17:58:58 +01:00
Cannix
c238fd1017 Core/Spells: Execute item casts immediately instead (#21396) 2018-02-17 17:45:28 +01:00
Aokromes
cbe84fa130 Core/Entities: remove grid-wide visibility from setActive and implement another method for it 2018-02-17 17:45:03 +01:00
ariel-
3292925319 Core/Events: update holiday code and remove misleading log (event date is the one from game_event)
- add siign to DBC struct member CalendarFilterType as it was being used as such
- kill localtime usage as it's deprecated

Closes #18542
2018-02-17 16:14:35 +01:00
Aokromes
70a30770d8 Core/Scripts: implemented Fungal Decay & Tail Sting 2018-02-17 16:11:01 +01:00
ariel-
a858e9937e Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise 2018-02-17 16:00:29 +01:00
Aokromes
ca5e3445b8 Core/SAI: Add an action_param3 to "summon gob" to control when the object will despawn
0 - For despawn when creature dies or time runs out
1 - For despawn after time
2018-02-16 04:05:47 +01:00
Aokromes
ade258873e Scripts/TotC: Reduce Twin Val'kyr berserk timer from 10 minutes to 8 minutes on normal mode (match DBM). 2018-02-16 03:49:47 +01:00
ariel-
25675405b2 Core/Auras: skip target map update for one world tick if owner is not yet in world
Closes #21426
2018-02-16 03:44:43 +01:00
Aokromes
1f7391a6b1 Scripts/Commands: add AI/ScriptName to .gobject info 2018-02-16 03:44:27 +01:00
Aokromes
66a01f2d69 Core/Handlers: fix bogus check that skipped CMSG_CAST_SPELL packet under certain conditions, missing a target change 2018-02-16 03:30:18 +01:00
ariel-
66334459a6 Core/Spells: fixed server being too overzealous with autoshot
- Interrupting it when casting another spell and switching targets

Ref #21390
2018-02-16 03:27:16 +01:00
Aokromes
4721d9814b Core/Scripts: Fixed some delayed enrage 2018-02-16 03:26:36 +01:00
Aokromes
0aacb75d73 Scripts/TheBarrens: Fix "The Escape" (863) 2018-02-16 02:21:09 +01:00
Aokromes
74b7ac101a Scripts/SmartAI: SMART_TARGET_INVOKER cleanup step 1. The core will n…
…ow log errors on start-up if SMART_TARGET_INVOKER abuse is found, but will continue to load the scripts as deprecated for now.

Note that a lot of these scripts may either not currently work, not work reliably, or may be prone to breaking unexpectedly when core internals change. SMART_TARGET_INVOKER is undefined behavior on any event that doesn't directly specify its invoker.

(We are considering options for allowing INVOKER to make sense in timed action lists in a reliable fashion, so they are exempted at this time.)
2018-02-16 02:08:56 +01:00
ariel-
bbe9aa23b0 Core/Spells: fix Vampiric touch dispel effect inheriting damage done pct twice 2018-02-16 01:57:08 +01:00
Wilcalaf
6d90944f02 Archaedas should properly start now when clicking on the altar. (#21401) 2018-02-16 01:40:15 +01:00
Aokromes
9f0f00257e Core/Scripts: fix nopch 2018-02-16 01:38:48 +01:00
ariel-
3a4035bb8d Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 2018-02-16 01:26:26 +01:00
Treeston
daa7c79f7e Revert "Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310)"
This reverts commit 6ff71dffbb.
2018-02-16 01:25:02 +01:00
Treeston
c83d9d3a4b Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310. 2018-02-16 01:24:55 +01:00
Treeston
302599decd Scripts/ScarletEnclave: fix Massacre at Light's Point mine cart escort to work again (tag #20310) 2018-02-16 01:24:48 +01:00
ariel-
e6888f72e0 Core/Scripts: implemented Combined Toxins proc only from poisons 2018-02-16 01:22:39 +01:00
Aokromes
d5a77f6b79 Core/Auras: fix periodic ticks proc after previous commit 2018-02-16 01:21:15 +01:00
ariel-
2388415edd Core/Spells: require phasemask set for periodic damage procflag
Closes #21379
2018-02-16 01:04:27 +01:00
jackpoz
bee461eda8 Core/Player: Add some asserts
Assert PlayerInfo for race/class pair in a few Player functions
2018-02-16 01:04:11 +01:00
jackpoz
46467499f3 Scripting/Obsidian Sanctum: Fix crash
Fix crash caused by calling Reset() in constructor (which is not allowed)
2018-02-16 01:03:56 +01:00
Jildor
53728216b6 Whitespace cleanup in Transaction.cpp
Removing white space after commit 54b0b8f5ea
2018-02-16 01:03:45 +01:00
jackpoz
d1df97db23 Shared/Database: Improve dead-lock error handling
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times
2018-02-10 16:16:14 +01:00
Keader
563de5bf20 Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
ty sirikfoll :)
2018-02-10 12:08:32 +01:00
Treeston
6363bc77b8 Game/AI: InvalidAIException internal cleanup 2018-02-10 12:08:24 +01:00
Keader
a162d421ce Core/Scripts: Fixed tabs issues introduced in 5bef3e426a 2018-02-10 12:04:09 +01:00
Keader
2f8361d320 Core/Scripts: Fixed possible crashs related with JustDied 2018-02-10 12:03:59 +01:00
ariel-
9fdb4c0a4d Core/Scripts: fix non-functional Celestial Planetarium Access GO
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982
2018-02-10 11:52:22 +01:00
sirikfoll
855a0bbaf0 Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor
Closes #20727
2018-02-10 11:52:11 +01:00