Commit Graph

2427 Commits

Author SHA1 Message Date
Shauren
3af9be830d Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes 2021-10-03 14:58:35 +02:00
Shauren
3bf6698116 Core/Misc: Fix appleclang 12 warnings 2021-10-01 11:18:29 +02:00
Keader
1d00e4eccb Scripts/Ruby Sanctum: Fixed Baltharus target amount of Enervating Brand part 2
(I forgot the clones, ty Gildor)

(cherry picked from commit 3102a6c903)
2021-09-28 15:32:32 +02:00
Keader
a046ef8604 Scripts/Ruby Sanctum: Fixed Baltharus target amount of Enervating Brand
(cherry picked from commit 8a312046b2)
2021-09-28 15:32:00 +02:00
Keader
d4be86d835 Kill a whitespace
(cherry picked from commit ee7c0c16f1)
2021-09-28 15:31:34 +02:00
Keader
4aaf3d67a3 Scripts/Pit of Saron: Fixed Ick not updading victim
Closes #22001

(cherry picked from commit 6cf8bd5ae7)
2021-09-28 00:15:42 +02:00
ccrs
426f9f2f92 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).

(cherry picked from commit 982643cd96)
2021-09-28 00:15:13 +02:00
jackpoz
376defd085 Scripts/Icecrown Citadel: Fix "intended" crash
Change an assert (that can happen easily using ".npc add") to a sanity check

(cherry picked from commit 953640d563)
2021-09-26 16:21:33 +02:00
Treeston
9f06cb63d2 Core/Threat: My dictionary informs me that "fixtate" is not, in fact, a word. Corrected to "fixate".
fd33b1c follow-up

(cherry picked from commit 1d27f83bda)
2021-09-26 16:13:15 +02:00
Treeston
f1ac141f25 Core/Unit: UNIT_FLAG renames
[UNIT_FLAG_PLAYER_CONTROLLED -> UNIT_FLAG_POSSESSED]
[UNIT_FLAG_PVP_ATTACKABLE -> UNIT_FLAG_PLAYER_CONTROLLED]
Signed off by: Shauren, Warlockbugs.

(cherry picked from commit 081eab3cf5)
2021-09-26 16:07:09 +02:00
Jorge Turrado Ferrero
a9b97939a8 Scripts/Ulduar: Fixed Vehicles when flame leviathan die(#21897)
(cherry picked from commit f13de80834)
2021-09-26 15:49:18 +02:00
ccrs
d59a6af9c6 Core/Movement: move MoveSplineInit (#21857)
The number of edge cases in which weirdness is seen on "effect movements" will be kinda reduced, plus consistency, plus movementInform on custom movement spline initalizations.

(cherry picked from commit 2a45418032)
2021-09-26 14:19:36 +02:00
ariel-
765987a9f5 Core/Misc: whitespace/tab cleanup
(cherry picked from commit bcc7427fbc)
2021-09-23 22:50:09 +02:00
Treeston
f69d12504c Core/Object: Bump hover delta handling on nearpoints downstack into GetNearPoint2D (from movement generators); functionality should be unchanged
(cherry picked from commit ebc96af6bb)
2021-09-23 22:28:06 +02:00
Treeston
bc89e1cdb0 Core/Position: Refactor GetAngle -> GetAbsoluteAngle because code clarity is good.
(cherry picked from commit 4692e10ca2)
2021-09-23 22:21:29 +02:00
ariel-
05c9b8c337 Scripts/ICC: use script searchers instead of saving list of creature pointers
Closes #21644

(cherry picked from commit f87da3a306)
2021-09-19 22:21:35 +02:00
Meji
0a83f74876 Core/Achievements: Update CriteriaType enum (#26856) 2021-09-08 22:07:01 +02:00
ariel-
7c5e23c973 Core/Spells: implemented 'Weakened Spirit' mechanic in Valithria Dreamwalker
- Debuff used to prevent multiple priests chaining 40% heal buff (Guardian Spirit)

(cherry picked from commit 7d118f05ba)
2021-09-06 20:38:34 +02:00
Treeston
a88cf958b0 Scripts/Naxxramas: Fix an issue that could cause Sapphiron to stop using Drain
(cherry picked from commit 43491ba7f4)
2021-09-06 15:17:53 +02:00
Shauren
8a4e1119ac Core/Spells: Unify spell effect access api in both branches 2021-09-04 15:13:15 +02:00
Shauren
8cc418460f Core/Misc: Fix gcc warnings 2021-08-28 16:08:33 +02:00
ariel-
962f6d7988 Core/Spells: rework part 5: GameObject casting
Closes #21330
Closes #18885
Ref #18752

(cherry picked from commit 45c5e1b9d6)
2021-08-28 15:59:11 +02:00
ariel-
65dca120d3 Core/Spells: rework part 4: iterate over effects first
Ref #18395

Implement far spell queue processing
Closes #7395

(cherry picked from commit 080d2c6cd4)
2021-08-28 15:59:11 +02:00
Shauren
a91edcb952 Core/Creatures: Remove hover on death
(cherry picked from commit 241109327b)
2021-08-24 13:45:34 +02:00
joschiwald
c94c561b85 Scripts/Misc: Fixed hover movement for Stormcaller Brundir
(cherry picked from commit e9aba10695)
2021-08-24 12:46:53 +02:00
Chaouki Dhib
246699a173 Scripts/Misc: Hover script fixes
(cherry picked from commit 510bc0b7a0)
2021-08-24 12:46:02 +02:00
Shauren
2e2b298618 Core/Movement: Fixed creature hover
Closes #15177

(cherry picked from commit 2baa81065b)
2021-08-24 12:44:38 +02:00
Treeston
994121e671 Core/CreatureAI: CheckBoundary -> IsInBoundary, better reflects what it does. Also moved to public so spellscript can use it.
(cherry picked from commit df639d85e4)
2021-08-23 23:28:48 +02:00
ariel-
e8e501609f Core/Entities: ghouls start with full energy
(cherry picked from commit 0c1e485e13)
2021-08-23 19:29:41 +02:00
ariel-
a1a00f823e Core/Entities: kill unused return value from Unit::HandleSpellClick
- AI hook will now receive the result by copy, as modifying it had no effect
- Some renaming: result->spellClickHandled, clickPair is actually clickBounds, the clickPair is the pair <creatureID, SpellClickInfo>

(cherry picked from commit 98d6258efd)
2021-08-08 21:21:34 +02:00
Wilcalaf
e3941e4199 Scripts/Nexus: Fixed a rare bug when sometimes Magus telestra managed to die while invisible preventing players from looting. (#21436)
(cherry picked from commit 2dd5735bd9)
2021-08-08 21:21:34 +02:00
sirikfoll
74101eaf7c Scripts/Icecrown Citadel: Prevent Lady Deathwhisper movement during first phase.
(cherry picked from commit 076bd11002)
2021-08-08 21:21:34 +02:00
Wyreth
8713a62328 Core/Entities: remove grid-wide visibility from setActive and implement another method for it (#20725)
(cherry picked from commit 56874b44f0)
2021-08-08 21:21:34 +02:00
Keader
ab8f8e1ffb Scripts/Ulduar: Fixed amount of Mole Machines in Razorscale 10 man
(cherry picked from commit f609589e22)
2021-06-22 13:06:33 +02:00
Treeston
f0823eb048 Scripts/TotC: Reduce Twin Val'kyr berserk timer from 10 minutes to 8 minutes on normal mode (match DBM). This closes #15367, no matter what ccrs' bong says.
(cherry picked from commit 789f3c5d37)
2021-06-22 12:47:40 +02:00
ariel-
d91e099b10 Core/Spells: prevent creatures to focus channeled spells without SPELL_ATTR1_CHANNEL_TRACK_TARGET
- Creatures stuck here wouldn't try attacking because of this
- Remove one workaround in halion script, now it's unneeded

Ref #11311

(cherry picked from commit 29f7258dc8)
2021-06-21 12:47:03 +02:00
Treeston
f982f3019a Core/Combat: Unify combat permitted checks between CvC and PvC - only require "not friendly" in all cases. Fixes Yogg-Saron encounter. Closes #21380.
Also some bonus cleanup to Yogg's script to make transition cleaner.

(cherry picked from commit 4da9321d2b)
2021-06-21 00:07:24 +02:00
Keader
cb8ea03175 Core/Scripts: Fixed some delayed enrage
Closes #15367

(cherry picked from commit 63c436f5fb)
2021-06-21 00:06:41 +02:00
Treeston
3b635a8a12 Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310.
(cherry picked from commit fe3b4de1cd)
2021-06-20 20:17:59 +02:00
ariel-
a342b86403 Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic)
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)

(cherry picked from commit bc2a4c816d)
2021-06-20 01:15:00 +02:00
ariel-
23a88fae6f Core/Scripts: remove Tenacity hack, implemented with proper aura
(cherry picked from commit 404240fb68)
2021-06-20 00:55:53 +02:00
Treeston
3c172ba17c Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310.
(cherry picked from commit b243a7929b)
2021-06-19 23:33:38 +02:00
ariel-
a24af55d13 Core/Scripts: implemented Combined Toxins proc only from poisons
(cherry picked from commit 477878630e)
2021-06-19 23:33:38 +02:00
jackpoz
e63c5f7b0c Scripting/Obsidian Sanctum: Fix crash
Fix crash caused by calling Reset() in constructor (which is not allowed)

(cherry picked from commit 5aba5c7aff)
2021-06-19 23:33:38 +02:00
Keader
299f22e3fc Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
ty sirikfoll :)

(cherry picked from commit 2994abeae6)
2021-06-19 23:33:37 +02:00
Keader
9b7f3bff9f Core/Scripts: Fixed tabs issues introduced in 5bef3e426a
(cherry picked from commit 31ad6358fb)
2021-06-19 23:33:24 +02:00
Keader
ad5b0fa9cd Core/Scripts: Fixed possible crashs related with JustDied
(cherry picked from commit 5bef3e426a)
2021-06-19 23:33:24 +02:00
ariel-
4ae29e38ee Core/Scripts: fix non-functional Celestial Planetarium Access GO
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982

(cherry picked from commit b490d3f5ad)
2021-06-19 23:33:24 +02:00
Treeston
d7542dc3e8 Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version.
Closes #21265.

(cherry picked from commit b3e0c89238)
2021-06-19 01:57:55 +02:00
Treeston
a8307e60a3 Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn.
Closes #21286.

(cherry picked from commit aefc25482f)
2021-06-19 01:35:41 +02:00