Unit::IsControlledByPlayer is a expected value for TempSummons (like some triggers used in quests, summoned by spells).
Previous logic broke a lot of quests which use triggers to do stuff.
Allow JustSummoned and events linked from other events with flag set also in charmed (prevents breaking event chains)
Allow vehicles (needed for vehicles with SmartAI, eg Iron Rune Constructs and You: Rocket Jumping)
- Icy Talons, Holy Concentration, Surge of Light, Trauma, Glowing twilight scale: these auras have SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED,
but spells triggering them don't have SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC or SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, so I suspect a wrong flag implementation in the core. Setting the "can proc with triggered" attribute for now.
- Trauma, Glowing twilight scale: added spell_proc entry to override SPELLFAMILY_PALADIN in dbc (no spells from other spell family could trigger this)
- Light's Grace: Casted Holy Light was proccing the triggered aura and removing the charge instantly, Add "must use spell mod" attribute.
- Dislodged Foreign Object: should proc on damaging spell casts only (has positive spell proc flag in DBC)
Turns out epic and legendary items are excluded from this limitation (or it could be just instanced content that is immune to this). Other qualities are affected as normal. Sorry for the mishap.
Fixes issues with quests that rely on this behaviour (eg Free your Mind)
Also updated SetSpawnHealth so it doesn't do anything in case spawn is manual (SetHealth(GetHealth()) does modify things depending on deathstate)
- Quest Nessa Shadowsong and following steps are only available to Night Elves.
- Fix offer reward text for quest Elanaria.
- NPC Webwood Spider should be neutral.
- Small cosmetic fix for quest Force Commander Danath's end event.
- Prevent NPCs Gnarlpine Shaman and Elder Timberling from spamming healing spells.
* Fixed unintentional typo?
Seemed to fix the issues related to the effect for the spells I tried.
Sometimes the caster triggers leapback onto targets, and with the old
code, it instead made the caster leap back instead of its targets
(cherry picked from commit 08aab73c7f)
Correction on Evasive Maneuvers (Oculus drake aura) proc
(845102b9fd follow-up)
Query used:
SELECT * FROM `spell_proc` WHERE `SpellFamilyName` = 0 AND `SpellTypeMask`=0 ORDER BY SpellId ASC;
