Commit Graph

16680 Commits

Author SHA1 Message Date
Shauren
40c71ea9fc Core/Misc: Remove unused variables 2020-06-29 09:23:38 +02:00
Shauren
2fcb79e2de Core/DataStores: Fixed loading db2 strings
Closes #24916
2020-06-29 00:10:37 +02:00
Shauren
deca201f77 Core/DataStores: Simplified string memory allocation in db2 files, dropped unneccessary level of indirection 2020-06-27 13:33:17 +02:00
Shauren
176c75e8db Core/Spells: Include more than first 2 spell effects when determining if a spell is negative 2020-06-26 00:23:46 +02:00
Shauren
bbdabd7d77 Core/Players: Remove deprecated skill related config AlwaysMaxWeaponSkill and command .maxskill 2020-06-25 14:45:28 +02:00
Carbenium
9969d6e194 Fix non-PCH build
(cherry picked from commit 05025d79f3)
2020-06-24 14:35:10 +02:00
Peter Keresztes Schmidt
bab5fd87a3 Core/Misc: Replace Trinity::make_unique with std (#24869) 2020-06-23 08:54:12 +02:00
Shauren
c3dcbe04dc Core/Spells: Assign spell effect handles for new apply aura effects 2020-06-22 11:04:57 +02:00
ForesterDev
01d098830a DB/Account: update account_access table (#24788)
* DB/Account: update account_access table:

- rename fields id -> AccountID, gmlevel -> SecurityLevel
- add Comment field
- rename command .acc set gmlevel to .acc set seclevel

* Update auth database

* Fix primary key

* Temporary restore old command account set gmlevel with same handler as account set seclevel

Use Optional  for realmID - if not set, use -1 (for all realms)

* Rename 2020_XX_XX_00_auth.sql to 2020_06_20_00_auth.sql

* Update auth_database.sql

* Rename 2020_XX_XX_00_world.sql to 2020_06_20_06_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 8e0365d8a6)
2020-06-22 11:03:31 +02:00
Shauren
fce9fca900 Core/Spells: Implemented new target types
* TARGET_UNIT_TARGET_ALLY_OR_RAID
* TARGET_UNIT_CASTER_AND_SUMMONS
* TARGET_UNIT_AREA_THREAT_LIST
* TARGET_UNIT_AREA_TAP_LIST
* TARGET_DEST_CASTER_GROUND
* TARGET_DEST_SUMMONER
* TARGET_DEST_TARGET_ALLY

Closes #18558
Closes #18867
Closes #24295
2020-06-21 15:59:43 +02:00
Shauren
22a3cb4432 Core/Auction House: Fixed sorting in non-equipment categories 2020-06-18 10:57:26 +02:00
ariel-
7c2e83604c Core/Scripts: moved Wild Growth calculation to script and fixed formula
Thanks ccrs for the formula

(cherry picked from commit 96ee23487f)
2020-06-14 23:49:05 +02:00
ariel-
8e44a6a381 Core/AI: restore old check forcing PetAI on Pets using SmartAI
includes more template love

Closes #19837

(cherry picked from commit 9c24ec5c96)
2020-06-14 23:49:05 +02:00
ForesterDev
15609a197e Scripts/Gossip: fix go_ahune_ice_stone (#19835)
(cherry picked from commit f9a01c4b69)
2020-06-14 23:49:05 +02:00
ariel-
3cf5db1831 Core/Globals: add more AIName and MovementType checks to ObjectMgr
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)

Closes #19831

(cherry picked from commit d56a28afee)
2020-06-14 23:49:05 +02:00
Keader
e50a95839c Core/Scripts: Fixed some events that not should triggered by non-players on Illidan encounter
(cherry picked from commit 0c6829f7f2)
2020-06-14 23:49:05 +02:00
Shauren
1fd59700d7 Core/Groups: Fixed calculating canReset attribute
Broken in d6df19cd99.

(cherry picked from commit 0222d9fc1a)
2020-06-14 23:49:05 +02:00
Shauren
042418cf26 Revert "Core/Groups: fix wrong query for loading group instance data. canReset attribute was calculated in the wrong way"
This reverts commit 0c1dd398bd.

Closes #19745

(cherry picked from commit 023d252155)
2020-06-14 23:49:05 +02:00
Keader
c9c178db19 Core/Spells: Removed duplicated check again followup 3a0417f712
to send some info to client

(cherry picked from commit ed43883160)
2020-06-14 23:49:05 +02:00
Keader
19602c2e83 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt

(cherry picked from commit 3a0417f712)
2020-06-14 23:49:05 +02:00
ariel-
1881088744 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code

(cherry picked from commit ce3787f190)
2020-06-14 23:49:05 +02:00
ariel-
43339e6840 Core/Players: fix null dereference crash
(cherry picked from commit c3176a8143)
2020-06-14 23:49:04 +02:00
treeston
57e3a67c94 Fix an issue where CanSpawn would never get invoked on creatures without per-guid script.
(cherry picked from commit aeaa8ecfab)
2020-06-14 23:49:04 +02:00
treeston
803012cc40 Add another helper to ScriptedGossip.h for resolving listId -> action.
(cherry picked from commit 302a039b7c)
2020-06-14 23:49:04 +02:00
sirikfoll
c99963b023 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823

(cherry picked from commit 1cc0458b11)
2020-06-14 23:49:04 +02:00
Treeston
aa811d57b6 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)

(cherry picked from commit 69fd6245dc)
2020-06-14 23:49:04 +02:00
ForesterDev
7211c6e51d Scripts/Command: implement .debug play music command
Closes #19809

(cherry picked from commit dd4ff1fe54)
2020-06-14 23:49:04 +02:00
Treeston
496263fccb Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.

(cherry picked from commit 1945874f96)
2020-06-14 23:49:04 +02:00
ariel-
b1f1cc4514 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit
(cherry picked from commit 63e502a67d)
2020-06-14 23:49:04 +02:00
treeston
6f73960480 Instances/Ulduar: Fix a super edge case bug where Algalon would evade if his tank successfully tanked a Cosmic Smash and got knocked up. Shadow priests everywhere rejoiced.
(cherry picked from commit b6a4e9f3f9)
2020-06-14 23:49:04 +02:00
ariel-
444754e65a Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip
Closes #19769

(cherry picked from commit f2b0819e53)
2020-06-14 23:49:04 +02:00
treeston
250aef5186 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast.
(cherry picked from commit 1c528c30f8)
2020-06-14 23:49:04 +02:00
ariel-
f1eb73001c Core/Spell: fixed some problems with per caster aura states
- Update clients whenever target has more than one application of an aura that applies such aurastate
- Update again when one application gets removed
- Fixed Fire and Brimstone computing damage if any warlock applied the Immolate (should only count for own)

Closes #19790

(cherry picked from commit e27c385b48)
2020-06-14 23:49:04 +02:00
ariel-
6fa8b8e1d5 Core/Creature: fix _DespawnAtEvade saving wrong respawn time
Closes #19557

(cherry picked from commit 47d387d6b0)
2020-06-14 23:49:04 +02:00
ariel-
25f47e4680 Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624

(cherry picked from commit 2f19d97d21)
2020-06-14 23:49:03 +02:00
ariel-
b161447b47 Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
Closes #19514

(cherry picked from commit d9a1c82ab4)
2020-06-14 23:49:03 +02:00
Aokromes
ce1dc8b3de Fix build
(cherry picked from commit 195db7c7bb)
2020-06-14 23:49:03 +02:00
ariel-
412af93a28 Core/Player: update interaction checks, some info taken from client
(cherry picked from commit d03e97d53f)
2020-06-14 23:49:03 +02:00
ForesterDev
c34b83a467 Core/Defines: define faction templates and replace magic numbers from scripts
(cherry picked from commit abea8bf4cb)
2020-06-14 23:49:03 +02:00
ccrs
205d8bf591 Scripts/ICC: add missing cases for Dark Martyrdom difficulty entries
how come nobody noticed this?

(cherry picked from commit 7afe0b7fb0)
2020-06-14 23:49:03 +02:00
ariel-
e2bc8c5383 Core/Scripts: improvements on the Thorim script
Improvements done to initial work by joschiwald:

- Fixed stormhammer casting and visuals
- Fixed spell credits
- Implemented removal of Impale when HP is higher than 90%
- Corrected faction templates for the pre combat creatures
- Implemeted Leap on the arena adds (thanks to joschiwald for implementing conditions)
- Scripted lighting charge using AuraScript periodic
- Fixed timings
- Corrections on the hallway encounters (added knockback immunity to minibosses too)
- Fixed multiple blizzards issue
- Lever will now reset properly, should players fail to get inside. This allows the door to be opened more than once during the combat
- Corrections in the outro event
- Implemented paralytic field traps on the hallway.
- Implemented Ancient Gate of the Keepers opening.
- Changed blizzard bunny targetting to conditions entirely.
- Removed obsolete scripts
- Standards: delete spell script names by ScriptName instead of spell_id
- Swapped factions for pre-adds (alliance should get horde trash and vs)
- Fixed Leap setting home position for adds
- Removed a bunch of magic numbers
- Runic Colossus should finish current Runic Explosion before beginning to attack
- Fixed UpdateAI logic to put it in line with other scripts (ie don't stop casts)

Special thanks to:
- chaodhib for the blizzard trigger waypoints and investigation on spell radius
- Malcrom for creating the Conditions Creator :P

Closes #15008
Closes #17072

(cherry picked from commit 4a69f5bda5)
2020-06-14 23:49:01 +02:00
joschiwald
d50dccbfce Scripts/Ulduar: Initial implementation of the Thorim Encounter
Closes #7651

Fix logic fail in achievement:
SPELL_LIGHTNING_CHARGE aka 62279 is casted on Thorim itself to buff him, not the damage spell tracked by the achievement.

(cherry picked from commit 5e90c76fd4)
2020-06-14 23:46:44 +02:00
Chaouki Dhib
a7e0bd06b3 Core/Spells: Change the radius of PBAoEs following the feedback received on (#16290)
(cherry picked from commit 2ff76e828f)
2020-06-14 22:51:44 +02:00
TecDian
4015c02a42 Scripts/Events: Add missing line for "Love is in the air" boss fight (#19521)
(cherry picked from commit 4b8644d6e6)
2020-06-14 22:48:17 +02:00
Rochet2
d4a356a0ba Core/Gossip: Fix gossip bug on modify money (#19551)
(cherry picked from commit 6e3a48c873)
2020-06-14 22:47:27 +02:00
ariel-
19eeca684f Core/Unit: don't clear low health aura states on death
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening

Closes #19754

(cherry picked from commit 05b42eef7e)
2020-06-14 22:47:27 +02:00
xinef1
9e954295c5 Core/Quests: Display quest objective explore completion message
- Game client should show an on-screen message for explored quest objectives
  (AreaExploredOrEventHappens) when the objective has been completed.

Closes #19543

(cherry picked from commit 538f60a880)
2020-06-14 20:14:41 +02:00
ariel-
3698f3a262 Core/Entities: allow guardian pets to inherit spellmods
(cherry picked from commit 97e608b053)
2020-06-14 20:09:45 +02:00
Chazy Chaz
e21e7cd2e2 Scripts/Commands: Update reload commands names
(cherry picked from commit 4843544c21)
2020-06-14 20:09:40 +02:00
Chaouki Dhib
419689b485 Core/Spells: change to the way the spell effect SPELL_EFFECT_JUMP work
(cherry picked from commit d625c0f619)
2020-06-14 20:04:17 +02:00