Commit Graph

36901 Commits

Author SHA1 Message Date
Keader
5d2b37634b Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828
Ty Rizztazz

(cherry picked from commit 746a1d89b3)
2021-12-18 22:24:21 +01:00
Giacomo Pozzoni
c886e87991 Core/Misc: Fix static analysis issue
Fix static analysis issue

(cherry picked from commit ed08754663)
2021-12-18 22:24:09 +01:00
tarwyn
474d903d79 Fix inconsistent NPC aggro on spell miss (#23816)
(cherry picked from commit c8dc9fdc41)
2021-12-18 22:23:00 +01:00
Ovah
f4ae34c5c9 Core/Movement: provide an extra spline path vertex for taxi pathings … (#23817)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.

* Update FlightPathMovementGenerator.cpp

(cherry picked from commit cf3277c641)
2021-12-18 22:21:57 +01:00
Killyana
f6e176b7d7 Instance/Script: Gorkun Ironskull & Martin Victus
(cherry picked from commit 8e3862cfbd)
2021-12-18 22:21:41 +01:00
jackpoz
044cb4ff34 Core/Map: Move a log from ERROR to WARN
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive

(cherry picked from commit 42ab6010f8)
2021-12-18 22:21:01 +01:00
Killyana
01aa5a5bf3 DB/Creature: Avatar of Sathal
Closes  #23805

(cherry picked from commit acedd840fa)
2021-12-18 22:20:47 +01:00
Gildor
6c239a8612 Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810)
(cherry picked from commit a392216d20)
2021-12-18 22:19:35 +01:00
Giacomo Pozzoni
562c567b1e Core/Calendar: Add some additional validation when creating events (#23797)
* Core/Calendar: Add some additional validation when creating events

Allow only 30 player events and 100 guild events to be created.
Don't allow to create guild events if player is not in guild.
Send some more error messages to the client (not blizzlike errors but better than nothing).

* Core/Calendar: Add some additional validation/checks

Add guild id check in GetPlayerEvents().
Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past.

* Core/Calendar: Add some additional validation/checks

Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3.

* Core/Calendar: Add some additional validation/checks

Implement 5 seconds cooldown between the creation of calendar events

* Core/Calendar: Add some additional validation/checks

Don't allow to copy events of a different player/guild

* Core/Calendar: Implement automatic deletion of old events

Implement automatic deletion of events older than 1 month (30 days).
Fix debug assertion triggered when deleting a character with calendar events.
Avoid double std::set lookup when deleting events when deleting a character.

NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits.
(cherry picked from commit fb059722fd)
2021-12-18 22:19:05 +01:00
Kelno
368d99787c Core/Commands: Fixed wrong permissions for .lookup map commands (#23800)
(cherry picked from commit 6fc7ab3448)
2021-12-18 22:19:05 +01:00
jackpoz
f012d4b7fc Core/Movement: Fix LoS issue of NPCs chasing targets
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target.

Fix re-implements 8927a04253 after 2a84562dc8 partially removed it.

Fix #23724

(cherry picked from commit 215a6cee24)
2021-12-18 22:19:03 +01:00
Killyana
1e77bfe3ca DB/Creature: Fix some flags
(cherry picked from commit 537c4d1208)
2021-12-18 22:02:23 +01:00
Killyana
cde57ae80a DB/Creature: Gorkun Ironskull & Martin Victus
(cherry picked from commit c9aeff3bf9)
2021-12-18 22:01:56 +01:00
TerrorBringer
9da01d95d0 DB/Creature: O'Mally's Instrument Bunny
Closes #23790

(cherry picked from commit b6c2baf5f6)
2021-12-18 22:01:21 +01:00
Killyana
522e22dce6 DB/Creature: Vision Guide Kill Credit Trigger
Closes #23784

(cherry picked from commit e300eed3d7)
2021-12-18 21:58:29 +01:00
Killyana
3bd5167b91 DB/Quest: Forge Camp: Annihilated
Closes #23778

(cherry picked from commit 546bd0f6fb)
2021-12-18 21:58:04 +01:00
Killyana
fe874142cd DB/Conditions: Remove wrong condition related to Sal'salabim gossip text
Closes #23780

(cherry picked from commit e8ab60955d)
2021-12-18 21:56:38 +01:00
genion18
b5e6ae7e5d DB/Quest: Garments of the Moon
Closes #23777

(cherry picked from commit 5b7b8f868f)
2021-12-18 21:53:18 +01:00
genion18
afec0e2460 DB/Quest: Tainted Parchment
Closes #23776

(cherry picked from commit 56a219de20)
2021-12-18 21:52:40 +01:00
jackpoz
50df50930d Core/MovementGenerator: 680e1cbd6c follow-up
(cherry picked from commit 7c0b31b8b5)
2021-12-18 21:51:58 +01:00
Killyana
3cc7028d7a DB: Missing change in the last commit (The Ring of Blood: The Blue Brothers on quest taken text)
(cherry picked from commit 0918e7eb13)
2021-12-18 21:51:47 +01:00
Killyana
51b40b5bb3 DB/SAI: Fix Texts related to The Ring of Blood
Closes #23774

(cherry picked from commit c907ab4381)
2021-12-18 21:51:17 +01:00
illfated
b2383193b0 DB/Quest: Slaves to Saronite RewardText
Closes #23707

(cherry picked from commit e2e62aa774)
2021-12-18 21:50:43 +01:00
Killyana
8835dd2e35 DB/Creature: Torek
Closes #23742

(cherry picked from commit eb9d27660b)
2021-12-18 21:49:35 +01:00
jackpoz
2eea34fb47 Core/MovementGenerator: Fix crash in taxi paths
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground.

(cherry picked from commit 680e1cbd6c)
2021-12-18 21:47:11 +01:00
Killyana
eb83175e91 DB/Quest: Fix chaining an DB errors
(cherry picked from commit c892f867d5)
2021-12-18 21:46:58 +01:00
Gildor
cc0940fe25 Core/Misc: Fix parry-haste mechanic. (#23773)
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03e )

Closes #23754

(cherry picked from commit f8d7b26047)
2021-12-18 21:45:45 +01:00
Artamedes
4e487c35a7 Scripts/Pet: Fix npc_pet_gen_soul_trader not following owner (#23772)
(cherry picked from commit 8ecc45cd1a)
2021-12-18 21:45:25 +01:00
Artamedes
e3cb89c168 Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage (#23768)
(cherry picked from commit 88e74ac385)
2021-12-18 21:45:15 +01:00
Artamedes
a2e792f0bc Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick (#23767)
(cherry picked from commit a17c83bde8)
2021-12-18 21:45:06 +01:00
Artamedes
8fbaab7337 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos

(cherry picked from commit 876a848730)
2021-12-18 21:44:43 +01:00
Artamedes
0b43b43566 Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter

* qq

* qq 2

* tryfix circleci build

* review suggestions

(cherry picked from commit 832c95fa4f)
2021-12-18 21:41:10 +01:00
Artamedes
e4607725dd Scripts/Outland: Change auto to TempSummon* (#23764)
(cherry picked from commit 1b095811b8)
2021-12-18 21:37:15 +01:00
Artamedes
913f0903a3 Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons

* fix nopch

(cherry picked from commit 0b3a9e2a2b)
2021-12-18 21:37:02 +01:00
Artamedes
00ba5df52b Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload and the pet bar disappears (#23762)
(cherry picked from commit 6ebe1afeec)
2021-12-18 21:35:41 +01:00
jackpoz
18d1f0c964 Core/Creature: Fix another pet assert
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell

(cherry picked from commit 4074cb0f01)
2021-12-18 21:32:51 +01:00
Killyana
13dfa97d71 DB/Creature: Professor Putricide
Updates #23727

(cherry picked from commit 6e2e55bc38)
2021-12-18 21:32:08 +01:00
Treeston
0bffed380d Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727.
(cherry picked from commit 23fd193e4e)
2021-12-18 21:31:31 +01:00
AlιAѕѕaѕѕιN
e1598fa1d6 [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a6

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3

* Better commenting for 7a50189de3

* Addendum to 2d6b0545e3

(cherry picked from commit 92d83c3c2e)
2021-12-18 21:31:17 +01:00
Keader
9d3dd3db84 nopch fix
(cherry picked from commit 10f6e38185)
2021-12-18 21:18:56 +01:00
Keader
f2e03dc9e5 Core/Scripts: Proper fix Gal'Darah Puncture remove
(cherry picked from commit cbc01f35b6)
2021-12-18 21:18:44 +01:00
Keader
b7503b6c76 Fix nopch build
(cherry picked from commit 1886507e7f)
2021-12-18 21:16:51 +01:00
Keader
2d0d0a3e58 Scripts/Gundrak: Fixed Puncture when Gal'darah die
(cherry picked from commit 130a3859ec)
2021-12-18 21:16:40 +01:00
Keader
7c2665bdca Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !

(cherry picked from commit 61ad87d106)
2021-12-18 21:15:40 +01:00
Sorikoff
374db51bae Scripts/Spells: Code style adjustments for druid scripts (#23725)
(cherry picked from commit 63bbf4a4be)
2021-12-18 21:14:53 +01:00
Sorikoff
568e60ef51 Scripts/Spells: Port druid scripts to new script registration syntax (2 of 3) (#23696)
* Scripts/Spells: Port Druid Scripts to New Script Registration

* Revert

* Revert 2

* Revert 3

* Revert 4

(cherry picked from commit 9a8a01925a)
2021-12-18 21:11:58 +01:00
Shauren
a995e5fda4 Tools/Misc: Document strange array access indexing
Closes #23723

(cherry picked from commit aa0d468e04)
2021-12-18 21:00:21 +01:00
jackpoz
6989141e71 Core/Misc: Fix linux build
(cherry picked from commit c4cce31a13)
2021-12-18 20:58:07 +01:00
jackpoz
bea0e48531 Core/MMaps: Fix mobs evading when target is out of MMap meshes
Fix mobs evading when target is out of MMap meshes causes by an overzealous check added in c602220e02 when trying to fix an infinite loop in Recast.
If the target is outside of the MMap mesh (for example very close to a wall which is an un-walkable area with current TrinityCore settings and that might be changed in the future) Detour will not be able to find the height of the poly and getPolyHeight() will return DT_FAILURE | DT_INVALID_PARAM . Most of the time this is ok and can be ignored and it's still better than having the Unit evade.
Fix #23613

(cherry picked from commit 5a98022649)
2021-12-18 20:57:57 +01:00
Shauren
8f3904f8fd Core/Map: Kill zoneId from RespawnInfo, all it did was significantly slow down startup to make one gm command faster
(cherry picked from commit 3a4216fd97)
2021-12-18 20:57:38 +01:00