Commit Graph

34590 Commits

Author SHA1 Message Date
Treeston
65172db460 DB/Quest: fix Territorial Trespass SmartScript to use proper target type (tag #20310)
(cherry picked from commit 92a8f65203)
2021-06-19 23:33:38 +02:00
Treeston
6d79b329ac Core/Movement: WaypointMovementGenerator cleanup
(cherry picked from commit fe1ba18905)
2021-06-19 23:33:38 +02:00
Treeston
88c1739e3e Core/Movement: Creatures' idle movement generator can no longer override player mover control.
Tagging #20310, partial fix.

(cherry picked from commit d02f481d9a)
2021-06-19 23:33:38 +02:00
ariel-
a24af55d13 Core/Scripts: implemented Combined Toxins proc only from poisons
(cherry picked from commit 477878630e)
2021-06-19 23:33:38 +02:00
ariel-
c21dc3c1b7 Core/Auras: fix periodic ticks proc after previous commit
(cherry picked from commit 9d0e90829c)
2021-06-19 23:33:38 +02:00
ariel-
91fa279bdf Core/Spells: require phasemask set for periodic damage procflag
Closes #21379

(cherry picked from commit b42ade918a)
2021-06-19 23:33:38 +02:00
jackpoz
cb0672081e Core/Player: Add some asserts
Assert PlayerInfo for race/class pair in a few Player functions

(cherry picked from commit 3576a38f6c)
2021-06-19 23:33:38 +02:00
jackpoz
e63c5f7b0c Scripting/Obsidian Sanctum: Fix crash
Fix crash caused by calling Reset() in constructor (which is not allowed)

(cherry picked from commit 5aba5c7aff)
2021-06-19 23:33:38 +02:00
Killyana
0b5bd43f34 DB/SAI: Mire Hydra
(cherry picked from commit 201b0b3720)
2021-06-19 23:33:38 +02:00
Killyana
f2c36b8634 DB: Fix some DB errors
Ref 3acd9a7c4f

(cherry picked from commit e4817aa822)
2021-06-19 23:33:38 +02:00
jackpoz
66f7e57990 Shared/Database: Improve dead-lock error handling
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times

(cherry picked from commit 54b0b8f5ea)
2021-06-19 23:33:38 +02:00
Killyana
c72fe6a972 DB/Creature: Arcatraz Sentinel
Updates #21156

(cherry picked from commit 6952d0a5ea)
2021-06-19 23:33:37 +02:00
Treeston
e8754cbdaf Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep)
(cherry picked from commit a4fc32dd86)
2021-06-19 23:33:37 +02:00
Keader
299f22e3fc Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload
ty sirikfoll :)

(cherry picked from commit 2994abeae6)
2021-06-19 23:33:37 +02:00
Treeston
ef710273d0 Game/AI: InvalidAIException internal cleanup
(cherry picked from commit b456915f9a)
2021-06-19 23:33:34 +02:00
ariel-
3485cb38ed Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC
Thanks to killerwife for the heads-up

(cherry picked from commit 303efcf0e4)
2021-06-19 23:33:25 +02:00
Killyana
a22ffcc18a DB: Fix the previous commit
(cherry picked from commit b4c16971cb)
2021-06-19 23:33:25 +02:00
Killyana
328f6f4873 DB/Creature: Remove Tamed Sporebat spawns, summoned as pets by other npcs
(cherry picked from commit 3acd9a7c4f)
2021-06-19 23:33:25 +02:00
ZenoX92
91f1c0b89c DB/Gossip: Zorbin Fandazzle
Closes #21369

(cherry picked from commit 23dd63da98)
2021-06-19 23:33:25 +02:00
ZenoX92
4be4e542cd DB/Quest: Zapped Giants
Closes #21370

(cherry picked from commit fa1db68fec)
2021-06-19 23:33:25 +02:00
ZenoX92
b3e9cd3a14 DB/Quest: Weapons of Spirit
Closes #21371

(cherry picked from commit 58bb542e50)
2021-06-19 23:33:25 +02:00
ZenoX92
09559d51de DB/Misc: Feralas Quest Emotes (Horde)
Closes #21372

(cherry picked from commit c60eef9cda)
2021-06-19 23:33:24 +02:00
ZenoX92
61b31f657a DB/Quest: Tran'rek (breadcrumb quest)
Closes #21373

(cherry picked from commit c705b02a0c)
2021-06-19 23:33:24 +02:00
Teppic1
2bc1f0593b DB/Loot: Set up correct rare drops for Shadowfang Keep exclusive items
Closes #21382

(cherry picked from commit 65237ecea7)
2021-06-19 23:33:24 +02:00
Teppic1
014a77938d DB/Loot: Reference template 24062 corrections
Closes #21368

(cherry picked from commit 3aee76b2d6)
2021-06-19 23:33:24 +02:00
Teppic1
2d08f4ce76 DB/Loot: Dun Morogh - Coldridge Valley loot tables redone
Closes #21364

(cherry picked from commit b17a084ecd)
2021-06-19 23:33:24 +02:00
Teppic1
51a4b60353 DB/Loot: Reference template 24060 corrections
Closes #21363

(cherry picked from commit c49003ac8b)
2021-06-19 23:33:24 +02:00
Keader
9b7f3bff9f Core/Scripts: Fixed tabs issues introduced in 5bef3e426a
(cherry picked from commit 31ad6358fb)
2021-06-19 23:33:24 +02:00
Keader
ad5b0fa9cd Core/Scripts: Fixed possible crashs related with JustDied
(cherry picked from commit 5bef3e426a)
2021-06-19 23:33:24 +02:00
ariel-
4ae29e38ee Core/Scripts: fix non-functional Celestial Planetarium Access GO
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982

(cherry picked from commit b490d3f5ad)
2021-06-19 23:33:24 +02:00
sirikfoll
9573987775 Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor
Closes #20727

(cherry picked from commit cfaa4e6caf)
2021-06-19 23:33:24 +02:00
sirikfoll
e2c72cc02e Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos)
(cherry picked from commit 14b6e3bbb3)
2021-06-19 23:33:24 +02:00
ariel-
8c379e920c Core/Spells: fix logic error causing near teleports to drop combat for players
Closes #21362

(cherry picked from commit 65709e1c30)
2021-06-19 23:33:24 +02:00
ariel-
f9b14ca795 Core/Spells: fix logic error causing near teleports to drop combat for players
Closes #21362

(cherry picked from commit 65709e1c30)
2021-06-19 23:33:24 +02:00
ariel-
800d92bec3 Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells
- It is already called at Unit::DealDamage

(cherry picked from commit e979a58d17)
2021-06-19 23:33:24 +02:00
Treeston
809c38994a Core/Threat: Custom ThreatListIterator that transparently iterates over the backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation.
Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view.

(cherry picked from commit 4cb13af4fa)
2021-06-19 23:33:24 +02:00
ariel-
d34292534c Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells
Closes #20597

(cherry picked from commit 2d2c43f4b9)
2021-06-19 23:33:23 +02:00
ariel-
01d9306854 Core/Spells: kill unused parameter from Spell constructor
Added in 1f2292af79

(cherry picked from commit 9fc732eb97)
2021-06-19 23:33:23 +02:00
Killyana
a1e0f3bbf7 DB/Loot: Fix fishing loots for some areas
Closes #11251

(cherry picked from commit c7476f335f)
2021-06-19 23:33:23 +02:00
jackpoz
b9159407e0 Core/AI: Fix assertion triggered with PetAI derived scripts (#21254)
* Core/AI: Fix assertion triggered with PetAI derived scripts

Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.

(cherry picked from commit 95a76a83fc)
2021-06-19 23:33:21 +02:00
Treeston
d7542dc3e8 Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version.
Closes #21265.

(cherry picked from commit b3e0c89238)
2021-06-19 01:57:55 +02:00
Treeston
7695784fd2 AI/SmartAI: Remove a silly incorrect piece of code that was breaking react state swaps on SAI creatures. Fixes #21353.
(cherry picked from commit 6e0df9fce1)
2021-06-19 01:55:18 +02:00
Treeston
a8307e60a3 Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn.
Closes #21286.

(cherry picked from commit aefc25482f)
2021-06-19 01:35:41 +02:00
sirikfoll
bd7fbce592 Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King)
Movement was being prevented by spell cast

(cherry picked from commit a217c0be92)
2021-06-19 01:35:41 +02:00
Killyana
7987afc0e8 DB/Misc: Death knights area rework part 9
Original work done by Grz3s on Cmangos

(cherry picked from commit 5376aa3483)
2021-06-19 01:35:41 +02:00
Killyana
854abdbfb6 Spell/Script: Torch 52953 and 58121 must hit only one target
(cherry picked from commit 8f71307e56)
2021-06-19 01:35:41 +02:00
Treeston
95fb6fe075 Core/Creature: Adjust SelectVictim behavior: (PR #21324)
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits.
- Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished.

(cherry picked from commit 1acfefb973)
2021-06-19 01:35:41 +02:00
Treeston
39dff738e1 Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. (PR #19818)
(cherry picked from commit 03ef79f3d9)
2021-06-19 01:35:41 +02:00
Treeston
f5ecb30413 DB/Spell: Un-Rubik's-cubed Poisoned Spear (for Ymirheim Defender)
(cherry picked from commit bd3e624fca)
2021-06-19 01:35:41 +02:00
Treeston
fdc1c5b6c9 Combat/Threat: Now set engaged state for all units on offline reference registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade.
This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you.

(cherry picked from commit 2402406228)
2021-06-19 01:35:40 +02:00