sanctum32
6ffb02e277
Core/SAI: Improve SMART_ACTION_ATTACK_START to exclude non-unit targets from selection pool ( #30653 )
...
(cherry picked from commit 444a98111a )
2025-02-01 05:36:40 +01:00
Shauren
9f084cd749
Core/Spells: Refactor SpellHistory ModifyCoooldowns and ResetCooldowns callbacks to use CooldownEntry argument instead of internal iterator
...
(cherry picked from commit ace6342aea )
# Conflicts:
# src/server/scripts/Spells/spell_dh.cpp
2025-02-01 05:36:35 +01:00
Shauren
1547fd0d8a
Core/Auras: Fixed SPELL_ATTR1_IMMUNITY_TO_HOSTILE_AND_FRIENDLY_EFFECTS logic - no longer incorrectly unapplies all auras for immunities that don't use it
...
(cherry picked from commit 107ca37c68 )
2025-02-01 05:36:20 +01:00
Shauren
176d1e73e8
Core/Spells: Don't fail spells SPELL_ATTR2_FAIL_ON_ALL_TARGETS_IMMUNE when target list is empty for one effect
...
Closes #30603
(cherry picked from commit a5c547a383 )
2025-02-01 05:36:16 +01:00
Shauren
7848d0bf8d
Core/Conditions: Corrected upper array bound requirement for PlayerConditionLogic
...
(cherry picked from commit 38096181eb )
2025-02-01 05:36:10 +01:00
Ovahlord
977452c74b
Scripts/Spells: fixed Seal of Insight
2025-01-26 16:44:36 +01:00
Ovahlord
59c61f7c15
Scripts/Spells: fixed Judgement of Truth damage bonus
2025-01-26 15:56:28 +01:00
Shauren
3eb4ccc9a0
Core/Items: Fixed item spell charge slot indexing
...
Closes #30585
(cherry picked from commit c85d12fc3f )
# Conflicts:
# src/server/game/Entities/Item/Item.h
# src/server/game/Globals/ObjectMgr.cpp
2025-01-26 12:59:30 +01:00
Shauren
b61960c1a9
Core/Spells: Prevent even more cases of sending aura update packets for auras that aren't visible on client
...
(cherry picked from commit 380b1f8986 )
2025-01-26 12:48:43 +01:00
Shauren
7fc1eb1054
Core/Objects: Removed type casts before accessing WorldObject::m_Events that became unneccessary after moving it from Unit to WorldObject
...
(cherry picked from commit bc8874f305 )
2025-01-26 12:48:37 +01:00
Shauren
32f4c360ac
Core/Spells: Prevent sending aura update packets for auras that aren't visible on client
...
Closes #30633
(cherry picked from commit e9470cd817 )
2025-01-26 12:47:52 +01:00
Ovahlord
5327688c26
Core/Spells: added missing AttributesEx15 member to SpellInfo
2025-01-26 12:47:25 +01:00
Meji
b54d93c7a9
Core/Spells: Added AttributesEx15 for serverside spells ( #30632 )
...
(cherry picked from commit c9456ce826 )
# Conflicts:
# sql/updates/world/cata_classic/2025_01_23_00_world.sql
# src/server/game/Spells/SpellMgr.cpp
2025-01-26 12:31:34 +01:00
Ovahlord
e9105be6d8
Scripts/Spells: fixed Seal of Truth
2025-01-26 12:15:14 +01:00
Ovahlord
a777f6768e
Scripts/Spells: round the damage values of Seal of Righteousness and Seal of Justice to match expected numbers and to prevent low level players from dealing no damage
2025-01-26 11:43:18 +01:00
Ovahlord
ccf00f50d4
Scripts/Spells: fixed Seal of Justice
2025-01-26 11:33:31 +01:00
Ovahlord
42740ba740
Scripts/Spells: fixed Judgement
2025-01-26 10:55:38 +01:00
Ovahlord
55992fe247
Core/Auras: apply AURA_STATE_MARKED for Paladin Seals
2025-01-25 11:45:03 +01:00
Ovahlord
3ec0ba7c83
Scripts/Spells: fixed Seal of Righteousness
2025-01-25 11:27:37 +01:00
Shauren
a1962dc319
Core/Spells: Reimplemented target type 106 as random point from points predefined in database
...
Closes #30116
(cherry picked from commit 2a51a64549 )
# Conflicts:
# sql/updates/world/cata_classic/2025_01_21_00_world.sql
2025-01-21 18:30:23 +01:00
Shauren
1c04f09609
Scripts/Spells: Use Spell::GetPowerTypeCostAmount where possible instead of iterating Spell::GetPowerCost
...
(cherry picked from commit 26376d89e1 )
# Conflicts:
# src/server/scripts/Spells/spell_druid.cpp
# src/server/scripts/Spells/spell_rogue.cpp
# src/server/scripts/Spells/spell_shaman.cpp
2025-01-21 18:28:54 +01:00
Shauren
d36d2e1fcc
Core/Spells: Replace SpellTargetPosition structure with WorldLocation
...
(cherry picked from commit 0e36fd9360 )
2025-01-20 20:46:27 +01:00
Shauren
562e2a616c
Core/Spells: Exclude TriggerCastFlags that can be set for non-triggered spells from being checked by Spell::IsTriggered
...
(cherry picked from commit 56fb627c7d )
2025-01-20 20:46:23 +01:00
Shauren
54d6486034
Core/Misc: Added float chrono typedefs
...
(cherry picked from commit cb4013efe6 )
# Conflicts:
# src/server/scripts/Spells/spell_dh.cpp
# src/server/scripts/Spells/spell_evoker.cpp
2025-01-20 20:46:17 +01:00
Shauren
f156cbf593
Core/Spells: Add summoned DynamicObject to casters ChannelObjects if spell is channelled
2025-01-18 00:09:10 +01:00
Shauren
a49dd60755
Core/Misc: Remove return type std::enable_if based SFINAE
2025-01-18 00:09:00 +01:00
Shauren
3fc2699a4f
Core/Misc: Remove unneccessary structure packing and one unused enum
2025-01-18 00:08:50 +01:00
Shauren
226b430fab
Core/Spells: Fixed SPELL_AURA_IGNORE_SPELL_COOLDOWN - don't start cooldown for affected spells
2025-01-18 00:08:40 +01:00
Shauren
f02d30be65
Core/Spells: DynamicObject auras will now use the largest radius found in SPELL_EFFECT_PERSISTENT_AREA_AURA effects of the spell creating them
...
(cherry picked from commit 4bec94451f )
(cherry picked from commit 497cb7df49 )
2025-01-13 19:31:20 +01:00
CraftedRO
7aac50c888
Core/Spells: Allow persistent area auras to apply all of their effects upon creation. ( #30422 )
...
This fixes the issue where the area auras do not instantly apply their effects.
Actually, they were only applying the last SPELL_EFFECT_PERSISTENT_AREA_AURA;
Flare and Frost Trap have 2 and 3 SPELL_EFFECT_PERSISTENT_AREA_AURA effects respectively, so only the last one would be applied.
Co-Authored-By: zana244 <50482785+zana244@users.noreply.github.com >
(cherry picked from commit b6bb35bb9a )
(cherry picked from commit d8636d4cc6 )
2025-01-13 19:31:15 +01:00
Ovahlord
7d5e794fd3
Core/Spells: send rune cooldowns even after miss to match sniff data
2025-01-12 18:52:20 +01:00
Ovahlord
dbe2f1ee7e
Core/Spells: corrected refunding runes - they don't get put on a cooldown and don't send cooldowns for spells which had their runes refunded
2025-01-12 01:29:04 +01:00
Shauren
b195f45635
Core/Spells: Don't grant runic power when death knight abilities that do it using negative power cost miss and the spell has SPELL_ATTR1_DISCOUNT_POWER_ON_MISS
...
(cherry picked from commit 76ab2007c0 )
2025-01-12 01:13:21 +01:00
Ovahlord
efb8ccc079
Core/Spells: reduce differences between branches
...
(cherry picked from commit 9b385282df40eef9370ae21e52a1b11e45bf9ab9)
2025-01-12 01:12:53 +01:00
Ovahlord
e2c011fbd4
Scripts/Spells: increased precision when calculating Howling Blast's attack power bonus to match tooltip values
2025-01-11 20:44:33 +01:00
Ovahlord
c1d8e30015
Scripts/Spells: fixed Howling Blast damage calculation
2025-01-11 20:36:09 +01:00
Ovahlord
7f29956937
Core/Spells: fixed power check for runes when casting spells - these have their own check and don't require the default one
2025-01-11 20:26:03 +01:00
Ovahlord
5564f95a21
Core/Spells: removed non-existing SpellCastVisual UF operator leftover from downgrading to Cataclysm
2025-01-11 19:29:44 +01:00
Shauren
4254434c1c
Core/Spells: Fixed crashes with spells using SPELL_EFFECT_ENCHANT_ITEM/SPELL_EFFECT_ENCHANT_ITEM_PRISMATIC that are not cast by an item
...
Closes #28664
(cherry picked from commit 1e3b8d1721 )
2025-01-11 00:40:51 +01:00
Shauren
45b60b5115
Core/Units: Fill CurrentAreaID updatefield
...
(cherry picked from commit d38941c19b )
2025-01-10 22:49:53 +01:00
ModoX
c702346ac6
Core/Conditions: Allow conditions for seen object in CONDITION_SOURCE_TYPE_OBJECT_ID_VISIBILITY
...
(cherry picked from commit 6e3c8a8463 )
2025-01-10 22:47:50 +01:00
Shauren
2693d73383
Core/AreaTriggers: Replace fixed movement times in database for areatriggers with speed
...
(cherry picked from commit 069771e22e )
# Conflicts:
# sql/updates/world/cata_classic/2025_01_10_00_world.sql
# src/server/game/Entities/AreaTrigger/AreaTrigger.cpp
# src/server/scripts/BrokenIsles/MawOfSouls/boss_ymiron_the_fallen_king.cpp
# src/server/scripts/Shadowlands/SepulcherOfTheFirstOnes/boss_anduin_wrynn.cpp
# src/server/scripts/Spells/spell_priest.cpp
# src/server/scripts/World/areatrigger_scripts.cpp
2025-01-10 22:47:14 +01:00
Shauren
aadaf748fa
Core/Auras: Use UnitListSearcher instead of WorldObjectListSearcher when searching for area aura targets
...
(cherry picked from commit 84b0eca447 )
2025-01-09 23:55:35 +01:00
Shauren
b6b985a822
Core/Spells: Replace MAX_SPELL_EFFECTS loop limits with correct upper bound depending on how many effects the spell has
...
(cherry picked from commit 561b122364 )
# Conflicts:
# src/server/game/Spells/Spell.cpp
2025-01-09 20:56:16 +01:00
Shauren
9e26bf6a7f
Core/Auras: Make iteration over Aura::GetAuraEffects safe by automatically skipping nullptr elements
...
(cherry picked from commit 97f58a59f1 )
# Conflicts:
# src/server/game/Entities/Player/Player.cpp
2025-01-09 20:55:14 +01:00
Shauren
08eb6312f2
Core/Auras: Fixed sending amounts for effects that need it, aren't first and don't have SPELL_ATTR8_AURA_POINTS_ON_CLIENT
...
(cherry picked from commit 0a1b81043e )
2025-01-09 20:54:38 +01:00
Shauren
e3ecbbd1b5
Core/DataStores: Delay building all DB2Manager containers after loading hotfix data to ignore rows marked as deleted by hotfixes
...
(cherry picked from commit da1ac5aa73 )
# Conflicts:
# src/server/game/DataStores/DB2Stores.cpp
2025-01-09 20:54:33 +01:00
Shauren
efeb9add00
Core/AreaTriggers: Don't suppress TimeToTarget changes in values update on movement start
...
(cherry picked from commit debbed0159 )
# Conflicts:
# src/server/scripts/Shadowlands/SepulcherOfTheFirstOnes/boss_anduin_wrynn.cpp
2025-01-09 20:53:53 +01:00
Shauren
43c1a47c3d
Fix nopch build
...
(cherry picked from commit 3eac7242d1 )
2025-01-09 20:53:42 +01:00
Shauren
904d8aa040
Core/Misc: Removed GetClassName preprocessor hack
...
(cherry picked from commit 6f0e96a30a )
2025-01-09 20:53:38 +01:00