Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-21 09:44:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
32,811 Commits 4 Branches 146 Tags
75fa2f5eab9d9042f6702843ca94c217997fc42b
Commit Graph

24359 Commits

Author SHA1 Message Date
Gustavo
53f79acda9 Core/Battlegrounds: disable health regen for battleground vehicles (#19183) 
Updates issue #950

(cherry picked from commit 85af0a0630)
 2020-04-24 17:18:51 +02:00
tkrokli
b259614778 Scripts: minimize duplicated enum names in header files (#19377) 
* Scripts: Minimize duplicated enum names in header files

This reduces the number of cache resets with the Zapcc compiler

- Standard followed is instance/raid TLA + DataTypes/CreaturesIds/etc
- Partial cherry-pick of master commit 7eb4512eee
- Removed unused defines in sunken_temple.h (the core scripts using these have been moved to SAI)

(cherry picked from commit f6f36be004)
 2020-04-24 17:18:51 +02:00
ariel-
cbcc4601ad Core/AI: Build fix 
- Stop exposing DoublePosition constructor versions, they're only used for internal representation
- Moved IsInBounds function to public scope

(cherry picked from commit 83162fafa4)
 2020-04-24 17:18:51 +02:00
ariel-
3f79c9f696 Core/AI: AreaBoundary refactor 
- Added an auxiliary function IsInBounds to base CreatureAI
- Changed container to vector. Set had no sense because we're storing new pointers, they have different addresses even if the boundary is the same

(cherry picked from commit 2f99fa09c9)
 2020-04-24 17:18:51 +02:00
ariel-
ea0bb7c65e Core/Creature: added CREATURE_FLAG_EXTRA_GHOST_VISIBILITY to allowed db flags_extra mask 
- Cleaned up the mask to be a much nicer enum definition

(cherry picked from commit 66a70088f4)
 2020-04-24 17:18:51 +02:00
ariel-
4ec50b35ea Core/Global: reserve storage for script names vector 
(cherry picked from commit c8bf1ab5f7)
 2020-04-24 17:18:50 +02:00
xinef1
70d5775d3f Added new creature extra flag which makes npc visible only to dead units 
closes #19333

* Rename 9999_99_99_99_world.sql to 2017_99_99_99_world_335.sql

- file affects creature removed in patch 4.0.3a

* Update Creature.cpp

(cherry picked from commit e72b380b93)
 2020-04-24 17:18:50 +02:00
ariel-
5348db2200 Core/Gameobject: remove virtual from GetScriptId, it's not overriden 
(cherry picked from commit 00b547146d)
 2020-04-24 17:18:50 +02:00
tkrokli
a0feff65be Game/AI: SMART_ACTION_JUMP_TO_POS should resume path when reached jump location (#19029) 
SmartAI NPCs using SMART_ACTION_JUMP_TO_POS
should resume their path when they have reached the jump location.

The changes in this PR makes the action work as intended.

Closes #18760

(cherry picked from commit 6e08051825)
 2020-04-24 17:18:50 +02:00
ariel-
da12320937 Core/Auras: fix a deleted memory access crash 
Closes #19319

(cherry picked from commit 01aaafb083)
 2020-04-24 17:18:50 +02:00
ccrs
953cdbf205 Fix warning 
field '_top' will be initialized after field '_owner'

(cherry picked from commit 2b5c765bcd)
 2020-04-24 17:18:50 +02:00
ccrs
f135b7aea1 Core/Movement: 96f4c7c followup 
(cherry picked from commit 9be7f5f57b)
 2020-04-24 17:18:50 +02:00
ccrs
b2d1b11326 Core/MotionMaster: cleanup use of _expireList 
And restore broken _cleanFlag check/use on update (eca3645d8b)

(cherry picked from commit 96f4c7c187)
 2020-04-24 17:18:50 +02:00
ccrs
1f0dc07ef1 Core/Unit: cleanup UnitState enum 
(cherry picked from commit bf56049f2f)
 2020-04-24 17:18:50 +02:00
ccrs
dbe54973fb Core/Movement: cleanup MovementGeneratorType 
(cherry picked from commit fce974c3b3)
 2020-04-24 17:18:49 +02:00
Gustavo
6f523b4fb6 Core/Scripts: minor fixes in boss_the_lich_king (#19311) 
Closes #4427
Closes #7091

(cherry picked from commit 2792046dc7)
 2020-04-24 17:18:49 +02:00
ariel-
7a561ad045 Core/Scripts: Updated Ulduar instance model 
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)

(cherry picked from commit b74cc80859)
 2020-04-24 17:18:49 +02:00
Chaouki Dhib
5d076cfe29 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290) 
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c14)
 2020-04-24 17:18:49 +02:00
S.V
b8b6fd9ca0 Core/Creatures: Fixed GMs being considered in party/raid with nearby creatures without CREATURE_TYPE_FLAG_TREAT_AS_RAID_UNIT 
Ref #19340

(cherry picked from commit eea16ce356)
 2020-04-24 17:18:49 +02:00
Keader
b234658617 Core/Scripts: Fixed wrong calculation of Aura of Desire 
Closes #19322

(cherry picked from commit 333a403409)
 2020-04-24 17:18:49 +02:00
xinef1
ca4720662d Core/Items: Fixed durability problems for wrapped item (#19003) 
(cherry picked from commit 81d011170d)
 2020-04-24 17:18:49 +02:00
ariel-
e44d0c8873 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle 
Closes #17234

(cherry picked from commit 4096b02a56)
 2020-04-24 17:18:49 +02:00
ariel-
786bb561ca Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts 
Closes #19334

(cherry picked from commit 9cfa7c752e)
 2020-04-24 17:18:49 +02:00
ariel-
848f0d1323 Core/Entities: don't finalize movesplines before deleting. 
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324

(cherry picked from commit b53d0530cd)
 2020-04-24 17:18:49 +02:00
robinsch
8874a3ac5d Core/Social: Implement FRIEND_STATUS_RAF (#19317) 
(cherry picked from commit d209aaa00f)
 2020-04-24 17:18:49 +02:00
Golrag
b8c8dcdbfc Core/Object: Fix Line of Sight issue with object edges 
Fixes: https://github.com/TrinityCore/TrinityCore/pull/15807#issuecomment-268077802
(cherry picked from commit 020a6b984d)
 2020-04-24 17:18:48 +02:00
jackpoz
bfcb276781 Core/Crash: Refactor and fixes 
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e21205)
 2020-04-24 17:18:48 +02:00
ariel-
6098c4549c Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules 
Ref #19319

(cherry picked from commit 36bb4cabae)
 2020-04-24 17:18:48 +02:00
ariel-
053d0cfda5 Core/Pet: load template immunities when creating (except for hunters) 
Fixes #19275

(cherry picked from commit e33263c677)
 2020-04-24 17:18:48 +02:00
ariel-
c16cebca64 Core/Unit: properly reset displayIds when having a shapeshift aura active 
Closes #19309

(cherry picked from commit 7a38eaa5a1)
 2020-04-24 17:18:48 +02:00
ariel-
1536f01a74 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId. 
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300

(cherry picked from commit 3b27a06265)
 2020-04-24 17:18:48 +02:00
ariel-
c03373c59f Core/Quests: changed quest_template_addon.NextQuestID to unsigned 
- No reason to keep this anymore after 4349adf0f2, this is a broken functionality.

(cherry picked from commit dca276716f)
 2020-04-24 17:18:48 +02:00
ariel-
feb8205d6a Core/Globals: some changes in quest loading 
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups

(cherry picked from commit 076293f1f2)
 2020-04-24 17:18:48 +02:00
ariel-
4472a3cbf3 Core/Globals: Fix Quest codestyle and member variable initialization 
(cherry picked from commit 09701b0229)
 2020-04-24 17:18:48 +02:00
ariel-
a098b454b8 Core/Entities: virtualize CheckAttackFitToAuraRequirement 
- Should've been like this to begin with

(cherry picked from commit 21d95a1d76)
 2020-04-24 17:18:47 +02:00
ariel-
5979f4f396 Core/Auras: fix more unused parameter warnings 
(cherry picked from commit 7de5befbc3)
 2020-04-24 17:18:47 +02:00
ariel-
1c4b1ba498 Core/Auras: fix comparison of integers of different signs warning 
(cherry picked from commit 9047d8bd6f)
 2020-04-24 17:18:47 +02:00
ariel-
e39ea201ce Core/Auras: fix unused parameter warning 
(cherry picked from commit 40489b8d57)
 2020-04-24 17:18:47 +02:00
ariel-
ebc06b1d04 Core/Auras: reworked multiplicative AuraEffects calculation 
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687

(cherry picked from commit c69a7d1223)
 2020-04-24 17:18:47 +02:00
ariel-
73ea9ecec1 Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h 
(cherry picked from commit 6d991e9361)
 2020-04-24 17:18:47 +02:00
ariel-
cdbe16fabe Core/Scripts: implemented Gnomish Harm Prevention Belt 
Updates #18542

(cherry picked from commit 2db3e86d9b)
 2020-04-24 17:18:47 +02:00
Keader
f3d946cee9 Core/Spell: Fixed Val'kyr Target Search exploit 
Closes #16347
by ariel-

(cherry picked from commit 28b955bd25)
 2020-04-24 17:18:46 +02:00
Shauren
bbfbb7d4bf Core/PacketIO: Implement building SMSG_UPDATE_OBJECT only for selected fields and use that to fix quest objects not glowing after accepting quests 2020-04-23 20:22:53 +02:00
Shauren
fb0a29131d Core/AuctionHouse: Add separate auction house throttle period for requests from auction house addons tainting default ui 2020-04-23 14:03:17 +02:00
Shauren
fea5cb4525 Core/PacketIO: Fixed WorldPackets::Addon::AddOnInfo structure 2020-04-22 23:59:20 +02:00
Shauren
aced88b09b Core/AuctionHouse: After taking a break at the start of patch 8.3 auction house is now back in business. 2020-04-20 20:36:24 +02:00
Shauren
7ef9acd765 Warning fix 2020-04-19 11:59:37 +02:00
Shauren
b702401978 Core/Items: Check required level to use items including any bonuses that modify it 2020-04-19 01:18:17 +02:00
Shauren
ecdf3d1a14 Core/Items: Add helper function to get item name including suffix 2020-04-18 10:59:35 +02:00
Shauren
d7524928e5 Core/Mail: Updated mailbox limit to 8.3 value 2020-04-17 17:36:24 +02:00