Gildor
81154a7455
Core/Spells: Check a few aura effects for determining if should be negative ( #25004 )
...
(cherry picked from commit 5e1571062a )
2022-01-23 15:20:09 +01:00
Shauren
b6a3774a38
Warning fix
2022-01-23 15:18:10 +01:00
Giacomo Pozzoni
e9cf3828ba
Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. ( #23 ) ( #24997 )
...
* Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23 )
Original research by @xvwyh.
* Add missing sql update
* Fix some build errors
* Remove unused enum values
* Change artkits from 0-4 to 0-3
* Remove unused code
* Code review feedback
* Fix sql
* Remove artkit4 special case handling
* Default initialize artKits
* Code review feedback
* Split sql into structure and data files
Co-authored-by: Warpten <vertozor@gmail.com >
(cherry picked from commit 203573db83 )
2022-01-23 15:17:54 +01:00
Shauren
a55801e35e
Correct g3d patch naming conflicts with 3.3.5 branch
2022-01-23 00:34:44 +01:00
Shauren
aed8e1c3b4
Fixed -Wdeprecated-copy warning in G3D
...
(cherry picked from commit a650bd631a )
2022-01-23 00:19:57 +01:00
Shauren
d4568a90b1
Fix warnings related to Vector3::operator= and remove -Wno-deprecated-copy suppression
...
(cherry picked from commit 042b1abfd7 )
2022-01-23 00:18:39 +01:00
Peter Keresztes Schmidt
365ae6ff25
Fix some compiler warnings reported by GCC ( #25007 )
...
* Core/AI: Remove unneeded null checks
GetMap() can never return NULL.
Fixes additionally -Wunused-variable warnings
reported by GCC.
* Core/GameObject: Fix a -Wunused-variable warning reported by GCC
* Core/Player: Fix a -Wunused-variable warning reported by GCC
* Scritps/CavernsOfTime: Fix -Wimplicit-fallthrough warnings reported by GCC
* Scritps/CavernsOfTime: Fix a -Wmaybe-uninitialized warning reported by GCC
Warning:
/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp: In member function ‘virtual void npc_arthas_stratholme::npc_arthas_stratholmeAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:1119:58: warning: ‘emote’ may be used uninitialized in this function [-Wmaybe-uninitialized]
1119 | (*it)->HandleEmoteCommand(emote);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
* Scritps/PitOfSaron: Fix -Wunused-variable warnings reported by GCC
* Scritps/EyeOfEternity: Fix a -Wclass-memaccess warning reported by GCC
Warning:
/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp: In member function ‘virtual void boss_malygos::boss_malygosAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp:950:81: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
950 | memset(_surgeTargetGUID, 0, sizeof(_surgeTargetGUID));
|
* Scritps/CoilfangReservoir: Fix a -Wclass-memaccess warning reported by GCC
Warning:
/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp: In member function ‘void boss_leotheras_the_blind::boss_leotheras_the_blindAI::Initialize()’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp:220:55: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
220 | memset(InnderDemon, 0, sizeof(InnderDemon));
| ^
* Scritps/Naxx: Fix a -Wimplicit-fallthrough warning reported by GCC
For discussion see https://github.com/TrinityCore/TrinityCore/pull/25007
(cherry picked from commit 10be49bdfe )
2022-01-23 00:16:31 +01:00
Peter Keresztes Schmidt
1e1679a1f7
Core/DataStores: Port refactors from Update DBC field names to generated ones ( #24999 )
...
(cherry picked from commit c92950b3e1 )
2022-01-23 00:06:16 +01:00
Max Drosdo.www
b7353fb927
Core/Player: Introduce separate level caps for each expansion ( #24989 )
...
(cherry picked from commit 3529442668 )
2022-01-22 16:00:49 +01:00
Aqua Deus
0bbdfc6112
Scripts/Spells: Move spell_anchor_here to generic because is used by more than one boss ( #27641 )
2022-01-22 14:52:05 +01:00
Aqua Deus
c2dd07aa32
Core/Auras: Named new proc flags ( #27655 )
2022-01-22 14:49:53 +01:00
Shauren
d32dd913fd
Core/Units: Fixed typo in unit flag name
2022-01-22 14:45:03 +01:00
Shauren
b4952db464
Core/Units: Named unit flags linked to CreatureDifficulty flags
2022-01-22 13:21:15 +01:00
Teleqraph
2fd4ce9fb9
Core/Units: Named UNIT_FLAG2_UNTARGETABLE_BY_CLIENT and renamed CREATURE_DIFFICULTYFLAGS_5_CANNOT_SWITCH_TARGETS to CREATURE_DIFFICULTYFLAGS_5_UNTARGETABLE_BY_CLIENT ( #27637 )
2022-01-22 12:22:55 +01:00
Shauren
e8368ed2eb
Core: Updated allowed build to 9.1.5.42010
2022-01-22 01:40:57 +01:00
offl
e62588b238
DB/Creature: Remove flee actions from civilians & texts related to civilians
...
Closes #24979
(cherry picked from commit 92efefabc8 )
2022-01-22 01:22:22 +01:00
offl
b0ae542a73
DB/Creature: Standardize creature respawn time part 7
...
Closes #24978
(cherry picked from commit 1943f7fc07 )
2022-01-22 01:21:52 +01:00
offl
a77ce94667
DB: Restore incorrectly removed spawn_group data
...
Closes #24977
(cherry picked from commit 6c806490d3 )
2022-01-22 01:21:16 +01:00
Eridium
a4ed8806b7
Creature/Script: npc_blackfathom_deeps_event ( #24969 )
...
* Creature/Script: npc_blackfathom_deeps_event
* Update blackfathom_deeps.cpp
* Update blackfathom_deeps.h
* codestyle
* Update blackfathom_deeps.cpp
Co-authored-by: Killyana <Killyana@users.noreply.github.com >
Co-authored-by: Ovah <dreadkiller@gmx.de >
(cherry picked from commit 98c37b15e0 )
2022-01-22 01:20:23 +01:00
Shauren
6ce56e8137
Core/DBLayer: Fixed false positive msvc analysis warning
2022-01-22 01:11:16 +01:00
jackpoz
ff778a7581
Core/Creature: Add null check for charmed creatures
...
(cherry picked from commit b4adaa838c )
2022-01-22 00:50:40 +01:00
ZenoX92
120c9f3f74
DB/Quest: The Divination
...
Closes #24975
(cherry picked from commit 293fd67fac )
2022-01-22 00:50:26 +01:00
ZenoX92
04ad583541
DB/Creature: Warmaul Chef Bufferlo
...
Closes #24974
(cherry picked from commit b54d389cf1 )
2022-01-22 00:36:28 +01:00
Ovah
c7cf9f8c6c
Core/Spells: Expose corpseTarget to spell scripts with SpellScript::GetHitCorpse() ( #24981 )
...
Closes #24945
(cherry picked from commit 94a4404e7e )
2022-01-22 00:34:38 +01:00
akrom23
77d76ecc1d
Creature/AI: Remove SetVisible from SmartAI::InitializeAI
...
Closes #24184
(cherry picked from commit f99a79cb43 )
2022-01-22 00:34:25 +01:00
Shauren
0ac5b1da8c
Core/Spells: Don't select corpses for spell targets that expect to hit units
...
Closes #24980
(cherry picked from commit 14db2215d3 )
2022-01-22 00:33:53 +01:00
Ovah
508ea9e3c7
Scripts/ICC: fixed a crash in the Lich King encounter caused by invalid corpse targets
...
(cherry picked from commit 232628f0a6 )
2022-01-22 00:33:12 +01:00
ZenoX92
49a6394b68
DB/Item: Diabolical Plans & Flayed Demon Skin
...
Closes #24971
(cherry picked from commit c1eb1c41f8 )
2022-01-22 00:32:58 +01:00
offl
a1de9b0beb
DB/Creature: Adjust some rare creatures respawn time
...
Closes #24970
(cherry picked from commit e472ef0237 )
2022-01-22 00:32:22 +01:00
offl
b0bac6cc59
DB/Creature: Make Xi'ri & Brutallus invincible
...
Closes #24967
(cherry picked from commit 3660e272d4 )
2022-01-22 00:29:48 +01:00
offl
5576d47116
DB/Creature: Standardize creature respawn time, remove wrong spawns part 6
...
Closes #24966
(cherry picked from commit 1cc16afc4f )
2022-01-22 00:29:18 +01:00
Killyana
d5163bc5c0
DB/Creature: Argent Skytalon
...
Closes #24963
(cherry picked from commit 95dd021f08 )
2022-01-22 00:20:22 +01:00
ZenoX92
e7df6f74e5
DB/Quest: Quest Emotes (Azuremyst Isle)
...
Closes #24953
(cherry picked from commit d5466ae563 )
2022-01-22 00:19:42 +01:00
ZenoX92
4f1f6a2364
DB/Texts: Antonio Perelli
...
Closes #24951
(cherry picked from commit 88f9b8634f )
2022-01-22 00:14:10 +01:00
ZenoX92
9ad979fe6f
DB/Quest: Gizmo for Warug
...
Closes #24950
(cherry picked from commit eb5bd6af8c )
2022-01-21 23:59:17 +01:00
offl
481f68f058
DB: Add broadcast texts to some creature texts
...
Closes #24948
(cherry picked from commit c73238ec3b )
2022-01-21 23:58:42 +01:00
offl
82f912aeb3
DB/Creature: Add gossip options to retrieve Brood of Nozdormu rings and script Anachronos' combat part
...
Closes #24944
(cherry picked from commit da62d78731 )
2022-01-21 23:55:09 +01:00
offl
2a474a01a5
DB/Creature: Warmaster Laggrond & Lieutenant Haggerdin: Options to restore Frostwolf / Stormpike Insignia
...
Closes #24943
(cherry picked from commit 4c25aeaa23 )
2022-01-21 23:06:13 +01:00
offl
937fa2555f
DB/Creature: Smith Regzar & Murgot Deepforge
...
Closes #24942
(cherry picked from commit 169ee64502 )
2022-01-21 22:51:49 +01:00
offl
086693a612
DB/Creature: Make Steven Thomas & Arcanist Myndimendez & Roitau invincible
...
Closes #24939
(cherry picked from commit d1e26da320 )
2022-01-21 22:50:33 +01:00
offl
750b7a7943
DB/SAI: Update some scripts using CMC cast flag
...
Closes #24937
(cherry picked from commit c3f682c8e5 )
2022-01-21 22:44:05 +01:00
offl
e5b1c642d1
DB/Creature: Standardize creature respawn time, remove wrong spawns part 5
...
Closes #24936
(cherry picked from commit 4975590824 )
2022-01-21 22:38:11 +01:00
offl
3f48824d73
DB: Add missing comments to creature_summon_groups
...
Closes #24935
(cherry picked from commit 868797035b )
2022-01-21 22:26:36 +01:00
offl
01700f611e
DB/Creature: Update recently converted escort quests to prevent reactstate override
...
Closes #24934
(cherry picked from commit 1c7e100b43 )
2022-01-21 22:25:36 +01:00
offl
fb6a72aa2d
DB/Quest: Convert & update support for 'Khu'nok Will Know' to SAI
...
Closes #24933
(cherry picked from commit c6811d3e4e )
2022-01-21 22:21:43 +01:00
offl
afc36f6079
DB: Add Comment column to spell_scripts, event_scripts and waypoint_scripts
...
Closes #24932
(cherry picked from commit a2bf8693eb )
2022-01-21 22:21:06 +01:00
offl
5f99e3eb5a
DB/Creature: Enable Thomas Booker's movement & formation and remove useless dist and angle from some formations
...
Closes #24926
(cherry picked from commit 79c269c161 )
2022-01-21 22:20:32 +01:00
Shauren
a0e5f9db7e
Core/Misc: Fixed engrish in static_assert for EnumFlag and restrict DEFINE_ENUM_FLAG to enums only (with std::is_enum)
2022-01-21 22:19:57 +01:00
Ovahlord
7a5529eb58
Core/Events: refactored battleground holiday assignments.
...
Instead of going with shitty bitmasks we now accept plain battleground ids
instead
(cherry picked from commit 8a82403400 )
2022-01-21 22:09:06 +01:00
Killyana
92e77e456a
DB: Fix a DB error
...
(cherry picked from commit 7987ec103e )
2022-01-21 20:43:57 +01:00