Commit Graph

16284 Commits

Author SHA1 Message Date
xinef1
825719c25c Remove auras interrupted by falling when we fall to the ground or water (#19115)
(cherrypicked from 9b284ab329)
2019-08-17 20:04:14 +02:00
ariel-
aaefda6100 Core/Scripts: Change null-check to assert
- ToPlayer() should never be null in this context

(cherrypicked from 12c680f9b1)
2019-08-17 20:04:14 +02:00
Keader
f087fbbcc6 Core/Scripts: Fixed crash in Sindragosa
Closes #19227

(cherrypicked from ecfb346d1a)
2019-08-17 20:04:14 +02:00
ariel-
9e840d05c4 Core/Misc: always output client cache version on loading
* Do same with hotfix

(cherrypicked from bb553743af)
2019-08-17 20:04:14 +02:00
ariel-
a24cb8a057 Core/Entities: spawned movementtype should override template movementtype
Core/SmartAI: pass the CreatureData pointer (if any) on updating template

(cherrypicked from ff43a74822)

Closes #19223
2019-08-17 20:04:14 +02:00
ariel-
396457e36a Core/Movement: Corrected all speed checks after 23b6991273
Ref issue #19210

(cherrypicked from 2e68736afc)
2019-08-17 20:04:14 +02:00
ariel-
5934f53717 Core/Scripts: implement Moss Covered Feet
Closes #19022

(cherrypicked from f302b3d68d)
2019-08-17 20:04:14 +02:00
jackpoz
6f1b13e5c4 Core/Misc: Fix static analysis issues
(cherrypicked from 8f2bcd79da)
2019-08-17 20:04:14 +02:00
jackpoz
154f9a03e7 Core/Misc: Fix static analysis issues
(cherrypicked from 6940071994)
2019-08-17 20:04:14 +02:00
ariel-
e050a7444e Core/Scripts: kill a warning
(cherrypicked from ace2a75197)
2019-08-17 20:04:14 +02:00
ariel-
beda1c2466 Core/Scripts: Thrusting Hodir's Spear
- Everything is sniffed, enjoy this hell of a quest!

Closes #12808

(cherrypicked from 01f5befcec)
2019-08-17 20:04:14 +02:00
Gustavo
1d2f20d59a Core/Unit: Correct speed calculus when affected by SPELL_AURA_MOD_MINIMUM_SPEED (#18136)
(cherrypicked from 4224259d83)
2019-08-17 20:04:14 +02:00
ariel-
07d43783f6 Core/Conditions: CONDITION_SOURCE_TYPE_QUEST_ACCEPT should not prevent completed question mark from showing (#18151 follow up)
Closes #19188

(cherrypicked from 6c9bda6093)
2019-08-17 20:04:14 +02:00
ariel-
5da9f724c3 Core/Entities: Fix null-dereference crash
Closes #19191

(cherrypicked from d61e0f79c4)
2019-08-17 20:04:14 +02:00
Keader
b428bfbd14 Core/Scripts: Fixed Illidan epic sounds again (#19184)
(cherrypicked from bb3c964e7c)
2019-08-17 20:04:14 +02:00
ariel-
420f2e8ec2 Core/Spells: refactor spell_enchant_proc_data table
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789

(cherrypicked from f609e7a08b)
2019-08-17 20:04:14 +02:00
ariel-
5f70be050f Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60
Closes #15734

(cherrypicked from eac9c1f0b9)
2019-08-17 20:04:14 +02:00
treeston
8e4f5e1627 Core/Creature: Fix SetSpawnHealth so it cooperates with the colossal hack that is Battleground::AddCreature. *puke*
(cherrypicked from b3b4054eb4)
2019-08-17 20:04:14 +02:00
ariel-
b91eac6a1c Core/Spells: fix Hand of Justice proc chance and reduce it past level 60.
Ref #7789

(cherrypicked from f4ae639961)
2019-08-17 20:04:14 +02:00
ariel-
77fc6ceea8 Core/Spell: Added the possibility to explicitly disable auraEffect procs using attributes
- Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use

(cherrypicked from e7ccd8ea3f)
2019-08-17 20:04:14 +02:00
funjoker
b4d30bb92c QueryCache port
partial port of:
(ae9d01a324)
(dd1aa64563)
2019-08-17 20:04:14 +02:00
xinef1
4380fe2751 Properly stop attacking after player leaves ffa area (like Gurubashi Arena) (#18952)
(cherrypicked from 4eae29d421)
2019-08-17 20:04:14 +02:00
Keader
ae0a429e52 Core/Scripts: Fixed epic sounds on Illidan Fight (#19172)
Thanks Kittnz for notice <3

(cherrypicked from 50973e9d6f)
2019-08-17 20:04:14 +02:00
Kittnz
1c926d0171 Script/GO: Alliance Bell, Horde Bell and Karazhan Bell will now send a bell sound on the start of each hour. (#19145)
* Script/GO: Alliance Bell, Horde Bell and Karazhan Bell will now send a bell sound on the start of each hour.

How many times it rings depence on the hour.

* fix little things from pr comments

* Added OnGameEvent

* Fix braces

* almost finished

* fix enum

* Add gameobjects to the game event

Fix override for InitializeAI

* enum squash

* remove braces

* Rename 9999_99_99_99_world.sql to 2017_02_19_01_world.sql

(cherrypicked from 495339a2c7)
2019-08-17 20:04:14 +02:00
xinef1
a32d5cfa17 Core/SmartAI: Various fixes and extensions for smart scripts: (#18673)
- Possible crashes fixed
- Memory leak fixed
- Implemented checking of vehicle conditions
- Extended eventphasemask to 12 bits (sql required to change DB field type)
- SMART_EVENT_GOSSIP_HELLO - added possibility to detect for gameobject reportUse call
- Renamed action SMART_ACTION_SET_FLY to SMART_ACTION_SET_DISABLE_GRAVITY (to reflect actual functionality)
- Added targetsLimit to action SMART_ACTION_CAST and SMART_ACTION_INVOKER_CAST to limit max amount of targets (selected randomly)
- Action SMART_ACTION_TALK corrected to always work as intended
- Properly call GroupEventHappens in action SMART_ACTION_CALL_GROUPEVENTHAPPENS if invoker was charmed or owned by the player
- Properly utilize followAngle in action SMART_ACTION_FOLLOW (db orientation should be in degrees), but keep backward compatibility
- Added action SMART_ACTION_SET_CAN_FLY (119) 0/1
- Added action SMART_ACTION_REMOVE_AURAS_BY_TYPE (120) AuraType, can be used to exit vehicle for example
- Added action SMART_ACTION_SET_SIGHT_DIST (121) sightDist
- Added action SMART_ACTION_FLEE (122) fleeTime
- Added action SMART_ACTION_ADD_THREAT (123) +threat, -threat
- Added action SMART_ACTION_LOAD_EQUIPMENT (124) equipmentId
- Added action SMART_ACTION_TRIGGER_RANDOM_TIMED_EVENT (125) minId, maxId
- Added action SMART_ACTION_REMOVE_ALL_GAMEOBJECTS (126), removes all owned gameobjects
- Added action SMART_ACTION_STOP_MOTION (127), stopMoving, movementExpired
- Extended target SMART_TARGET_HOSTILE_SECOND_AGGRO with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_LAST_AGGRO with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_RANDOM with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_RANDOM_NOT_TOP with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_THREAT_LIST with maxdist
- Extended target SMART_TARGET_OWNER_OR_SUMMONER to be able to get charmer/owner of current owner
- Added new target SMART_TARGET_FARTHEST with maxDist, playerOnly, isInLos restrictions
- Added SpellHit hook to GameObjectAI and extended SmartGameObjectAI to call SMART_EVENT_SPELLHIT when gameobject is hit by spell
- Call GameObjectAI Reset hook on gameobject respawn (for ex. to reset one time events in smart scripts)
- Fixed some logic errors in code
- SmartAI Escorts properly despawn escortee if no players are in range
- Disable Evading while charming creature with SmartAI
- Don't call SMART_EVENT_RESPAWN for dead units before they actually respawn
- Don't call SMART_EVENT_RESPAWN for not spawned gameobjects
- Properly call SMART_EVENT_RESPAWN for gameobject respawn
- Allow action SMART_ACTION_SET_IN_COMBAT_WITH_ZONE to utilize targetlist
- Allow action SMART_ACTION_CALL_FOR_HELP to utilize targetList
- Allow action SMART_ACTION_SET_INVINCIBILITY_HP_LEVEL to utilize targetList
- Allow action SMART_ACTION_SET_VISIBILITY to utilize targetList
- Allow action SMART_ACTION_SET_ACTIVE to utilize targetList
- Allow action SMART_ACTION_ATTACK_START to select random attack target instead of first on the list
- Allow gameobjects to summon gameobjects with action SMART_ACTION_SUMMON_GO
- Properly store action invokers for action SMART_ACTION_WP_START, if no player invokers are found, distance despawn check won't be used
- Allow action SMART_ACTION_WP_RESUME to compensate for the state the unit actually is in (eg. combat)
- Allow action SMART_ACTION_MOVE_TO_POS to select random of the avaiable targets, not only the first one.
- Allow action SMART_ACTION_MOVE_TO_POS to utilize x, y, z parameters as an offset to calculated coordinates
- Action SMART_ACTION_RESPAWN_TARGET should never modify respawntime of already spawned gameobjects, use dedicated function
- Properly delete ontime events created by SMART_ACTION_CREATE_TIMED_EVENT
- If action could not be started because conditions were not satisfied, do not recalculate the waittime to action repeattime, use smaller value to recheck more frequently
- Allow target SMART_TARGET_CLOSEST_PLAYER to be used by gameobjects
- Allow target SMART_TARGET_OWNER_OR_SUMMONER to be used by gameobjects
- Fixed SMART_EVENT_COUNTER_SET to be only called for the id that was incremented
- Changed the way counters work
- Protect PhaseInc from surpassing maximum phase
- Added loading checks for missing NON_REPEATABLE flag if no repeatmin, repeatmax is set
- Added spell validation for SMART_ACTION_CROSS_CAST

(cherrypicked from b0ae5fadd1)
2019-08-17 20:04:14 +02:00
Riztazz
2caec4f4d2 Revert "[3.3.5][master] Core/Movement: Smooth movement #13467 (#18020)"
This reverts commit 05fb27dae4.

(cherrypicked from a3c6880579)
2019-08-17 20:04:14 +02:00
KobeSagami
7d60b9a289 Core/Misc: Minor change to racial wisp handling to make custom easier (or so i heard) (#22954) 2019-08-17 17:07:16 +02:00
Ovah
9bd8d90728 Core/Spells: implement SPELL_AURA_OVERRIDE_AUTOATTACK_WITH_MELEE_SPELL (#23467) 2019-08-17 14:56:22 +02:00
Shauren
b054a3f526 Core/Items: Defined new item flags 2019-08-15 12:03:38 +02:00
Shauren
f884e5a856 Core: Updated allowed build to 8.2.0.31429 2019-08-11 12:19:56 +02:00
Shauren
ee081084d6 Core/PacketIO: Fixed updatefield structures 2019-08-06 19:45:00 +02:00
funjoker
245b6db202 Core/Loot: Fix setting UNIT_FLAG_LOOTING (PR #23666) 2019-08-01 21:52:13 +02:00
Keader
dc1cddf3bb Core/Spells: Split ProcFlags of PROC_HIT_INTERRUPT
Followup: 44d0d24af8
2019-08-01 15:23:08 -03:00
Keader
44d0d24af8 Core/Spells: Fixed PROC_HIT_INTERRUPT not triggering by PROC_FLAG_TAKEN_SPELL_MELEE_DMG_CLASS
Cherrypick of 3ffe570b21
2019-08-01 11:38:25 -03:00
Shauren
176cb72b70 Core/PacketIO: Fixed SMSG_INSPECT_RESULT structure 2019-07-28 16:14:14 +02:00
MaxtorCoder
2e8d7194a9 Core/PacketIO: Fixed inspect client crash 2019-07-28 16:14:14 +02:00
Shauren
f2ef5f878d Core/PacketIO: Added missing packet array size checks 2019-07-28 00:07:19 +02:00
Shauren
168fd20709 Core/Proto: Update client protobuf messages 2019-07-27 14:11:46 +02:00
Shauren
13440434c3 Core/DBLayer: Prevent mixing databases with query holders 2019-07-27 11:45:56 +02:00
Shauren
f6e2b8cdc1 Core/DBLayer: Prevent committing transactions started on a different database 2019-07-27 10:52:33 +02:00
Shauren
e8e89f58fb Core/DBLayer: Prevent using prepared statements on wrong database 2019-07-27 01:00:37 +02:00
Shauren
1dcbceba81 Nopch fix4 2019-07-26 19:09:29 +02:00
Shauren
d211d20b8d Nopch fix3 2019-07-26 19:00:34 +02:00
Shauren
030cb72bdc Nopch fix2 2019-07-26 18:58:37 +02:00
Shauren
d57f020a34 Nopch fix 2019-07-26 18:31:45 +02:00
Shauren
71cbb0ae1c Core: Updated allowed build to 8.2.0.31229 2019-07-26 18:25:25 +02:00
treeston
6455f1c256 DB/Creature: The instance_encounters extra flag (CREATURE_FLAG_EXTRA_DUNGEON_BOSS) now properly propagates to all difficulty entries (not just difficulty 0).
This lets us simplify IsDungeonBoss() on Creature (and move it to header).

Closes #18824.

(cherrypicked from 1beb2e5fd6)
2019-07-21 21:06:54 +02:00
r00ty-tc
83e2777249 [Core/AH] Correctly check player can pay deposit
- Deposit amount wasn't correctly checked in the case of multiple items,
   player with insufficient funds could auctin more items than they should

(cherrypicked from 6bd9aa2787)
2019-07-21 21:06:54 +02:00
xinef1
fb5c07ffe8 Fixed setting and unsetting of m_spellModTakingSpell (#19116)
- A problem when a different spell tries to overwrite existing ModTakingSpell should no longer happen

(cherrypicked from e261754c9c)
2019-07-21 21:06:54 +02:00
xinef1
ecb44f82a4 Core/Creatures: Remove template immunities only for hunter pets (#19100)
(cherrypicked from 949b38b048)
2019-07-21 21:06:54 +02:00