Commit Graph

2361 Commits

Author SHA1 Message Date
Treeston
896b68d5c2 Core/Time: Rename GetGameTime{System, Steady}Point methods
The names are a bit unhandy. Rename them (shorter but still meaningful).

GetGameTimeSystemPoint() -> GetSystemTime()
GetGameTimeSteadyPoint() -> Now()

Also add 2 new typedefs:

typedef std::chrono::steady_clock::time_point TimePoint;
typedef std::chrono::system_clock::time_point SystemTimePoint;

Closes #25042
2020-07-17 17:05:55 +02:00
Peter Keresztes Schmidt
6968e7a1a1 Scripts/Icecrown Citadel: Use std::chrono::duration overloads of EventMap (Part 2) (#25041)
Part 2: gunship battle and Sindragosa

Contributes to https://github.com/TrinityCore/TrinityCore/issues/25012
2020-07-14 21:06:40 +02:00
Peter Keresztes Schmidt
5eaff8a3bc Scripts/Icecrown Citadel: Use std::chrono::duration overloads of EventMap (#25036)
Part 1: without gunship battle and Sindragosa

Contributes to #25012
2020-07-14 21:03:06 +02:00
Peter Keresztes Schmidt
f00ab389d6 Scripts/Utgarde Keep: Use std::chrono::duration overloads of EventMap (#25039)
Contributes to #25012
2020-07-14 20:48:08 +02:00
Peter Keresztes Schmidt
d4bce9f4d2 Scripts/Ulduar: Use std::chrono::duration overloads of EventMap (#25035)
Contributes to #25012
2020-07-14 20:43:43 +02:00
Peter Keresztes Schmidt
2f538258d9 Scripts/Nexus: Use std::chrono::duration overloads of EventMap (#25033)
Contributes to #25012
2020-07-14 20:23:24 +02:00
Peter Keresztes Schmidt
6eec0bc50f Scripts/Naxxramas: Use std::chrono::duration overloads of EventMap (#25032)
Contributes to #25012
2020-07-14 20:19:42 +02:00
Peter Keresztes Schmidt
1a32b0f5b3 Scripts/Isle of Conquest: Use std::chrono::duration overloads of EventMap (#25031)
Contributes to #25012
2020-07-14 20:19:25 +02:00
Peter Keresztes Schmidt
3a9b3259b8 Scripts/Gundrak: Use std::chrono::duration overloads of EventMap (#25030)
Contributes to #25012
2020-07-14 20:17:59 +02:00
Peter Keresztes Schmidt
19ee4d6254 Scripts/Frozen Halls: Use std::chrono::duration overloads of EventMap (#25029)
Contributes to #25012
2020-07-14 20:16:01 +02:00
Peter Keresztes Schmidt
65e01053a8 Scripts/Drak'Tharon Keep: Use std::chrono::duration overloads of EventMap (#25028)
Contributes to #25012
2020-07-14 20:04:10 +02:00
Peter Keresztes Schmidt
42102871a7 Scripts/Chamber of Aspects: Use std::chrono::duration overloads of EventMap (#25027)
Contributes to #25012
2020-07-14 20:03:33 +02:00
Peter Keresztes Schmidt
1c3187e596 Scripts/Azjol-Nerub: Use std::chrono::duration overloads of EventMap (#25026)
Contributes to #25012
2020-07-14 19:48:24 +02:00
Peter Keresztes Schmidt
29779db58b Scripts/Northrend: Use std::chrono::duration overloads of EventMap (#25021)
Contributes to #25012
2020-07-14 19:32:28 +02:00
Peter Keresztes Schmidt
a2b2dc7ad0 Scripts/Trial of the Crusader: Use std::chrono::duration overloads of EventMap (#25020)
Contributes to #25012
2020-07-14 19:13:27 +02:00
Giacomo Pozzoni
ee34a1f19e Scripts/Kologarn: Fix another "stuck in combat" issue (#24998) 2020-07-14 09:44:17 +02:00
Peter Keresztes Schmidt
10be49bdfe Fix some compiler warnings reported by GCC (#25007)
* Core/AI: Remove unneeded null checks

GetMap() can never return NULL.

Fixes additionally -Wunused-variable warnings
reported by GCC.

* Core/GameObject: Fix a -Wunused-variable warning reported by GCC

* Core/Player: Fix a -Wunused-variable warning reported by GCC

* Scritps/CavernsOfTime: Fix -Wimplicit-fallthrough warnings reported by GCC

* Scritps/CavernsOfTime: Fix a -Wmaybe-uninitialized warning reported by GCC

Warning:

/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp: In member function ‘virtual void npc_arthas_stratholme::npc_arthas_stratholmeAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:1119:58: warning: ‘emote’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 1119 |                                 (*it)->HandleEmoteCommand(emote);
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

* Scritps/PitOfSaron: Fix -Wunused-variable warnings reported by GCC

* Scritps/EyeOfEternity: Fix a -Wclass-memaccess warning reported by GCC

Warning:

/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp: In member function ‘virtual void boss_malygos::boss_malygosAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp:950:81: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
  950 |                             memset(_surgeTargetGUID, 0, sizeof(_surgeTargetGUID));
      |

* Scritps/CoilfangReservoir: Fix a -Wclass-memaccess warning reported by GCC

Warning:

/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp: In member function ‘void boss_leotheras_the_blind::boss_leotheras_the_blindAI::Initialize()’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp:220:55: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
  220 |             memset(InnderDemon, 0, sizeof(InnderDemon));
      |                                                       ^

* Scritps/Naxx: Fix a -Wimplicit-fallthrough warning reported by GCC

For discussion see https://github.com/TrinityCore/TrinityCore/pull/25007
2020-07-13 16:35:31 +02:00
Peter Keresztes Schmidt
c92950b3e1 Core/DataStores: Update DBC field names to generated ones (#24999) 2020-07-12 15:36:55 +02:00
Shauren
14db2215d3 Core/Spells: Don't select corpses for spell targets that expect to hit units
Closes #24980
2020-07-09 18:44:21 +02:00
Ovah
232628f0a6 Scripts/ICC: fixed a crash in the Lich King encounter caused by invalid corpse targets 2020-07-09 14:22:00 +02:00
offl
c6811d3e4e DB/Quest: Convert & update support for 'Khu'nok Will Know' to SAI
Closes #24933
2020-07-08 17:37:05 +02:00
offl
2ebef0c51c DB/Creature: Convert & update support for 'Messenger Torvus' to SAI
Closes #24852
2020-07-02 23:20:19 +02:00
Carbenium
c40b897d36 Scripts/Battlefield: Move npc_wg_give_promotion_credit script to BattlefieldWG
The script references BattlefieldWG, which is not exported in dynamic builds.
Move the script, so it is in the same library.
2020-06-24 15:09:57 +02:00
Carbenium
f7faf20254 Battlefields: Move BF scripts out of game
This commit introduces the usual script interface
for battlefields.
2020-06-24 15:09:57 +02:00
Carbenium
6a8c12587e Core/Misc: Create new enum for AreaIds
Move Wintergrasp BF related values there
2020-06-24 15:09:57 +02:00
jackpoz
54e30d4eba Scripts/VioletHold: Limit the number of current summons before the waves start 2020-06-20 14:12:47 +02:00
Peter Keresztes Schmidt
418c3b1fd5 game/AI: Convert SelectAggroTarget to enum class (#24818)
* game/AI: Convert SelectAggroTarget to enum class

* game/AI: Rename SelectAggroTarget to SelectTargetMethod
2020-06-16 23:08:56 +02:00
Gildor
aeb41e67a9 Scripts/Naxxramas: Fix Kel'thuzad evade mode when he dies (#24763) 2020-06-07 12:55:38 +02:00
ForesterDev
e3b232fe0e Core/AI: refactor SpellHit and SpellHitTarget. (#24691)
* Core/AI: refactor SpellHit and SpellHitTarget.

- now caster/target is WorldObject instead of Unit
- remove SpellHitByGameObject / SpellHitTargetGameObject (handled by SpellHit / SpellHitTarget)
- rename parameters in scripts according parent methods

* Restore logic in Algalon script

* Changed check for REMORSELESS_WINTER hit to avoid dublicate call, because it has TARGET_UNIT_CASTER for effects 0/1 and TARGET_GAMEOBJECT_SRC_AREA for effect 2

* Fix build after merge
2020-06-07 10:22:13 +02:00
Gildor
1181b636c0 Scripts/Naxxramas: Noth the Plaguebringer improvements (#24724) 2020-06-06 14:22:19 +02:00
Keader
d81a9e5bc3 Core/Misc: Fixed resistance calculate for Mutated Transformation and Twilight Bloodbolt (#24717)
Ref: 9f7b464a6a
- Implemented a new SpellScript hook that allow control Resistance/Absorb amount of a damage spell.
2020-06-03 22:05:08 -03:00
Giacomo Pozzoni
8c09b6e58b Cherry-pick some cmake commits (#24720)
* Build system: Support  new in cmake 3.17 Ninja Multi-Config generator

(cherry picked from commit 369b618d4f)

* Build system: Fixed PCH with MSVC & Ninja generator

(cherry picked from commit d669f46b6d)

* Core: Fix clang 10 warnings

(cherry picked from commit 7272508cb4)

# Conflicts:
#	src/common/Utilities/Util.h
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/game/Entities/Object/Position.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Guilds/GuildFinderMgr.h
#	src/server/game/Movement/Spline/MoveSplineFlag.h
#	src/server/shared/Dynamic/LinkedList.h

* Build system: Set -Wno-deprecated-copy only for clang 10

(cherry picked from commit 7fdeb259ba)

* Core/Misc: GCC build and warning fixes

(cherry picked from commit 4d69cc1c56)

# Conflicts:
#	src/common/Utilities/Util.cpp
#	src/server/database/Database/MySQLConnection.cpp
#	src/server/game/Battlefield/Zones/BattlefieldTB.cpp
#	src/server/game/DataStores/M2Stores.cpp
#	src/server/game/DungeonFinding/LFGMgr.cpp
#	src/server/game/DungeonFinding/LFGPlayerData.cpp
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Object/Updates/UpdateFields.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/RestMgr.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/GuildPackets.h
#	src/server/game/Spells/Auras/SpellAuraEffects.cpp
#	src/server/game/Spells/Auras/SpellAuras.cpp
#	src/server/game/Spells/Spell.cpp
#	src/server/game/Spells/SpellInfo.cpp
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Argus/AntorusTheBurningThrone/boss_garothi_worldbreaker.cpp
#	src/server/scripts/Kalimdor/HallsOfOrigination/instance_halls_of_origination.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/instance_icecrown_citadel.cpp
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_mimiron.cpp
#	src/server/scripts/Northrend/zone_sholazar_basin.cpp
#	src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp
#	src/server/scripts/Outland/GruulsLair/instance_gruuls_lair.cpp
#	src/server/scripts/Outland/HellfireCitadel/BloodFurnace/instance_blood_furnace.cpp
#	src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
#	src/tools/vmap4_extractor/gameobject_extract.cpp
#	src/tools/vmap4_extractor/model.cpp
#	src/tools/vmap4_extractor/vec3d.h

* Build system: Print found git version when warning about it being too old

(cherry picked from commit 1ae72db201)

* Build system: Removed hard requirement on BOOST_ROOT being set as environment variable, it can now be also passed as command line argument to cmake and fix compile warning with boost 1.73

(cherry picked from commit 161944b764)

# Conflicts:
#	dep/boost/CMakeLists.txt

* Remove some code that was already removed from 335 and then cherry-picked into master

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-31 14:17:26 +02:00
Keader
a72197911e Scripts/Ulduar: Codestyle fix
* Making jackpoz happy xD
2020-05-30 13:13:02 -03:00
Keader
05eeaade3e Scripts/Ulduar: Fixed XT002 Heart health regeneration 2020-05-30 11:47:43 -03:00
Gildor
6c1a874e57 Scripts/Trial Of The Crusader: Fixed Anub'arak Pursuing Spikes movement (#24715) 2020-05-30 08:50:33 -03:00
Gildor
3ab970aa47 Scripts/Ulduar: Fix Flame Leviathan movement (#24673) 2020-05-26 13:20:38 +02:00
Gildor
dd3fbf426c Scripts/Icecrown Citadel: Fix Sindragosa movement when Wipe in fly phase (#24665) 2020-05-24 20:38:24 +02:00
Keader
99c457c270 Scripts/ICC: Fixed duplicated call of reputation spell 2020-05-19 11:45:12 -03:00
Keader
d1e1b8753c Scripts/ICC: Fixed Deathbringer/Valithria reputation handler + codestyle fixes
* Added correct reputation spell for both bosses
* Fixed debuffs remove when deathbringer dies (it also fix recount)
* Changed all DoCast(me, xxx) -> DoCastSelf(xx)
* Removed old reputation hack in DB
* Fixed my OCD with spells enum :)
2020-05-19 11:42:11 -03:00
Shauren
1d43003cfa Scripts/Icecrown Citadel: Fixed Professor Putricide oozes not moving during their channel 2020-05-15 18:16:03 +02:00
Metalaka
e2434e4f47 Core/CreatureAI: Shambling Horror re-cast Enrage as soon as it is not stun (#24618) 2020-05-14 21:17:00 +02:00
NoName
22aaf32a79 Scripts/IcecrownCitadel: Adding IsAlive check to avoid possible crash in Event (#24514) 2020-04-29 21:14:27 +02:00
NoName
45993428f5 Core/Spells: Crystallize should not use DIMINISHING (#24502)
and also correcting spelling in script

by Rushor and wotlk-enthusiast
2020-04-26 21:40:57 +02:00
Gildor
6c7c2c6cd2 Scripts/Naxxramas: Fix Heigan Eruption spell (#24470) 2020-04-17 22:54:36 +02:00
Keader
77dd751499 Scripts/Ulduar: Little improvements in Auriaya
* Removed DespawnAtEvade
* Fix Feral Defender Damage
2020-04-15 11:28:46 -03:00
Keader
78dff46bf2 Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset
2020-04-15 09:53:46 -03:00
Killyana
d0f9ace679 Creature: Gorkun Ironskull & Martin Victus in The Pit of Saron
Still some events are missing in this instance
2020-04-10 20:05:26 +02:00
Shauren
f57b1e27d0 Scripts/Eye of Eternity: Fixed The Focusing Iris not respawning on wipe
Closes #22948
2020-04-10 17:08:25 +02:00
jackpoz
caae3886d2 Core/Misc: Remove whitespace at the end of lines 2020-04-05 19:11:00 +02:00
Jozef Dúc
936ff574c5 Fixes #22884 (#24338)
Fix issue 22884 with non stacking necrotic plague debuff after dispell//death
2020-04-04 15:30:55 +02:00