Commit Graph

13798 Commits

Author SHA1 Message Date
Killyana
9435caa8d1 Instance/Script: Blood Furnace
Ref #23285
2019-05-16 19:31:54 +02:00
ccrs
74678b247e Core/PetAI: apply some movement related corrections
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air
2019-05-16 01:11:13 +02:00
ccrs
a4e94dcf6b Core/PlayerAI: apply some movement related corrections
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air
2019-05-16 00:44:50 +02:00
ccrs
79b90f9d3a Core/Misc: remove incorrect ClearUnitState calls related to movement
these unit states should never be removed outside motionmaster's handlings
2019-05-16 00:21:09 +02:00
Aokromes
61ba477c77 Core/Creature: equipment_id field on creature table is not working correctly, if it's set to 0 the npc still spawn with the equipement. (#23273)
By Malcrom
Closes #16416
2019-05-15 23:12:38 +02:00
ccrs
f309b49eb1 Core/AI: couple movement related corrections in FollowerAI
plus EnterEvadeMode streamline
2019-05-15 22:23:04 +02:00
ccrs
d3b8d69e38 Core/AI: streamline FollowerAI::MoveInLineOfSight with SmartAI and EscortAI
plus another method reorganization
2019-05-15 22:04:24 +02:00
ccrs
0e22d61d4a Core/AI: streamline FollowerAI::AssistPlayerInCombatAgainst with SmartAI and EscortAI
plus couple method reorganizations
2019-05-15 21:59:10 +02:00
ccrs
fdb71ce19e Core/AI: logs, codestyle & cosmetics standarization 2019-05-15 19:23:28 +02:00
ccrs
0eb5d240fa Core/AI: silence a freaking annoying VS IntelliSense warning 2019-05-15 16:42:28 +02:00
ccrs
179c7da1fc Core/AI: variable naming standarization
plus minimum codestyle changes
2019-05-15 01:33:55 +02:00
ccrs
7025b00656 Scripts/Northrend: couple cosmetic corrections after 552720a 2019-05-14 22:07:23 +02:00
jackpoz
df7f166e5e Core/Misc: Fix GCC 8 warning 2019-05-11 19:46:23 +02:00
Wyreth
552720a993 Scripts/Northrend: improvements for quest Get Me Outa Here! (11673) (#20753)
* Script/Quest: improvements for quest Get Me Outa Here! (11673).

* Happiness for our Travis overlord

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update zone_borean_tundra.cpp

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Fix hook that got renamed

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Rename 9999_99_99_99_world_quest_get_me_outa_here.sql to 2019_05_11_08_world.sql
2019-05-11 19:39:03 +02:00
Shauren
3e9239a1e5 Core/Movement: Use correct root check 2019-05-10 23:32:57 +02:00
Shauren
99a9129a72 Core/Movement: Prevent rooted units from falling
* Fixes a client freeze

Closes #23042
2019-05-10 23:30:50 +02:00
brotalnia
49d0a5bbb6 Core/Spells: Return CheckCast result from CastSpell (#23236)
* Return CheckCast result from CastSpell

* Return cast result from UnitAI methods too.
2019-05-10 18:58:26 +02:00
Aokromes
cc1a520299 Core/Movement: Fix Warrior's Charge launch visual while jumping backw… (#23243)
* Core/Movement: Fix Warrior's Charge launch visual while jumping backwards

By Natureknight

* fix no-pch
2019-05-10 17:54:54 +02:00
Wyrserth
49dc8a8e44 Core/Quest: improve source item deletion logic for items that give quests (#23250)
* Core/Quest: improve source item deletion logic for items that give quests.

Prevent deletion of items that aren't supposed to be destroyed (like Demon Scarred Cloak).

* Whoops.
2019-05-10 17:49:46 +02:00
Keader
a639a99c6c Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening quest
killer can be a pet
2019-05-08 21:12:56 -03:00
Demonid
d1c5b3c897 Scripts/Icecrown Citadel: The Lich King's Last Stand quest kill credit (#23239)
Closes #8919
2019-05-08 18:43:33 -03:00
Trond B. Krokli
1e97dfec53 Core/Spells: make Four Horsemen debuffs negative (#23253)
By Riztazz
Closes #23248
2019-05-08 15:42:54 -03:00
Killyana
ce562415ed Spell/Script: Throw Torch must hit only one target 2019-05-07 21:36:29 +02:00
Wyrserth
b76bcc836c Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. (#23252) 2019-05-07 19:49:25 +02:00
Wyrserth
0a25069db4 Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. (#23249) 2019-05-07 10:45:37 +02:00
Giacomo Pozzoni
06d8f4dc78 Core/Misc: Fix no-pch build 2019-05-07 09:41:44 +02:00
jackpoz
991b2a11bd Core/Misc: Log Map name in asserts 2019-05-06 21:00:59 +02:00
jackpoz
4130384f2e Core/Misc: Log Spell/Aura name in Spell/Auras asserts 2019-05-06 20:20:10 +02:00
jackpoz
6dae4a747d Core/Vehicles: Fix accessories disappearing on reset 2019-05-05 17:20:10 +02:00
jackpoz
a76d01278a Core/Misc: Apply fatigue when flying too
Fix #22856
2019-05-04 19:36:00 +02:00
Killyana
fe311260f7 Remove deprecated code 2019-05-04 16:52:59 +02:00
Killyana
fd166025c8 Remove Deprecated code 2019-05-04 16:11:50 +02:00
Giacomo Pozzoni
d4414af2d4 Core/Vehicles: Fix multiple vehicle join events on same seat (#23233) 2019-05-03 22:15:30 +02:00
Jozef Dúc
78070163dc Core/Object: Range check vol. 2 (#23226)
* Core/Object: Fix all missing parts for #23062

* Update GameObject.cpp
2019-05-02 21:53:12 +02:00
sirikfoll
fe3bf57aba Core/Scripts: Fix Skadi dismount issue
Closes #23005
2019-05-02 15:46:46 -03:00
Giacomo Pozzoni
20772dbf5d Scripts/Spells: Fix implementation of #22332 (#23228)
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead
2019-05-02 14:34:23 +02:00
jackpoz
24fbbee4b9 Core/LFG: Remove dungeon cooldown when completing random dungeons 2019-05-01 18:37:39 +02:00
ccrs
69c15f5ae7 Core/Creature: couple refactors/renaming 2019-05-01 14:08:52 +02:00
Killyana
14445088ea Quest/Script: Breakfast Of Champions
Set both Earthshaker Drum Events to 50%
2019-04-30 02:23:23 +02:00
ccrs
dfa54d3bf4 Core/Object: re-change faction template related logs 2019-04-29 22:48:45 +02:00
ccrs
aee26eb467 Core/Misc: standarize a couple logs 2019-04-28 19:41:30 +02:00
jackpoz
3f0ce98f7c Core/Commands: Fix heap-use-after-free in ".ticket delete" command
Reported by Address Sanitizer
2019-04-28 18:56:45 +02:00
jackpoz
f45ebe71b0 Core/Misc: Fix *nix build 2019-04-28 18:53:01 +02:00
jackpoz
70fcdc687d Core/Pet: Change assert to error log
Change assert added in 43dec9e4d0 to error log since charmed creatures lose their AI until next map update
2019-04-28 18:47:19 +02:00
Shauren
408d68717c Core/Misc: Fixed -Wcast-function-type warning 2019-04-28 16:30:15 +02:00
jackpoz
26b6cb0584 Core/Misc: Fix some GCC 8 warnings 2019-04-28 15:59:34 +02:00
jackpoz
d910ffd779 Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ChaseMovementGenerator in 386b5a6fd9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned.
The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.
2019-04-28 14:50:33 +02:00
jackpoz
e3a9a9bfb2 Core/Scripts: Rename recent GameObject spell overloads to fix GCC warnings
Rename recent GameObject spell overloads (they used to accept only Unit as parameters) to fix GCC warnings about partial function override.
2019-04-27 23:48:39 +02:00
jackpoz
71d15ea25b Scripts/Commands: Add .debug asan commands
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)
2019-04-27 20:11:48 +02:00
jackpoz
844e7ee926 Scripts/Guards: Fix infinite loop in npc_air_force_bots
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.
2019-04-27 16:32:41 +02:00