Commit Graph

1701 Commits

Author SHA1 Message Date
jackpoz
95bae7143f Scripts/VioletHold: Fix issue reported by static analysis
Coverity defect IDs: 1318019
2015-08-24 22:37:59 +02:00
jackpoz
f50df72820 Scripts/VioletHold: Fix crash in Xevozz boss fight
Fix crash happening during Xevozz boss fight caused by passing a local list by reference to a lambda expression
Closes #15345
2015-08-24 14:52:18 +02:00
StormBytePP
3a4f54197c Scripts/Build: Fixed noPCH compile 2015-08-23 16:43:44 +02:00
joschiwald
df21162fe4 Scripts/VioletHold: rewrote the whole instance
thanks @MitchesD for help
2015-08-23 14:43:11 +02:00
joschiwald
30fc4f9f63 Scripts/Ulduar: fixed hodir kill credit
Closes #15303
2015-08-17 23:27:42 +02:00
jackpoz
2f92a2f58e Scripts/Misc: Replace some unsafe WorldObject* class members in scripts with ObjectGuid
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
2015-08-16 22:29:56 +02:00
jackpoz
5f0f152345 Scripts/Misc: Fix possible crash
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj
2015-08-12 12:43:59 +02:00
David Carlos Manuelda
e3c3b8f08f Core/Misc: Added some missing overrides 2015-08-11 12:44:35 +02:00
jackpoz
eb2e8f873a Merge pull request #15058 from Golrag/rorface
Scripts/Rotface: Fix Ooze flood targets.

Fixes #15031
2015-08-09 18:35:17 +02:00
Warpten
80ec3e1515 Scripts/RubySanctum: Widen random angles for meteor flames.
Don't QQ because "OMG you're not testing any of your stuff", I can't build TC atm.

Memo: Meteor Flames have
```
[12] UNIT_CREATED_BY_SPELL: 74689/1.046616E-40
```

which isn't in DBCs, exists, but is not seen in sniffs.
(cherry picked from commit 0dc6ea161d)
2015-07-28 20:36:21 -03:00
Warpten
ef93d1174d Scripts/RubySanctum: Fixed Meteor Flames
(cherry picked from commit 982b59d2ec)

Update boss_halion.cpp
(cherry picked from commit 50c23bbcb8)
2015-07-27 17:37:28 -03:00
Unholychick
0d5a0c81a8 Scripts/Ulduar: Fix a visual issue with Mimirons Rocket Strike
In p2 he should fire left or right rocket at random, not always left one. ref https://www.youtube.com/watch?v=oY-nZ0EjDRw

Fix Mimiron DB target attacking players.
2015-07-26 03:30:29 +02:00
joschiwald
8a9f1b871a Scripts/Ulduar: fixed freya loot and added missing conditions
thanks @Keader

Closes #15098
2015-07-25 15:28:39 +02:00
Warpten
a82e55f684 Scripts/RubySanctum: Halion: Correctly spawn X-shaped flames. 2015-07-24 17:11:30 +02:00
Shauren
caf808163d Misc: Removed tabs
(cherry picked from commit 4e83094354)
2015-07-24 12:05:14 +01:00
Gacko
73fd4fb49c Fix non pch build.
(cherry picked from commit 49a6f7b7bd)
2015-07-24 11:52:28 +01:00
Shauren
b4adf3f5dd Core/Misc: Fixing warnings detected by Visual Studio 2015 compiler
(cherry picked from commit a22e4e121a)

Conflicts:
	cmake/compiler/msvc/settings.cmake
	src/server/game/DataStores/DBCStores.cpp
	src/server/game/Entities/GameObject/GameObject.cpp
	src/server/game/Entities/Object/Object.cpp
	src/server/game/Entities/Object/Object.h
	src/server/game/Entities/Pet/Pet.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Garrison/Garrison.cpp
	src/server/game/Garrison/GarrisonMgr.cpp
	src/server/game/Globals/ObjectMgr.cpp
	src/server/game/Globals/ObjectMgr.h
	src/server/game/Guilds/GuildMgr.cpp
	src/server/game/Handlers/CharacterHandler.cpp
	src/server/game/Handlers/QueryHandler.cpp
	src/server/game/Handlers/QuestHandler.cpp
	src/server/game/Handlers/SpellHandler.cpp
	src/server/game/Server/Packets/ChannelPackets.h
	src/server/game/Server/Packets/PartyPackets.cpp
	src/server/game/Server/WorldSession.h
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellInfo.cpp
	src/server/game/Spells/SpellScript.cpp
	src/server/scripts/Commands/cs_list.cpp
2015-07-24 11:51:48 +01:00
Vincent-Michael
5c5533c355 Core: Remove whitespaces
(cherry picked from commit 5705555f1f)

Conflicts:
	src/server/game/Server/Packets/TicketPackets.h
2015-07-24 11:35:34 +01:00
jackpoz
a22fd7dca5 Scripts/VioletHold: Fix build warnings 2015-07-19 14:57:10 +02:00
Golrag
111ed6fd5b Script/Rotface: Fixed Ooze flood targets. 2015-07-12 20:38:44 +02:00
joschiwald
7b1fee6c78 Scripts/FoS/Bronjahm: fixed corrupted soul fragment
Closes #5215
2015-07-12 14:37:46 +02:00
jackpoz
b574c99549 Scripts/Ulduar: Fix Flame Leviathan instance lock
Fix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005
2015-07-05 17:16:35 +02:00
joschiwald
6680a7c331 Scripts/EoE: fixed crash
- removed some useless code (and some other random changes)
2015-07-03 21:01:29 +02:00
jackpoz
275bb93034 Scripts/EyeOfEternity: Fix crash added in d1853f693b
Close https://github.com/TrinityCore/TrinityCore/issues/14984#issuecomment-118044904
2015-07-02 22:08:19 +02:00
jackpoz
55681666b3 Core/Misc: Fix build warnings 2015-07-01 20:57:20 +02:00
Nyeriah
0b1355b280 Scripts/RubySanctum: Fix build warnings 2015-06-30 10:22:28 -03:00
mik1893
7c01638d45 Scripts/VioletHold: fix a crash during Ichoron encounter
Closes #14962
2015-06-27 22:07:57 +02:00
Mik1893
409c8e406d Scripts/Oculus: Implemented Drake GPS system 2015-06-26 16:24:12 +02:00
DDuarte
5a7adbba3a Fix build after recent cherry picks (v2.0) 2015-06-26 04:08:40 +01:00
DDuarte
079ebe4d5d Fix build after recent cherry picks 2015-06-26 04:01:26 +01:00
DDuarte
02df39f791 Fix build and SQL import after recent cherry picks 2015-06-26 02:42:24 +01:00
Warpten
aade16a2f4 Scripts/RubySanctum: Updates to Halion.
* Fixed Living Embers not spawning.
* Meteor Strike is now randomized.

(cherry picked from 1447875cac)

Scripts/RubySanctum: Fix a mathematical mistake.
SQL: Do not use MAX(Id), hardcode it.

(cherry picked from 7a5bc9e1fe)

Scripts/RubySanctum: Correctly spawn Living Embers.

(cherry picked from 7c4b8b0e82)

Scripts/RubySanctum: Remove duplicate code.

(cherry picked from 1d29328769)

Core/Misc: Warning fixes

(cherry picked from dc53dad8a4)
2015-06-26 01:52:17 +01:00
DDuarte
24b5dfcb4d Core/BattlegroundIC: Removed 1 hack:
* Parachute spell is now blizzlike
* Also restored "The battle will begin in 2 minutes."

(cherry picked from commit 8a4afad63a)

Conflicts:
	sql/updates/world/2015_05_01_00_world.sql
	src/server/game/Miscellaneous/Language.h

Rename 2015_05_01_00_world.sql to 2015_06_13_00_world.sql

(cherry picked from commit 74eeefa5be)
2015-06-26 01:24:21 +01:00
mik1893
49809bd404 Scripts/VioletHold: Fix codestyle and unwanted crash in Violet/Hold
closes #14952 and #14953
2015-06-26 00:30:04 +02:00
MitchesD
e34f74dace Scripts/VioletHold: fixed non-pch build and codestyle 2015-06-25 15:26:02 +02:00
mik1893
0bb7f89e82 Core/Scripts: Rework Violet Hold bosses adding missing spells/mechanics:
- Cyanigosa, Arcane Vacuum
- Ichoron, globules mechanic
- Moragg, optic link visuals
- Lavanthor, minor changes
- Zuramat, correctly implement void sentries
- Erekem, implement Windfury and correct management of Erekem Guards
- Script for the pre-event
Thx @ManuFe
2015-06-23 16:32:50 +02:00
joschiwald
34a721ba84 Scripts/VioletHold: picked some things from pull request #11399 (thx MitchedD for initial work) 2015-06-14 16:03:17 +02:00
DDuarte
1e54097084 Core/Scripts: Corrected argument types in GetCreatureEntry/GetGameObjectEntry ZoneScript hooks
(cherry picked from commit b0c4268a6b)

Conflicts:
	src/server/game/Entities/GameObject/GameObject.cpp
2015-06-01 00:44:11 +01:00
jackpoz
25881ca95f Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1022861, 1022862, 1022863, 1302435, 1302439, 1302440
2015-05-30 23:09:34 +02:00
tkrokli
9325f18528 [3.3.5a][ICC/Professor Putricide] Volatile Ooze Eruption fix
by @ManuFe and @Rushor; closes #12336

In the existing source, the rooting aura is removed after the explosion,
therefore the knockback effect does not work because the player is still rooted.
By swapping these 2 lines, the aura is removed, then the explosion happens.

Result: rooting is removed before the knockback effect is cast on the player.
2015-05-27 06:42:14 +02:00
Shauren
1f076a395f Scripts/Icecrown Citadel: Fixed Ice Tomb during phase 3 of Sindragosa encounter
(cherry picked from commit f85605b5f7)
2015-05-21 00:03:11 +02:00
Carbenium
64bed16a57 Scripts/Icecrown: Move Squire David to SmartAI 2015-05-19 23:20:26 +02:00
Shauren
8a013ba0fb Core/Misc: Moved Position to its own file
(cherry picked from commit 48ee1f0033)

Conflicts:
	src/server/game/Entities/Object/Object.cpp
	src/server/game/Entities/Object/Object.h
	src/server/game/Spells/Spell.cpp
2015-05-19 21:44:39 +01:00
Duarte Duarte
f4c1a8fb2d Merge pull request #14454 from ariel-/cd
Port Core/Spells: Cooldown updates (6.x branch)
2015-05-19 18:52:05 +01:00
jackpoz
b5cc8c5b17 Scripts/ToC: Fix doors opening/closing during Dreadscale fight
Fix doors opening/closing during Dreadscale fight by sending a CloseDoor command instead of toggling the door state when Dreadscale resets its movement.
Note that bounding the door state to boss movement makes poor sense and should be changed. Other bosses in ToC have this logic and should be updated if they show the same bug.
2015-05-17 14:50:30 +02:00
Nyeriah
da74aa526a Scripts/Ulduar: Fix a comple of issues with Flame Leviathan's towers
* Fix tower count being set to 0 once the first tower is destroyed due to bad logic
* Prevent towers from reducing counter twice (caused by event being sent twice by the gameobject when destroyed)
2015-05-12 14:16:51 -03:00
Nyeriah
2d349da2ac Scripts/Eye of Eternity: Provide players with drakes when entering instance after Malygos' demise 2015-05-05 02:04:04 -03:00
jackpoz
09aed25659 Scripts/VioletHold: Fix crash
Fix crash in Violet Hold happening when crystals were activated without killing trash mobs.
Crash added in cba6515acb and f4531c5a58 .
Closes #14629
2015-05-03 11:57:04 +02:00
Nyeriah
335cceb26e Scripts/HallsOfStone: Set the Tribunal of Ages encounter state to IN_PROGRESS once it starts, instead of when Brann's escort starts 2015-04-23 23:51:40 -03:00
Nyeriah
6645af4b3c Scripts/HallsOfStone: Brann Spankin' New achievement should only fail if damage is taken during event 2015-04-23 23:13:25 -03:00