Commit Graph

17123 Commits

Author SHA1 Message Date
jackpoz
a01d397c3d Core/Misc: Fix static analysis issues
Fix static analysis issues reported by 3rd party tools

(cherry picked from commit 24e82fe83d)
2021-02-25 18:50:55 +01:00
jackpoz
668a3ad643 Core/Misc: Fix static analysis issues
Fix coverity id 1382860

(cherry picked from commit 19e99478a7)
2021-02-25 18:50:55 +01:00
Ovah
2a51edc5bc Core/Creatures: Implemented extra flag to use offhand attacks (#21008)
* Fixed initial offhand attack timer so the main and offhand attacks will now act blizzlike instead of getting executed at the same time

Note: since some creature equipment items cannot be identified as weapon since they are only visual items there is no way to detect this automaticly
(cherry picked from commit 869affa893)
2021-02-25 18:50:55 +01:00
Keader
2630a5288a Core/Scripts: Fixed Enervating Brand in Baltharus encounter
Closes #21027
By Mihapro

(cherry picked from commit 6598c5d2f3)
2021-02-25 18:50:55 +01:00
Shauren
c1ad297a72 Core/Spells: Fixed accessing freed memory after reloading spell_area
(cherry picked from commit d011097ab0)
2021-02-25 18:50:55 +01:00
jackpoz
7cb6c17df4 Core/CreatureAI: Disable TotemAI from database
Disable TotemAI set in creature_template, triggering an assert when spawning the creature

(cherry picked from commit 072c884ed8)
2021-02-25 18:50:55 +01:00
Treeston
03ab9bc6fa woops (ref 76a4c7d)
(cherry picked from commit b4df977ca6)
2021-02-25 18:50:55 +01:00
Treeston
2c0b94a000 Some misc streamlining/cleanup:
- std::chrono overloads for SummonCreature
- Removed misleading const qualifier from SummonCreature (it wasn't being honored)
- Rename parameters of SummonCreature to follow convention
- EventProcessor has a new method (AddEventAtOffset) that adds an event...at an offset. Genius.

PS: Hi there Keader.
(cherry picked from commit 76a4c7d974)
2021-02-25 18:50:55 +01:00
jackpoz
f1388f37b6 Core/WorldSession: Fix idle WorldSessions getting kicked twice as fast as supposed
Fix SocketTimeOutTime and SocketTimeOutTimeActive settings being effectively halved by reducing the timeout time twice every update instead of just once, causing much faster kicks (i.e. after 30 seconds with 60 seconds set in the configs).

(cherry picked from commit 032194099e)
2021-02-25 18:50:55 +01:00
Killyana
29aae591bc DB/Creature: Scourging Crystal
And fix spell script spell_q11396_11399_scourging_crystal_controller
Closes #17596

(cherry picked from commit 00e3023b32)
2021-02-25 18:50:55 +01:00
Ovah
9ff4aea416 Fix build 2021-02-24 23:03:00 +01:00
Ovah
c2632999ee Core/PacketIO: Fixed building SMSG_PARTY_MEMBER_FULL_STATE for multiple receivers 2021-02-24 23:00:35 +01:00
Matan Shukry
37db083589 Scripts/Spells: Changed palading spell scripts to use RegisterSpellScript and RegisterAuraScript (#26149) 2021-02-24 22:30:22 +01:00
Matan Shukry
ed2a0b610a Scripts/Spells: Remove old paladin spell scripts (#26148) 2021-02-24 22:13:52 +01:00
Shauren
8740c2f85f Core/Auras: Improve PROC_ATTR_USE_STACKS_FOR_CHARGES implementation to give stacks priority over charges if both are present in spell data
Closes #26146
2021-02-24 22:08:21 +01:00
Matan Shukry
9e948ff4bd Core/Spells: Corrected the spell id source used in the learn spells map when loading SpellLearnSpell.db2 data (#26140) 2021-02-24 20:20:14 +01:00
Matan Shukry
428fbcb133 Core/Players: Always clear old action bars on specialization change, even if new specialization doesn't have anything on its bars (#26134) 2021-02-23 20:08:21 +01:00
Matan Shukry
2b672d807f Scripts/Spells: Fix Ferocious Bite damage increase from extra energy (#26093) 2021-02-23 20:05:39 +01:00
Matan Shukry
03f1d3cedf Core/Auras: Implemented SPELL_AURA_MOD_POWER_GAIN_PCT (#26132) 2021-02-23 17:36:36 +01:00
Matan Shukry
23aa13257a Core/Spells: Fixed spells using SPELL_EFFECT_POWER_BURN not working when combined with other effect types that hit other units and power burn hits caster (#26097) 2021-02-23 00:16:02 +01:00
Matan Shukry
4302f2ba95 Scripts/Spells: Implemented druid's Skull Bash (#26103) 2021-02-22 22:10:49 +01:00
Shauren
01a3be276f Core/Spells: Prevent spell power costs from changing their sign (positive cost cannot become negative) 2021-02-21 23:19:18 +01:00
Matan Shukry
a76c08843f Core/Auras: implement mana cost modification aura (#26085) 2021-02-21 23:08:51 +01:00
Matan Shukry
19b733fefc Scripts/Spells: Fix Prayer of Mending (#26020) 2021-02-21 21:12:08 +01:00
Shauren
51a9d2a9c2 Core/Auras: Implemented new spell modifier type to change aura stack size on apply 2021-02-21 18:36:18 +01:00
Matan Shukry
b4b13e7b38 Core/Auras: Implemented new spell modifier type to change max aura stack size (#26109) 2021-02-21 18:11:34 +01:00
Shauren
dd31b36291 Core/Spells: Fix typo (fixes casting all spells) 2021-02-21 18:07:42 +01:00
Shauren
834d78638a Core/Players: Rename player flag PLAYER_ALLOW_ONLY_ABILITY to PLAYER_FLAGS_HIDE_ACCOUNT_ACHIEVEMENTS 2021-02-21 16:11:35 +01:00
Shauren
ac1ef5efbe Core/Auras: Implemented SPELL_AURA_DISABLE_ATTACKING_EXCEPT_ABILITIES 2021-02-21 16:10:48 +01:00
Shauren
1b8ef46808 Core/Auras: Reimplement SPELL_AURA_DISABLE_CASTING_EXCEPT_ABILITIES to properly allow casting listed spells 2021-02-21 16:10:22 +01:00
Shauren
b811da080c Core/Auras: Implemented SPELL_AURA_MOD_COMBAT_RATING_FROM_COMBAT_RATING 2021-02-21 16:07:01 +01:00
Shauren
d2a9953684 Core/Auras: Implemented SPELL_AURA_LEARN_SPELL 2021-02-21 16:06:35 +01:00
Shauren
84cb6718ee Core/Auras: Implemented SPELL_AURA_MOD_CRIT_CHANCE_VERSUS_TARGET_HEALTH and SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER 2021-02-21 15:43:58 +01:00
Shauren
6fd90ebb61 Core/Auras: Update comment for aura 235 - SPELL_AURA_MOD_HOVER_NO_HEIGHT_OFFSET 2021-02-21 15:39:53 +01:00
Shauren
983e565650 Core/Auras: Restore old SPELL_AURA_MOD_HOT_PCT implementation from 3.3.5 branch 2021-02-21 15:39:14 +01:00
Shauren
c57b012ee4 Core/Auras: Implemented SPELL_AURA_SET_FFA_PVP 2021-02-21 15:37:11 +01:00
Shauren
ffbbc1d8e5 Core/Auras: Implemented SPELL_AURA_MOD_AUTOATTACK_RANGE and SPELL_AURA_MOD_AUTOATTACK_CRIT_CHANCE 2021-02-21 15:35:33 +01:00
Shauren
4f38650810 Core/Auras: Implemented SPELL_AURA_MOD_INCREASE_HEALTH_PERCENT2 2021-02-21 15:33:54 +01:00
Shauren
5ed75bb2d3 Core/Auras: Implemented SPELL_AURA_PERIODIC_WEAPON_PERCENT_DAMAGE 2021-02-21 15:32:52 +01:00
Shauren
fea8306aa3 Core/Auras: Implemented SPELL_AURA_REMOVE_TRANSMOG_COST and SPELL_AURA_REMOVE_BARBER_SHOP_COST 2021-02-21 15:24:22 +01:00
Shauren
e533d53da8 Core/Spells: Define new spell attribute 2021-02-21 15:21:07 +01:00
Shauren
4ee565b2c8 Core/Auras: Implemented SPELL_AURA_MOD_PERIODIC_DAMAGE_TAKEN 2021-02-21 15:20:18 +01:00
Shauren
bd7c714c97 Core/Auras: Rename many old aura types to their new meaning 2021-02-21 15:16:55 +01:00
Osleyder Gonzalez Acosta
8cc76993a2 Core/Misc: Updated current expansion config 9.0.2 (#26122) 2021-02-21 11:03:29 +01:00
Shauren
512931646a Core/Auras: Refactor logic determining which spell aura type values need to be sent 2021-02-20 14:53:33 +01:00
Shauren
04bf6b500d Fix build 2021-02-20 14:30:44 +01:00
Shauren
31d3080091 Core/Players: Corrected shield block value calculations 2021-02-20 14:00:48 +01:00
Shauren
411631743a Core/Auras: Do not warn about nonexisting proc spells when spell id is 0 and aura is a dummy 2021-02-18 23:30:28 +01:00
Shauren
a680e247ec Scripts/Spells: Convert Mage Fingers of Frost stack dropping script to use new proc attribute 2021-02-18 23:29:04 +01:00
Shauren
54c5cc97f5 Core/Auras: Implemented new spell proc attribute PROC_ATTR_USE_STACKS_FOR_CHARGES to drop stacks instead of charges 2021-02-18 23:28:26 +01:00