thanks @MitchesD for help
(cherry picked from commit df21162fe4)
(cherry picked from commit 3a4f54197c)
(cherry picked from commit f50df72820)
(cherry picked from commit 95bae7143f)
(cherry picked from commit 5406f82044)
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs
(cherry picked from commit 3e2014a958)
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy
(cherry picked from commit 3fc1bb1abf)
# Conflicts:
# src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats
(cherry picked from commit ea1c783b84)
This fixes the following bugs:
Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.
Closes#15396
Signed-off-by: DDuarte <dnpd.dd@gmail.com>
(cherry picked from commit a83437af3d)
Fixed bugs with Sapphiron encounter:
- Sapphiron will now properly re-engage if the previous attempt ended while he was in flight.
- Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground.
- Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.
(cherry picked from commit a90ae075c9)
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.
(cherry picked from commit 2f92a2f58e)
Conflicts:
src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
Don't QQ because "OMG you're not testing any of your stuff", I can't build TC atm.
Memo: Meteor Flames have
```
[12] UNIT_CREATED_BY_SPELL: 74689/1.046616E-40
```
which isn't in DBCs, exists, but is not seen in sniffs.
Scripts/Ulduar: Fix a visual issue with Mimirons Rocket Strike and Fix Mimiron DB target attacking players
(cherry picked from commit 66bbdfb82c)
Conflicts:
sql/updates/world/2015_07_26_05_world.sql
---
Scripts/VioletHold: picked some things from pull request #11399 (thx MitchedD for initial work)
(cherry picked from commit 34a721ba84)
by joschiwald
---
Core/Scripts: Rework Violet Hold bosses adding missing spells/mechanics:
- Cyanigosa, Arcane Vacuum
- Ichoron, globules mechanic
- Moragg, optic link visuals
- Lavanthor, minor changes
- Zuramat, correctly implement void sentries
- Erekem, implement Windfury and correct management of Erekem Guards
- Script for the pre-event
Thx @ManuFe
(cherry picked from commit 0bb7f89e82)
Conflicts:
src/server/scripts/Northrend/VioletHold/boss_erekem.cpp
by mik1893
---
Rename 2015_06_08_01_world.sql to 2015_06_25_00_world.sql
(cherry picked from commit 8176902b17)
by MitchesD
---
Scripts/VioletHold: fixed non-pch build and codestyle
(cherry picked from commit e34f74dace)
by MitchesD
---
Scripts/VioletHold: Fix codestyle and unwanted crash in Violet/Hold
closes#14952 and #14953
(cherry picked from commit 49809bd404)
by mik1893
---
Scripts/VioletHold: fix a crash during Ichoron encounter
Closes#14962
(cherry picked from commit 7c01638d45)
by mik1893
---
Core/Misc: Fix build warnings
(cherry picked from commit 55681666b3)
Conflicts:
src/server/authserver/Main.cpp
by jackpoz
Fix Flame Leviathan instance lock not being granted to players because they were ejected from the vehicles as soon as boss died.
Players are now ejected some seconds later.
Close https://github.com/TrinityCore/TrinityCore/issues/15005
(cherry picked from commit b574c99549)
- removed some useless code (and some other random changes)
(cherry picked from commit 6680a7c331)
Conflicts:
src/server/scripts/Northrend/Nexus/EyeOfEternity/instance_eye_of_eternity.cpp
Fix doors opening/closing during Dreadscale fight by sending a CloseDoor command instead of toggling the door state when Dreadscale resets its movement.
Note that bounding the door state to boss movement makes poor sense and should be changed. Other bosses in ToC have this logic and should be updated if they show the same bug.
(cherry picked from commit b5cc8c5b17)
Fix crash in Violet Hold happening when crystals were activated without killing trash mobs.
Crash added in cba6515acb and f4531c5a58 .
Closes#14629
(cherry picked from commit 09aed25659)
