* Core/Pets: Pet management refactoring
* Preload basic pet data on character login with async query
* Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed
* Remove all select queries related to pet stable/unstable
* Remove all silent pet deletions except explicit UI-triggered abandons
* Fixed displaying stable master content when current pet is not summoned
* Allow to stable/swap unsummoned current pet
Closes#3610Closes#21266
(cherry picked from commit 5c1fc5e387)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter
* Scripts/HoR: Fix wrong emote during escape event
* Core/Unit: Make improve type safety of HandleEmoteCommand
Change argument type to the expected enum type Emote
* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE
UNIT_NPC_EMOTESTATE is no flag field
(cherry picked from commit 6c7837f947)
* Scripts/Comamnds: Improve ".debug objectcount" command
Include the top 5 most common creatures in the map
* Use C++ features to copy data
* Fix build warnings
* Update src/server/scripts/Commands/cs_debug.cpp
Co-authored-by: Shauren <shauren.trinity@gmail.com>
* Update src/server/scripts/Commands/cs_debug.cpp
Co-authored-by: Shauren <shauren.trinity@gmail.com>
* Update src/server/scripts/Commands/cs_debug.cpp
Co-authored-by: Shauren <shauren.trinity@gmail.com>
* Move CreatureCountWorker out of function and use template for unhandled cases
* Code cleanup
Co-authored-by: Shauren <shauren.trinity@gmail.com>
(cherry picked from commit bd5e832a64)
* Scripts/Naxxramas: Frogger event improvements
* Prevent Living Poison accumulation
* Now Living Poison cast Explode
* check for a nearby player
* move event to the frogger trigger's AI
* Initialize and removing unnecessary things
* applying suggestions
* remove unnecessary header
* Rename 9999_99_99_99_world.sql to 2020_08_05_00_world.sql
(cherry picked from commit 174ac95800)
Cast damage spell in AfterEffectApply instead OnEffectHitTarget. This avoids the scenario where we try to apply an aura to a potential dead target.
Ref #21856
(cherry picked from commit 0dd4b685df)
* Scripts/AzjolNerub: Update Anub'Arak to current coding standards
* no functional changes
* Scripts/AzjolNerub: Update Anub'Arak Darter to current coding standards
* no functional changes
* Scripts/AzjolNerub: Update Anub'Arak Assassin to current coding standards
* no functional changes
* Scripts/AzjolNerub: Update Anub'Arak Guardian to current coding standards
* no functional changes
* Scripts/AzjolNerub: Update Anub'Arak Venomancer to current coding standards
* no functional changes
* Scripts/AzjolNerub: Update Anub'Arak Impale Target to current coding standards
* Scripts/AzjolNerub: Update Anub'Arak Pound spell to current coding standards
* Scripts/AzjolNerub: Update Anub'Arak carrion beetles aura script to current coding standards
(cherry picked from commit dab8768c18)
* Scripts/Gundrak: Update Slad'Ran's script to use TaskScheduler
* No functional changes
* Scripts/Gundrak: Update Slad'Ran's adds to use TaskScheduler
* No functional changes
(cherry picked from commit 7abe9d66d0)
* Scripts/Gundrak: Update Drakkari Colossus to current coding standards
* no functional changes
* Scripts/Gundrak: Update Drakkari Elemental to current coding standards
* no functional changes
* Scripts/Gundrak: Update Living Mojo to current coding standards
* no functional changes
(cherry picked from commit dd8666f38d)
* Scripts/MoltenCore: Update Golemagg to current coding standards
* no functional changes
* Scripts/MoltenCore: Update Core Ranger to current coding standards
* no functional changes
(cherry picked from commit c88234727b)
* Scripts/Quest: Force of Neltharaku quest credit
**Description:**
Suggested solution to resolve the kill credit double cast issue
in the quest "The Force of Neltharaku" (10854).
by Rushor
**Changes proposed:**
- Remove duplicate spell casts in the zone quest script
- Remove commented-out script section
- Set a couple of unit flags (anim/stand/hover)
- Move return new creature script override to end of script
- Move PlayerGUID, FlyTimer, and Tapped to Private
- Add DB flight movement control to Enslaved Netherwing Drake
- Add SpellMgr MaxAffectedTargets = 1 for spell 38762
- Add movement enum POINT_MOVE_UP
- Add missing enum for quest ID
**Target branch(es):** 3.3.5/master
- [X] 3.3.5
- [X] master
**Issues addressed:** Closes#24796
**Tests performed:** (Does it build, tested in-game, etc.)
Pending for now.
**Known issues and TODO list:** (add/remove lines as needed)
- [X] Open PR in draft mode until testing is cleared
- [ ] Compile and create local server
- [ ] Test changes on local server
* Rename 9999_99_99_99_world.sql to 2020_07_29_00_world.sql
Co-authored-by: Rushor <Rushor@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit e0dae8feb6)
