Commit Graph

24755 Commits

Author SHA1 Message Date
Gustavo
5e5ca6c84a Core/Scripts: Boss Amanitar rewrite (#20283)
* Core/Scripts: Boss Amanitar rewrite

Fixes mushrooms behavior, correct and script his spell, size, spawn positions, despawn and respawn, and everything else
Fixes Mini spell cast(only re-cast if there is at least one person without the debuff)
Corrects boss initial position
Updates script register model

(cherry picked from commit 0b766db6a4)
2020-09-12 00:17:29 +02:00
Gustavo
e531beeb83 Core/Scripts: Boss Jedoga Shadowseeker rewrite (#20279)
* Core/Scripts: Boss Jedoga Shadowseeker rewrite

Added all missing spells and visuals
Added Twilight volunteers in the fight
Fixed Jedoga Controller's behavior, mostly moved to boss_prince_taldaram, where they belong
Updated script register model
Misc updates and improvements
Updated instance model

(cherry picked from commit f1ff7e642f)
2020-09-12 00:13:32 +02:00
Ovah
ed79d904e0 Core/GameObjects: trigger npcs that are summoned for gameobject casting will now inherit their gameobject's phase shift as well 2020-09-11 16:30:21 +02:00
Keader
a9ea939185 Core/Spells: Fixed Cloak of Shadows dispel (removed old hack)
Closes #8758
Serverside spell (35729) already handle with it

(cherry picked from commit c1b833a919)
2020-09-08 22:49:44 +02:00
Shauren
dd21e7ff40 Core/Spells: Implemented using base weapon damage in spell attack power formulas 2020-09-07 20:59:50 +02:00
sirikfoll
82764a71fc Core/Scripts: Minor fixes in boss Coren Direbrew
Update script register model
Fix number os Mole Machine spell targets
Fix Mole Machine timer
Fix minions summon

(cherry picked from commit 05a101881c)
2020-09-06 21:40:44 +02:00
Shauren
089fd5575d Core/Spells: Removed spellinfo corrections for non-existing spells 2020-09-06 15:39:28 +02:00
Shauren
b6ed0c7870 Core/PacketIO: Fixed ByteBuffer auto-flush after b231903932 2020-09-06 15:39:07 +02:00
Shauren
e3126ed8a6 Kill whitespace 2020-09-05 10:28:02 +02:00
Maks Szokalski
6812af37bb Core/Cosmetic: Execute OnStartup script hook before printing that startup is finished (#25401) 2020-09-05 10:25:09 +02:00
Shauren
b231903932 Core/Misc: Port all the refactors sneaked in master to 3.3.5 include cleanup port 2020-09-04 13:38:24 +02:00
Treeston
fe938b99f8 Core/Scripts: Implemented OnlyOnceAreaTriggerScript (#20288)
(cherry picked from commit 971ed856a4)
2020-08-29 00:41:22 +02:00
Treeston
77d13a7b97 Scripts/Patchwerk: Finally fix that crash for real. Closes #20247.
(cherry picked from commit 49daef4b77)
2020-08-29 00:19:04 +02:00
Keader
6210fc10ae Core/Handlers: Fixed changing equipment while charmed with equipament manager
Closes #20209
Followup: a1a12ec755

(cherry picked from commit 42be04898c)
2020-08-29 00:18:37 +02:00
Aokromes
8534c23dfe Core/Scripting: remove long time dead code
(cherry picked from commit 7ed36d353a)
2020-08-29 00:15:09 +02:00
Treeston
bece27ef3f Scripts/Naxxramas: Fix an edge case crash with people teleporting out of the dungeon during the Patchwerk encounter (tagging #20247)
(cherry picked from commit 50e8de103b)
2020-08-29 00:14:50 +02:00
Treeston
35e74687c3 Core/Player: More cleanups to Player::UpdateZone, including correcting an oversight that was causing the last known zone id to not update when leaving map. Closes #20289 for real this time.
(cherry picked from commit 47af704f63)
2020-08-23 23:25:35 +02:00
Shauren
9a76af8434 Fix build 2020-08-23 22:51:26 +02:00
Treeston
10b590acb6 Core/Player: Resequence Player::UpdateZone some more to hopefully prevent future edge cases like #20289 from occurring.
(cherry picked from commit 0f7015012b)
2020-08-23 22:37:03 +02:00
Treeston
8db10c67d7 Core/Player: Update map zone stats BEFORE invoking scripts. Fixes a crash with zone change scripts that invoke another zone change. Closes #20289.
(cherry picked from commit dbabcfbe24)
2020-08-23 22:36:00 +02:00
Treeston
4a909ada55 Scripts/Naxxramas: Missing nullptr check in Patchwerk. Closes #20247.
(cherry picked from commit c9ac68d6e3)
2020-08-23 19:02:57 +02:00
Treeston
fc12e47cb8 Core/Player: Prevent changing equipment while charmed. Closes #20209.
(cherry picked from commit a1a12ec755)
2020-08-23 19:02:30 +02:00
Keader
b3c6330a6e Core/Scripts: Auriaya rewrite (#20204)
(cherry picked from commit f67c6a5a12)
2020-08-23 18:59:36 +02:00
ccrs
debe97b77a Core/Movement: minor correction on WaypointMovementGenerator
remove the CanMove check since it will never trigger
the timer is left there to prevent errors on loading such as leader being created before the other members of the formation making them skip the first movement; purely a workaround

(cherry picked from commit c7d565739b)
2020-08-23 18:46:49 +02:00
Keader
68992bcd0d Core/Scripts: Removed wrong AddThreat call in Pursuit spellscript
followup 52ad0c9e5c
checked in sniffs, only ick add threat in target, wrong call in original script (why o keep it? o.o)

(cherry picked from commit f86b4e45e5)
2020-08-23 18:39:49 +02:00
ccrs
c065c5c774 Core: fix noPCH build v2.0
(cherry picked from commit 5f370a035c)
2020-08-23 18:02:32 +02:00
Carbenium
4e44bc6ea2 Core: Fix non-PCH build
(cherry picked from commit 45cb8c90e9)
2020-08-23 17:57:07 +02:00
Keader
d0a655de12 Core/Scripts: Typo fix
(cherry picked from commit 72aa03441f)
2020-08-23 17:49:42 +02:00
Keader
0537f3bd58 Core/Script: Krick and Ick, fixed spell Pursuit
Close #2261

(cherry picked from commit 52ad0c9e5c)
2020-08-23 17:48:07 +02:00
Treeston
06a1271a50 Core/Misc: random refactors
(cherry picked from commit 37dff2b7a1)
2020-08-23 17:47:41 +02:00
Treeston
27806eeac9 Core/Spawn: Move spawn group state management from sObjectMgr to the Map object, which makes it actually function as intended with instances. Woops.
(cherry picked from commit f279207d48)
2020-08-23 17:00:59 +02:00
ccrs
5d61618955 Scripts/AzjolNerub: minor corrections
ref #19072

(cherry picked from commit 80a8867332)
2020-08-23 16:25:25 +02:00
Treeston
67abc694e3 Scripts/AzjolNerub: Fix some duplicate summons after JustAppeared changes. Closes #20183.
(cherry picked from commit dcc3cd21e8)
2020-08-23 16:07:46 +02:00
Yehonal
ae4dacfd1d Core/Scripts: FOR_SCRIPTS macro shouldn't return early (#20187)
FOR_SCRIPTS, insteadof FOR_SCRIPTS_RET, shouldn't return
otherwise methods such as void ScriptMgr::OnPlayerEnterMap(Map* map, Player* player) will end prematurely

(cherry picked from commit 4ee16fb536)
2020-08-23 16:06:43 +02:00
Treeston
f97b601d93 Core/Creature: Fix an oversight in Creature::SelectVictim that was causing creatures to evade when chased by another creature from outside their own aggro range. Closes #19998.
(cherry picked from commit 1f57d1ac67)
2020-08-23 16:01:13 +02:00
ccrs
9a5e2b80b3 Core/Creature: regenerate health
There are three possible scenarios regarding regenerating health
- db lock and curhealth set to > 0
- db lock and curhealth set to 0
- dynamic lock (set in scripts and such) overriding db lock

(cherry picked from commit 91c0d49c18)
2020-08-23 15:56:21 +02:00
Treeston
22b754c9e2 Core/Creature: temporary summons are now dynamic flagged (oversight in dynspawn). This fixes issues with vehicle kit resets breaking AI.
Closes #20137 #20138 #20153.

(cherry picked from commit 92e9376e5e)
2020-08-23 14:52:51 +02:00
Treeston
2924ae0803 Scripts/Commands: .npc delete and .gobj delete now work while the specified guid is despawned. Fixes #20145.
(cherry picked from commit cac99beffd)
2020-08-23 14:47:48 +02:00
Treeston
88a61fa9d6 Scripts/Auchindoun: Fix a super edge case crash bug with GM far teleports during Blackheart's charm phase. Follow-up to d80d7c6.
(cherry picked from commit 165bc02889)
2020-08-23 14:47:29 +02:00
Keader
43f76c8cdd Core/Scripts: Updated Razorscale to new registers model
* More codestyle fixes
* Ty sirikfoll :)

(cherry picked from commit 76fc9ed635)
2020-08-23 14:44:29 +02:00
Keader
3df7e8b9fb Core/Razorscale: Codestyle Updates
* Removing spelldifficulty_dbc to make portable to master
* Updated to new Spell/Aurascript model

(cherry picked from commit 203c5f7058)
2020-08-23 14:39:20 +02:00
Foereaper
07e903a23d Scripts/Naxxramas: Fix Heigan the Unclean eruption event (#20129)
By scheduling the eruption event without cancelling the previously registered eruption events, Heigan's eruption (or dance) would overlap and cause a runaway scenario, where eruptions would not follow a proper timer.

By using Reschedule and not locking the Eruption event to the fighting phase, the dance now works as intended.

(cherry picked from commit 6f4492bc61)
2020-08-23 14:35:07 +02:00
Gustavo
e5963fda0e Core/Scripts: More fixes in boss Lich King (#20147)
* Core/Scripts: More fixes in boss Lich King

Fix Valkyr charge spell, they will no longer ignore Z position and become unreachable.
Correct height of Spirit Bomb and added the 3 seconds delay on his explosion.
Set the Trigger inside frostmourne room as active, to avoid problems with reseting the room, e.g: Spirit Bombs not despawning and Wicked Spirits stuck in evade.
Use correct InhabitType for Wicked and Vile Spirits, this avoid a situation where they could spawn falling.

(cherry picked from commit 22a7956069)
2020-08-23 01:20:27 +02:00
Demonid
fa762826e9 Scripts/Icecrown Citadel: Fixed Lord Marrowgar - Coldflame to not ignore resistances (#20146)
Closes #13240

(cherry picked from commit 7b747848ed)
2020-08-23 01:16:17 +02:00
ccrs
5e39572c06 Core/Movement: 7fff83d675 followup
since MOTION_SLOT_IDLE cannot be expired, signal path done and behave like IdleMotionGenerator

(cherry picked from commit eb2769996f)
2020-08-23 00:52:05 +02:00
ccrs
138edeb34e Core/AI: add missing checks on AssistPlayerInCombatAgainst
(cherry picked from commit ee5cbf28bc)
2020-08-23 00:49:53 +02:00
ccrs
e10018029d Core/SmatAI: correct MoveInLineOfSight
mistake introduced in 15f2706aca that was masqueraded by other checks in combat start, till recent related commits

(cherry picked from commit d117a0e4d4)
2020-08-23 00:49:36 +02:00
ccrs
0a133e77d6 Core/Movement: 7fff83d675 followup
remove home position set from creature PauseMovement, and use it when necessary
change log level on DelayedDelete

(cherry picked from commit cd4775420a)
2020-08-23 00:48:46 +02:00
sirikfoll
7586daad62 Core/Misc: Remove Whitespaces
(cherry picked from commit e2565c2597)
2020-08-23 00:48:19 +02:00
ccrs
97585597f0 Core/Movement: waypoint movement (#20121)
Following the work done in #19361 this is the cleanup and improvement of the related logic of waypoint management.

Ref 28050f3 #18020
(taking the good parts and ignoring the incomplete work)

(cherry picked from commit 7fff83d675)
2020-08-23 00:45:46 +02:00