Aokromes
cc1a520299
Core/Movement: Fix Warrior's Charge launch visual while jumping backw… ( #23243 )
...
* Core/Movement: Fix Warrior's Charge launch visual while jumping backwards
By Natureknight
* fix no-pch
2019-05-10 17:54:54 +02:00
Wyrserth
49dc8a8e44
Core/Quest: improve source item deletion logic for items that give quests ( #23250 )
...
* Core/Quest: improve source item deletion logic for items that give quests.
Prevent deletion of items that aren't supposed to be destroyed (like Demon Scarred Cloak).
* Whoops.
2019-05-10 17:49:46 +02:00
Keader
a639a99c6c
Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening quest
...
killer can be a pet
2019-05-08 21:12:56 -03:00
Demonid
d1c5b3c897
Scripts/Icecrown Citadel: The Lich King's Last Stand quest kill credit ( #23239 )
...
Closes #8919
2019-05-08 18:43:33 -03:00
Trond B. Krokli
1e97dfec53
Core/Spells: make Four Horsemen debuffs negative ( #23253 )
...
By Riztazz
Closes #23248
2019-05-08 15:42:54 -03:00
Killyana
ce562415ed
Spell/Script: Throw Torch must hit only one target
2019-05-07 21:36:29 +02:00
Wyrserth
b76bcc836c
Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. ( #23252 )
2019-05-07 19:49:25 +02:00
Wyrserth
0a25069db4
Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. ( #23249 )
2019-05-07 10:45:37 +02:00
Giacomo Pozzoni
06d8f4dc78
Core/Misc: Fix no-pch build
2019-05-07 09:41:44 +02:00
jackpoz
991b2a11bd
Core/Misc: Log Map name in asserts
2019-05-06 21:00:59 +02:00
jackpoz
4130384f2e
Core/Misc: Log Spell/Aura name in Spell/Auras asserts
2019-05-06 20:20:10 +02:00
jackpoz
6dae4a747d
Core/Vehicles: Fix accessories disappearing on reset
2019-05-05 17:20:10 +02:00
jackpoz
a76d01278a
Core/Misc: Apply fatigue when flying too
...
Fix #22856
2019-05-04 19:36:00 +02:00
Killyana
fe311260f7
Remove deprecated code
2019-05-04 16:52:59 +02:00
Killyana
fd166025c8
Remove Deprecated code
2019-05-04 16:11:50 +02:00
Giacomo Pozzoni
d4414af2d4
Core/Vehicles: Fix multiple vehicle join events on same seat ( #23233 )
2019-05-03 22:15:30 +02:00
Jozef Dúc
78070163dc
Core/Object: Range check vol. 2 ( #23226 )
...
* Core/Object: Fix all missing parts for #23062
* Update GameObject.cpp
2019-05-02 21:53:12 +02:00
sirikfoll
fe3bf57aba
Core/Scripts: Fix Skadi dismount issue
...
Closes #23005
2019-05-02 15:46:46 -03:00
Giacomo Pozzoni
20772dbf5d
Scripts/Spells: Fix implementation of #22332 ( #23228 )
...
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead
2019-05-02 14:34:23 +02:00
jackpoz
24fbbee4b9
Core/LFG: Remove dungeon cooldown when completing random dungeons
2019-05-01 18:37:39 +02:00
ccrs
69c15f5ae7
Core/Creature: couple refactors/renaming
2019-05-01 14:08:52 +02:00
Killyana
14445088ea
Quest/Script: Breakfast Of Champions
...
Set both Earthshaker Drum Events to 50%
2019-04-30 02:23:23 +02:00
ccrs
dfa54d3bf4
Core/Object: re-change faction template related logs
2019-04-29 22:48:45 +02:00
ccrs
aee26eb467
Core/Misc: standarize a couple logs
2019-04-28 19:41:30 +02:00
jackpoz
3f0ce98f7c
Core/Commands: Fix heap-use-after-free in ".ticket delete" command
...
Reported by Address Sanitizer
2019-04-28 18:56:45 +02:00
jackpoz
f45ebe71b0
Core/Misc: Fix *nix build
2019-04-28 18:53:01 +02:00
jackpoz
70fcdc687d
Core/Pet: Change assert to error log
...
Change assert added in 43dec9e4d0
2019-04-28 18:47:19 +02:00
jackpoz
37478c5ac1
Core/CrashHandler: Update placeholder text
2019-04-28 17:53:19 +02:00
jackpoz
25bcb1a0b2
Core/CrashHandler: Remove sensible data from crashlogs
2019-04-28 17:32:53 +02:00
Shauren
408d68717c
Core/Misc: Fixed -Wcast-function-type warning
2019-04-28 16:30:15 +02:00
jackpoz
26b6cb0584
Core/Misc: Fix some GCC 8 warnings
2019-04-28 15:59:34 +02:00
jackpoz
d910ffd779
Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ChaseMovementGenerator in 386b5a6fd9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned.
...
The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.
2019-04-28 14:50:33 +02:00
jackpoz
e3a9a9bfb2
Core/Scripts: Rename recent GameObject spell overloads to fix GCC warnings
...
Rename recent GameObject spell overloads (they used to accept only Unit as parameters) to fix GCC warnings about partial function override.
2019-04-27 23:48:39 +02:00
jackpoz
71d15ea25b
Scripts/Commands: Add .debug asan commands
...
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)
2019-04-27 20:11:48 +02:00
jackpoz
0d1ff7446d
Shared/Metric: Fix a rare memory leak
...
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread.
2019-04-27 17:18:13 +02:00
jackpoz
844e7ee926
Scripts/Guards: Fix infinite loop in npc_air_force_bots
...
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.
2019-04-27 16:32:41 +02:00
jackpoz
f26f716714
Core/Commands: Fix .cheat god command letting you die
...
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff
2019-04-27 14:40:28 +02:00
jackpoz
1c833f28e4
Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon()
...
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).
2019-04-27 13:57:46 +02:00
Killyana
56b65329e5
Core: Restore reset in EscortAI::InitializeAI ( #23197 )
...
Closes #23008
2019-04-25 17:57:54 +02:00
Jozef Dúc
32e1de39a2
Core/Object: Range check ( #23179 )
...
* Should solve #23062 . All credits to @xvwyh
* Remove unused variables
* Remove unused variable
* Cast int32 to uint32
* Remove G3D headers from core header file
* Change door distance
* Update GameObject.cpp
Add newline
* Update GameObject.h
Indentation
2019-04-24 20:39:01 +02:00
jackpoz
16a154c4e8
Core/GameObject: Code cleanup
2019-04-24 20:33:04 +02:00
Killyana
9db64666dc
Core/GameObject: Remove summoned gobs properly from the map without effecting other cases
...
Ref 0e8e3828f4#23115
2019-04-24 20:08:07 +02:00
ForesterDev
ae8750716f
Scripts/Commands: add some missing checks for .guild create command ( #23201 )
...
* Core/Conditions: implement CONDITION_GAMEMASTER
* Scripts/Commands: add some missing checks for .guild create command
2019-04-24 16:58:55 +02:00
Keader
f163c2f96a
Scripts/Trial of the Crusader: Fixed Resilience will Fix achievement
...
Broken by 2362e9c794
2019-04-24 11:55:58 -03:00
Killyana
21667f97cb
Indentation
2019-04-23 16:50:39 +02:00
Killyana
65afe47580
Indentation
2019-04-23 16:49:32 +02:00
Killyana
0e8e3828f4
Core/GameObject: Delete summoned gobs and DestroyForNearbyPlayers gobs spawned with negative spawn time once the gob is deactivated
2019-04-23 16:43:49 +02:00
Sorikoff
4468a538ff
Scripts/Scarlet Enclave: Unworthy Initiate ( #23195 )
2019-04-22 11:25:17 -03:00
Sorikoff
90d4254a87
Scripts: Minor improvements to recently migrated scripts ( #23189 )
...
Ref: 2cfaeb1400
2019-04-21 11:22:39 -03:00
Keader
961bc9d829
Scripts/Spells: Fixed a console error inspell_dru_lifebloom
...
Closes #23192
2019-04-21 11:01:59 -03:00
