Commit Graph

2522 Commits

Author SHA1 Message Date
Treeston
c13d83796f Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
(cherry picked from commit 0e7c66cb4c)
2021-12-17 00:23:33 +01:00
Wyrserth
96bca1fe2b Script/BoreanTundra: move Pile of Fake Furs' script (related to quest Unfit for Death) from ItemScript to SpellScript.
Closes #21890.

(cherry picked from commit e7cf24d263)
2021-12-16 21:20:39 +01:00
Treeston
eee950cdd7 Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
- Map::RemoveRespawnTime(SpawnObjectType, LowType, doRespawn) split into Map::Respawn and Map::RemoveRespawnTime, without the extra boolean
- Map::RemoveRespawnTime(RespawnInfo*) merged into Map::DeleteRespawnInfo(RespawnInfo*) and is now private
- Map::DeleteRespawnInfo(void) renamed to Map::UnloadAllRespawnInfos to properly describe what it does
- Map::ProcessRespawns now actually saves the delayed respawn time to DB if the respawn was delayed
- Map::AddRespawnInfo now takes const reference, and returns success as a boolean
- Map::AddRespawnInfo no longer offers an unused "replace" parameter
- Map::DeleteRespawnInfo no longer offers a variety of unused private overloads
- Map::SaveRespawnTime no longer offers a tantalizing writeDB parameter. Parameter is now called "startup" to properly describe what it does.
- Map::SaveRespawnInfoDB now takes RespawnInfo reference instead of all the various fields. Still public because compatibility mode. QQ.
- Map::GetWorldObjectBySpawnId sanitized
- Map::GetXRespawnTime methods sanitized to all go through Map::GetRespawnTime

(cherry picked from commit d60082ae86)
2021-12-16 01:33:09 +01:00
Treeston
fc9908d163 warning fix f2cd721 follow-up
(cherry picked from commit be96d8242c)
2021-12-15 00:17:32 +01:00
Treeston
9491650401 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026.
(cherry picked from commit f2cd721d53)
2021-12-15 00:17:32 +01:00
Wyrserth
569660a933 Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
Closes #19452.

(cherry picked from commit 37862942ce)
2021-12-14 22:13:56 +01:00
Gildor
e0f3255f90 Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy (#23559)
(cherry picked from commit a0a64b10b5)
2021-12-14 00:07:14 +01:00
Wyrserth
9cfa2ed71e Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
Closes #23337.

(cherry picked from commit a8b8a43b8d)
2021-12-13 00:42:20 +01:00
ccrs
2e4f38d949 Scripts/ICC: cleanup ReadSaveDataMore definition
(cherry picked from commit 4c398743b9)
2021-12-13 00:42:19 +01:00
ccrs
3bc4fc65b9 Scripts/ICC: 3dbf3fe followup
repeat timer typo

(cherry picked from commit b19a23a5c6)
2021-12-13 00:42:19 +01:00
ccrs
8be1927d31 Scripts/ICC: base support for Ymirjar Vrykuls AI
(cherry picked from commit 3dbf3fed7c)
2021-12-13 00:42:19 +01:00
ccrs
9d84b56df1 Scripts/ICC: 1eb2aef followup
(cherry picked from commit 3e9b553618)
2021-12-13 00:42:19 +01:00
ccrs
bb321ccb02 Scripts/ICC: move Sister Svalna to her own file
I've almost guttered her, so lets try it more gently this time

(cherry picked from commit 1eb2aef179)
2021-12-13 00:42:19 +01:00
ccrs
5e3ba5e96f Scripts/ICC: 94b60ff followup
(cherry picked from commit eb6ea57e7f)
2021-12-13 00:42:19 +01:00
ccrs
70fd6e7398 Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling
(cherry picked from commit 22b3b21ae3)
2021-12-13 00:42:18 +01:00
ccrs
cadbf42ea4 Misc: some corrections after recent merges
(cherry picked from commit 626a24822b)
2021-12-13 00:42:18 +01:00
Sorikoff
7b08125c23 Scripts/Spells: Remove Collapsing Cave Aura (#23533)
* Scripts/Spells: Remove Collapsing Cave Aura

* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql

(cherry picked from commit 8d1a5fa126)
2021-12-13 00:42:18 +01:00
jackpoz
841630fcc3 Core/Misc: Fix static analysis issues reported by Coverity Scan
(cherry picked from commit de88691e25)
2021-12-13 00:42:18 +01:00
Sorikoff
88457030cc Scripts/Spells: Deathbolt (#23531)
* Scripts/Spells: Deathbolt

* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql

(cherry picked from commit 62b2c379b3)
2021-12-13 00:42:18 +01:00
Keader
adc16ffbdc Script/FoS: prevent Wailing Souls from becoming desynched in the Devourer of Souls encounter.
(cherry picked from commit 079b77b5fc)
2021-12-13 00:42:17 +01:00
Shauren
9951b53808 Core/Misc: Fixed some gcc warnings 2021-12-12 19:19:15 +01:00
ccrs
a4da12119e Scripts/Misc: couple corrections to the recent PRs
(cherry picked from commit 4a8736b829)
2021-12-12 02:16:01 +01:00
Treeston
38d7c1530a Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490.
(cherry picked from commit 1158f267df)
2021-12-12 02:09:15 +01:00
Sorikoff
aa407adf3e Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster (#23456)
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster

* Fix NoPCH

* Correct header

* fixup! Clean up

* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql

(cherry picked from commit 40b09e3df1)
2021-12-11 22:58:16 +01:00
Keader
ba606753bd Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
Followup: 394b119664
(cherry picked from commit 3b0743ea67)
(cherry picked from commit f9a366628a)
2021-12-11 21:37:53 +01:00
Keader
b3493935b6 Core/Scripts: Fixed a reference error introduced in 394b119664
(cherry picked from commit 70cbedd75d)
2021-12-11 14:56:14 +01:00
Keader
f749b3a2e9 Scripts/Icecrown Citadel: Fixed Blood Orb Game Object (#23397)
Close #18005 and Update #18529

(cherry picked from commit 394b119664)
2021-12-11 14:55:18 +01:00
Keader
42ad1b86a1 Core/Misc: Implemented Icecrown Citadel buff disable (#23394)
Closes #8576
Closes #7940

(cherry picked from commit 94b60ff0ef)
2021-12-11 11:59:54 +01:00
Keader
79d4a0f8aa Scripts/Icecrown Citadel: Fixed Heroic Attempts logic (#23379)
(cherry picked from commit 136964769d)
2021-12-11 01:27:48 +01:00
Wyrserth
88d5b91c05 Script/Dalaran: don't allow Dalaran faction guards to teleport a player that has the Trespasser! debuff. (#23373)
(cherry picked from commit 5016f588d5)
2021-12-10 22:47:33 +01:00
Wyrserth
db6fdef3d7 Script/Quest: implement event for the quest Orabus the Helmsman (#23346)
* Script/Quest: implement event for the quest Orabus the Helmsman.

Thanks Wyreth for the original script.

* Fix coordinates that I inverted by mistake.

* Rename 9999_99_99_99_world.sql to 2019_06_04_04_world.sql

(cherry picked from commit b5e04c8920)
2021-12-10 21:38:27 +01:00
Wyrserth
b6d28b5497 Script/GunDrak: fix order for yell and altar texts on death for two bosses (#23357)
(cherry picked from commit 65aea13c25)
2021-12-10 21:16:10 +01:00
Wyrserth
647893597c Script/Creature: implement spell effect for the item Prototype Neural Needler used on Imprisoned Beryl Sorcerer (#23349)
* Script/Creature: implement spell effect for the item Prototype Neural Needler used on Imprisoned Beryl Sorcerer.

* Rename 9999_99_99_99_world.sql to 2019_06_03_02_world.sql

(cherry picked from commit eb5d1d3248)
2021-12-10 21:15:56 +01:00
jackpoz
363f385fc0 Scripts/HallsOfLightning: Fix Volkhan spamming in chat when wiping at 10% health
Ref #23082

(cherry picked from commit 2d5387ea42)
2021-12-09 00:32:32 +01:00
Wyrserth
9d865f7536 Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura (#23319)
* Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura.

* Forgot to change this in last-second rename.

* Apply suggested changes, thanks Shauren!

(cherry picked from commit 8bc5451864)
2021-12-09 00:13:59 +01:00
lactoseti
6b2e40257a Creature/Script: npc_tallhorn_stag
Ref #2623

(cherry picked from commit bfffa5d45e)
2021-12-08 23:20:51 +01:00
Giacomo Pozzoni
5f545f5402 3.3.5 gameobject summoner (#23289)
* Scripts/Misc: Change IsSummonedBy(Unit*) to IsSummonedBy(WorldObject*)

* Scripts/Misc: Fix build

* Core/TempSummons: Rename GetSummoner() to GetSummonerUnit()

* Core/TempSummons: Add support to TempSummons::GetSummoner() to return GameObject too

* Fix build

* Core/TempSummons: Allow GameObject to be owner of TempSummon

* Core/TempSummons: Add support to SAI for GameObject owner of TempSummon

* Scripts/Misc: Fix no-pch build

* Core/TempSummons: Implement PR comments

(cherry picked from commit 797fba98e9)
2021-12-07 00:02:03 +01:00
ccrs
6efb8d2d22 Scripts/Northrend: couple cosmetic corrections after 552720a
(cherry picked from commit 7025b00656)
2021-12-05 16:02:29 +01:00
Wyreth
40ec90e1f5 Scripts/Northrend: improvements for quest Get Me Outa Here! (11673) (#20753)
* Script/Quest: improvements for quest Get Me Outa Here! (11673).

* Happiness for our Travis overlord

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update zone_borean_tundra.cpp

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Fix hook that got renamed

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Rename 9999_99_99_99_world_quest_get_me_outa_here.sql to 2019_05_11_08_world.sql

(cherry picked from commit 552720a993)
2021-12-05 15:15:52 +01:00
Keader
0b7089a7d1 Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening quest
killer can be a pet

(cherry picked from commit a639a99c6c)
2021-12-04 00:37:17 +01:00
Demonid
f981b15389 Scripts/Icecrown Citadel: The Lich King's Last Stand quest kill credit (#23239)
Closes #8919

(cherry picked from commit d1c5b3c897)
2021-12-04 00:31:32 +01:00
sirikfoll
03e03f3fc6 Core/Scripts: Fix Skadi dismount issue
Closes #23005

(cherry picked from commit fe3bf57aba)
2021-12-02 23:51:51 +01:00
Giacomo Pozzoni
46170fdf01 Scripts/Spells: Fix implementation of #22332 (#23228)
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead

(cherry picked from commit 20772dbf5d)
2021-12-02 23:46:00 +01:00
jackpoz
cf979de813 Core/Misc: Fix some GCC 8 warnings
(cherry picked from commit 26b6cb0584)
2021-12-02 00:39:28 +01:00
Keader
93a9ee9c12 Scripts/Trial of the Crusader: Fixed Resilience will Fix achievement
Broken by 2362e9c794

(cherry picked from commit f163c2f96a)
2021-12-02 00:39:20 +01:00
Killyana
f98e82103f Spell/Script: Kill logs spam for spell_ioc_parachute_ic
Closes #23163

(cherry picked from commit c318b3e16d)
2021-11-30 22:41:16 +01:00
jackpoz
721f4c6032 Core/Misc: Fix static analysis issues
Fix static analysis issues spotted by Coverity Scan

(cherry picked from commit 750d89beed)
2021-11-24 23:45:36 +01:00
jackpoz
43a41caafb Core/Misc: Fix GCC 8 warnings
(cherry picked from commit 1d04a3b216)
2021-11-24 23:40:15 +01:00
Trond B. Krokli
36feb3bfe7 Scripts/Borean Tundra: link gossip content for NPC Iruk from DB (#23118)
- remove hardcoded text (deprecated method)
- add already existing DB gossip content to enum
- correct spell enum from spell_creature_ to spell_create_
- replace case switch with if statement (only one boolean case)

Extra script file update:
- remove SD comment line 22 (outdated info, replaced by SAI)

(cherry picked from commit 7cb31aa482)
2021-11-24 22:26:05 +01:00
ccrs
67e0b25739 Scripts/Northrend: 482e0da followup
add a little bit of tolerance

(cherry picked from commit a006362615)
2021-11-24 20:35:19 +01:00