Commit Graph

5465 Commits

Author SHA1 Message Date
Jinnaix
e3aa87641f Scripts/BlackrockSpire: Fix encage event of Pyroguard encounter (#25177) 2020-07-31 13:58:26 +02:00
Somebody
81f3ed1d0c Scripts/Deadmines: Doors after Rhahk'Zor, Sneed and Gilnid (#25107)
* Fix doors opening after killing Sneed and Gilnid in the Deadmines dungeon

* Add SQL file

* Update 2020_99_99_00_world.sql

SQL conventions

* Change SAI door opening into C++ door opening and make it use SetBossState.

* Delete 2020_99_99_00_world.sql

Replaced by different sql file

* Make CircleCI happy

* Change const to constexpr for EncounterCount variable

* Update src/server/scripts/EasternKingdoms/Deadmines/deadmines.h

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>

* Update src/server/scripts/EasternKingdoms/Deadmines/deadmines.h

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>

* Rename 9999_99_99_00_world.sql to 2020_07_30_00_world.sql

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-07-30 14:14:08 +02:00
Trond B. Krokli
e0dae8feb6 Scripts/Quest: Force of Neltharaku quest credit (#24807)
* Scripts/Quest: Force of Neltharaku quest credit

**Description:**

Suggested solution to resolve the kill credit double cast issue
in the quest "The Force of Neltharaku" (10854).

by Rushor

**Changes proposed:**

- Remove duplicate spell casts in the zone quest script
- Remove commented-out script section
- Set a couple of unit flags (anim/stand/hover)
- Move return new creature script override to end of script
- Move PlayerGUID, FlyTimer, and Tapped to Private
- Add DB flight movement control to Enslaved Netherwing Drake
- Add SpellMgr MaxAffectedTargets = 1 for spell 38762
- Add movement enum POINT_MOVE_UP
- Add missing enum for quest ID

**Target branch(es):** 3.3.5/master

- [X] 3.3.5
- [X] master

**Issues addressed:** Closes #24796

**Tests performed:** (Does it build, tested in-game, etc.)

Pending for now.

**Known issues and TODO list:** (add/remove lines as needed)

- [X] Open PR in draft mode until testing is cleared
- [ ] Compile and create local server
- [ ] Test changes on local server

* Rename 9999_99_99_99_world.sql to 2020_07_29_00_world.sql

Co-authored-by: Rushor <Rushor@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-07-29 13:26:39 +02:00
Carbenium
1245833cdd Core/CreatureAI: std::chrono-ify DoSummon* methods 2020-07-28 17:25:51 +02:00
Carbenium
8642aaaf92 Core/WorldObject: Replace non-std::chrono SummonGameObject overloads
Also fix intended despawn time of GOs used by the "Engineering a Disaster" quest
2020-07-27 23:00:51 +02:00
Carbenium
3620b47c41 Core/WorldObject: Replace non-std::chrono SummonTrigger overloads 2020-07-27 14:58:18 +02:00
Carbenium
a41f599be7 Core/WorldObject: Remove non-std::chrono SummonCreature overload
Remove
TempSummon* SummonCreature(uint32 entry, Position const& pos, TempSummonType despawnType = TEMPSUMMON_MANUAL_DESPAWN, uint32 despawnTime = 0, uint32 vehId = 0, uint32 spellId = 0);
2020-07-27 14:53:25 +02:00
Carbenium
480dee3125 Core/Creature: Remove non-std::chrono overload of DespawnOrUnsummon 2020-07-27 13:37:18 +02:00
Carbenium
1d8782e356 Core/EventProcessor: std::chrono-ify the remaining public API 2020-07-27 13:36:25 +02:00
Carbenium
92a02a5c87 Core/EventProcessor: std::chrono-ify CalculateTime
uint64 CalculateTime(uint64 t_offset) has been replaced with Milliseconds CalculateTime(Milliseconds t_offset).
Also add the std::chrono-ified overload void AddEvent(BasicEvent*, Milliseconds, bool)
2020-07-27 13:36:25 +02:00
Carbenium
1131229ee9 Core/WorldObject: Partially std::chrono-ify SummonCreature overloads
TempSummon* SummonCreature(uint32 entry, float x, float y, float z, float o = 0, TempSummonType despawnType = TEMPSUMMON_MANUAL_DESPAWN, uint32 despawnTime = 0);
to
TempSummon* SummonCreature(uint32 entry, float x, float y, float z, float o = 0, TempSummonType despawnType = TEMPSUMMON_MANUAL_DESPAWN, Milliseconds despawnTime = 0s);
2020-07-26 23:30:32 +02:00
Carbenium
8cb35b0d5f EventMap: Change GetTimeUntilEvent to return std::chrono types 2020-07-26 23:20:11 +02:00
Carbenium
40efda9726 Scripts/Kalimdor: Use std::chrono overload of Creature::DespawnOrUnsummon 2020-07-26 22:23:51 +02:00
Carbenium
5832790428 Scripts/World+Outland+Spells: Use std::chrono overload of Creature::DespawnOrUnsummon 2020-07-26 22:21:59 +02:00
Carbenium
fc9e7226c0 Scripts/Northrend: Use std::chrono overload of Creature::DespawnOrUnsummon 2020-07-26 22:21:09 +02:00
Carbenium
d1a39a2ebf Scripts/EasternKingdoms: Use std::chrono overload of Creature::DespawnOrUnsummon 2020-07-26 22:12:24 +02:00
Treeston
210176fd91 Core/Authserver: Authserver cleanup (PR#25093)
- Fix a handful of 1/256 bugs with most significant byte zero in BigNumber
- Get rid of (most of) the C-style arrays in authserver
- CryptoRandom as a unified source for cryptographic randomness
- Bring our other crypto APIs into 2020
- BigNumber usability improvements
- Authserver is now actually readable as a result of all of the above
2020-07-26 01:53:34 +02:00
Carbenium
cdaf890af4 Core/EscortAI: std::chrono-ify SetPauseTimer 2020-07-25 23:45:01 +02:00
Carbenium
4b9fdc5d3d Core/EscortAI: std::chrono-ify AddWaypoint 2020-07-25 23:45:01 +02:00
Carbenium
f5076112cb Core/ScriptedAI: std::chrono-ify DoSpawnCreature 2020-07-25 23:16:04 +02:00
Carbenium
27229c10cd Core/BossAI: Remove _DespawnAtEvade(uint32, Creature*) overload
Use _DespawnAtEvade(Seconds,  Creature*) instead
2020-07-25 23:11:10 +02:00
Carbenium
d7ff8c272a Core/InstanceScript: std::chrono-ify DoRespawnGameObject 2020-07-25 23:10:14 +02:00
Trond B. Krokli
ebb9e1b4de Scripts/Borean Tundra: duplicate comment text (#25102) 2020-07-24 13:11:48 +02:00
Giacomo Pozzoni
3c0ac7302f Core/Metric: Add more metrics about World::Update() loop (#25098)
* Core/Metric: Add more metrics about World::Update() loop

* Add new Performance profiling grafana dashboard

* Add new cmake setting WITHOUT_METRICS that disables all metrics

As new metrics are added, someone might want to disable them if unused.

* Add more metrics about World::Update() loop

* Remove old performance profiling features

Remove "server set difftime" command, "-RecordUpdateTimeDiffInterval" and "MinRecordUpdateTimeDiff" worldserver config settings and their related code.
The whole UpdateTime class could be removed too.

* Update and rename 2020_07_99_99_world.sql to 2020_07_24_00_world.sql
2020-07-24 00:30:16 +02:00
Carbenium
f1f251eb38 Core/Scripts: Fix timing issue of EVENT_FLY_TO_RANDOM_PILLAR during Illidan encounter
The intention here is to add additional 30 seconds of delay to the current delay of EVENT_FLY_TO_RANDOM_PILLAR.
Instead of EventMap::GetNextEventTime, EventMap::GetTimeUntilEvent has to be used which returns the currently
scheduled delay until the event occurs.
EventMap::GetNextEventTime instead exposes the timer value internal to EventMap at which the event should occur.
2020-07-22 01:19:59 +02:00
Peter Keresztes Schmidt
e6e5775be8 Build: Enable -Wimplicit-fallthrough on clang (#25056)
* Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs

Related: #25006

* Misc: Add some missing breaks (no-ops) to satisfy clang

Related: #25006
Closes #25055

* Build: Enable -Wimplicit-fallthrough on clang

Closes #25006
2020-07-18 20:43:16 +02:00
Peter Keresztes Schmidt
85b5b842ca Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs (#25054)
Related: #25006
2020-07-18 20:42:28 +02:00
Giacomo Pozzoni
7032ee0bdb Core/Misc: Replace boost::shared_mutex with std::shared_mutex (#24328)
* Core/Misc: Replace boost::shared_mutex with std::shared_mutex

* Remove std forward declarations
2020-07-18 18:34:45 +02:00
Treeston
896b68d5c2 Core/Time: Rename GetGameTime{System, Steady}Point methods
The names are a bit unhandy. Rename them (shorter but still meaningful).

GetGameTimeSystemPoint() -> GetSystemTime()
GetGameTimeSteadyPoint() -> Now()

Also add 2 new typedefs:

typedef std::chrono::steady_clock::time_point TimePoint;
typedef std::chrono::system_clock::time_point SystemTimePoint;

Closes #25042
2020-07-17 17:05:55 +02:00
Peter Keresztes Schmidt
ddf16ae4d9 Misc: Remove some unneeded/duplicated includes (#25051) 2020-07-16 14:14:01 +02:00
Peter Keresztes Schmidt
202fd41389 Core/Misc: Replace boost::optional with std::optional (#25047)
C++17 is already mandatory, so it's a safe thing to do
2020-07-15 10:22:29 +02:00
Peter Keresztes Schmidt
0072fa922d Scripts/World+Pet: Use std::chrono::duration overloads of EventMap (#25017)
Contributes to #25012
2020-07-14 21:15:15 +02:00
Peter Keresztes Schmidt
6968e7a1a1 Scripts/Icecrown Citadel: Use std::chrono::duration overloads of EventMap (Part 2) (#25041)
Part 2: gunship battle and Sindragosa

Contributes to https://github.com/TrinityCore/TrinityCore/issues/25012
2020-07-14 21:06:40 +02:00
Peter Keresztes Schmidt
5eaff8a3bc Scripts/Icecrown Citadel: Use std::chrono::duration overloads of EventMap (#25036)
Part 1: without gunship battle and Sindragosa

Contributes to #25012
2020-07-14 21:03:06 +02:00
Peter Keresztes Schmidt
2d9c5979a6 Scripts/Tempest Keep: Use std::chrono::duration overloads of EventMap (#25040)
Contributes to #25012
2020-07-14 20:50:37 +02:00
Peter Keresztes Schmidt
f00ab389d6 Scripts/Utgarde Keep: Use std::chrono::duration overloads of EventMap (#25039)
Contributes to #25012
2020-07-14 20:48:08 +02:00
Peter Keresztes Schmidt
88314660b6 Scripts/Magisters Terrace: Use std::chrono::duration overloads of EventMap (#25038)
Contributes to #25012
2020-07-14 20:47:10 +02:00
Peter Keresztes Schmidt
d4bce9f4d2 Scripts/Ulduar: Use std::chrono::duration overloads of EventMap (#25035)
Contributes to #25012
2020-07-14 20:43:43 +02:00
Peter Keresztes Schmidt
2f538258d9 Scripts/Nexus: Use std::chrono::duration overloads of EventMap (#25033)
Contributes to #25012
2020-07-14 20:23:24 +02:00
Peter Keresztes Schmidt
6eec0bc50f Scripts/Naxxramas: Use std::chrono::duration overloads of EventMap (#25032)
Contributes to #25012
2020-07-14 20:19:42 +02:00
Peter Keresztes Schmidt
1a32b0f5b3 Scripts/Isle of Conquest: Use std::chrono::duration overloads of EventMap (#25031)
Contributes to #25012
2020-07-14 20:19:25 +02:00
Peter Keresztes Schmidt
3a9b3259b8 Scripts/Gundrak: Use std::chrono::duration overloads of EventMap (#25030)
Contributes to #25012
2020-07-14 20:17:59 +02:00
Peter Keresztes Schmidt
19ee4d6254 Scripts/Frozen Halls: Use std::chrono::duration overloads of EventMap (#25029)
Contributes to #25012
2020-07-14 20:16:01 +02:00
Peter Keresztes Schmidt
65e01053a8 Scripts/Drak'Tharon Keep: Use std::chrono::duration overloads of EventMap (#25028)
Contributes to #25012
2020-07-14 20:04:10 +02:00
Peter Keresztes Schmidt
42102871a7 Scripts/Chamber of Aspects: Use std::chrono::duration overloads of EventMap (#25027)
Contributes to #25012
2020-07-14 20:03:33 +02:00
Peter Keresztes Schmidt
5ed6c6a5c3 Scripts/Coilfang Reservoir: Use std::chrono::duration overloads of EventMap (#25025)
Contributes to #25012
2020-07-14 19:49:47 +02:00
Peter Keresztes Schmidt
d00c95f26f Scripts/Hellfire Citadel: Use std::chrono::duration overloads of EventMap (#25024)
Contributes to #25012
2020-07-14 19:49:12 +02:00
Peter Keresztes Schmidt
1c3187e596 Scripts/Azjol-Nerub: Use std::chrono::duration overloads of EventMap (#25026)
Contributes to #25012
2020-07-14 19:48:24 +02:00
Shauren
7e5cf40d4c Scripts/Mana Tombs: Fix Pandemonious Dark Shell event delay 2020-07-14 19:39:29 +02:00
Peter Keresztes Schmidt
4ad80434a2 Scripts/Auchindoun: Use std::chrono::duration overloads of EventMap (#25023)
Contributes to #25012
2020-07-14 19:37:51 +02:00