ccrs
eda6e5c316
Script/CoS: full instance rewrite ( #23388 )
...
(cherry picked from commit ca62280675 )
2021-12-13 00:42:16 +01:00
Wyrserth
e8c1adcf8f
Core/SAI: silence wrong SAI error when using SMART_ACTION_SET_DATA on a creature using CreatureAI.
...
This behavior is fully allowed and should not report any kind of error.
(cherry picked from commit c95531595e )
2021-12-13 00:42:16 +01:00
Shauren
54f607641a
Core/Spells: Moved SpellVisual functions from Unit to WorldObject
2021-12-12 19:34:00 +01:00
Shauren
f61de627e5
Core/Commands: Fixed crash in .npc showloot
2021-12-12 19:19:29 +01:00
Shauren
9951b53808
Core/Misc: Fixed some gcc warnings
2021-12-12 19:19:15 +01:00
Meji
1a84641549
Core/BattlePets: Added default cooldown to revive battle pets ( #27383 )
...
* Added SpellHistory function to retrieve remaining category cooldown
* Changed SpellHistory::ModifySpellCooldown to allow adjusting only regular spell cooldown without touching category
2021-12-12 18:35:15 +01:00
Shauren
1c00109756
Core/Creatures: Fixed crash in CreatureAI::JustAppeared caused by scripted summons without SummonProperties
...
Closes #23507
(cherry picked from commit c0b25c9a83 )
2021-12-12 02:20:42 +01:00
ccrs
4747debed1
Core/Player: 72fc79a followup
...
safer approach, please report any returning issue
(cherry picked from commit 337de2b61e )
2021-12-12 02:16:42 +01:00
ccrs
a4da12119e
Scripts/Misc: couple corrections to the recent PRs
...
(cherry picked from commit 4a8736b829 )
2021-12-12 02:16:01 +01:00
ccrs
f4a71ea9aa
Core/AI: remove extra empty line
...
(cherry picked from commit 3c77c04b05 )
2021-12-12 02:15:10 +01:00
ccrs
d7e544e816
Core/AI: minimize further undesired behaviours ( e3e4b97 followup)
...
Those Category checks come from checking all Spell::SummonGuardian uses
(cherry picked from commit ebd438883e )
2021-12-12 02:15:00 +01:00
Treeston
007eb8c931
AI/TotemAI: Tell Shaman Totems to stay put and stop moving. Closes #23498 .
...
(cherry picked from commit e3e4b975ce )
2021-12-12 02:13:19 +01:00
Treeston
743d022cee
AI/SmartAI: Properly forward to inherited CreatureAI::JustAppeared in SmartAI::JustAppeared. Fixes #23491 .
...
(cherry picked from commit 854a113fc7 )
2021-12-12 02:11:15 +01:00
Treeston
38d7c1530a
Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490 .
...
(cherry picked from commit 1158f267df )
2021-12-12 02:09:15 +01:00
Treeston
e398bb1664
AI/SmartAI: Move SMART_EVENT_RESPAWN invocation from ::InitializeAI() to ::JustAppeared(). Closes #23313 .
...
(cherry picked from commit 37fc38b917 )
2021-12-12 01:27:04 +01:00
Treeston
9f7d3ebd6a
Core/AI: Remove EnterEvadeMode calls from Guardian/Summon spell handlers. Add follow logic to CreatureAI::JustAppeared. Closes #23270 .
...
(cherry picked from commit 8499434340 )
2021-12-12 01:27:04 +01:00
Treeston
f9b8fe686d
Entities/Unit: Adjust an overzealous assert to not catch self references, and add the inverse assert too. 396f87c follow-up.
...
(cherry picked from commit aeed616c22 )
2021-12-12 01:27:04 +01:00
Treeston
d10554da14
Entities/Unit: Fix an issue where Unit pointers could be left dangling if a channeled Charm was interrupted by a control aura application. Closes #23440 .
...
(cherry picked from commit f4b06fd0b7 )
2021-12-12 01:27:04 +01:00
Treeston
edc7583119
Entities/Unit: Cleanup all the direct accesses to m_unitMovedByMe. Refactor the field to be protected. Add assertions to catch dangling pointers.
...
(cherry picked from commit 396f87c30d )
2021-12-12 01:26:41 +01:00
Treeston
06823f19cd
Core/Misc: Add static versions of GetGUID and ToX methods to Object. The static versions return Empty/nullptr for null objects.
...
(cherry picked from commit b3ee407707 )
2021-12-12 00:46:03 +01:00
Treeston
f29644efd5
some more cleanup, a5f8c0d follow-up
...
(cherry picked from commit 00728cef15 )
2021-12-12 00:33:36 +01:00
Treeston
e3411b4740
Core/Creature: Attach out-of-combat health regen to the Engaged system, not the Combat flag. Closes #21571 .
...
(cherry picked from commit a5f8c0d30c )
2021-12-12 00:33:23 +01:00
Treeston
dabdad3b47
Core/Misc: Rename Unit::AttackedTarget to Unit::AtTargetAttacked to match naming scheme for these notifiers
...
(cherry picked from commit 632a300dd2 )
2021-12-12 00:33:18 +01:00
Treeston
35e55f1089
Core/Entities: Kick engagement logic upstairs to Unit (from ThreatManager), since all Units with AI need it (not just those with threat list). Fixes #17981 .
...
(cherry picked from commit dbe3bbefe7 )
2021-12-12 00:31:15 +01:00
jackpoz
dd22c6fe67
Core/Misc: Code cleanup
...
(cherry picked from commit eeced9ae15 )
2021-12-11 23:20:05 +01:00
zartech22
1c3c59d7fa
Core/Instance : Fix instance resetting exploit ( #23263 )
...
* Push offline players out of instance
Push offline players out of instance when reseting dungeon with a raid mode group
* Add SQL request to character
Add a SQL request to update the position of a player in a specified map
* Teleport to graveyard instead
(cherry picked from commit 678e0e606a )
2021-12-11 23:12:27 +01:00
Sorikoff
799fba7fd1
Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind ( #23463 )
...
* Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind
* Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind"
This reverts commit a8055960
* Revert "Revert "Scripts/Spells: Portal to Orgrimmar & Portal to Stormwind""
This reverts commit a5be792b
* Fix NoPCH
* Clean up
* Clean up
* fixup! Clean up
* Caster -> Target
* Rename 9999_99_99_99_world.sql to 2019_06_22_01_world.sql
(cherry picked from commit ac7c72d633 )
2021-12-11 23:01:46 +01:00
Sorikoff
aa407adf3e
Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster ( #23456 )
...
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster
* Fix NoPCH
* Correct header
* fixup! Clean up
* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql
(cherry picked from commit 40b09e3df1 )
2021-12-11 22:58:16 +01:00
Wyrserth
b709ea9a8d
Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts ( #23459 )
...
* Core/RBAC: add permission that prevents accounts from earning all achievements or only realm firsts.
* Kill evil spaces.
* Rename 9999_99_99_99_auth.sql to 2019_06_21_00_auth.sql
* Update auth_database.sql
(cherry picked from commit 8163ea60c8 )
2021-12-11 22:47:08 +01:00
Sorikoff
8fc52bc5e5
Scripts/Spells: Migrate Teleporting to Script ( #23458 )
...
* Scripts/Spells: Migrate Teleporting to Script
* Rename 9999_99_99_99_world.sql to 2019_06_21_02_world.sql
(cherry picked from commit e9d803ccee )
2021-12-11 22:28:55 +01:00
Shauren
4595e63dd7
Core/Spells: Deleted old script (partial port of a4cd4d8b87)
2021-12-11 21:40:30 +01:00
Keader
ba606753bd
Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
...
Followup: 394b119664
(cherry picked from commit 3b0743ea67 )
(cherry picked from commit f9a366628a )
2021-12-11 21:37:53 +01:00
Killyana
2aca19a079
DB/Quest: "Where Kings Walk" and "Warchief's Blessing"
...
The script was deleted by 5f928f7949 But it wasn't done properly via the spell_area anyway
(cherry picked from commit 8d6295559d )
2021-12-11 21:34:48 +01:00
Killyana
0993b491dd
DB/Quest: A Visit With The Ancestors
...
Closes #23284
(cherry picked from commit a3dec9068b )
2021-12-11 16:32:05 +01:00
Wyrserth
07dcb28f80
Spell/Fishing: ensure that the fishing bobber expires when the Fishing channeling ends, and don't allow fish to be hooked in the instant the spell is cast. ( #23448 )
...
(cherry picked from commit 9083fc149d )
2021-12-11 16:18:57 +01:00
Wyrserth
bfef73b510
Core/Loot: don't allow to regenerate chest loot inside instances and raids. ( #23449 )
...
(cherry picked from commit 4320cd7d37 )
2021-12-11 16:18:41 +01:00
Shauren
3d3d255a47
Core/Conditions: Sync CONDITION_QUEST_OBJECTIVE_PROGRESS implementation with 3.3.5
2021-12-11 16:13:45 +01:00
Wyrserth
a032d84cf4
Core/FlightPath: teleport players at destination on floor Z when the flight ends ( #23428 )
...
* Core/FlightPath: teleport players at destination on floor Z when the flight ends, instead of having them fall from the air.
Closes #10051 .
* Use the path destination's mapheight instead of the player position's.
* Update FlightPathMovementGenerator.cpp
(cherry picked from commit 6a0a800535 )
2021-12-11 16:05:31 +01:00
Wyrserth
5331656785
Core/SAI: allow to start waypoint movement for a creature that is in combat. ( #23426 )
...
(cherry picked from commit d6e3660115 )
2021-12-11 15:29:32 +01:00
DanVS
f15bcebdbe
Core/Spell: Jump Speed Calculations ( #22886 )
...
* Jump Speed Calculations
* Fix
(cherry picked from commit 0197a2f990 )
2021-12-11 15:25:57 +01:00
Wyrserth
2bcfc6680c
Core/Misc: don't allow FindNearestCreature() and FindNearestGameObject() searches to return the entity that called them. ( #23437 )
...
Closes #23334 .
(cherry picked from commit 015870bfe1 )
2021-12-11 15:14:43 +01:00
Keader
b3493935b6
Core/Scripts: Fixed a reference error introduced in 394b119664
...
(cherry picked from commit 70cbedd75d )
2021-12-11 14:56:14 +01:00
Keader
f749b3a2e9
Scripts/Icecrown Citadel: Fixed Blood Orb Game Object ( #23397 )
...
Close #18005 and Update #18529
(cherry picked from commit 394b119664 )
2021-12-11 14:55:18 +01:00
Sorikoff
c8d0e0fd6d
Scripts/Isle of Quel'Danas: Thalorien Dawnseeker ( #23382 )
...
* Scripts/Isle of Quel'Danas: Thalorien Dawnseeker
* Kill warning
* Kill warning
* Fixes
* Code style
* Code style
* Accident
* Prevent Out of Bound & spelling
(cherry picked from commit e87f8b1aac )
2021-12-11 14:51:31 +01:00
Wyrserth
7745e3f943
Core/SAI: add cooldownMin (event_param2) and cooldownMax (event_param3) to SMART_EVENT_ACCEPTED_QUEST and SMART_EVENT_REWARD_QUEST. ( #23422 )
...
(cherry picked from commit 50be697e1f )
2021-12-11 14:14:10 +01:00
Wyrserth
4c5ae42a63
Core/Creature: drop current target when evading while a spell cast is in progress ( #23420 )
...
* Core/Creature: drop current target when evading while a spell cast is in progress.
Closes #18373 .
* Update Creature.h, thanks jackpoz!
(cherry picked from commit 5ac9b20fcf )
2021-12-11 14:13:53 +01:00
Wyrserth
e846d4c3ef
Core/SAI: don't allow to start a new SAI actionlist while the entity is already running one. ( #23421 )
...
(cherry picked from commit 2b1cde2560 )
2021-12-11 14:13:11 +01:00
Wyrserth
ae43820ca0
Core/Commands: implement commands to look up a map/item/quest name for a given id ( #23416 )
...
* Core/Commands: implement commands to look up a map/item/quest name for a given id.
* Add entry to updates table.
* Rename 9999_99_99_99_auth.sql to 2019_06_16_00_auth.sql
* Add missed change, thanks jackpoz!
* Update auth_database.sql
(cherry picked from commit ce3dcdcb1a )
2021-12-11 14:12:54 +01:00
Wyrserth
01be9f44af
Core/RDF: fix counting issue with the achievement Looking for More (and similar) ( #23418 )
...
* Core/RDF: allow the achievement Looking for More (and similar) to increase the counter based on how many random players were picked.
* Use getter/setter instead.
(cherry picked from commit 14c2bdc5da )
2021-12-11 14:12:54 +01:00
Wyrserth
3278f87789
Core/Loot: fix some other cases where a creature should not be able to set focus. ( #23415 )
...
(cherry picked from commit d50be8e020 )
2021-12-11 14:12:54 +01:00