Commit Graph

35718 Commits

Author SHA1 Message Date
Giacomo Pozzoni
fbe4abf3be Core/MMaps: Fix charge underwater/falling (#24010)
* Core/MMaps: Fix charge underwater

Fix charge sometimes returning "no path available" when swimming/underwater.
Fix charge selecting a destination point 4 yards above swimming/underwater targets

* Allow falling units to charge targets that are below (lower Z coordinate)

* Disable "raycast" pathfinding as it's not blizzlike.

This might show some strange paths when charging with a target in front.
It also fixes some falling undermap issues.

This Reverts 272009ebee

* Remove Z offset when charging a target as it never made sense
2020-02-20 21:27:00 +01:00
Ovahlord
d0f946f30a DB/Trainers: added gossip trainer assignment for Brother Sammuel
closes #37
2020-02-20 18:33:13 +01:00
Ovahlord
be34d3fd00 DB/Quests: added breadcrumbs for Hero' Call: Westfall, Duskwood, Redridge Mountains, and Northern Stranglethorn Vale and their respective questline counterparts 2020-02-20 05:48:28 +01:00
Wyrserth
8e67cfe38e Core/Quest: remove arbitrary error logs related to breadcrumb quest chaining.
There are complex cases where breadcrumb quests are mutually exclusive with other breadcrumbs leading to other quests, chaining them shouldn't generate log errors.
2020-02-20 05:09:47 +01:00
Ovahlord
59120fbd38 Core/Quests: ported breadcrumb quest handlings and cleaned up quest template loading handlings 2020-02-20 05:08:09 +01:00
ariel-
0fcc0ebca2 Core/Player: don't check quest requirements against RewardNextQuest
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest

Closes #19515
2020-02-20 02:20:08 +01:00
xinef1
c72ee80eb7 Core/Quests: Display quest objective explore completion message
- Game client should show an on-screen message for explored quest objectives
  (AreaExploredOrEventHappens) when the objective has been completed.
2020-02-20 02:15:00 +01:00
ariel-
d28be94e4a Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike

thanks Cannix for the heads up
2020-02-20 01:55:48 +01:00
xinef1
d6e7cc52a8 Various quest system fixes (seasonal quests, timed quests and more) (#18940)
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone

Closes #18913
Closes #11187
Closes #15279
2020-02-20 01:51:14 +01:00
ariel-
08e174549e Core/Quest: fix RewardNextQuest being used to condition previous quests in chain 2020-02-20 01:42:01 +01:00
ariel-
a7484837a8 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId.
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300
2020-02-20 01:39:08 +01:00
ariel-
d78ad034d0 Core/Quests: changed quest_template_addon.NextQuestID to unsigned
- No reason to keep this anymore after 4349adf0f2, this is a broken functionality.
2020-02-20 01:33:53 +01:00
ariel-
330f399de3 Core/Globals: some changes in quest loading
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups
2020-02-20 01:31:29 +01:00
ariel-
ef6f5abf75 Core/Globals: Fix Quest codestyle and member variable initialization 2020-02-20 01:24:47 +01:00
Ovahlord
6e6c9b2787 Core/Movement: use GameTimeMS at a missing spot 2020-02-19 07:00:02 +01:00
Ovahlord
eb9d3ac09a DB: fixed auth database base file file naming for updates 2020-02-19 06:05:03 +01:00
Ovahlord
97ba299f15 DB: renamed sql files 2020-02-19 05:37:14 +01:00
Ovahlord
6680a2fe66 DB/Duskwood: reworked most remaining smart scripts and added missing random movements and waypoints to most npcs 2020-02-19 05:21:49 +01:00
Ghaster
df173c7e1c Core/Bnet: Cleanup/Improve Battle.net account commands (#33) 2020-02-19 02:52:11 +01:00
funjoker
8447d9a6a5 Scripts/Westfall: Fix Westfall Intro Quest (#35) 2020-02-18 23:50:32 +01:00
Ovahlord
a998247586 Scripts/Duskwood: reworked SAI scripts for the following creatures:
Nightbane Tainted One, Nightbane Vile Fang, Black Ravager, Blackbelly Forager, Barn Owl, Splinter Fist Ogre, Splinter Fist Firemonger and Splinter Fist Warrior
2020-02-18 23:18:04 +01:00
Ovahlord
ae657b2c31 Core/AI: fixed smartAI validation 2020-02-18 22:39:40 +01:00
Ovahlord
6dce62f0fd Core/AI: replaced SMART_ACTION_STOP_MOTION with new functionality called SMART_ACTION_PAUSE_MOVEMENT 2020-02-18 22:13:33 +01:00
Ovahlord
ea32427608 Core/Movement: fixed some db layout issues when loading creature movements 2020-02-18 20:54:28 +01:00
Ovahlord
1793f39fcc Core/Movement: Allow using run when moving randomly 2020-02-18 06:32:25 +01:00
Ovahlord
4534308280 DB/Duskwood: corrected smart scripts for Skeletal Mage, Skeletal Warrior, Black Widow Hatchling and Insane Ghoul 2020-02-18 05:52:19 +01:00
Ovahlord
41497227dc DB/Duskwood: properly scripted Nightbane Shadow Waver and Nightbane Stalker 2020-02-18 05:06:18 +01:00
Ovahlord
6b24697f4b DB/Duskwood: added waypoints to Watcher Backus 2020-02-18 04:07:52 +01:00
Ovahlord
06175eff5f DB/Stormwind: added waypoints for Stormwind Harbor Guards 2020-02-18 03:46:48 +01:00
Ovahlord
e619492a19 DB/Stormwind: added night time equipment to stormwind city guards and patrollers and moved waypoint scripts to smartAI 2020-02-18 00:13:30 +01:00
Ovahlord
6107791aa2 DB/Events: extended end date for most outdated events to 2030 2020-02-17 22:41:04 +01:00
Ovahlord
4aff2dd524 Core/Packets: fixed structure of SMSG_NEW_WORLD 2020-02-17 21:15:46 +01:00
Gildor
ed1ec44b15 DB/Spells: Everlasting Affliction will no longer get triggered by Shadow Bolt
closes #36
2020-02-17 20:09:32 +01:00
Ovahlord
87955a487e Core/Packets: corrected packet structure of SMSG_SUSPEND_TOKEN 2020-02-17 19:51:22 +01:00
Ovahlord
22ed3f306d Core/Movement: implement SMSG_SUSPEND_TOKEN and CMSG_SUSPEND_TOKEN_RESPONSE packets and converted SMSG_TRANSFER_PENDING and SMSG_NEW_WORLD to packet class 2020-02-17 18:40:21 +01:00
Ovahlord
a5e56171af Core/Units: added pointer check in SetMinion to protect the core against old/bad coding and improved codestyle in function 2020-02-17 00:18:32 +01:00
Ovahlord
4a4fbee952 Scripts: make Travis happy 2020-02-15 23:22:35 +01:00
Killyana
cb48dc8736 DB/Spells: Sparkles for the quest Fear No Evil 2020-02-15 22:51:04 +01:00
Ovahlord
05cbdf56b7 Scripts/Elwynn: updated all existing scripts to new scripting model, cleaned up older scripts and improved handlings accross the board 2020-02-15 22:47:30 +01:00
Ovahlord
d85348576d Scripts: fixed two warnings caused by unused return values 2020-02-15 22:05:09 +01:00
Ovahlord
34e727472c DB/Spells: changed Shadow Orbs proc phase to hit instead of cast 2020-02-15 21:47:57 +01:00
Ovahlord
957850560e Core/Spells: the damage bonus for Mind Spike and Mind Blast will now be applied on the final damage value instead of the base one 2020-02-15 21:30:25 +01:00
Ovahlord
296aa29ce7 Scripts/ZA: make some compilers happy 2020-02-14 15:04:47 +01:00
Ovahlord
b74a3ae035 Scripts/BWD: fixed a warning 2020-02-10 16:00:20 +01:00
Ovahlord
deac78a248 Scripts/BWD: followup for e0d610e79b 2020-02-10 15:01:33 +01:00
Ovahlord
e0d610e79b Scripts/BWD: reworked handlings for riding and damage phase of Magmaw
* cleaned up unneeded members and move initialization to a more fitting place
* minor corrections to timer layouts
* fixed passengers not getting ejected from Magmaw's Pincers when Magmaw is about to impale himself
* handle missing whisper message for players that have been mangled
2020-02-10 14:57:25 +01:00
Ovahlord
1c9e3b767d DB/Conditions: fixed two startup errors 2020-02-09 21:02:29 +01:00
Ovahlord
4494794c60 Scripts/ZA: implement Akil'zon encounter 2020-02-09 19:49:30 +01:00
Ovahlord
1192d02373 Core/Vehicles: disable passenger gravity also for vehicles that can fly by default 2020-02-09 19:22:13 +01:00
Ovahlord
9a220efa3a Core/Vehicles: apply disable gravity movement flag alongside the packet when entering a vehicle seat with disable gravity flag 2020-02-09 18:42:59 +01:00