Commit Graph

5976 Commits

Author SHA1 Message Date
Wyrserth
fd030069f7 Core/Spell: add proper cooldowns to some spells used by vehicles (#23260)
* Core/Spell: add proper cooldowns to some spells used by vehicles, thanks to jackpoz and sirikfoll.

* Add Wing Buffet and Stampy's Stompy-Stomp.

* Add Tag Greater Felfire Diemetradon and Touch of Darkness.

* Rename 9999_99_99_99_world.sql to 2019_05_17_00_world.sql

(cherry picked from commit 4d04344b41)
2021-12-05 18:44:59 +01:00
Killyana
cb9a1c38f1 Instance/Script: Blood Furnace
Ref #23285

(cherry picked from commit 9435caa8d1)
2021-12-05 18:39:09 +01:00
ccrs
6efb8d2d22 Scripts/Northrend: couple cosmetic corrections after 552720a
(cherry picked from commit 7025b00656)
2021-12-05 16:02:29 +01:00
Wyreth
40ec90e1f5 Scripts/Northrend: improvements for quest Get Me Outa Here! (11673) (#20753)
* Script/Quest: improvements for quest Get Me Outa Here! (11673).

* Happiness for our Travis overlord

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update zone_borean_tundra.cpp

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Fix hook that got renamed

* Update 9999_99_99_99_world_quest_get_me_outa_here.sql

* Rename 9999_99_99_99_world_quest_get_me_outa_here.sql to 2019_05_11_08_world.sql

(cherry picked from commit 552720a993)
2021-12-05 15:15:52 +01:00
Keader
0b7089a7d1 Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening quest
killer can be a pet

(cherry picked from commit a639a99c6c)
2021-12-04 00:37:17 +01:00
Demonid
f981b15389 Scripts/Icecrown Citadel: The Lich King's Last Stand quest kill credit (#23239)
Closes #8919

(cherry picked from commit d1c5b3c897)
2021-12-04 00:31:32 +01:00
Killyana
19ce65c01b Remove deprecated code
(cherry picked from commit fe311260f7)
2021-12-03 22:00:47 +01:00
sirikfoll
03e03f3fc6 Core/Scripts: Fix Skadi dismount issue
Closes #23005

(cherry picked from commit fe3bf57aba)
2021-12-02 23:51:51 +01:00
Giacomo Pozzoni
46170fdf01 Scripts/Spells: Fix implementation of #22332 (#23228)
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead

(cherry picked from commit 20772dbf5d)
2021-12-02 23:46:00 +01:00
Killyana
5163559c1e Quest/Script: Breakfast Of Champions
Set both Earthshaker Drum Events to 50%

(cherry picked from commit 14445088ea)
2021-12-02 19:35:47 +01:00
jackpoz
cf979de813 Core/Misc: Fix some GCC 8 warnings
(cherry picked from commit 26b6cb0584)
2021-12-02 00:39:28 +01:00
jackpoz
c73fd0e6e3 Scripts/Commands: Add .debug asan commands
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)

(cherry picked from commit 71d15ea25b)
2021-12-02 00:39:20 +01:00
jackpoz
98863659bb Scripts/Guards: Fix infinite loop in npc_air_force_bots
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.

(cherry picked from commit 844e7ee926)
2021-12-02 00:39:20 +01:00
Jozef Dúc
b717603a9b Core/Object: Range check (#23179)
* Should solve #23062. All credits to @xvwyh

* Remove unused variables

* Remove unused variable

* Cast int32 to uint32

* Remove G3D headers from core header file

* Change door distance

* Update GameObject.cpp

Add newline

* Update GameObject.h

Indentation

(cherry picked from commit 32e1de39a2)
2021-12-02 00:39:20 +01:00
ForesterDev
a2c0f6d321 Scripts/Commands: add some missing checks for .guild create command (#23201)
* Core/Conditions: implement CONDITION_GAMEMASTER

* Scripts/Commands: add some missing checks for .guild create command

(cherry picked from commit ae8750716f)
2021-12-02 00:39:20 +01:00
Keader
93a9ee9c12 Scripts/Trial of the Crusader: Fixed Resilience will Fix achievement
Broken by 2362e9c794

(cherry picked from commit f163c2f96a)
2021-12-02 00:39:20 +01:00
Sorikoff
8f0afc81da Scripts/Scarlet Enclave: Unworthy Initiate (#23195)
(cherry picked from commit 4468a538ff)
2021-12-02 00:38:42 +01:00
Sorikoff
575bcc8c82 Scripts: Minor improvements to recently migrated scripts (#23189)
Ref: 2cfaeb1400
(cherry picked from commit 90d4254a87)
2021-12-02 00:37:00 +01:00
Keader
4b3e6b9998 Scripts/Spells: Fixed a console error inspell_dru_lifebloom
Closes #23192

(cherry picked from commit 961bc9d829)
2021-12-02 00:37:00 +01:00
Killyana
f98e82103f Spell/Script: Kill logs spam for spell_ioc_parachute_ic
Closes #23163

(cherry picked from commit c318b3e16d)
2021-11-30 22:41:16 +01:00
Sorikoff
d72e809ecf Scripts/Spells: Migrate Some Scripted Spells to Scripts (#23185)
* Migrate spells to scripts

* Simplify code

* I need to sleep

* Update chapter1.cpp

* Use actual damage

* No need in null check here

(cherry picked from commit 2cfaeb1400)
2021-11-30 22:30:53 +01:00
Gustavo
b86a66c5be Core/Scripts: Fix Blood summon position (#23088)
* Core/Scripts: Fix Blood summon position

Updates #13162

(cherry picked from commit cc3293c002)
2021-11-26 11:21:24 +01:00
Gustavo
6aaf9aaf3b Core/Misc: Warning fixes (/W4) (#23149)
* Core/Misc: Warning fixes (/W4)

(cherry picked from commit 50f122de77)
2021-11-26 11:18:15 +01:00
jackpoz
721f4c6032 Core/Misc: Fix static analysis issues
Fix static analysis issues spotted by Coverity Scan

(cherry picked from commit 750d89beed)
2021-11-24 23:45:36 +01:00
jackpoz
43a41caafb Core/Misc: Fix GCC 8 warnings
(cherry picked from commit 1d04a3b216)
2021-11-24 23:40:15 +01:00
Trond B. Krokli
bc628572fe Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus, not $n (#23122)
* Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus the Devourer

Disciple of Naralex should say
"This Mutanus the Devourer is a minion from Naralex's nightmare no doubt!"
instead of using $n caused by a missing target in the Talk() script command.

(cherry picked from commit a040d48443)
2021-11-24 22:39:18 +01:00
Trond B. Krokli
36feb3bfe7 Scripts/Borean Tundra: link gossip content for NPC Iruk from DB (#23118)
- remove hardcoded text (deprecated method)
- add already existing DB gossip content to enum
- correct spell enum from spell_creature_ to spell_create_
- replace case switch with if statement (only one boolean case)

Extra script file update:
- remove SD comment line 22 (outdated info, replaced by SAI)

(cherry picked from commit 7cb31aa482)
2021-11-24 22:26:05 +01:00
Langerz82
e61266815f Spell/Script: Guard's Mark
Closes #16888

(cherry picked from commit e840d4967e)
2021-11-24 20:41:03 +01:00
PolarCookie
f7299dce97 Core/Spell: SpellAura Redux (#22794)
* typo and correction

* spell aura no longer shared between targets

_spellAura isolated

* SPELL_AURA_CONTROL_VEHICLE is not strictly single target spell

Steam Tank Control and Wyrmrest Commander

units can reseat themselves again

* Rename 9999_99_99_99_world.sql to 2019_03_08_00_world.sql

(cherry picked from commit ec3cb05d7f)
2021-11-24 20:35:19 +01:00
ccrs
67e0b25739 Scripts/Northrend: 482e0da followup
add a little bit of tolerance

(cherry picked from commit a006362615)
2021-11-24 20:35:19 +01:00
ccrs
27bc3bc7db Scripts/Northrend: 482e0da followup
(cherry picked from commit 3eecadcebf)
2021-11-24 20:35:18 +01:00
Killyana
67e702b29b Spell/Script: Specify a target for Azure Dragon: On Death Force Cast Wyrmrest Defender to Whisper to Controller - Random
(cherry picked from commit e5470ab1ee)
2021-11-24 20:35:18 +01:00
Keader
c72afc76be Creature/Script: Daegarn
Remove the incorrect SAI and move it to cpp

(cherry picked from commit 482e0dad30)
2021-11-24 20:35:18 +01:00
Shauren
2be8a1f189 Core/Misc: PORT CURSED REFACTORS FROM e69570dd76
WHO ON EARTH THOUGHT IT WAS A GOOD IDEA TO ADD REFACTORS TO A CHERRY-PICK COMMIT???
2021-11-24 20:35:18 +01:00
Keader
02db59806a Scripts/Trial of the Crusader: Fixed Slime Pool visual effect
Closes #21660

(cherry picked from commit e1aafddc2e)
2021-11-24 20:35:17 +01:00
Keader
955ac45cf5 Spell/Script: Freezing Circle
Closes #11312
See the original issue before cherry pick

(cherry picked from commit 990ad000f8)
2021-11-24 20:34:56 +01:00
Sorikoff
956158d299 Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing

(cherry picked from commit dbadb6369c)
2021-11-24 20:34:54 +01:00
sirikfoll
402e63427e Scripts/Ulduar: Mimiron improvements
Closes #23043

Fix Aerial hover
Some visual issues

(cherry picked from commit a803342029)
2021-11-24 00:02:13 +01:00
Sorikoff
b3f75852c2 Allow walk when chasing (#23069)
(cherry picked from commit c2f2db08aa)
2021-11-24 00:02:13 +01:00
jackpoz
97401a2997 Core/Commands: Don't re-add active quests with ".quest add" command
(cherry picked from commit f17120cc78)
2021-11-24 00:02:13 +01:00
Ovah
2dda5fb477 Scripts/MGT: Kael'thas intro can now be skipped when not killing the trash pack in his room
Scripts/MGT: Kael'thas will now despawn at evade

Cherry picked from
f6e9ff5ca4
ed8c1830f5

(cherry picked from commit c10c8c6bba)
2021-11-23 23:17:08 +01:00
Keader
dba7e2507f Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits
(cherry picked from commit a617cc4097)
2021-11-23 23:16:43 +01:00
Sorikoff
ee0662ca3d Scripts/Scarlet Enclave: Stable Master Kitrik's spell Repo (#23023)
(cherry picked from commit f0f4d0280d)
2021-11-23 23:04:34 +01:00
Shauren
c14cf5a892 Core/Misc: Added lambda support to EventProcessor
Closes #22909

(cherry picked from commit 813f693768)
2021-11-23 23:01:47 +01:00
TheWinchesters
47adf2e4c8 [3.3.5] Commands: lookup player shows which character is online (#23039)
* Show 'online' for every online player in lookup player commands

(cherry picked from commit a0056951f7)
2021-11-23 22:52:53 +01:00
jackpoz
3ddbf02dc7 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan

(cherry picked from commit 2fda1572d2)
2021-11-23 22:20:39 +01:00
Sorikoff
fc9106054b Scripts/Scarlet Enclave: Grand Theft Palomino (#22967)
* Grand Theft Palomino

* Cosmetic issues

* Address CR

(cherry picked from commit d5f565f429)
2021-11-23 21:28:03 +01:00
Sorikoff
31f4bb1436 DB/Quest: Sniff Out the Enemy
Closes #23006

(cherry picked from commit 806dd940ce)
2021-11-23 20:46:27 +01:00
Keader
084491669e Scripts/Magister Terrace: Fixed a enum mistake
(cherry picked from commit 33b0654f8e)
2021-11-23 00:40:07 +01:00
Keader
cfd0e18b81 Core/Misc: Fixed shaman elementals and magister terrace first boss access
(cherry picked from commit 6545cd33b9)
2021-11-23 00:39:59 +01:00