Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-19 08:55:32 +01:00
Code Issues Packages Projects Releases Wiki Activity
34,608 Commits 4 Branches 146 Tags
ffce2c1f9a416eddad2e45ab2e03df964d5e39cd
Commit Graph

25440 Commits

Author SHA1 Message Date
Treeston
ffce2c1f9a Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156. 
(cherry picked from commit ac8b9be5d6)
 2021-06-20 20:22:18 +02:00
Treeston
3b635a8a12 Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310. 
(cherry picked from commit fe3b4de1cd)
 2021-06-20 20:17:59 +02:00
ccrs
cecb91ad3d Core/Movement: fe1ba18905 followup 
ref fe1ba18905 (r27507316)

plus I noticed a logic error on speedchange call

(cherry picked from commit 28c6db0807)
 2021-06-20 01:34:48 +02:00
ariel-
a342b86403 Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic) 
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)

(cherry picked from commit bc2a4c816d)
 2021-06-20 01:15:00 +02:00
ariel-
15810eb579 Core/Unit: kill unused parameter from SpellxxxBonusTaken 
(cherry picked from commit c7095375c3)
 2021-06-20 01:09:20 +02:00
ariel-
23a88fae6f Core/Scripts: remove Tenacity hack, implemented with proper aura 
(cherry picked from commit 404240fb68)
 2021-06-20 00:55:53 +02:00
Wilcalaf
e9833447ed Archaedas should properly start now when clicking on the altar. (#21401) 
(cherry picked from commit 0c1aaac219)
 2021-06-20 00:30:33 +02:00
ariel-
bc6b0c5197 Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras 
- Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses
- Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty)

(cherry picked from commit 4d14f613f3)
 2021-06-20 00:28:50 +02:00
ariel-
18780206bc Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit 2021-06-19 23:55:03 +02:00
ariel-
3582bacc4a Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD 
(cherry picked from commit dfa861593e)
 2021-06-19 23:34:15 +02:00
ariel-
13be704cb4 Core/Spells: implement SPELLVALUE_CRIT_CHANCE 
(cherry picked from commit 546a605bd0)
 2021-06-19 23:33:44 +02:00
ariel-
85e5509e91 Core/Spells: calculate crit chance only for spells that do damage/healing 
Refs #18813

(cherry picked from commit 52873a7072)
 2021-06-19 23:33:38 +02:00
Treeston
f4cc76063f Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent. 
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.

Tagging #20310.

(cherry picked from commit e4e6e2209c)
 2021-06-19 23:33:38 +02:00
Treeston
3c172ba17c Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310. 
(cherry picked from commit b243a7929b)
 2021-06-19 23:33:38 +02:00
Treeston
6d79b329ac Core/Movement: WaypointMovementGenerator cleanup 
(cherry picked from commit fe1ba18905)
 2021-06-19 23:33:38 +02:00
Treeston
88c1739e3e Core/Movement: Creatures' idle movement generator can no longer override player mover control. 
Tagging #20310, partial fix.

(cherry picked from commit d02f481d9a)
 2021-06-19 23:33:38 +02:00
ariel-
a24af55d13 Core/Scripts: implemented Combined Toxins proc only from poisons 
(cherry picked from commit 477878630e)
 2021-06-19 23:33:38 +02:00
ariel-
c21dc3c1b7 Core/Auras: fix periodic ticks proc after previous commit 
(cherry picked from commit 9d0e90829c)
 2021-06-19 23:33:38 +02:00
ariel-
91fa279bdf Core/Spells: require phasemask set for periodic damage procflag 
Closes #21379

(cherry picked from commit b42ade918a)
 2021-06-19 23:33:38 +02:00
jackpoz
cb0672081e Core/Player: Add some asserts 
Assert PlayerInfo for race/class pair in a few Player functions

(cherry picked from commit 3576a38f6c)
 2021-06-19 23:33:38 +02:00
jackpoz
e63c5f7b0c Scripting/Obsidian Sanctum: Fix crash 
Fix crash caused by calling Reset() in constructor (which is not allowed)

(cherry picked from commit 5aba5c7aff)
 2021-06-19 23:33:38 +02:00
jackpoz
66f7e57990 Shared/Database: Improve dead-lock error handling 
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times

(cherry picked from commit 54b0b8f5ea)
 2021-06-19 23:33:38 +02:00
Treeston
e8754cbdaf Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep) 
(cherry picked from commit a4fc32dd86)
 2021-06-19 23:33:37 +02:00
Keader
299f22e3fc Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload 
ty sirikfoll :)

(cherry picked from commit 2994abeae6)
 2021-06-19 23:33:37 +02:00
Treeston
ef710273d0 Game/AI: InvalidAIException internal cleanup 
(cherry picked from commit b456915f9a)
 2021-06-19 23:33:34 +02:00
ariel-
3485cb38ed Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC 
Thanks to killerwife for the heads-up

(cherry picked from commit 303efcf0e4)
 2021-06-19 23:33:25 +02:00
Keader
9b7f3bff9f Core/Scripts: Fixed tabs issues introduced in 5bef3e426a 
(cherry picked from commit 31ad6358fb)
 2021-06-19 23:33:24 +02:00
Keader
ad5b0fa9cd Core/Scripts: Fixed possible crashs related with JustDied 
(cherry picked from commit 5bef3e426a)
 2021-06-19 23:33:24 +02:00
ariel-
4ae29e38ee Core/Scripts: fix non-functional Celestial Planetarium Access GO 
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982

(cherry picked from commit b490d3f5ad)
 2021-06-19 23:33:24 +02:00
sirikfoll
9573987775 Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor 
Closes #20727

(cherry picked from commit cfaa4e6caf)
 2021-06-19 23:33:24 +02:00
sirikfoll
e2c72cc02e Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos) 
(cherry picked from commit 14b6e3bbb3)
 2021-06-19 23:33:24 +02:00
ariel-
8c379e920c Core/Spells: fix logic error causing near teleports to drop combat for players 
Closes #21362

(cherry picked from commit 65709e1c30)
 2021-06-19 23:33:24 +02:00
ariel-
f9b14ca795 Core/Spells: fix logic error causing near teleports to drop combat for players 
Closes #21362

(cherry picked from commit 65709e1c30)
 2021-06-19 23:33:24 +02:00
ariel-
800d92bec3 Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spells 
- It is already called at Unit::DealDamage

(cherry picked from commit e979a58d17)
 2021-06-19 23:33:24 +02:00
Treeston
809c38994a Core/Threat: Custom ThreatListIterator that transparently iterates over the backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation. 
Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view.

(cherry picked from commit 4cb13af4fa)
 2021-06-19 23:33:24 +02:00
ariel-
d34292534c Core/Spells: fix SPELLMOD_DAMAGE application order for melee spells 
Closes #20597

(cherry picked from commit 2d2c43f4b9)
 2021-06-19 23:33:23 +02:00
ariel-
01d9306854 Core/Spells: kill unused parameter from Spell constructor 
Added in 1f2292af79

(cherry picked from commit 9fc732eb97)
 2021-06-19 23:33:23 +02:00
jackpoz
b9159407e0 Core/AI: Fix assertion triggered with PetAI derived scripts (#21254) 
* Core/AI: Fix assertion triggered with PetAI derived scripts

Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.

(cherry picked from commit 95a76a83fc)
 2021-06-19 23:33:21 +02:00
Treeston
d7542dc3e8 Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version. 
Closes #21265.

(cherry picked from commit b3e0c89238)
 2021-06-19 01:57:55 +02:00
Treeston
7695784fd2 AI/SmartAI: Remove a silly incorrect piece of code that was breaking react state swaps on SAI creatures. Fixes #21353. 
(cherry picked from commit 6e0df9fce1)
 2021-06-19 01:55:18 +02:00
Treeston
a8307e60a3 Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn. 
Closes #21286.

(cherry picked from commit aefc25482f)
 2021-06-19 01:35:41 +02:00
sirikfoll
bd7fbce592 Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King) 
Movement was being prevented by spell cast

(cherry picked from commit a217c0be92)
 2021-06-19 01:35:41 +02:00
Killyana
854abdbfb6 Spell/Script: Torch 52953 and 58121 must hit only one target 
(cherry picked from commit 8f71307e56)
 2021-06-19 01:35:41 +02:00
Treeston
95fb6fe075 Core/Creature: Adjust SelectVictim behavior: (PR #21324) 
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits.
- Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished.

(cherry picked from commit 1acfefb973)
 2021-06-19 01:35:41 +02:00
Treeston
39dff738e1 Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. (PR #19818) 
(cherry picked from commit 03ef79f3d9)
 2021-06-19 01:35:41 +02:00
Treeston
fdc1c5b6c9 Combat/Threat: Now set engaged state for all units on offline reference registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade. 
This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you.

(cherry picked from commit 2402406228)
 2021-06-19 01:35:40 +02:00
Treeston
75a3b2f122 Game/AI: Remove some unused old logic. 
(cherry picked from commit c69584a967)
 2021-06-19 01:35:40 +02:00
Shauren
428bf60f7f Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big Ooze (Rotface) 
(cherry picked from commit aaab7ba9f4)
 2021-06-19 01:35:40 +02:00
Killyana
2d43b8aaa3 Quest/script: Freedom to Ruul 
Follows 4dc91429dd

(cherry picked from commit 52fc5a572b)
 2021-06-19 01:35:38 +02:00
Killyana
30feaa06e8 DB/Quest: Freedom to Ruul 
Closes #7262

(cherry picked from commit 4dc91429dd)
 2021-06-19 00:14:06 +02:00