aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2019-05-29Core/Channel: Sanitize channel namesjackpoz
2019-05-29Core/Channel: Fix CRT Debug Assert triggered with invalid channel namesjackpoz
2019-05-29Core/Movement: Fix assertion triggered in SplineChainMovementGeneratorGiacomo Pozzoni
Fix an assertion triggered in SplineChainMovementGenerator happening when a new generator is added while last spline of the SplineChainMovementGenerator is being processed but is not finalized yet. Fix #23077
2019-05-27Core/Players: out of range group updates will now get sent every 5 seconds ↵Ovah
instead of as soon as they are available to reflect retail behaivior. (#23323) * according to sniffs the group update packet for out of range members has a fixed 5 seconds interval instead of spaming packets like crazy for example when updating positions. On 4.x and above this will fix a very nasty and ugly fps drop * validated with 4.3.4 and 3.3.5 sniffs
2019-05-27Creature/Script: npc_tallhorn_staglactoseti
Ref #2623
2019-05-26Core/Console: start CliRunnable thread after all log messages have been ↵Wyrserth
printed. (#23321)
2019-05-26Core/GameObjects: goober gameobjects may reset only if they have a lock id ↵Ovah
or a reset time specified (#23298) * Core/GameObjects: goober gameobjects may reset only if they have a lock id Tests have shown that Goobers without a lock id (Data0=0) are not allowed to reset their go state such as the teleporters in Ulduar and Icecrown Citadel. The tests has been expanded by checking 4.x goobers as well and the perfect example that confirms that result is the Ancient Bell for Atramedes' intro which also is not suposed to reset after using it. * Core/GameObjects: allow to reset goobers without a lock id if a reset time is defined * fixed a typo
2019-05-26Core/SmartAI: Improve SMART_EVENT_GOSSIP_HELLOjackpoz
Add another value to event_param1 for SMART_EVENT_GOSSIP_HELLO to support all cases of OnGossipHello/OnReportUse in GameObjects: - event_param1 set to 0: execute the action for both OnGossipHello and OnReportUse. This might result in the action being executed twice when clicking the GameObject - event_param1 set to 1: execute the action for only OnGossipHello - event_param1 set to 2: execute the action for only OnReportUse
2019-05-25Core/Weather: Define WEATHER_STATE_DRIZZLE stateKittnz
2019-05-25DB/Creature: Hydross the unstable npc triggersKillyana
Update the correct channel spell SPELL_BLUE_BEAM and spawn triggers used to cast it
2019-05-25DB/Creature: Dark Portal Dummy 1.30Killyana
2019-05-24Core/Spells: Fix spells with Health Leech effect, now check damage absorb ↵Gildor
when calculate Heal (#23312) Closes: #23311
2019-05-24Core/SmartAI: Implement SMART_EVENT_SUMMONED_UNIT and ↵jackpoz
SMART_EVENT_SUMMON_DESPAWNED for GameObject owners
2019-05-24Scripts/Zul'Gurub 22974 high priestess marli hatching eggs (#23212)Ianislav Vasilev
* Issue 22974: Initial bugfix suggestion. * Fixed allignment. * Removed unused call. * Initial spider spawn targeting is done. * Resolves issue 22874. Initial implementation suggestion. * Commenting out dead code. * Reordered private members to meet standards of member initializer list. * Removing unused parameter and changing data structure from list to vector. * Changed list to vector in the grid notifier. * Removing comments and fixing identation. * Stupid collapsed blocks. * Scripts/Misc: Change IsSummonedBy(Unit*) to IsSummonedBy(WorldObject*) * Scripts/Misc: Fix build * Core/TempSummons: Rename GetSummoner() to GetSummonerUnit() * Core/TempSummons: Add support to TempSummons::GetSummoner() to return GameObject too * Fix build * Core/TempSummons: Allow GameObject to be owner of TempSummon * Core/TempSummons: Add support to SAI for GameObject owner of TempSummon * Scripts/Misc: Fix no-pch build * Cleaned up all the core changes and scripted eggs and spell according to pull request comments. * Fix no-pch build. * Fix no-pch build 2. * Added sql file for the spell and gameobject script. * Update 2019_05_20_00_world.sql * Added conditions to spell thanks @xvywh and some minor changes to the code. * Removed some strange leftovers. * Removed obsolete brackets. * Rename 2019_05_20_00_world.sql to 2019_05_24_00_world.sql
2019-05-233.3.5 gameobject summoner (#23289)Giacomo Pozzoni
* Scripts/Misc: Change IsSummonedBy(Unit*) to IsSummonedBy(WorldObject*) * Scripts/Misc: Fix build * Core/TempSummons: Rename GetSummoner() to GetSummonerUnit() * Core/TempSummons: Add support to TempSummons::GetSummoner() to return GameObject too * Fix build * Core/TempSummons: Allow GameObject to be owner of TempSummon * Core/TempSummons: Add support to SAI for GameObject owner of TempSummon * Scripts/Misc: Fix no-pch build * Core/TempSummons: Implement PR comments
2019-05-23Core/SmartAI: Fix SMART_EVENT_SUMMON_DESPAWNEDjackpoz
Fix SMART_EVENT_SUMMON_DESPAWNED not working when event_param1 was set to any value other than 0
2019-05-23Core/GameObjects: Validate rotation quaternion at startupShauren
Ref #23306
2019-05-19Core/PetAI: apply some movement related correctionsccrs
Unit::StopMoving() is evil, and so is MotionMaster::Clear() the first can really mess up existing movement generators the second can interrupt "controlled" movements... can do it literally mid-air
2019-05-19Core/Handlers: apply some movement related correctionsccrs
Unit::StopMoving() is evil, and so is MotionMaster::Clear() the first can really mess up existing movement generators the second can interrupt "controlled" movements... can do it literally mid-air
2019-05-19Core/Handlers: random PetHandler cosmetics & codestyleccrs
2019-05-19Core/Movement: move DelayedAction into MotionMaster and add a couple definesccrs
2019-05-18Core/Packet: Clean up packet creationjackpoz
Clean up packet creation by removing some unneeded checks to specify the exact packet size to reserve. It's cheaper and easier to just always specify the max size as it's a matter of a few bytes only anyway.
2019-05-18Core/Misc: Fix static analysis issues reported by Coverityjackpoz
2019-05-18Spell/Scripts: Add cooldown for Arcano-Scorp spellsKillyana
Closes #23287
2019-05-17Core/Scripts: implement a PlayerScript hook called when a quest's objective ↵Wyrserth
receives progress (#23286)
2019-05-17Scripts/Blackrock Depths: High Priestess of Thaurissan (#23230)Ianislav Vasilev
* Initial fix suggestion for 22660. * Removed todo related to the work done in this branch. * Removing obsolete braces and added failfast check. * Refactored the logic about having the quest. * Removing obsolete braces. * Adding reference to incomplete type. * Switching from forward declaration to header where type is defined. * Including Player type definition in order to work with nopch. * Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com> * Update src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com> * Reverted mistakenly deleted todo
2019-05-17Core/Spell: add proper cooldowns to some spells used by vehicles (#23260)Wyrserth
* Core/Spell: add proper cooldowns to some spells used by vehicles, thanks to jackpoz and sirikfoll. * Add Wing Buffet and Stampy's Stompy-Stomp. * Add Tag Greater Felfire Diemetradon and Touch of Darkness. * Rename 9999_99_99_99_world.sql to 2019_05_17_00_world.sql
2019-05-17Build: fix variable order initialization errorccrs
fatal error: field 'Action' will be initialized after field 'Validator' [-Wreorder]
2019-05-17Core/Movement: implement MotionMasterDelayedAction validatorccrs
2019-05-17Core/AI: PetAI method reorderingccrs
2019-05-16Instance/Script: Blood FurnaceKillyana
Ref #23285
2019-05-16Core/PetAI: apply some movement related correctionsccrs
Unit::StopMoving() is evil, and so is MotionMaster::Clear() the first can really mess up existing movement generators the second can interrupt "controlled" movements... can do it literally mid-air
2019-05-16Core/PlayerAI: apply some movement related correctionsccrs
Unit::StopMoving() is evil, and so is MotionMaster::Clear() the first can really mess up existing movement generators the second can interrupt "controlled" movements... can do it literally mid-air
2019-05-16Core/Misc: remove incorrect ClearUnitState calls related to movementccrs
these unit states should never be removed outside motionmaster's handlings
2019-05-15Core/Creature: equipment_id field on creature table is not working ↵Aokromes
correctly, if it's set to 0 the npc still spawn with the equipement. (#23273) By Malcrom Closes #16416
2019-05-15Core/AI: couple movement related corrections in FollowerAIccrs
plus EnterEvadeMode streamline
2019-05-15Core/AI: streamline FollowerAI::MoveInLineOfSight with SmartAI and EscortAIccrs
plus another method reorganization
2019-05-15Core/AI: streamline FollowerAI::AssistPlayerInCombatAgainst with SmartAI and ↵ccrs
EscortAI plus couple method reorganizations
2019-05-15Core/AI: logs, codestyle & cosmetics standarizationccrs
2019-05-15Core/AI: silence a freaking annoying VS IntelliSense warningccrs
2019-05-15Core/AI: variable naming standarizationccrs
plus minimum codestyle changes
2019-05-14Scripts/Northrend: couple cosmetic corrections after 552720accrs
2019-05-11Core/Misc: Fix GCC 8 warningjackpoz
2019-05-11Scripts/Northrend: improvements for quest Get Me Outa Here! (11673) (#20753)Wyreth
* Script/Quest: improvements for quest Get Me Outa Here! (11673). * Happiness for our Travis overlord * Update 9999_99_99_99_world_quest_get_me_outa_here.sql * Update zone_borean_tundra.cpp * Update 9999_99_99_99_world_quest_get_me_outa_here.sql * Update 9999_99_99_99_world_quest_get_me_outa_here.sql * Fix hook that got renamed * Update 9999_99_99_99_world_quest_get_me_outa_here.sql * Rename 9999_99_99_99_world_quest_get_me_outa_here.sql to 2019_05_11_08_world.sql
2019-05-10Core/Movement: Use correct root checkShauren
2019-05-10Core/Movement: Prevent rooted units from fallingShauren
* Fixes a client freeze Closes #23042
2019-05-10Core/Spells: Return CheckCast result from CastSpell (#23236)brotalnia
* Return CheckCast result from CastSpell * Return cast result from UnitAI methods too.
2019-05-10Core/Movement: Fix Warrior's Charge launch visual while jumping backw… ↵Aokromes
(#23243) * Core/Movement: Fix Warrior's Charge launch visual while jumping backwards By Natureknight * fix no-pch
2019-05-10Core/Quest: improve source item deletion logic for items that give quests ↵Wyrserth
(#23250) * Core/Quest: improve source item deletion logic for items that give quests. Prevent deletion of items that aren't supposed to be destroyed (like Demon Scarred Cloak). * Whoops.
2019-05-08Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening questKeader
killer can be a pet