aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2021-12-18Core/Misc: Fix static analysis issuesGiacomo Pozzoni
Fix static analysis issues reported by Coverity (cherry picked from commit ca8953a0ec8356345147b2bbc7bbdf0fa97cd625)
2021-12-18Scripts/Tempest Keep: Fixed a typo in Nethermancer SepethreaKeader
Closes #23828 Ty Rizztazz (cherry picked from commit 746a1d89b34984f31ab66ef00e93a648dc42af5d)
2021-12-18Core/Misc: Fix static analysis issueGiacomo Pozzoni
Fix static analysis issue (cherry picked from commit ed087546635331e4cff4e97772a9f9978f4b1833)
2021-12-18Fix inconsistent NPC aggro on spell miss (#23816)tarwyn
(cherry picked from commit c8dc9fdc418d9703893e21603b7593b015f08fea)
2021-12-18Core/Movement: provide an extra spline path vertex for taxi pathings … ↵Ovah
(#23817) * Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost. * Update FlightPathMovementGenerator.cpp (cherry picked from commit cf3277c641bd877b9fa1939da5da7cde1778561b)
2021-12-18Instance/Script: Gorkun Ironskull & Martin VictusKillyana
(cherry picked from commit 8e3862cfbd9ee677866fbbee60c3b96ee3f4868a)
2021-12-18Core/Map: Move a log from ERROR to WARNjackpoz
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive (cherry picked from commit 42ab6010f862e530517e2acd347ef6230bcf1c3b)
2021-12-18Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810)Gildor
(cherry picked from commit a392216d209c6c4184581eca58e014c8babe24e1)
2021-12-18Core/Calendar: Add some additional validation when creating events (#23797)Giacomo Pozzoni
* Core/Calendar: Add some additional validation when creating events Allow only 30 player events and 100 guild events to be created. Don't allow to create guild events if player is not in guild. Send some more error messages to the client (not blizzlike errors but better than nothing). * Core/Calendar: Add some additional validation/checks Add guild id check in GetPlayerEvents(). Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past. * Core/Calendar: Add some additional validation/checks Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3. * Core/Calendar: Add some additional validation/checks Implement 5 seconds cooldown between the creation of calendar events * Core/Calendar: Add some additional validation/checks Don't allow to copy events of a different player/guild * Core/Calendar: Implement automatic deletion of old events Implement automatic deletion of events older than 1 month (30 days). Fix debug assertion triggered when deleting a character with calendar events. Avoid double std::set lookup when deleting events when deleting a character. NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits. (cherry picked from commit fb059722fdb18a94d47b3f44a5b2d7f183bf5a29)
2021-12-18Core/Commands: Fixed wrong permissions for .lookup map commands (#23800)Kelno
(cherry picked from commit 6fc7ab3448850199835f9ee9dca6991b511eba09)
2021-12-18Core/Movement: Fix LoS issue of NPCs chasing targetsjackpoz
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target. Fix re-implements 8927a042536d4671e94ad901e9209efcf78ffa2c after 2a84562dc85516f432bb1e5de9add23c28b26ce4 partially removed it. Fix #23724 (cherry picked from commit 215a6cee24896f2def2a5af390c089ac1d947e65)
2021-12-18Core/MovementGenerator: 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633 follow-upjackpoz
(cherry picked from commit 7c0b31b8b52903ec233ad863597965594196a8e8)
2021-12-18Core/MovementGenerator: Fix crash in taxi pathsjackpoz
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground. (cherry picked from commit 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633)
2021-12-18Core/Misc: Fix parry-haste mechanic. (#23773)Gildor
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03ef204289bbd96e8e1e07117b3bebd9f ) Closes #23754 (cherry picked from commit f8d7b260476c69e09ab0329cb7cd6c277f5473a7)
2021-12-18Scripts/Pet: Fix npc_pet_gen_soul_trader not following owner (#23772)Artamedes
(cherry picked from commit 8ecc45cd1aac1c33c8b4cb2f269ac24d728570cc)
2021-12-18Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive ↵Artamedes
Barrage (#23768) (cherry picked from commit 88e74ac3855ebd5ba818c3b12899337829ce2999)
2021-12-18Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill ↵Artamedes
Ick (#23767) (cherry picked from commit a17c83bde84a9f54ad5702f40ff9dd8b54e0afe0)
2021-12-18Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)Artamedes
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls * Cleanup and fix logic + review * Review: remove autos (cherry picked from commit 876a8487301088fec1580e7c9ef6bf98783d9d7d)
2021-12-18Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)Artamedes
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter * qq * qq 2 * tryfix circleci build * review suggestions (cherry picked from commit 832c95fa4f3bb8897481b0c65975b14674bbf7ee)
2021-12-18Scripts/Outland: Change auto to TempSummon* (#23764)Artamedes
(cherry picked from commit 1b095811b82e7bf390e3a3e522e768fc2b42d2b0)
2021-12-18Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)Artamedes
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons * fix nopch (cherry picked from commit 0b3a9e2a2b2537e7224d103947ad6028c6d2e5fe)
2021-12-18Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload ↵Artamedes
and the pet bar disappears (#23762) (cherry picked from commit 6ebe1afeeccb847702c12e522bddaa7b5694dc38)
2021-12-18Core/Creature: Fix another pet assertjackpoz
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell (cherry picked from commit 4074cb0f01d106c69546c3cb944d6fcf92ade456)
2021-12-18Scripts/ICC: Professor Putricide no longer tries to add threat on units it ↵Treeston
cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. (cherry picked from commit 23fd193e4e489bb5f231653987e98ba24448832b)
2021-12-18[3.3.5] Fix spell_area not checking for zoneID for quests (#23719)AlιAѕѕaѕѕιN
* Fix spell_area not checking for zoneID for quests * Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8 * Fix spell_area handle same spell with the same quests Also fix not checking for quest_end at all. * Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d * Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7 * Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d (cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-12-18nopch fixKeader
(cherry picked from commit 10f6e3818578410246750c6fce53d189ad05bee4)
2021-12-18Core/Scripts: Proper fix Gal'Darah Puncture removeKeader
(cherry picked from commit cbc01f35b6b80c1069b2274a619c8f7a3ff730c7)
2021-12-18Fix nopch buildKeader
(cherry picked from commit 1886507e7f91249a335978e2fa1a859e93d56ffa)
2021-12-18Scripts/Gundrak: Fixed Puncture when Gal'darah dieKeader
(cherry picked from commit 130a3859ecdcb0ad9eba180641b2e4ffbca83613)
2021-12-18Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge scriptKeader
Noob Keader, Shame ! (cherry picked from commit 61ad87d1069a1ed44f7ae50f3c0646102b3ccb9a)
2021-12-18Scripts/Spells: Code style adjustments for druid scripts (#23725)Sorikoff
(cherry picked from commit 63bbf4a4bee03a3ca5e73eafcef4976c76d86f5d)
2021-12-18Scripts/Spells: Port druid scripts to new script registration syntax (2 of ↵Sorikoff
3) (#23696) * Scripts/Spells: Port Druid Scripts to New Script Registration * Revert * Revert 2 * Revert 3 * Revert 4 (cherry picked from commit 9a8a01925ae0a02f565fb317a2786e82b20cc298)
2021-12-18Tools/Misc: Document strange array access indexingShauren
Closes #23723 (cherry picked from commit aa0d468e04311ace1e6e5117b4a339c50b636367)
2021-12-18Core/Misc: Fix linux buildjackpoz
(cherry picked from commit c4cce31a13b2e98538f015ecf289856c73f13037)
2021-12-18Core/MMaps: Fix mobs evading when target is out of MMap meshesjackpoz
Fix mobs evading when target is out of MMap meshes causes by an overzealous check added in c602220e02bed1ad76c9e60064eeec5fd97bfe80 when trying to fix an infinite loop in Recast. If the target is outside of the MMap mesh (for example very close to a wall which is an un-walkable area with current TrinityCore settings and that might be changed in the future) Detour will not be able to find the height of the poly and getPolyHeight() will return DT_FAILURE | DT_INVALID_PARAM . Most of the time this is ok and can be ignored and it's still better than having the Unit evade. Fix #23613 (cherry picked from commit 5a980226497605b18f1855fa39f340c10ee9dd53)
2021-12-18Core/Map: Kill zoneId from RespawnInfo, all it did was significantly slow ↵Shauren
down startup to make one gm command faster (cherry picked from commit 3a4216fd979eb2a7667b0861a770e9af4f242eab)
2021-12-18Core/Spells: Fixed some issues with Drain SoulKeader
Issue 1: Drain soul was always negative, but effect2 need be positive. Issue 2: Drain soul was interrupted if someone in your group die. Caused by negative effects proccing in creature. Issue 3: Since effect2 is positive, it was down-ranking in low level targets and should never happens (fixed before by ariel, transforming everything in negative in 2c8a6fb771a42169a1817149ab0a2a19912ebea7 but it's wrong) (cherry picked from commit 43c08b176115505b76c027667047f9a5bfcc4e11)
2021-12-18Scripts/Spells: Port druid scripts to new script registration syntax (3 of ↵Sorikoff
3) (#23714) (cherry picked from commit f7793e78000389315d53b22fb4e117d512c5a4d6)
2021-12-18Core/Spells: Fixed SPELL_EFFECT_DISPEL when target has 2 spells with same ID ↵Keader
(#23710) Ty sirikfoll for all help :) (cherry picked from commit 95284b23d1e48883fe738ecf5a12c4253566894e)
2021-12-18Entities/Creature: Fix an edge case assertion failure with pets dying in ↵Treeston
specific situations while casting spells. (cherry picked from commit 6590a0bfcefe7b8e5f87c82ba5ab4df2c72be418)
2021-12-18Core/Spells: Survey Sinkholes will now have a bigger range to be able…Aokromes
… to hit all trigger npcs By Ovahlord (cherry picked from commit 028db8432eb220de198123871741fd8c36c52ebe)
2021-12-18Entities/Player: ReacquireSpellFocusTarget is now private. It should've been ↵Treeston
private all along. (cherry picked from commit 1c2b1cbba82fcd523ccd0cceafe532f35d71dcc1)
2021-12-18Core/Creature: Fix an issue that sometimes prevented spellcast focus targets ↵Treeston
from being reacquired. (cherry picked from commit fcce90508d899641494d7c281a0e08e411a0d5ab)
2021-12-18Core/Bnetserver: Added --update-databases-only console argument to bnetserverShauren
2021-12-18[3.3.5] Core/Authserver: TOTP rewrite: (PR #23633)Treeston
- Proper management commands (.account 2fa) - Secrets can now be encrypted (set TOTPTokenSecret in .conf) - Secret now stored in binary - Argon2 and AES primitives - Base32/64 support (cherry picked from commit 4211645834c467a03c60248e80818d3607be9ea7)
2021-12-18Core/Channels: Fix a bug that would cause channel settings to disappear in ↵Treeston
certain settings. Fix a bug that would cause channels to not be saved on .server shutdown without delay. Closes #23699. (cherry picked from commit 464b0b059b5ccb7db6d2f282937711032005b5c3)
2021-12-18Scripts/Spells: Runic Healing Injector (#23690)Sorikoff
* Scripts/Spells: Runic Healing Injector * Rename 9999_99_99_99_world.sql to 2019_08_08_00_world.sql (cherry picked from commit 382f563571d39f9ec02a0df899dbdaaf1745af83)
2021-12-18Scripts/Spells: Port Part of Druid Scripts to New Script Registration (#23691)Sorikoff
(cherry picked from commit 996d4f7cc49041d57ab6152961dd645784b909a7)
2021-12-18Scripts/Commands: Add .go boss, and do a usability pass over .go instance to ↵Treeston
match it. (cherry picked from commit 57b36dfdc6b077cc4eba29406e3ded4dbf9f8ce6)
2021-12-18Scripts/Commands: Cleanup some output from .go instanceTreeston
(cherry picked from commit 4320a021e93423122745684e2689aa1a7028f8b4)