Commit Graph

25313 Commits

Author SHA1 Message Date
Shauren
0b2087ae41 Core/Criteria: Add all values of CriteriaStartEvent 2021-06-01 21:16:41 +02:00
Shauren
4b6ddfbbcc Core/Criteria: Add all values of CriteriaFailEvent 2021-06-01 21:04:22 +02:00
KoNicks
cfd4f18885 Core/Misc: Fix build when using libstdc++-11 (#26565) 2021-05-30 20:00:34 +02:00
Shauren
b29cc8f31a Fix build 2021-05-29 22:04:49 +02:00
Kittnz
299746f9f6 Scripts/Outland: Implement Hellfire event in Honor Hold (#21110)
* Script/Outland: Implement Hellfire event in Honor Hold

This is hourly, event is only 60 seconds long.

(cherry picked from commit acc73d4693)
2021-05-29 21:27:11 +02:00
ariel-
63f9b52ea1 Core/Misc: kill whitespace
(cherry picked from commit f50a333418)
2021-05-29 21:27:11 +02:00
lachtanek
5e774fc7f1 Core/Pools: Fixed spawning in pools with both explicitly and equally chanced entries (#21170)
(cherry picked from commit c50aefac96)
2021-05-29 21:27:11 +02:00
Shauren
6ecfe58cae Core/Maps & Extractors: Move copypasted map file headers into a single shared file and replace #defines with enums 2021-05-29 21:21:37 +02:00
Shauren
2de6e56d29 Core/Misc: Rename MapDefines.h to MMapDefines.h as it contains mmap defines exclusively 2021-05-29 14:48:18 +02:00
sueastward
28c075765b Scripts/Spells: Implement mage Alter Time 2021-05-27 12:56:10 +02:00
Shauren
480039f913 Core/Logging: Add functions that allow creating loggers and appenders from other sources than config files 2021-05-27 11:47:51 +02:00
Shauren
3c08eb190f Core/Misc: Add another boost hack. Fixes bnetserver/worldserver -c command line parameter when path contains spaces 2021-05-24 00:08:03 +02:00
Shauren
ce37c24481 Core/PacketIO: Properly send inventory error when attempting to withdraw guild bank item into "any slot" when bags are full 2021-05-23 01:39:08 +02:00
Luzifix
7f7ccfd6cd Core/PacketIO: Implement new guild bank item swap opcodes 2021-05-23 01:39:08 +02:00
Luzifix
07ee254b7d Core/PacketIO: Delete old guild bank swap item structures and handler 2021-05-23 01:39:08 +02:00
Shauren
de59dea83f Core/Misc: Initialize local variable 2021-05-23 01:39:08 +02:00
Shauren
9d4ccbda34 Core/PacketIO: Add new guild bank interaction opcodes 2021-05-23 01:39:08 +02:00
Shauren
daa09f3346 Core/PacketIO: Fixed swapped values for bank interaction opcodes 2021-05-22 23:35:46 +02:00
MistiX
c22f27a767 Core/PlayerChoice: Fixed loading player_choice_response from db (#26541) 2021-05-22 15:13:50 +02:00
Shauren
622cec8a8f Core/Vmaps: Fixed crash in unloading vmaps
Closes #26536
2021-05-21 12:31:21 +02:00
Shauren
3df64ceff4 Core/Items: Fixed crash happening when deleting item before it was saved for the first time
Closes #26532
2021-05-18 14:41:06 +02:00
Treeston
ac8ff49274 Core/Unit: Abide UNIT_FLAG2_DISABLE_TURN on creatures. Add that flag to Kologarn (from sniff). Hi sirikfoll.
(cherry picked from commit d9c772303c)
2021-05-17 00:36:06 +02:00
Treeston
563188fe4b 3dcd49e v2, slightly cheaper
(cherry picked from commit b53cbf467b)
2021-05-17 00:06:52 +02:00
Treeston
7cd61b581c Core/Threat: fix a potential super edge case iterator invalidation
(cherry picked from commit 3dcd49ef90)
2021-05-17 00:05:47 +02:00
Treeston
4a65dcaecb Scripts/World: New target dummy AI, because I don't trust the existing one in light of #21187.
(cherry picked from commit a23c97a0fc)
2021-05-17 00:02:27 +02:00
Treeston
e090c9a00e Scripts/Commands: New command: .debug threatinfo
(cherry picked from commit f45c211987)
2021-05-16 21:57:35 +02:00
Chaouki Dhib
0ce1e9d652 Core/Movement: Correct the allowed distance to target before a repositioning is necessary. #20173
Also getting rid of the wordserveur config parameter 'TargetPosRecalculateRange' since it is no longer needed.

(cherry picked from commit 274dede3dc)
2021-05-16 21:56:07 +02:00
xinef1
1912999b9e Core/Spells: Defined and implemented some new spell attributes (#18950)
(cherry picked from commit 23823f5147)
2021-05-16 21:56:07 +02:00
Keader
068b4f96e5 Core/Spells: Fixed Shapeshift using macro
Close #21197
Author: lineagedr

(cherry picked from commit 57672fdf25)
2021-05-16 21:56:06 +02:00
kelno
1206e815cd Core/Creature: improve DB linked_respawn handling (#21172)
* Fixed SetCreatureLinkedRespawn function possible erasing/replacing a GameObject link (instead of a creature one)

(cherry picked from commit 70eb18d0e5)
2021-05-16 21:56:06 +02:00
Treeston
a121f47ba3 9ad11e6 follow-up, prevent Halion respawn without loot
tagging #21198

(cherry picked from commit f0a394753a)
2021-05-16 21:56:06 +02:00
Treeston
c31ae7ab33 Core/Threat: Fix a potential exploit allowing players to damage a boss without them taking damage.
Scripts/Halion: General cleanup of old hacks no longer needed under new combat system.

(cherry picked from commit 9ad11e67fb)
2021-05-16 21:56:06 +02:00
Treeston
8b7728f82e Core/Map: New Map::ForceRespawn to override objections and force a respawn (equivalent to force = true). Use this to fix various GM commands.
Scripts/Valithria: Fix an issue that could get the encounter stuck in an unloaded state.

(cherry picked from commit 3bb33e3108)
2021-05-16 21:56:06 +02:00
Shauren
c79e5528e1 Core/Units: Remove Unit::EnergizeBySpell overload taking spellId argument 2021-05-16 21:56:06 +02:00
Shauren
b9d63c2009 Core/Scripts: Remove deprecated overload of QuestReward without LootItemType argument 2021-05-16 21:56:06 +02:00
Treeston
6344ddd633 Core/Threat: only send periodic threat list updates while unit is engaged
(cherry picked from commit a08ad9aac1)
2021-05-16 21:56:05 +02:00
Treeston
dce39aedc2 Core/Combat: Some more sanity check asserts to try and track down #21187.
Also, some anti-annoyance treatment for dot tele.

(cherry picked from commit fdacf12739)
2021-05-16 21:56:05 +02:00
Treeston
2a7bb9b404 Core/Combat: some more detailed assertions to possibly shed light on #21187.
(cherry picked from commit 5a9fddaa5a)
2021-05-16 21:56:05 +02:00
Treeston
b00d3812ab Core/Map: Fix a crash that could happen if a player moved very far away from a creature they were in combat with. Closes #21177.
(cherry picked from commit e0b609a178)
2021-05-16 21:56:05 +02:00
Moein
673cc20e79 MovementInform should overrides
(cherry picked from commit 18f5eae835)
2021-05-16 21:56:05 +02:00
Treeston
5aee452943 Core/Misc: A variety of clean-up changes, mostly following up on 532ab1c to fix legacy bugs exposed by it:
- Triggers can no longer have a threat list (this may expose some ugliness in old legacy scripts)
- Threat entries are forced to OFFLINE if the AI refuses to attack the target
- Clean up passive creature evade behavior to be more consistent
- Fix a months old issue in spawn group management that would cause "Inactive" to incorrectly show in .list respawns for system groups outside of map 0
- Valithria script cleanups, remove old hacks and make it work with the new system. Closes #21174.
- Some strings cleanup

(cherry picked from commit 9f9507e6a1)
2021-05-16 21:56:05 +02:00
ariel-
83159544b5 Core/Spells: fix casting NO_TARGET event spells
Closes #19978

(cherry picked from commit e245113660)
2021-05-16 21:56:05 +02:00
Treeston
34c7810fe5 Core: Combat/threat system rewrite (PR #19930)
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
  - They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
  - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
  - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.

Closes #7951 and #19998.

(cherry picked from commit 532ab1c7f8)
2021-05-16 21:56:01 +02:00
Shauren
5158136ee8 Core/Players: Fixed last tick of power regeneration when reaching minimum or maximum value not being visible clientside and not triggering auras on power value change 2021-05-15 17:44:31 +02:00
Shauren
12ed21e690 Scripts/Spells: Clear arcane charge damage/cost/cast time modifier aura when reaching 0 arcane charges (power) 2021-05-15 17:44:31 +02:00
Shauren
331c7ec7c2 Scripts/Spells: Remove manual damage adjustment from Arcane Barrage for scaling with arcane charges and use spell cast for mana energize 2021-05-15 17:44:31 +02:00
Shauren
fd7f854995 Scripts/Spells: Properly utilize all Arcane Explosion energize effects 2021-05-15 17:44:31 +02:00
Matan Shukry
be8cbab4b3 Scripts/Spells: Fixed arcane barrage + explosion 2021-05-15 17:44:31 +02:00
Shauren
e2964dadf4 Fixed nopch build with clang 11 2021-05-15 02:17:08 +02:00
Shauren
b511fac643 Core/Spells: Send actual power gain amount in spell energize log 2021-05-15 02:15:09 +02:00