Commit Graph

15405 Commits

Author SHA1 Message Date
offl
2681143141 Scripts/Pet: Update pet scripts to new register model (2/2) (#26662) 2021-07-11 14:56:06 +03:00
offl
51c94fed9a Scripts/Pet: Update pet scripts to new register model (1/2) (#26661) 2021-07-11 14:55:47 +03:00
jackpoz
40f4b141bd Core/Unit: Include m_Controlled in crashlogs 2021-07-11 11:55:23 +02:00
Chaouki Dhib
4806b3a860 Core:Movement: Replace assert by logging and returning in case of unexpected case in WorldSession::ReadMovementInfo 2021-07-04 23:00:55 +02:00
Chaouki Dhib
722bd7e0e5 Core/Movement: Add missing change to the unit validation of ACK handlers 2021-07-04 22:25:37 +02:00
Chaouki Dhib
7314d5b992 Core/Movement: Fix crash that occurs when ReadMovementInfo is called with mi.guid is not set 2021-07-04 22:24:03 +02:00
Chaouki Dhib
ef113ce673 Revert "Core/Movement: Better handle cases of passing incomplete data to ReadMovementInfo()"
This reverts commit 0c90970b06.
2021-07-04 22:01:22 +02:00
jackpoz
0c90970b06 Core/Movement: Better handle cases of passing incomplete data to ReadMovementInfo()
ReadMovementInfo() checks MovementInfo::guid but that field is not always set by the callers. An error is logged in that case, skipping triggering an assert.
2021-07-04 20:06:21 +02:00
jackpoz
479c636612 Core/Movement: Include GetGameClientMovingMe() details in assert logs 2021-07-04 19:40:28 +02:00
Chaouki Dhib
fdbff48808 Core/Movement: Fix movement handler crash during ReadMovementInfo check (#26644)
* Core/Movement: Fix movement handler crash during ReadMovementInfo check

* fix noph build

* add an assert
2021-07-04 18:49:30 +02:00
Peter Keresztes Schmidt
3bcda5acf4 Scripts/SholazarBasin: Fix a possible nullptr dereference issue found by coverity (#26648) 2021-07-03 12:08:30 +02:00
Carbenium
6b9afac82f Scripts/Commands: Convert misc command table to new system 2021-06-28 00:45:44 +02:00
Carbenium
5a5b232a44 Scripts/Commands: Convert honor command table to new system 2021-06-28 00:44:44 +02:00
Giacomo Pozzoni
c8ca48823d Core/Pools: Fix pools with 1 member never spawning anything anymore (#26620)
* Core/Pools: Fix pools with 1 member never spawning anything anymore

Attempts to fix a 6 years old bug and never fixed by the original author.

* Remove respawn times from db once a respawn has been handled

* Allow to specify if Despawn1Object() should save or not the respawn time. We don't need to do that when respawning an object.

* Apply the same fix to GameObjects too
2021-06-26 14:21:18 +02:00
Giacomo Pozzoni
84c8d21ad3 Core/SAI: Add a warning when a boolean value is outside of [0,1] range (#26608)
* Core/SAI: Add a warning when a boolean value is outside of [0,1] range

*  Replace boolean fields in SAI with SAIBool (from uint32)
2021-06-25 20:44:28 +02:00
Carbenium
c08f086a02 Scripts/SholazarBasin: Make quest "Engineering a Disaster" more retail-like
* Use correct spells and add the appropriate spell scripts
* Use correct flame GOs
* Fix emotes of the escortee
2021-06-24 22:50:57 +02:00
Kelno
17ed3fd1dc Core/Misc: Clear unused undef leftover in a refactor (#26616)
Previously this function was using a macro that was #undef at the end of the function. Since then it uses a lambda function and the undef is not needed anymore.
2021-06-22 16:30:33 +02:00
jackpoz
33dace231c Core/Misc: Fix issues reported by static analysis 2021-06-20 13:11:53 +02:00
Gildor
5446209b89 Scripts/Commands: Minor improvements in .pinfo and .unban character commands (#26586)
* Scripts/Commands: Minor improvements in .pinfo and .unban character commands
2021-06-20 12:08:12 +02:00
shenhuyong
9b05c3967b Fix kick after map changed and speed changed 2021-06-19 21:17:42 +02:00
Kelno
c3a013c499 Core/Config:Remove now unused CONFIG_SET_SHAPASSHASH config (#26606)
This is a leftover from bcdbdd6f23
2021-06-19 16:02:05 +02:00
jackpoz
5628ca7f7c Core/SAI: Allow SMART_ACTION_SUMMON_CREATURE to summon more than 1 creature
Add 6th parameter "count" to SMART_ACTION_SUMMON_CREATURE action to summon more than 1 creature. For backward compatibility, a value of 0 will be treated as 1.
2021-06-17 19:47:50 +02:00
Giacomo Pozzoni
38a661b8db Core/Misc: Fix no-pch build 2021-06-17 11:45:21 +02:00
Giacomo Pozzoni
e655783431 Core/Movement: Wrap recent kicks about a setting and improve logs.
Wrap recent kicks added related to speed change ack packets around the same "AntiCheat.PendingMoveChangesTimeoutTime" setting used by other anti-cheat kicks.
Log more details about why a kick was triggered.
2021-06-17 11:35:50 +02:00
jackpoz
32fd44d2aa Core/Misc: Fix issues reported by static analysis 2021-06-15 23:17:51 +02:00
Chaouki Dhib
d337fb99ed Core/Movement: Implement proper player speed change (#26561) 2021-06-15 23:09:48 +02:00
jackpoz
4b9465e1f9 Scripts/Misc: Fix issues reported by static analysis 2021-06-15 22:55:50 +02:00
Shauren
4acd6e1d38 Core/Pets: Fixed saving pets put in stable while not being summoned
Closes #26599
2021-06-14 13:07:40 +02:00
Giacomo Pozzoni
8d92f6f2b4 Core/Loot: Allow master looter to see all quest items (#26584) 2021-06-13 19:41:51 +02:00
jackpoz
e9a8cea018 Scripts/UBRS: Fix crash
Fix crash triggered during Dragonspire Hall event caused by having more than 5 mobs near a rune.
Crash added in 7c19fb8d0e
Fix #26589
2021-06-12 18:02:01 +02:00
offl
180f495c70 Scripts/Misc: Remove few more evil flags
Ref #25764
2021-06-10 19:15:35 +03:00
offl
8a2c1377a9 Scripts/Quest: Rework 'Taken by the Scourge' (11611) (#26578) 2021-06-09 19:17:24 +03:00
offl
3d0a081f8e Scripts/Instances/Underbog: Rework Hungarfen (#26567) 2021-06-09 19:16:55 +03:00
Giacomo Pozzoni
9e7cdb02d2 Core/SAI: Add support to friendly+hostile to SMART_EVENT_OOC_LOS and SMART_EVENT_IC_LOS (#26579)
Change SMART_EVENT_OOC_LOS and SMART_EVENT_IC_LOS first parameter to have 3 values:
- 0 : Hostile
- 1 : Not hostile (not that Friendly and Not hostile have different meanings)
- 2 : Any, as in both Hostile and Not hostile

Close #24789

* Add validation on startup for allowed values.
Code cleanup.

* Fix errors
2021-06-08 18:59:46 +03:00
offl
7c6ee033e0 Scripts/Instances/EoE: Update Malygos to new register model (#26583) 2021-06-07 00:32:57 +03:00
offl
2a556b900c Scripts/Instances/DK: Update Trollgore to new register model (#26582) 2021-06-07 00:32:41 +03:00
offl
f5a4b95a02 Scripts/Instances/DK: Update Tharon'ja to new register model (#26581) 2021-06-07 00:32:23 +03:00
offl
cdfce090fc Scripts/Instances/DK: Update Novos to new register model (#26580) 2021-06-07 00:32:09 +03:00
offl
0051b3e345 Scripts/Zone: Update IoC scripts to new register model (#26571) 2021-06-07 00:26:32 +03:00
offl
dadc67c883 Scripts/Zone: Update Blasted Lands scripts to new register model (#26570) 2021-06-07 00:26:18 +03:00
offl
7b9476ea4b Scripts/Instances: Update Mechanar scripts to new register model (#26569) 2021-06-07 00:26:02 +03:00
offl
57d369dd6a Scripts/Instances: Update Slave Pens scripts to new register model (#26568) 2021-06-07 00:25:46 +03:00
jackpoz
483f24c5ed Core/SAI: Fix typo 2021-06-06 18:07:55 +02:00
Matan Shukry
e6a36f058e Core/SAI: Don't clear stored pathid if it changed after processing waypoint events (#26334)
(cherry picked from commit 8b0de23d0e)

# Conflicts:
#	src/server/game/AI/SmartScripts/SmartScriptMgr.cpp
2021-06-06 18:04:43 +02:00
Giacomo Pozzoni
9fe9dc087b Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH (#26549)
* Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH

Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH to keep movement generators even after death.

Fixes #23095
Could replace ff26027453

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Keep MoveJump movement generator after death

Co-authored-by: ccrs <ccrs@users.noreply.github.com>
2021-06-06 17:51:00 +02:00
Shauren
9f852c27b9 Core/Players: Add PlayerExtraFlags for tracking race change, and raf level grant usage 2021-06-06 14:10:23 +02:00
jackpoz
af815e991d Core/Player: Log more information when Player::StopCastingCharm() fails 2021-06-05 18:41:51 +02:00
jackpoz
105c70802d Scripts/Commands: Fix crashes with ".group revive" and ".group repair"
Close #26575
2021-06-05 12:37:30 +02:00
ccrs
a57bbe0394 Core/Movement: comment unused parameter
/home/runner/work/TrinityCore/TrinityCore/src/server/game/AI/CoreAI/PassiveAI.cpp:82:52: error: unused parameter ‘id’ [-Werror=unused-parameter]
 void CritterAI::MovementInform(uint32 type, uint32 id)
                                             ~~~~~~~^~
compilation terminated due to -Wfatal-errors.
2021-06-03 15:59:42 +02:00
ccrs
303e01c834 Core/Movement: remove redundant method MovementGenerator::NotifyAIOnFinalize and use existing Finalize - MovementInform implementation
6fde051e4e follow up
2021-06-03 15:01:47 +02:00