Commit Graph

4205 Commits

Author SHA1 Message Date
jackpoz
2edfedc2b6 Scripts/Azjol-Nerub: fix static analysis issues 2016-10-08 19:21:40 +02:00
Kittnz
eee7fa3fa7 Core/Scripts: Initialize rnd and remove where it was not needed 2016-10-08 16:43:08 +02:00
Kittnz
963278459a Core/Event: Pirate Day Music during the event 2016-10-08 15:49:18 +02:00
Kittnz
e3560f3f51 Core/Event: Add Darkmoon Fair Music during the event 2016-10-08 15:43:13 +02:00
Kittnz
19f8acdb61 Core/Event: Add Midsummer Music during the event 2016-10-08 15:38:17 +02:00
SnapperRy
a0c9d33ed6 Battlefield/Wintergrasp: improvements:
- Move Wintergrasp Keep guard spawns from core to db, removing all duplicates in the meanwhile.
- Add Alliance Brigadier General inside the relic room.

Closes #7593.
2016-10-08 14:16:05 +02:00
ariel-
66688a7855 Core/Channel: revamp channel system (#17980)
* Core/Channel: change the way channels are stored and sent to client.

- Fixes multiple channels per zone when using different locales
- Connected clients will receive locally the name of the channel for their apropiate locale (if available)
- In other cases default locale name will be sent, so as to prevent breaking channel chat for those players

Closes #8411
2016-10-07 00:59:56 -03:00
ariel-
dbba3ad5a5 Core/Scripts: Fix some runtime errors 2016-10-07 00:14:46 -03:00
Kittnz
3eacc25e5d Core/Event: Fix Brewfest Music
Was only playing the same song over and over again.
2016-10-06 20:14:53 +02:00
ariel-
a0e317b991 Core/Scripts: De-hack glyph of Barkskin with proper spell 2016-10-06 00:59:26 -03:00
SnapperRy
81d4c02f34 Fix non PCH build. 2016-10-06 00:17:28 +02:00
Kittnz
002b0a7a65 Core/Event: Add Brewfest Music during the event
Note: Dark Iron invasion music can be added with a trigger at a later stage
2016-10-05 22:34:04 +02:00
ariel-
b5e8e0a5db Core/Auras: reset periodic aura timers by default. Except when aura comes from triggered spell
Closes #17961
2016-10-05 03:10:05 -03:00
ariel-
d482b0e368 Core/Scripts: add a workaround for Will of the Forsaken shared cooldown
Closes #7151
2016-10-05 01:40:00 -03:00
ariel-
51493a63e2 Core/Scripts: fix 2 runtime error logs 2016-10-04 22:34:39 -03:00
ariel-
66749470ef Core/Scripts: add even more headers 2016-10-04 21:13:27 -03:00
ariel-
192f8186bd Core/Scripts: add more headers required for NoPCH 2016-10-04 21:10:57 -03:00
ariel-
dc7a1894c5 Core/Scripts: add headers required for NoPCH build 2016-10-04 21:08:03 -03:00
ariel-
2ff855054f Core/Scripts: Convert spells to new proc system
- Converted Unit::HandleDummyAuraProc function to AuraScripts
  * Extra: DMC: Madness now uses DB texts. yay!
  * Extra: improvements on Imp. Spell Reflection (range and max targets, filter caster with conditions)

- Fixed Glyph of Succubus. (Closes #6599)

- Changed old (not-blizz) behavior of Vampiric Embrace:
  * Before: party heal affected the priest too and self heal was reduced by that amount to not over-heal
  * Now: self heal amount not affected, rather filter the priest out of the party heal using conditions :)

- Solve bug in AQ 3p set bonus, it should only trigger when healing others, not self heals.
- Priest T10 2p bonus (heal) now rolls its effect properly

- Use brand new GetEffectiveHeal to fix #17142
- While we're at it, also close #17034 for good
- Converted Unit::HandleAuraProc function to AuraScripts (#17941)
- Converted Unit::HandleAuraProc function to AuraScripts (cont'd) (#17955)
- Corrected Flametongue weapon damage formula
- Actually check offhand weapon for flametongue in Lava Lash script
- Implemented halved proc chance for Missile Barrage on Arcane Barrage, Fireball, Frostbolt and Frostfire Bolt cast
- Converted Unit::HandleProcTriggerSpell function to AuraScripts (#17956)
- De-hack Earth shield. Fixes #13808
- Updated Honor among Thieves
- Implemented mana proc for Mark of Conquest in case of ranged attack
- Fixed Scent of Blood giving more stacks than the talent rank currently learnt.
- Ported old proc table. Proc system is dead. Long live the proc system!
- Recklessness should get charges removed per cast. Closes #15529
- Use proc system to remove Molten Core charges on Incinerate/Soul Fire cast. Closes #15942

Closes #3463
Closes #5401
Closes #15595
Closes #15974
Closes #16679
Closes #17925
2016-10-04 20:21:58 -03:00
ariel-
e641d0c7d7 Core/Spells: Implementation of QAston proc system
- Move checks from Unit::IsTriggeredAtSpellProcEvent (old system) to Aura::IsProcTriggeredOnEvent (new system)
- Templatize SpellModOp param of Player::ApplySpellMod, also killed charge counter from SpellModifier and Player system for handling charges... no point in having 3 different systems doing the same thing
- Automatically add default entries to spellProcMap, based on spellinfo (else auras won't proc without an entry) Based on old Unit::ProcDamageAndSpellFor
- Old Unit::ProcDamageAndSpellFor renamed to Unit::ProcSkillsAndReactives and made private, will no longer handle auras.
- Start making use of HealInfo::AbsorbHeal in unit calculations, add effective healing info to HealInfo struct
- Changes in spell reflection system, emulates old behaviour, delaying aura drop
- Removed old charge count hacks in SpellMgr::LoadSpellInfoCorrections
- Removed bogus error log when procChance is 0: Some auras have initial 0 procChance but modified by SPELLMOD_CHANCE_OF_SUCCESS
- Fixed TriggerAurasProcOnEvent logic that tried to trigger twice from actor.
- Allow non damaging spells with DamageClass Melee or Ranged to proc character enchants. Ref issue #17034:

  * http://web.archive.org/web/20110309092008/http://elitistjerks.com/f47/t49865-paladin_retribution_pve/
  * When an auto-attack lands (does not dodge/parry/miss) that can proc a seal the of the following things happen independently of each other (see 2 roll system).

  * 1) A "hidden strike" which uses melee combat mechanics occurs. If it lands it refreshes/stacks SoV DoT. Only white swings can trigger a refresh or stack. (This hidden strike mechanic can also proc things like berserking..)
  * 2) A weapon damage based proc will occur if you used a special (CS/DS/judge) or if you have a 5 stack (from auto attacks). This attack can not be avoided.

  * Holy Vengeance is the "hidden strike" it has an apply aura effect and damage class melee.
- Fixed Blood Tap interaction with Death Runes (btw, don't know what was going on with those MiscValueB, spell 45529 doesn't have any MiscValueB in SPELL_EFFECT_ACTIVATE_RUNE)
- Ported some AuraEffect checks from old Unit.cpp function. added new AuraScript hook to check procs of an specific effect
- Allow only AuraEffects that passed the check to proc, this won't block whole aura from proccing (and lose charges) if at least one of the effects procs, though
- Changes in spell mod system (for SPELLMOD_CASTING_TIME). fixes #17558.
- Added an exception for SPELLMOD_CRITICAL_CHANCE too, fixes #15193
2016-10-04 20:21:55 -03:00
Aokromes
308a2413a1 Scripts/Wintergrasp: Fix vehicle teleporter (#17550)
By WoWErrorDev, closes #5831.
2016-10-04 20:55:05 +02:00
SnapperRy
fd620ca7d6 Core/Conditions: partially revert 723c253, replacing CONDITION_WINTERGRASP_HORDE with a ConditionScript. 2016-10-04 18:47:58 +02:00
ariel-
83771597c1 Core/Scripts: kill whitespace 2016-10-04 10:15:37 -03:00
treeston
84cf239fda Various: Fix coverity reported issues. 2016-10-04 13:49:05 +02:00
ariel-
0c24e4ee0e Core/Unit: rewrite of the attack table system
- Removed a bunch of duplicated code
- Fix off-by-one errors in Unit::RollMeleeOutcomeAgainst and Unit::MeleeSpellHitResult (TC's combat table was actually of 100.01%)
- Implemented boss-level hit table (6.5% dodge/14% parry), bosses only had 5.6% of each until now
- Updated formula for chance and damage of Glancing hits

Sources:
- http://wow.gamepedia.com/index.php?title=Attack_table&oldid=2071465
- http://web.archive.org/web/20100903145646/http://www.mmo-champion.com/threads/650071-Expertise-Hit-for-Paladins-%28updated-for-3.3%29?daysprune=60
2016-10-04 01:26:34 -03:00
SnapperRy
790844e72d Script/Quest: A Cry For Help: (#18026)
- Add missing dialogue from Cowlen.
- Timers and emotes.
2016-10-03 23:47:41 +02:00
SnapperRy
6cef1de8d3 Core/Quest: Gordunni Cobalt:
- Add second gameobject (Gordunni Dirt Mound, containing only junk items) that can spawn in place of the first (same name, but contains the quest item), 50% chance.
2016-10-03 13:30:14 +02:00
ariel-
b54042d68f Core/Spells: Flag of Ownership shouldn't target creatures 2016-10-02 22:15:09 -03:00
SnapperRy
4147312d29 Script/Quest: fix text for creature Gelkak involved in quest Gyromast's Revenge.
Gelkak is supposed to say it, not The Threshwackonator 4100.
2016-10-01 22:43:43 +02:00
SnapperRy
d59f111cab Core/Script: make creature Webbed Creature spawn creature Expedition Researcher when appropriate.
Also don't allow it to spawn a copy of itself.
2016-10-01 14:15:39 +02:00
Keader
05c2fa2e02 Core/Scripts: Fixed Gunship Mage cast interrupt
Closes: #14912
2016-09-27 00:23:58 +01:00
treeston
5e5fe37a7e and you get a header, and everyone gets a header... 2016-09-27 01:17:40 +02:00
treeston
2528194cc1 .....hail PCH 2016-09-27 01:15:00 +02:00
treeston
dbe0789eba ...for real this time (seriously - what happened to test builds before merging, Aok?) 2016-09-27 01:11:51 +02:00
treeston
e121d66fbb Fix nonPCH. 2016-09-27 01:10:39 +02:00
Treeston
ae163197a7 I think I got all of them this time
No idea how this one got past travis.
2016-09-27 01:05:07 +02:00
Aokromes
aeb20951bb Update boss_hadronox.cpp
I hate travis, learn from buildbot
2016-09-27 01:01:08 +02:00
Aokromes
04ec868768 Update boss_hadronox.cpp 2016-09-27 00:30:21 +02:00
Treeston
4b990eb7d7 [3.3.5] Azjol-Nerub rewrite
* Scripts/AzjolNerub: Complete rewrite.
- Gatewatcher:
  - Trash now actually engages properly one by one
  - Fix trash spell casting
  - Add missing quotes
- Hadronox:
  - Everything. Literally.
- Anub'arak:
  - Fix add spawns
  - Fix impale
  - OK this might as well be "fix everything with every boss". Because that's pretty much what happened.
- General hack cleanup

* Update and rename 9999_99_99_99_AZJOLNERUB.sql to 2016_09_25_01_world.sql

* Update and rename 2016_09_25_01_world.sql to 2016_09_25_02_world.sql

* Rename 2016_09_25_02_world.sql to 2016_09_26_02_world.sql
2016-09-26 12:49:32 +02:00
ariel-
6174091d76 Core/Scripts: Fix build 2016-09-25 14:25:13 -03:00
SnapperRy
31e495f44c Script/Quest: Trail of Fire (#17939) 2016-09-25 19:14:50 +02:00
tkrokli
cd6fcce84b Core/Scripts: move #define to enum/boss emote to DB (#17967)
boss_lurker_below.cpp : remove deprecated #define entries
- remove hardcoded text, use creature_text/broadcast_text
- move #define value & text reference to enum section
- replace TextEmote() with Talk() pointing to DB entry
2016-09-24 19:20:12 +02:00
jackpoz
c4865fe63e Scripts/ICC: Fix chest loot exploit
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.
2016-09-24 14:43:18 +02:00
tkrokli
3ad76dea7b Core/Scripts: move npc_lunaclaw_spirit to SAI
This PR moves the core script `npc_lunaclaw_spirit` to SAI, removing hardcoded text.
The quests 6001 + 6002 are druid class quests to get bear form, removed in patch 4.0.3a

Changes in this PR:
- remove core script, including hardcoded text (with typo)
- use gossip_menu_option for each faction (Alliance & Horde)
- add SAI script to complete quest 6001 or 6002 based on option
- add gossip option conditions for team A (469) or team H (67)
- add gossip option conditions for quest 6001/6002 not completed
2016-09-24 02:26:04 +02:00
SnapperRy
0d70a7349d Script/Quest: The Exorcism of Colonel Jules:
- Summoned NPCs will no longer give experience on kill.
- Require quests Fel Spirits and Digging for Prayer Beads to be completed.
- Reduce number of Foul Purges spawned in a single wave (only two should spawn each time).
- Properly give quest credit when talking with Colonel Jules after the exorcism.
2016-09-24 01:32:20 +02:00
treeston
429700e614 Scripts/IcecrownCitadel: Fix an issue where Deathbringer Saurfang's exit door could get stuck in a closed state. Fixes and closes #15018. 2016-09-22 15:22:54 +02:00
Keader
1f83412e4d Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900) 2016-09-22 03:18:43 +02:00
Treeston
7860da0de6 Code style follow-up, I blame Notepad++. 2016-09-20 20:28:59 +02:00
treeston
2170541a51 Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.
2016-09-20 20:19:15 +02:00
treeston
3298a5f65d 5952752 follow-up: Member declaration now matches order of usage. 2016-09-20 14:25:48 +02:00