Commit Graph

11638 Commits

Author SHA1 Message Date
SnapperRy
3d075da504 Core/Creature: update health/mana/damage/armor when changing a creature's entry while keeping the original level.
Fixes an issue introduced in a6ef9d4.
2016-09-24 03:50:20 +02:00
tkrokli
3ad76dea7b Core/Scripts: move npc_lunaclaw_spirit to SAI
This PR moves the core script `npc_lunaclaw_spirit` to SAI, removing hardcoded text.
The quests 6001 + 6002 are druid class quests to get bear form, removed in patch 4.0.3a

Changes in this PR:
- remove core script, including hardcoded text (with typo)
- use gossip_menu_option for each faction (Alliance & Horde)
- add SAI script to complete quest 6001 or 6002 based on option
- add gossip option conditions for team A (469) or team H (67)
- add gossip option conditions for quest 6001/6002 not completed
2016-09-24 02:26:04 +02:00
SnapperRy
0d70a7349d Script/Quest: The Exorcism of Colonel Jules:
- Summoned NPCs will no longer give experience on kill.
- Require quests Fel Spirits and Digging for Prayer Beads to be completed.
- Reduce number of Foul Purges spawned in a single wave (only two should spawn each time).
- Properly give quest credit when talking with Colonel Jules after the exorcism.
2016-09-24 01:32:20 +02:00
treeston
429700e614 Scripts/IcecrownCitadel: Fix an issue where Deathbringer Saurfang's exit door could get stuck in a closed state. Fixes and closes #15018. 2016-09-22 15:22:54 +02:00
Keader
1f83412e4d Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900) 2016-09-22 03:18:43 +02:00
treeston
55ac0186cc Movement/SplineChain: Fix a potential critical bug where resume info returned during an edge case could fail an assertion when used. 2016-09-22 02:57:07 +02:00
treeston
4deeee66bd d3214a0 follow-up for code style. 2016-09-21 16:49:19 +02:00
treeston
d3214a0012 Movement/SplineChain: Streamline the script workflow for resume info a bit, provide static method that does all the ugly pointer casts for you. Also prevent a nullptr dereference crash if scripts mishandle motionmaster, and canonize Chain == nullptr to signify "no resume info". 2016-09-21 16:22:12 +02:00
treeston
820e843391 Map/InstanceMap: Ease up on a somewhat overzealous error message regarding instance saves. 2016-09-21 15:36:21 +02:00
treeston
3ec1b2f27e Core/Movement: Fix a DB spline chain overload I missed in 2170541 2016-09-21 01:29:48 +02:00
Treeston
7860da0de6 Code style follow-up, I blame Notepad++. 2016-09-20 20:28:59 +02:00
treeston
2170541a51 Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.
2016-09-20 20:19:15 +02:00
treeston
3298a5f65d 5952752 follow-up: Member declaration now matches order of usage. 2016-09-20 14:25:48 +02:00
treeston
59527521e6 Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids. 2016-09-20 14:13:42 +02:00
treeston
4a1a460241 PCH build fix. Again.
(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
2016-09-20 13:23:21 +02:00
treeston
4fa646c0b2 Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around). 2016-09-20 12:45:11 +02:00
treeston
20f483967f Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946) 2016-09-20 12:02:25 +02:00
treeston
6d00d3f283 Core/Movement: Add new SplineChainMovementGenerator that allows accurate replication of sniffed waypoints in static sequences, along with DB facilities that allow loading of waypoints from DB. 2016-09-20 00:37:36 +02:00
tkrokli
a475033c76 Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB
2016-09-17 05:20:40 +02:00
Treeston
cf628880d5 Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940) 2016-09-16 13:09:16 +02:00
Naios
600e0be7e1 Core/Scripts: Fix a crash when swapping creatures with pending vehicle join events.
* Closes #17833
2016-09-15 15:13:57 +02:00
Naios
79adaf4ee0 Core/Scripts: Fix a crash when adding/removing objects from the map while swapping
* Ref #17833
2016-09-15 15:13:57 +02:00
SnapperRy
c41b4000f9 Fix wrong copy-paste from last commit.
Sorry.
2016-09-15 13:52:24 +02:00
SnapperRy
4eb799560c Core/Achievement: do not consider overkill damage for ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE. 2016-09-15 13:50:20 +02:00
SnapperRy
025002b907 Core/Creature: enable pet bar for TempSummons with category SUMMON_CATEGORY_PET.
Thanks @ariel- for helping with the research (although I'm two months late).
2016-09-14 22:42:47 +02:00
SnapperRy
6586885bca Core/SmartAI: do not target player's group for SMART_ACTION_CALL_AREAEXPLOREDOREVENTHAPPENS.
SMART_TARGET_INVOKER_PARTY or SMART_ACTION_CALL_GROUPEVENTHAPPENS should instead be used to achieve this functionality.
2016-09-14 20:28:02 +02:00
treeston
a7afb47633 Maps/Boundary: Some code style clean-up in AreaBoundary code, as well as adding an additional utility overload to IsWithinBoundary (Position const&). 2016-09-14 01:54:15 +02:00
SnapperRy
6f1e823cac Core/Fishing: implement retail-like fishing skill-up functionality (#17528) 2016-09-13 04:16:05 +02:00
SnapperRy
271c16fb60 DB/Quest: improvements for Test at Sea:
- Prevent player from entering combat when using the quest item.
- The targeted NPCs should only yell sporadically.
2016-09-13 01:44:33 +02:00
ariel-
e0ba5f9ed6 Core/Spell: Updated SpellInfo::GetMaxTicks with all effects capable of periodics 2016-09-12 20:19:06 -03:00
SnapperRy
4164e0cf88 Core/Fishing: ignore required skill when fishing in pools. 2016-09-12 19:37:24 +02:00
ariel-
08e0390d95 Core/Spell: do not cast interrupt effect if the spell did not hit 2016-09-12 12:41:02 -03:00
treeston
5d87e4af8c Instance/UtgardePinnacle: Fix Svala Sorrowgrave timings (from sniff). 2016-09-12 10:49:05 +02:00
Aokromes
9250680680 Update DBUpdater.cpp 2016-09-12 01:04:15 +02:00
Aokromes
fb048a4cdb Update DBUpdater.cpp 2016-09-12 01:00:27 +02:00
Aokromes
fe9f79780e Core/Updater: Clarify more 2 errors 2016-09-12 00:51:06 +02:00
treeston
f2067d3557 Core/Movement: Fix an edge case crash in HomeMovementGenerator. 2016-09-11 12:41:22 +02:00
ariel-
43846d2d51 Core/SpellMgr: removed some wrong spells from LoadSpellInfoCorrections:
34754 is actually Holy concentration, and does not proc.
39805 doesn't exist
2016-09-11 00:06:06 -03:00
treeston
1b7eebc7ba Woops. Thanks, clang.
Crash fix.
2016-09-10 14:51:13 +02:00
treeston
0e8c2f9032 Entities/Object: Add some Position const& overloads to distance/angle methods for usability. 2016-09-10 14:14:34 +02:00
SnapperRy
2f493430c9 Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!". 2016-09-10 02:30:22 +02:00
SnapperRy
0479f08c3c Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
2016-09-10 01:13:35 +02:00
Rochet2
c52566a888 Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865) 2016-09-09 21:11:36 +02:00
treeston
0c2c88ed50 Fine, this time I actually built it. Promise. 2016-09-09 19:48:31 +02:00
treeston
a9f1151f2c Build fix. 2016-09-09 19:43:29 +02:00
treeston
91c2b3162d Game/Scripting: Follow-up to b3d44d6. Fix script selection for creatures on difficulty > 0. 2016-09-09 19:37:04 +02:00
treeston
3c32086b81 Core/Maps: Add override to allow InstanceMap const* -> InstanceScript const*.
Also tighten const-ness on CanSpawn method of CreatureScript.
2016-09-09 18:08:43 +02:00
treeston
62cffd11d0 Core/Conditions: New CONDITION_QUESTSTATE (47). It's the existing quest conditions collapsed into a bitmask value2 because I'm a lazy person that doesn't like having long SQL queries.
Then use this new condition to fix Sniffing out the Perpetrator for Horde. Tagging issue #17914.
2016-09-09 17:14:34 +02:00
treeston
b3d44d6c36 Creature/Scripting: Move CreatureAI::CanRespawn to CreatureScript::CanSpawn. Now also applies to initial spawn. Dynamic spawning prep. 2016-09-09 16:21:27 +02:00
treeston
9180bcd404 Derp. Build fix. 2016-09-09 15:03:56 +02:00