Commit Graph

11751 Commits

Author SHA1 Message Date
ariel-
449ec0d6ff Core/Auras: don't ignore SPELL_ATTR3_ONLY_TARGET_PLAYERS in area auras.
Also, start abusing the arbitrary containers for searchers introduced in 8775f8b28a
2016-10-11 22:01:42 -03:00
Shauren
1c7f099297 Core/Items: Defined all item flags
(cherry picked from commit ef29f32965)
2016-10-11 19:46:29 -03:00
SnapperRy
41445e0d3e Core/Loot: revert unique item check introduced in ea69115.
Proven to be wrong in its current form. Will reintroduce later either in the same method or via db conditions.
2016-10-12 00:13:46 +02:00
SnapperRy
fffeae0da2 Core/Loot: limit unique items check introduced in ea69115 to affect only items that start a quest.
Turns out epic and legendary items are excluded from this limitation (or it could be just instanced content that is immune to this). Other qualities are affected as normal. Sorry for the mishap.
2016-10-11 23:36:49 +02:00
ariel-
d685c7079d Core/Scripts: Implemented Blessing of the Eternals Earthliving proc chance increase 2016-10-11 17:59:34 -03:00
SnapperRy
387b18775d Script/Quest: Apply Heat and Stir.
Enjoy one of the most frustrating quests in Northrend!
2016-10-11 16:59:28 +02:00
ariel-
b8a1a18a5a Core/Creature: Call SetSpawnHealth after JustReachedHome in HomeMovementGenerator
Fixes issues with quests that rely on this behaviour (eg Free your Mind)

Also updated SetSpawnHealth so it doesn't do anything in case spawn is manual (SetHealth(GetHealth()) does modify things depending on deathstate)
2016-10-11 01:43:14 -03:00
ariel-
e2a8cf6809 Core/SmartAI: There's a function for that 2016-10-10 19:05:28 -03:00
ariel-
f749dea8b2 Core/Scripts: don't check ghoul each update. Send proper text packet, so client replaces %s with DK name 2016-10-10 19:05:06 -03:00
ariel-
a129b41f3d Core/Spells: fix runtime error
Partial revert of 11650e4008
2016-10-10 16:31:47 -03:00
ariel-
d429273410 Core/Scripts: fix warning reported by MSVC 2016-10-10 16:23:12 -03:00
SnapperRy
5267381e39 Core/SAI: don't reset event phase when npc evades/resets.
The scripts themselves should take care of that.
2016-10-10 13:58:07 +02:00
ariel-
4cdbc1a09b Core/Spell: Fix 2 more off by one probability calc and duplicated logic in spell hit roll 2016-10-09 20:18:07 -03:00
Krudor
73a72fb7d3 Core/Spells: Effect leap back fix (#18057)
* Fixed unintentional typo?

Seemed to fix the issues related to the effect for the spells I tried.
Sometimes the caster triggers leapback onto targets, and with the old
code, it instead made the caster leap back instead of its targets

(cherry picked from commit 08aab73c7f)
2016-10-09 21:57:36 +02:00
ariel-
10437a1e2e Core/Unit: enabled parry for all creatures, not only humanoids
If there's some creature that _shouldn't_ parry, use the `flags_extra` field in `creature_template` table
2016-10-09 01:55:14 -03:00
ariel-
86903f7015 Core/Auras: moved check for CC auras out of proc handler, and fixed its logic 2016-10-09 01:48:48 -03:00
ariel-
666422d827 Core/Scripts: added missing null checks for DamageInfo struct 2016-10-08 22:20:49 -03:00
SnapperRy
b8bb1545ec Core/Wintergrasp: fix ownership of workshops at the beginning of a new battle.
Those two, together with the two workshop in the Keep, always belong to the defender team. The SouthEast and SouthWest ones always belong to the attacker team.
2016-10-09 00:18:42 +02:00
ariel-
abe514d548 Core/Scripts: fix some copy paste and indentation mistake in Chimera Shot script 2016-10-08 17:13:27 -03:00
ariel-
11650e4008 Core/Scripts: updated Lock and Load script with new hooks, DamageInfo might be null, so check for that too 2016-10-08 16:48:03 -03:00
SnapperRy
eb1a7297cf Core/Wintergrasp: cleanup and codestyle. 2016-10-08 21:13:05 +02:00
jackpoz
2edfedc2b6 Scripts/Azjol-Nerub: fix static analysis issues 2016-10-08 19:21:40 +02:00
Kittnz
eee7fa3fa7 Core/Scripts: Initialize rnd and remove where it was not needed 2016-10-08 16:43:08 +02:00
Kittnz
963278459a Core/Event: Pirate Day Music during the event 2016-10-08 15:49:18 +02:00
Kittnz
e3560f3f51 Core/Event: Add Darkmoon Fair Music during the event 2016-10-08 15:43:13 +02:00
Kittnz
19f8acdb61 Core/Event: Add Midsummer Music during the event 2016-10-08 15:38:17 +02:00
SnapperRy
7ce3811913 Remove unused variable. 2016-10-08 14:26:17 +02:00
SnapperRy
a0c9d33ed6 Battlefield/Wintergrasp: improvements:
- Move Wintergrasp Keep guard spawns from core to db, removing all duplicates in the meanwhile.
- Add Alliance Brigadier General inside the relic room.

Closes #7593.
2016-10-08 14:16:05 +02:00
SnapperRy
d72b025fcb Core/Wintergrasp: fix Defend the Siege quests.
Closes #7953.
2016-10-08 03:54:09 +02:00
ariel-
b93ee312fa Core/Auras: prevent stack overflow while processing SPELL_EFFECT_ADD_EXTRA_ATTACKS 2016-10-07 12:52:01 -03:00
ariel-
d078029124 Revert "Core/Unit: prevent m_extraAttacks underflow. Fixes a freeze with SPELL_EFFECT_ADD_EXTRA_ATTACKS"
This reverts commit f09e7cbbfe.
2016-10-07 12:50:08 -03:00
ariel-
2a5548a13e Core/Channels: remove unneeded default constructor 2016-10-07 12:04:35 -03:00
ariel-
66688a7855 Core/Channel: revamp channel system (#17980)
* Core/Channel: change the way channels are stored and sent to client.

- Fixes multiple channels per zone when using different locales
- Connected clients will receive locally the name of the channel for their apropiate locale (if available)
- In other cases default locale name will be sent, so as to prevent breaking channel chat for those players

Closes #8411
2016-10-07 00:59:56 -03:00
ariel-
ce45e1bf95 Core/Globals: cache SpellSpecific and AuraState information instead of computing them each time they're needed 2016-10-07 00:51:52 -03:00
ariel-
f58de52de3 Core/Auras: stop some compilers from complaining 2016-10-07 00:23:02 -03:00
ariel-
dbba3ad5a5 Core/Scripts: Fix some runtime errors 2016-10-07 00:14:46 -03:00
ariel-
3b6fd226be Core/Misc: fix interaction of spells like Shadowmeld with Threat reducing effects
- SPELL_AURA_MOD_TOTAL_THREAT should be temporary and not added/subtracted from total, only computed
- Cleanup of reference related code
- Kill getLast() and reverse iterator obsevers, LinkedList iterator can't be used as a standard reverse_iterator (ie with operator++). They weren't used anyways
2016-10-06 23:14:51 -03:00
Naios
8775f8b28a Core/Grids: Allow arbitrary containers in grid searchers that support push_back
* Makes it possible to use vector and dequeue with grid searchers.
2016-10-06 21:17:06 +02:00
Kittnz
3eacc25e5d Core/Event: Fix Brewfest Music
Was only playing the same song over and over again.
2016-10-06 20:14:53 +02:00
SnapperRy
79c1b5942c Revert "Core/Creature: don't give kill and achievement credit if a creature kills itself."
Causes an issue where a creature killed by a reflected spell will not give credits.

Thanks Aokromes for noticing. Reverting this until a better solution is found.

This reverts commit 5417a1a37f.
2016-10-06 11:16:05 +02:00
SnapperRy
5417a1a37f Core/Creature: don't give kill and achievement credit if a creature kills itself.
Prevents Wintergrasp vehicles from giving credit when killed by Wintergrasp Water and other similar exploits.
2016-10-06 10:50:50 +02:00
ariel-
8a82a3ba81 Core/Unit: implemented crit suppression
Thanks Riztazz for the infos :P
2016-10-06 01:06:37 -03:00
ariel-
a0e317b991 Core/Scripts: De-hack glyph of Barkskin with proper spell 2016-10-06 00:59:26 -03:00
ariel-
f09e7cbbfe Core/Unit: prevent m_extraAttacks underflow. Fixes a freeze with SPELL_EFFECT_ADD_EXTRA_ATTACKS 2016-10-05 22:46:26 -03:00
SnapperRy
81d4c02f34 Fix non PCH build. 2016-10-06 00:17:28 +02:00
Kittnz
002b0a7a65 Core/Event: Add Brewfest Music during the event
Note: Dark Iron invasion music can be added with a trigger at a later stage
2016-10-05 22:34:04 +02:00
ariel-
5b7078c30a Core/Unit: fix weapon skill up.
Closes #18044
2016-10-05 13:07:44 -03:00
ariel-
b5e8e0a5db Core/Auras: reset periodic aura timers by default. Except when aura comes from triggered spell
Closes #17961
2016-10-05 03:10:05 -03:00
ariel-
d482b0e368 Core/Scripts: add a workaround for Will of the Forsaken shared cooldown
Closes #7151
2016-10-05 01:40:00 -03:00
ariel-
d9e4c8e04f Core/Spells: add Target Processing (SMSG_SPELLLOGEXECUTE) to LAUNCH_TARGET phase.
Move EffectInterruptCast to LAUNCH_TARGET Phase.

Closes #3718
Closes #6042
2016-10-04 23:35:50 -03:00