Commit Graph

27332 Commits

Author SHA1 Message Date
Treeston
45e9e94311 Core/ChatCommands: C++17 cleanup (again) (PR #25323)
(cherry picked from commit 2f7d2ef3e9)
2022-02-04 21:21:17 +01:00
Ovahlord
175fb7056b Core/AI: SortByDistance will now sort the referenced list instead of a copy of it. This fixes MinDistance and MaxDistance target selection
(cherry picked from commit c08180d9bc)
2022-02-04 13:05:36 +01:00
Shauren
7cd98cd7d2 Core/Config: Restore ability to load additional config files for custom scripts
(cherry picked from commit c1e4cfd07e)
2022-02-04 13:05:06 +01:00
Jinnaix
2e10a2de3b Core/Misc: Update Worldserver.conf for AhBot Pricing -make things more clear (#25341)
* AhBot Pricing: Make things more clear

* Change default value to BuyPrice and add some more information to how two sided AH works

* Sync c++ configs with .conf ones

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 812c2af4da)
2022-02-04 13:01:25 +01:00
Giacomo Pozzoni
c66bcc4c0e Core/Spell: Fix name clashing between local variables and class member fields (#25352)
(cherry picked from commit 8a48ece573)
2022-02-04 13:00:08 +01:00
Jinnaix
6830d883ad Core/Unit: send npcs home after fear runs out (#25347)
* Core/Unit: send npcs home after fear runs out

* Whoops, wrong

(cherry picked from commit 7e6f17a701)
2022-02-04 12:19:36 +01:00
jackpoz
4051ccd1bd Core/AHBot: Warn about different AHBot behavior when AllowTwoSide.Interaction.Auction is enabled
Closes #18243

(cherry picked from commit 92f9abab06)
2022-02-04 12:19:15 +01:00
Giacomo Pozzoni
99ee958e0a Core/Misc: Fix issues reported by static analysis (#25351)
* Core/Misc: Fix issues reported by static analysis

* Core/Vmaps: Code cleanup after e777161888

(cherry picked from commit cfc8f7b442)
2022-02-04 12:18:15 +01:00
Treeston
1303ca0e7e Common/Utilities: Make StringTo<bool>'s signature match that of the other integral types, making for easier templating. Default behavior unchanged.
(cherry picked from commit f54cec4db7)
2022-02-04 12:06:26 +01:00
Maks Szokalski
663ec92794 Scripts: Minor loop refactors (#25325)
(cherry picked from commit dc9e0c1e86)
2022-02-04 12:06:01 +01:00
kvipka
5a20f14a99 Scripts/InstanceScript: Fix an issue where LoadAllGrids would load creatures before TeamInInstance was properly set (PR #25340)
(cherry picked from commit 5d2780c43c)
2022-02-04 12:05:36 +01:00
Shauren
bb185a78fb Build: Put tests-extractor_common under correct folder when WITH_SOURCE_TREE is set to hierarchical-folders 2022-02-04 11:01:02 +01:00
Aokromes
af7c211230 Script/Azuremyst_isle: Remove useless log
(cherry picked from commit bf8b34946d)
2022-02-04 10:58:44 +01:00
Shauren
53563c24c3 Warning fix 2022-02-04 10:04:38 +01:00
Treeston
9f97fdd31a Core/Common: Tokenizer -> Trinity::Tokenize (PR: #25327)
(cherry picked from commit 534a2388b7)
2022-02-04 00:27:14 +01:00
Treeston
6e45c371c4 Common/Utilities: Properly read std::from_chars documentation and check for out_of_range errors.
(cherry picked from commit 7478c2c65a)
2022-02-04 00:27:14 +01:00
Treeston
be9dadc189 Common/Utilities: Centralize string -> T conversion in StringConvert.h (PR #25335)
(cherry picked from commit cd30e0b86c)
2022-02-04 00:27:13 +01:00
Treeston
7b88fd607e Core/Warden: Ensure Warden packets do not exceed 512 bytes. This should rectify random Warden timeouts.
(cherry picked from commit 7cc027401e)
2022-02-04 00:27:13 +01:00
Giacomo Pozzoni
902ed74c2a Core/SAI: Implement SMART_TARGET_ACTION_INVOKER in SMART_EVENT_FRIENDLY_HEALTH_PCT (#25318)
* Core/SAI: Implement SMART_TARGET_ACTION_INVOKER in SMART_EVENT_FRIENDLY_HEALTH_PCT

* Require radius (5th parameter) to be set

(cherry picked from commit cbed1039c4)
2022-02-04 00:27:13 +01:00
Shauren
f7ed56f232 Core/Warden: Fix warden timeout ticking twice as fast as it should
(cherry picked from commit ec783fcbb5)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
0257cdc8ca Core/ChatCommands: Do not try to consume integral types if the token is empty (PR #25320)
(cherry picked from commit 6079bc7f34)
2022-02-04 00:27:12 +01:00
jackpoz
1f34964df4 Core/Movement: Fix RandomMovementGenerator for swimming creatures
Fix RandomMovementGenerator for swimming creatures not moving at all due to PATHFIND_FARFROMPOLY being handled as wrong path.
Fixes #25236

(cherry picked from commit 1aceb41349)
2022-02-04 00:27:12 +01:00
Treeston
03b5c17863 Common/Utilities: Move EnumUtils' implementation struct from Trinity::Impl to Trinity::Impl::EnumUtilsImpl. This avoids confusing name clashes for other implementations in sub-namespaces of Trinity::Impl.
(cherry picked from commit 91744de316)
2022-02-04 00:27:12 +01:00
Treeston
0473beff2b Core/Misc: std::string -> std::string_view in a bunch of places, notably chat commands and Util.h
(cherry picked from commit a41bbd9ad9)
2022-02-04 00:27:12 +01:00
robinsch
5ba95cb42f Core/Unit: Fixed race condition when loot recipient is in different map (#25312)
(cherry picked from commit aaa089ab7f)
2022-02-04 00:27:12 +01:00
jackpoz
1f2c48f8bb Core/SAI: Remove completed timed action lists even while evading
Fixes #25294

(cherry picked from commit 03eb0886a8)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
1a6564f42f Scripts/Commands: Convert argument parsing of some misc commands to new system (#25308)
* Core/Shared: Make WeatherType smart

* Scripts/Commands: Convert argument parsing of some misc commands to new system

(cherry picked from commit 5bab0e43c6)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
53b28572bf Scripts/Commands: Convert argument parsing of cast commands to new system (#25309)
(cherry picked from commit cefac75a7d)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
582b8458ea Scripts/Commands: Fix two unreachable code issues found by PVS-studio (#25311)
(cherry picked from commit 3262ef447a)
2022-02-04 00:27:12 +01:00
offl
fc2f582d4f DB/Quest: Convert & update support for 'Ebon Blade Prisoners' to SAI
Closes #24672

(cherry picked from commit 6611b71457)
2022-02-04 00:27:12 +01:00
offl
192b98e544 DB/Quest: Convert & update support for Borean Tundra escort quests to SAI
Closes #25001

(cherry picked from commit 040fda87ef)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
5675d62159 Scripts/Commands: Convert argument parsing of message commands to new system (#25305)
(cherry picked from commit f17b9b20f1)
2022-02-04 00:27:11 +01:00
Peter Keresztes Schmidt
b527a031b9 Core/ChatCommands: Add std::wstring argument type (#25302)
(cherry picked from commit 617a769d6f)
2022-02-04 00:27:11 +01:00
Peter Keresztes Schmidt
e9209c3131 Scripts/Commands: Convert argument parsing of most list commands to new system (#25303)
(cherry picked from commit 522a4cb1a6)
2022-02-04 00:27:11 +01:00
Treeston
6303fbc449 Core/Misc: Update worldserver.conf.dist to match actual defaults.
(cherry picked from commit d717b9dc3e)
2022-02-04 00:27:11 +01:00
Treeston
c6582096ab Core/Warden: Add Lua checks to Warden (PR #25286)
(cherry picked from commit 0531463a3c)
2022-02-04 00:27:11 +01:00
Maks Szokalski
b5d0a94ead Core/Gossip: Add new helper method to ScriptedGossip for resolving menuId -> sender (PR #25293)
(cherry picked from commit db8bdaa08f)
2022-02-04 00:27:11 +01:00
Treeston
669b6bea21 Core/Warden: Ignore the length value in the database for MEM_CHECK checks. Hi there Aokromes.
(cherry picked from commit fc32c3fd3b)
2022-02-04 00:27:11 +01:00
Treeston
15d75dea10 Core/Warden: More refactors lifted from #25286.
(cherry picked from commit a3971ca4b0)
2022-02-04 00:27:11 +01:00
Treeston
317bb198b1 Core/Warden: Some Warden refactors lifted from #25286.
(cherry picked from commit 5b4288f05f)
2022-02-04 00:27:11 +01:00
Shauren
015cee5f27 Core/Networking: Initialize MPSCQueueIntrusive dummy node without undefined behavior
(cherry picked from commit e1289805fc)
2022-02-04 00:27:11 +01:00
Shauren
0a1acb9c05 Scripts/Spells: Replace RegisterAuraScript with RegisterSpellScript and remove it
(cherry picked from commit 7d4fbf706a)
2022-02-04 00:27:10 +01:00
Shauren
17e7f8497c Scripts/Spells: Convert remaining spell_generic scripts to simplified script registration using new additional constructor argument support
(cherry picked from commit 7a5a010d41)
2022-02-04 00:27:10 +01:00
Shauren
e81b5838a6 Core/Scripts: Unify RegisterSpellScript and RegisterAuraScript macros to do the same thing and implemented passing custom arguments to spell script classes
(cherry picked from commit 75a6a7a0ad)
2022-02-03 00:25:03 +01:00
Shauren
4064b22dd7 Core/Util: Added another template utility - find_type_if
* Trinity::find_type_if - Find a type matching predicate in a given template parameter pack

(cherry picked from commit 84a87d87bf)
2022-02-03 00:24:33 +01:00
Shauren
c37984fc6a Core/Util: Added new utilities
* Trinity::new_from_tuple - same as std::make_from_tuple except allocates object using "new"
* Trinity::is_tuple - detects whether given type is a tuple specialization
* advstd::type_identity - C++20 std::type_identity

(cherry picked from commit 7c08fc863a)
2022-02-03 00:24:10 +01:00
Shauren
348acb105c Core/Commands: Exclude ambigious cast operator overloads from command Variant
Closes #25618

(cherry picked from commit b57530ebb1)
2022-02-03 00:22:24 +01:00
Peter Keresztes Schmidt
86bfde389a Scripts/Commands: Convert argument parsing of event commands to new system (PR #25275)
(cherry picked from commit 7bfeb03c13)
2022-02-03 00:19:14 +01:00
Peter Keresztes Schmidt
3c82863c52 Core/ChatCommands: Check whether a passed numeric enum value is valid (#25285)
(cherry picked from commit 4286e7aa02)
2022-02-03 00:18:48 +01:00
Peter Keresztes Schmidt
3ba767c438 Scripts/Commands: Convert argument parsing of gm commands to new system (#25279)
(cherry picked from commit 9c9e8c7d58)
2022-02-03 00:10:31 +01:00