Commit Graph

6342 Commits

Author SHA1 Message Date
Peter Keresztes Schmidt
5086f1bfdc Scripts/Northrend: Use std::chrono::duration overloads of EventMap (#25021)
Contributes to #25012

(cherry picked from commit 29779db58b)
2022-01-23 15:46:37 +01:00
Peter Keresztes Schmidt
c56f99a1d4 Scripts/Trial of the Crusader: Use std::chrono::duration overloads of EventMap (#25020)
Contributes to #25012

(cherry picked from commit a2b2dc7ad0)
2022-01-23 15:41:42 +01:00
Peter Keresztes Schmidt
111521d3c9 Scripts/EasternKingdoms: Use std::chrono::duration overloads of EventMap (#25019)
Contributes to #25012

(cherry picked from commit 5ef576d223)
2022-01-23 15:41:30 +01:00
Peter Keresztes Schmidt
41dab047ed Scripts/Blackrock Mountain: Use std::chrono::duration overloads of EventMap (#25018)
Contributes to #25012

(cherry picked from commit ac27c922d1)
2022-01-23 15:39:28 +01:00
Peter Keresztes Schmidt
8fb60c4d19 Scripts/Kalimdor: Use std::chrono::duration overloads of EventMap (#25016)
Contributes to #25012

(cherry picked from commit 90d5e7e1e8)
2022-01-23 15:38:35 +01:00
Giacomo Pozzoni
e188a75c68 Scripts/Kologarn: Fix another "stuck in combat" issue (#24998)
(cherry picked from commit ee34a1f19e)
2022-01-23 15:20:29 +01:00
Giacomo Pozzoni
e9cf3828ba Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23) (#24997)
* Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23)

Original research by @xvwyh.

* Add missing sql update

* Fix some build errors

* Remove unused enum values

* Change artkits from 0-4 to 0-3

* Remove unused code

* Code review feedback

* Fix sql

* Remove artkit4 special case handling

* Default initialize artKits

* Code review feedback

* Split sql into structure and data files

Co-authored-by: Warpten <vertozor@gmail.com>
(cherry picked from commit 203573db83)
2022-01-23 15:17:54 +01:00
Peter Keresztes Schmidt
365ae6ff25 Fix some compiler warnings reported by GCC (#25007)
* Core/AI: Remove unneeded null checks

GetMap() can never return NULL.

Fixes additionally -Wunused-variable warnings
reported by GCC.

* Core/GameObject: Fix a -Wunused-variable warning reported by GCC

* Core/Player: Fix a -Wunused-variable warning reported by GCC

* Scritps/CavernsOfTime: Fix -Wimplicit-fallthrough warnings reported by GCC

* Scritps/CavernsOfTime: Fix a -Wmaybe-uninitialized warning reported by GCC

Warning:

/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp: In member function ‘virtual void npc_arthas_stratholme::npc_arthas_stratholmeAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:1119:58: warning: ‘emote’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 1119 |                                 (*it)->HandleEmoteCommand(emote);
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

* Scritps/PitOfSaron: Fix -Wunused-variable warnings reported by GCC

* Scritps/EyeOfEternity: Fix a -Wclass-memaccess warning reported by GCC

Warning:

/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp: In member function ‘virtual void boss_malygos::boss_malygosAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp:950:81: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
  950 |                             memset(_surgeTargetGUID, 0, sizeof(_surgeTargetGUID));
      |

* Scritps/CoilfangReservoir: Fix a -Wclass-memaccess warning reported by GCC

Warning:

/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp: In member function ‘void boss_leotheras_the_blind::boss_leotheras_the_blindAI::Initialize()’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp:220:55: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
  220 |             memset(InnderDemon, 0, sizeof(InnderDemon));
      |                                                       ^

* Scritps/Naxx: Fix a -Wimplicit-fallthrough warning reported by GCC

For discussion see https://github.com/TrinityCore/TrinityCore/pull/25007

(cherry picked from commit 10be49bdfe)
2022-01-23 00:16:31 +01:00
Peter Keresztes Schmidt
1e1679a1f7 Core/DataStores: Port refactors from Update DBC field names to generated ones (#24999)
(cherry picked from commit c92950b3e1)
2022-01-23 00:06:16 +01:00
Aqua Deus
0bbdfc6112 Scripts/Spells: Move spell_anchor_here to generic because is used by more than one boss (#27641) 2022-01-22 14:52:05 +01:00
Shauren
d32dd913fd Core/Units: Fixed typo in unit flag name 2022-01-22 14:45:03 +01:00
Shauren
b4952db464 Core/Units: Named unit flags linked to CreatureDifficulty flags 2022-01-22 13:21:15 +01:00
Eridium
a4ed8806b7 Creature/Script: npc_blackfathom_deeps_event (#24969)
* Creature/Script: npc_blackfathom_deeps_event

* Update blackfathom_deeps.cpp

* Update blackfathom_deeps.h

* codestyle

* Update blackfathom_deeps.cpp

Co-authored-by: Killyana <Killyana@users.noreply.github.com>
Co-authored-by: Ovah <dreadkiller@gmx.de>
(cherry picked from commit 98c37b15e0)
2022-01-22 01:20:23 +01:00
Shauren
0ac5b1da8c Core/Spells: Don't select corpses for spell targets that expect to hit units
Closes #24980

(cherry picked from commit 14db2215d3)
2022-01-22 00:33:53 +01:00
Ovah
508ea9e3c7 Scripts/ICC: fixed a crash in the Lich King encounter caused by invalid corpse targets
(cherry picked from commit 232628f0a6)
2022-01-22 00:33:12 +01:00
offl
fb6a72aa2d DB/Quest: Convert & update support for 'Khu'nok Will Know' to SAI
Closes #24933

(cherry picked from commit c6811d3e4e)
2022-01-21 22:21:43 +01:00
offl
144914b4f0 DB/Quest: Convert & update support for 'Chasing A-Me 01' to SAI
Closes #24925

(cherry picked from commit 46ad9fa0d9)
2022-01-21 20:42:32 +01:00
offl
4d64524a70 DB/Quest: Convert & update scripts from Thousand Needles to SAI
Closes #24924

(cherry picked from commit 18864aeddb)
2022-01-21 20:36:00 +01:00
offl
20535a5d2d DB/Quest: Convert & update support for 'Protect Kaya' to SAI
Closes #24923

(cherry picked from commit c29e3b46af)
2022-01-21 20:34:54 +01:00
offl
dde859cb21 DB/Creature: Convert & update support for 'Messenger Torvus' to SAI
Closes #24852

(cherry picked from commit 2ebef0c51c)
2022-01-21 16:16:43 +01:00
genion18
1ddfbf3ecc DB/Quest: Rumors for Kravel outro event
Closes #24835

(cherry picked from commit 32aebc14ab)
2022-01-19 23:06:57 +01:00
offl
fa0d4ceea1 DB/Quest: Convert & update support for 'Escorting Erland' to SAI
Closes #24834

(cherry picked from commit eea3cf1401)
2022-01-19 23:01:12 +01:00
offl
306e08cc31 DB/Quest: Convert & update support for 'Scratches' to SAI
Closes #24824

(cherry picked from commit d526d5d176)
2022-01-19 20:54:24 +01:00
Shauren
279744efcd Core/Commands: Fixed wrong field being used to determine instance type in .lookup map id 2022-01-19 12:37:27 +01:00
offl
c5bc1cbeb6 DB/Quest: Convert Galen's Escape to SAI
Closes #23684

(cherry picked from commit f621173748)
2022-01-18 23:47:59 +01:00
offl
775c6ca039 DB/Quest: Convert & update support for 'City of Light' to SAI
Closes #24814

(cherry picked from commit f2c2210dbb)
2022-01-18 23:45:00 +01:00
Shauren
03dd82b52d Scripts/Spells: Updated Power Word: Shield script
Closes #27630
2022-01-18 14:33:07 +01:00
Rothend
77e1304a5a Script/Creature: script Terokk's encounter (#24871)
* Script/Creature: script Terokk's encounter.

Closes #2029

* Apply suggested changes.

* Fix nopch build.

* Rename 9999_99_99_99_world_terokk.sql to 2020_06_24_02_world.sql

* Update 2020_06_24_02_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
(cherry picked from commit 3227ed94bc)
2022-01-18 00:27:18 +01:00
Rothend
f5967b8a87 Script/Spell: fix Midsummer's Juggling Torch (#24885)
* Script/Spell: fix Midsummer's Juggling Torch.

Closes #17446

* Remove unneeded GetPosition() call, thanks jackpoz for noticing!

* Rename 9999_99_99_99_world_midsummer_torch_juggling.sql to 2020_06_24_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 5f35bf9e79)
2022-01-18 00:06:59 +01:00
Aqua Deus
d8efda4ff3 Scripts/Spells: Fix mage Flame On talent (#27622) 2022-01-17 23:36:12 +01:00
Aqua Deus
92335bf900 Scripts/Spells: Fix warlock chaos bolt damage (#27616) 2022-01-17 20:56:31 +01:00
Aqua Deus
d95a1e7eaf Scripts/Spells: Fix warlock immolate periodic (#27615) 2022-01-16 23:10:09 +01:00
Aqua Deus
a3b2e4d987 Core/Items: Reagent bank (#27592) 2022-01-16 22:31:24 +01:00
Shauren
c5727921b9 Warning fix 2022-01-13 00:07:08 +01:00
My name is Mud
d6c43b3d63 Scripts/Spells: Fixed mage talent Firestarter (#27576)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-12 23:49:14 +01:00
My name is Mud
3dceb3622f Scripts/Spells: Fixed hunter talent A Murder of Crows (#27566)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-12 23:10:44 +01:00
Ovah
97fe56962a Scripts/Baradin Hold: fixed a crash in Occuthar's Focused Fire target selection and improved target filter scripts (#27604) 2022-01-12 22:23:58 +01:00
Robingad
bd19e22513 Scripts/Spells: Fix shaman Mastery: Elemental Overload + Stormkeeper and Unlimited Power talents (#27561)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-12 12:48:43 +01:00
My name is Mud
043d1cf254 Scripts/Spells: Fix priest Shadow Mend damage (#27525) 2022-01-10 00:28:50 +01:00
Shauren
0d3235f569 Core/Guilds: Separate guild rank id from guild rank order
Co-authored-by: aquadeus <efectokoleos13@gmail.com>
2022-01-09 23:12:00 +01:00
My name is Mud
861d572f9c Scripts/Spells: Fix shaman talent Spirit Wolf (#27478) 2022-01-09 19:06:48 +01:00
Shauren
6df3cb0995 Scripts/Spells: Corrected script registrations for shaman spells to match db2 data 2022-01-09 14:59:35 +01:00
Shauren
b042919daf Scripts/Spells: Updated Windfury Weapon script 2022-01-09 14:42:55 +01:00
Shauren
60539d2e24 Scripts/Spells: Changed shaman Healing Stream Totem target selection to use Trinity::SelectRandomInjuredTargets 2022-01-09 13:44:43 +01:00
Shauren
4d3439b024 Scripts/Spells: Fixed shaman Healing Rain target limit 2022-01-09 13:43:45 +01:00
Shauren
30f232d5db Scripts/Spells: Fixed shaman Healing Rain not doing anything 2022-01-09 12:45:32 +01:00
My name is Mud
1410e018eb Scripts/Spells: Fix Warlock Drain Soul energize (#27512) 2022-01-07 22:17:12 +01:00
Carbenium
366a514462 Core/Battlefield: Move SendInitWorldStatesTo to Battlefield class
(cherry picked from commit 488b91ab83)
2022-01-07 00:25:36 +01:00
Carbenium
81a3c135a7 Scripts/Battlefield: Move npc_wg_give_promotion_credit script to BattlefieldWG
The script references BattlefieldWG, which is not exported in dynamic builds.
Move the script, so it is in the same library.

(cherry picked from commit c40b897d36)
2022-01-07 00:22:38 +01:00
Carbenium
49523a74a4 Battlefields: Move BF scripts out of game
This commit introduces the usual script interface
for battlefields.

(cherry picked from commit f7faf20254)
2022-01-07 00:20:57 +01:00