SmartAI uses that same method internally, so there's no need to handle it in two different ways.
Does not affect functionality, but prevents useless SAI error log in case the target creature is not using SAI.
(cherry picked from commit 727f77ec6a)
Unit::IsControlledByPlayer is a expected value for TempSummons (like some triggers used in quests, summoned by spells).
Previous logic broke a lot of quests which use triggers to do stuff.
Allow JustSummoned and events linked from other events with flag set also in charmed (prevents breaking event chains)
Allow vehicles (needed for vehicles with SmartAI, eg Iron Rune Constructs and You: Rocket Jumping)
(cherry picked from commit 3e596376a7)
* Mostly aimed at removing Log/DatabaseEnv includes from other headers
* Fix most packet headers including other packet headers - moved common structures such as ItemInstance to their own files
* Moved SAI function definitions to source files (massive or requiring many different dependencies)
* Scripts/AzjolNerub: Complete rewrite.
- Gatewatcher:
- Trash now actually engages properly one by one
- Fix trash spell casting
- Add missing quotes
- Hadronox:
- Everything. Literally.
- Anub'arak:
- Fix add spawns
- Fix impale
- OK this might as well be "fix everything with every boss". Because that's pretty much what happened.
- General hack cleanup
* Update and rename 9999_99_99_99_AZJOLNERUB.sql to 2016_09_25_01_world.sql
* Update and rename 2016_09_25_01_world.sql to 2016_09_25_02_world.sql
* Rename 2016_09_25_02_world.sql to 2016_09_26_02_world.sql
(cherry picked from commit 4b990eb7d7)
# Conflicts:
# src/server/game/Spells/SpellMgr.cpp
# src/server/scripts/Northrend/AzjolNerub/AzjolNerub/azjol_nerub.h
# src/server/scripts/Northrend/AzjolNerub/AzjolNerub/boss_anubarak.cpp
Update boss_hadronox.cpp
(cherry picked from commit 04ec868768)
Update boss_hadronox.cpp
I hate travis, learn from buildbot
(cherry picked from commit aeb20951bb)
I think I got all of them this time
No idea how this one got past travis.
(cherry picked from commit ae163197a7)
Fix nonPCH.
(cherry picked from commit e121d66fbb)
...for real this time (seriously - what happened to test builds before merging, Aok?)
(cherry picked from commit dbe0789eba)
.....hail PCH
(cherry picked from commit 2528194cc1)
and you get a header, and everyone gets a header...
(cherry picked from commit 5e5fe37a7e)
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.
(cherry picked from commit 2170541a51)
Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6)
(cherry picked from commit 6d00d3f283)
Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967f)
Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2)
PCH build fix. Again.
(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241)
SMART_TARGET_INVOKER_PARTY or SMART_ACTION_CALL_GROUPEVENTHAPPENS should instead be used to achieve this functionality.
(cherry picked from commit 6586885bca)
(cherry picked from commit b3d44d6c36)
Game/Scripting: Follow-up to b3d44d6. Fix script selection for creatures on difficulty > 0.
(cherry picked from commit 91c2b3162d)
Build fix.
(cherry picked from commit a9f1151f2c)
Fine, this time I actually built it. Promise.
(cherry picked from commit 0c2c88ed50)
This allows us to fix quest 12261 (No Place to Run). Closes#16291.
(cherry picked from commit e69a483aa9)
Derp. Build fix.
(cherry picked from commit 9180bcd404)
(cherry picked from commit 175db157f7)
You saw nothing (build fix).
(cherry picked from commit 72a7f4b507)
Build fix. Again. Oops.
(cherry picked from commit 61eb70fd82)
....right, I actually went through a full rebuild now just to make sure it works.
(cherry picked from commit 8531f012a2)
Last one. For real. Please. (Build fix#5).
(cherry picked from commit a32536d490)
(cherry picked from commit 47a9cb1e56)
...Huh. Wonder how this one didn't make travis complain on the PR.
(cherry picked from commit 93a68d5881)
Was Travis completely napping on this one?
(cherry picked from commit 2d7dec0d39)
